spark_api 1.4.18 → 1.4.19

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    OTQxYzNmMDgyMGU3NTNlMGJhMDA4ZWUwMDNmMDk0ZjFmOTdkZjQwMg==
+    NjBhNTg3Y2Q0ZWY3NzUzZDI3ZjViNjNkZjY3NGQ2YmU1ZTIwODE4Mw==
   data.tar.gz: !binary |-
-    ZjNkYjFiYTAwOTRmNjA5M2I5MzA5MjJkNTFiZWYwMDg0ODZiNjFkZQ==
+    ZjkwOTRhZGVhYjkzZmFjYjkwOGYzMDkzYzI2M2VkYWQwNzJjY2VhZg==
 SHA512:
   metadata.gz: !binary |-
-    OWE3ZTg0M2JiNmU0NTdlNzYwNDU4NDFiMjNmNTZiNTA4YzVlMzJiMTUyZjQ2
-    MjBlNzc4NWEzOTQ2ZDQ0MjQzNGVkYjI1M2E5NmE4OGUzYmI1OWM0ZTE5MmZk
-    YzAwZjk1YWE0OGRmYTlkODJmNTFhOGQwZWYyNjNhZjliMDY1YzA=
+    MWIzZTkzZGJmZDcwNzg1YmY4ZTY4NTcyZDViOWZjNTgzYzZhNjNlZmFiZmQw
+    NWZhZGUwZTc1YTA5NDljOTc3NzVkM2UwZTcwMjQ1Y2MyMThmN2E4ZTU4NjVh
+    ZTc1YTMyZTNlZTUzNzRiNmJiY2Q0YTA4YjRhZmNlNWE0NDA2MzM=
   data.tar.gz: !binary |-
-    NjAwMGMxOGZhNDE2YTc0NDUwZTk4ZjRmOTQ0MzVjOTRjYTMwZWY0MWI3ZjNl
-    YjhiMzkzNGI4YzdmYzkxNDRlMzc2MmE4YjFhNTMxYjcwOTEyOWE4NDljNmQy
-    OWIxMjJiOGM5ZDM4YjJhMTc3N2U5OGM0ZmMzYWViYmU1ZWE5ZGY=
+    ZDI2YzIxZTU1NjlhMDBmN2U2NTgwYWEwNDFhZGI5NWE2MjI0NzYxZjJhODJj
+    YjQzOWExZjFiMDU2ODE5YWU1NWQ3OGZjY2RlZjM0MmM3OTc4ZjAzNmQ3NTRi
+    YzYxYzI2OTAwZmY2YTk0YzM0NjM1MTZkYTMzOTE4OWFlOGRhMTY=

data/VERSION

@@ -1 +1 @@
-1.4.18
+1.4.19

data/lib/spark_api/request.rb

@@ -92,7 +92,12 @@ module SparkApi
         SparkApi.logger.error { "Authentication failed or server is sending us expired tokens, nothing we can do here." }
         raise
       end
-      response.body
+
+      if options[:full_response]
+        return response
+      else
+        return response.body
+      end
     rescue Faraday::Error::ConnectionFailed => e
       if self.ssl_verify && e.message =~ /certificate verify failed/
         SparkApi.logger.error { SparkApi::Errors.ssl_verification_error }

data/lib/spark_api/response.rb

@@ -1,7 +1,7 @@
 module SparkApi
   # API Response interface
   module Response
-    ATTRIBUTES = [:code, :message, :results, :success, :pagination, :details, :d]
+    ATTRIBUTES = [:code, :message, :results, :success, :pagination, :details, :d, :errors, :sparkql_errors]
     attr_accessor *ATTRIBUTES
     def success?
       @success
@@ -23,6 +23,8 @@ module SparkApi
         self.success    = self.d["Success"]
         self.pagination = self.d["Pagination"]
         self.details    = self.d["Details"] || []
+        self.errors     = self.d["Errors"]
+        self.sparkql_errors = self.d['SparkQLErrors']
         super(results)
       rescue Exception => e
         SparkApi.logger.error "Unable to understand the response! #{d}"

data/spec/unit/spark_api/request_spec.rb

@@ -57,6 +57,20 @@ describe SparkApi do
       r.success?.should be(false)
       r.message.should be == "I am a failure."
     end
+    it "should have SparkQLErrors when present" do
+      err = {"Token" => "ExpirationDate", "Status" => "Dropped"}
+      r = SparkApi::ApiResponse.new({"D"=>{"Success" => false, "Message" => "I am a failure from .",
+        "SparkQLErrors" => [err]
+      }})
+      r.sparkql_errors.first.should eq(err)
+    end
+    it "should have Errors when present" do
+      err = {"Type" => "InvalidAttribute", "Attribute" => "DisplayName", "Message" => "DisplayName is wrong."}
+      r = SparkApi::ApiResponse.new({"D"=>{"Success" => false, "Message" => "I am a failure from .",
+        "Errors" => [err]
+      }})
+      r.errors.first.should eq(err)
+    end
   end
   
   describe SparkApi::Request do
@@ -197,6 +211,13 @@ describe SparkApi do
         subject.post('/stringdata', 'I am a lonely String!').success?.should == true
       end
 
+      it "should allow response object to be returned instead of body" do
+        r = subject.get('/system', { full_response: true })
+
+        r.is_a?(Faraday::Response).should be(true)
+        r.status.should eq(200)
+      end
+
       it "should give me BigDecimal results for large floating point numbers" do
         MultiJson.default_adapter.should eq(:yajl) unless jruby?
         result = subject.get('/listings/1000')[0]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spark_api
 version: !ruby/object:Gem::Version
-  version: 1.4.18
+  version: 1.4.19
 platform: ruby
 authors:
 - Brandon Hornseth
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-19 00:00:00.000000000 Z
+date: 2018-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday