spark_api 1.4.1 → 1.4.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YjFjYTgyZjBhYTRiMjM1MTIzYzkxODEwYjlmNjg5ZTQ3ZmUwZmY2OA==
+    Y2U5OGIwYmZhZWFlZWQ2Njc1NzA4YmMxNzhjN2NiYTZlNjEzZTA5Yg==
   data.tar.gz: !binary |-
-    ZDUxMGNkNzVkMTQzNmJjOTgxY2JhMjBjMjA5ZDNkYjkzZDk2Zjc1ZA==
+    MzM2NGZjNmMxMWU1MWY4OTMwZDczN2VhZmVmM2EzMjUyM2ZmNTM2MA==
 SHA512:
   metadata.gz: !binary |-
-    Y2IwNzI3MmRjOTJmOGYxOWMyYzBmZjA4ZjViNmY3YTQ5ZjM2ZWMwZTE4ZTBl
-    ZjgwY2JjN2IzZGEzYWY1NmRjZmY1Y2UwMWNhMjcwMzNhMGVjY2ZhNmNkMzgx
-    ZjY5ODY3ZjE3NDQzMGZiOGRmNzYzZTJjZDg5ZjEwNTRlNGU2ZTM=
+    ODY1Mjk3OTZhYTc3YmQ4ZTgwMzc1NGM5YjMxNjg2NjM3ZDFhYmRiOGVkYWFm
+    MTVhYWUxZmViNzI1NTY4NTI5MjBhMTEyM2IzMDI4Y2Q1NTBkOTM3YzRiYmI2
+    ZjUyYWVmYTk0NzFhY2IyMGY1NmVjMGRlNGJjYTYxYWNkODZjY2I=
   data.tar.gz: !binary |-
-    ZjgwNDE2NThkY2IxMjFiYjE3NGFjOWI4NzU1MjZlMTgxYTY0ZmZlN2Y2ZmIy
-    NmQ2Yzg5NzZjZTViMWYyNjNkMjE4MGUxNDE3MjE2OTExMzZjNGYwOGE2NGVk
-    ZDhkMjJmMTVhZmQ1NjllNGYyZWM4MTc2ZTc5ZmIyMDk2M2JiMDE=
+    MTJmZTBiMDdhM2ZmY2U0Y2JmNGI0OTNlMWI2M2RmMGU2NmU5YTk0NGZmNjJl
+    ODMwY2EyODBjZTAwNWVhOWIzYmY4ODllNWMzMTNkOGQzNDkwNDJiNmRiNTVh
+    NTA5ZmYzYjg1ZWEyNWEyZjZiNzI0ZDkzYjE1NGVkMWY0Y2M1YTI=

data/VERSION

@@ -1 +1 @@
-1.4.1
+1.4.2

data/lib/spark_api/models.rb

@@ -2,6 +2,7 @@ require 'spark_api/models/dirty'
 require 'spark_api/models/base'
 require 'spark_api/models/constraint'
 require 'spark_api/models/finders'
+require 'spark_api/models/defaultable'
 require 'spark_api/models/subresource'
 require 'spark_api/models/concerns'
 

data/lib/spark_api/models/defaultable.rb

@@ -0,0 +1,37 @@
+module SparkApi
+  module Models
+    module Defaultable
+
+      DEFAULT_ID = "default"
+
+      extend Finders
+
+      def self.included(base)
+
+        class << base
+          alias original_find find
+        end
+
+        base.extend(ClassMethods)
+
+      end
+  
+      module ClassMethods
+
+        def default(options = {})
+          find(DEFAULT_ID, options)
+        end
+
+        def find(*arguments)
+          result = original_find(*arguments)
+          if arguments.first == DEFAULT_ID
+            result.Id = DEFAULT_ID if result.Id.nil?
+          end
+          result
+        end
+
+      end
+
+    end
+  end
+end

data/lib/spark_api/models/idx_link.rb

@@ -3,16 +3,12 @@ module SparkApi
     class IdxLink < Base
 
       extend Finders
+      include Defaultable
       
       self.element_name = "idxlinks"
       
       LINK_TYPES = ["QuickSearch", "SavedSearch", "MyListings", "Roster"]
 
-      def self.default(options = {})
-        response = connection.get("/#{self.element_name}/default", options).first
-        response.nil? ? nil : new(response)
-      end
-
     end
   end
 end

data/lib/spark_api/models/search_template/quick_search.rb

@@ -2,6 +2,7 @@ module SparkApi
   module Models
     class QuickSearch < Base 
       extend Finders
+      include Defaultable
       include Concerns::Savable,
               Concerns::Destroyable
 

data/spec/unit/spark_api/models/defaultable_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+describe Defaultable do
+
+  module SparkApi
+    module Models
+      class TestClass < Base
+        extend Finders
+        include Defaultable
+        self.element_name = 'testclass'
+      end
+    end
+  end
+
+  describe 'default' do
+
+    it 'calls find' do
+      expect(TestClass).to receive(:find).with('default', {})
+      TestClass.default
+    end
+    
+  end
+  
+  describe 'find' do
+
+    it "adds the id 'default'" do
+      allow(TestClass).to receive(:connection).and_return(double(get: [{Id: nil, Name: 'foo'}]))
+      default = TestClass.find(TestClass::DEFAULT_ID)
+      expect(default.Id).to eq 'default'
+    end
+
+    it "doesn't override the id if one is present" do
+      allow(TestClass).to receive(:connection).and_return(double(get: [{Id: '5', Name: 'foo'}]))
+      expect(TestClass.find(TestClass::DEFAULT_ID).Id).to eq '5'
+    end
+
+    it "calls Finders.find when given a normal id" do
+      connection = double
+      expect(connection).to receive(:get).with("/testclass/5", {foo: true}).and_return([{}])
+      allow(TestClass).to receive(:connection).and_return(connection)
+      TestClass.find('5', foo: true)
+    end
+    
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spark_api
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - Brandon Hornseth
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-18 00:00:00.000000000 Z
+date: 2016-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -285,6 +285,7 @@ files:
 - lib/spark_api/models/constraint.rb
 - lib/spark_api/models/contact.rb
 - lib/spark_api/models/custom_fields.rb
+- lib/spark_api/models/defaultable.rb
 - lib/spark_api/models/dirty.rb
 - lib/spark_api/models/document.rb
 - lib/spark_api/models/fields.rb
@@ -480,11 +481,11 @@ files:
 - spec/unit/spark_api/models/connect_prefs_spec.rb
 - spec/unit/spark_api/models/constraint_spec.rb
 - spec/unit/spark_api/models/contact_spec.rb
+- spec/unit/spark_api/models/defaultable_spec.rb
 - spec/unit/spark_api/models/dirty_spec.rb
 - spec/unit/spark_api/models/document_spec.rb
 - spec/unit/spark_api/models/fields_spec.rb
 - spec/unit/spark_api/models/finders_spec.rb
-- spec/unit/spark_api/models/idx_link_spec.rb
 - spec/unit/spark_api/models/listing_cart_spec.rb
 - spec/unit/spark_api/models/listing_spec.rb
 - spec/unit/spark_api/models/message_spec.rb
@@ -686,6 +687,7 @@ test_files:
 - spec/unit/spark_api/authentication/base_auth_spec.rb
 - spec/unit/spark_api/configuration_spec.rb
 - spec/unit/spark_api/request_spec.rb
+- spec/unit/spark_api/models/defaultable_spec.rb
 - spec/unit/spark_api/models/news_feed_meta_spec.rb
 - spec/unit/spark_api/models/open_house_spec.rb
 - spec/unit/spark_api/models/document_spec.rb
@@ -719,7 +721,6 @@ test_files:
 - spec/unit/spark_api/models/property_types_spec.rb
 - spec/unit/spark_api/models/base_spec.rb
 - spec/unit/spark_api/models/subresource_spec.rb
-- spec/unit/spark_api/models/idx_link_spec.rb
 - spec/unit/spark_api/models/vow_account_spec.rb
 - spec/unit/spark_api/models/activity_spec.rb
 - spec/unit/spark_api_spec.rb

data/spec/unit/spark_api/models/idx_link_spec.rb

@@ -1,28 +0,0 @@
-require 'spec_helper'
-
-describe IdxLink do
-
-  before :each do
-    stub_auth_request
-  end
-
-  describe "/idxlinks/default" do
-
-    on_get_it "returns an agent's default idx link" do
-      s = stub_api_get("/idxlinks/default", "idx_links/get.json")
-      @idx_link = subject.class.default
-      @idx_link.should be_an(IdxLink)
-      @idx_link.Uri.should eq("http://link.dev.fbsdata.com/zq1fkiw4d3f,1")
-      s.should have_been_requested
-    end
-
-    on_get_it "returns nil if the user doesn't have one" do
-      s = stub_api_get("/idxlinks/default", "no_results.json")
-      @idx_link = subject.class.default
-      @idx_link.should be_nil
-      s.should have_been_requested
-    end
-
-  end
-
-end