spark_api 1.3.24 → 1.3.25

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZTQ2YzBjNTczYWI1YTdjMDA1OTkzMDZiYTAzZjc3ZjUxMjY0NGFlMA==
+    ZTVmZTkxOTdiYjI5YmE1N2UwN2Q5ZjQ3MmMxNDg1OTU2Njk4M2I0MQ==
   data.tar.gz: !binary |-
-    YWE2YjQ2ZDAyOTVhZDk5YzNjMGZmOTY2ZjNmYzI4MDA1MTg1MWM1YQ==
+    OWIyNTk5YjliMGVjM2RlNjM3M2IzZDAxY2JjYjUxYzRlNTYyYTUzMw==
 SHA512:
   metadata.gz: !binary |-
-    OGYyNTM1ZGE2YTRhZmMzYjUwYmExMjljMmI3NjZjOGU3ZTM2ZmZkMmFkYWI4
-    ZTUwNDEwZTFiODk4NTY1N2NjZWFmMzEzN2E0ZmMzNGEzMzEyMTg4NGJlMzRk
-    M2YxMDgzOTMyMDg2MzE2NDA3YzQ3MzJhNDBhYjJmYjM0NmZhOGM=
+    YjM2OWFhMDdhZDQ0MWQzZGZjYTVkODgyZGIxMmI2NTg1MzRmMWMwNDU4ZTQ3
+    ZGViMzU3MjhhODQyNWUxYzAwYzY4YzJhZTQzOTNhMzliM2M0OGJlNjQyNjAw
+    OGQ2YThjMzMxNDUxM2MwNDQxOGRiZWZhNDkyMWJlODg5NmJlMWU=
   data.tar.gz: !binary |-
-    YTQxZTNmYmQzNjE2ZTY3NmNiYTkzOGU0ODc4MGQyNTg5YzFjZDVjYzAwM2Qz
-    NDY5YWQ3ZmNmNTE4ZGE5ZjhhYzM0MzY5YmM2N2Y1ZWNjMTQ4YTZmODkwYzVm
-    MTY3YzAzYmJmMWMyMmEwN2E2ZDE5NmQzYWJlNmZhMzU3ZWM3ODE=
+    NTk1Y2Y3ZDZiZjg2ODJiZDg2YjBmZTJjMjVhNjI0MjJkNThhMTQ0ZmRmY2Q4
+    OTg5OWIzMTdkNjZjMmU2MGZjODdmYjVjZDhlZDlmZGQ0YjIwYTFmY2MzM2Mw
+    NjcyZDUxYjI4M2JkYzk0MzlhMTUxZGJiNWQ0MGFiMThiMjgwOTk=

data/Rakefile

@@ -1,9 +1,15 @@
 require "rubygems"
 
 require 'rubygems/user_interaction'
-require 'flexmls_gems/tasks'
-require 'flexmls_gems/tasks/spec'
-require 'flexmls_gems/tasks/rdoc'
+require 'rspec'
+require 'rspec/core/rake_task'
+require 'ci/reporter/rake/rspec'
+require 'bundler/gem_tasks'
+
+RSpec::Core::RakeTask.new do |t|
+    t.rspec_opts = ["-c", "-f progress"]
+    t.pattern = 'spec/**/*_spec.rb'
+end
 
 desc "Run all the tests"
 task :default => :spec

data/VERSION

@@ -1 +1 @@
-1.3.24
+1.3.25

data/lib/spark_api/models.rb

@@ -24,11 +24,13 @@ require 'spark_api/models/notification'
 require 'spark_api/models/open_house'
 require 'spark_api/models/photo'
 require 'spark_api/models/portal'
+require 'spark_api/models/portal_listing_cart'
 require 'spark_api/models/property_types'
 require 'spark_api/models/rental_calendar'
 require 'spark_api/models/saved_search'
 require 'spark_api/models/search_template/quick_search'
 require 'spark_api/models/shared_listing'
+require 'spark_api/models/sort'
 require 'spark_api/models/standard_fields'
 require 'spark_api/models/system_info'
 require 'spark_api/models/tour_of_home'

data/lib/spark_api/models/base.rb

@@ -129,6 +129,19 @@ module SparkApi
         attributes['Id']
       end
 
+      def to_partial_path
+        "#{underscore(resource_pluralized)}/#{underscore(self.class.name.split('::').last)}"
+      end
+
+      # can be overridden
+      def resource_pluralized
+        resource = self.class.name.split('::').last
+        unless resource.split('').last == "s"
+          resource = resource + "s"
+        end
+        resource
+      end
+
       protected
 
       def write_attribute(attribute, value)
@@ -139,6 +152,16 @@ module SparkApi
         end
       end
 
+      private
+
+      def underscore(string)
+        string.to_s.gsub(/::/, '/').
+        gsub(/([A-Z]+)([A-Z][a-z])/,'\1_\2').
+        gsub(/([a-z\d])([A-Z])/,'\1_\2').
+        tr("-", "_").
+        downcase
+      end
+
     end
   end
 end

data/lib/spark_api/models/concerns/savable.rb

@@ -22,12 +22,17 @@ module SparkApi
 
         def create!(arguments = {})
           results = connection.post self.path, post_data.merge(params_for_save), arguments
-          update_attributes(results.first)
+          update_attributes_after_create(results.first)
           reset_dirty
           params_for_save.clear
           true
         end
 
+        def update_attributes(attrs = {})
+          attrs.each{|k,v| public_send(:"#{k}=", v)}
+          save!
+        end
+
         def update!(arguments = {})
           return true unless changed? && persisted?
           connection.put resource_uri, dirty_attributes, arguments
@@ -48,21 +53,12 @@ module SparkApi
 
         private 
 
-        def update_attributes(result)
+        def update_attributes_after_create(result)
           attributes['Id'] = result['Id'] ? result['Id'] : parse_id(result['ResourceUri'])
           result.delete('Id')
           attributes.merge! result
         end
 
-        # can be overridden
-        def resource_pluralized
-          resource = self.class.name.split('::').last
-          unless resource.split('').last == "s"
-            resource = resource + "s"
-          end
-          resource
-        end
-
       end
 
     end

data/lib/spark_api/models/idx_link.rb

@@ -1,6 +1,9 @@
 module SparkApi
   module Models
     class IdxLink < Base
+
+      extend Finders
+      
       self.element_name="idxlinks"
       
       LINK_TYPES = ["QuickSearch", "SavedSearch", "MyListings", "Roster"]
@@ -34,14 +37,6 @@ module SparkApi
 
       private
 
-      def self.find_every(options)
-        raise NotImplementedError # TODO
-      end
-
-      def self.find_one(options)
-        raise NotImplementedError # TODO
-      end
-
       def self.find_single(scope, options)
         resp = SparkApi.client.get("/idxlinks/#{scope}", options)
         new(resp.first)

data/lib/spark_api/models/listing.rb

@@ -191,7 +191,26 @@ module SparkApi
         results = connection.put "#{self.class.path}/#{self.Id}/photos", arguments
         true
       end
-      
+
+      def reorder_photo(photo_id, index)
+        unless Integer(index)
+          raise ArgumentError, "Photo reorder failed. '#{index}' is not a number."
+        end
+
+        begin
+          return reorder_photo!(photo_id, index)
+        rescue BadResourceRequest => e
+          SparkApi.logger.warn { "Failed to save resource #{self}: #{e.message}" }
+        rescue NotFound => e
+          SparkApi.logger.error { "Failed to save resource #{self}: #{e.message}" }
+        end
+        false
+      end
+      def reorder_photo!(photo_id, index)
+        connection.put "#{self.class.path}/#{self.Id}/photos/#{photo_id}", "Photos" => [{"Order"=>index}]
+        true
+      end
+
       def editable?(editable_settings = [])
         settings = Array(editable_settings)
         editable = attributes.include?("Permissions") && self.Permissions["Editable"] == true

data/lib/spark_api/models/listing_cart.rb

@@ -15,11 +15,12 @@ module SparkApi
       def ListingIds=(listing_ids)
         write_attribute("ListingIds", Array(listing_ids))
       end
+
       def Name=(name)
         write_attribute("Name", name)
       end
 
-      def path
+      def self.path
         if @contact_id
           "/contacts/#{@contact_id}/listingcarts"
         else
@@ -27,6 +28,15 @@ module SparkApi
         end
       end
 
+      def filter
+        "ListingCart Eq '#{self.Id}'"
+      end
+
+      def listings(args = {})
+        return [] if attributes["ListingIds"].nil?
+        Listing.collect(connection.get("#{self.path}/#{self.Id}/listings", args))
+      end
+
       def add_listing(listing)
         ids = listing.respond_to?(:Id) ? listing.Id : listing
         results = connection.post("#{self.resource_uri}", {"ListingIds" => Array(ids)})
@@ -52,6 +62,10 @@ module SparkApi
           collect(connection.get("/#{self.element_name}/portal", arguments))
       end
 
+      def deletable?
+        !attributes.has_key?("PortalCartType") || self.PortalCartType == "Custom"
+      end
+
     end
   end
 end

data/lib/spark_api/models/portal_listing_cart.rb

@@ -0,0 +1,13 @@
+module SparkApi
+  module Models
+
+    class PortalListingCart < ListingCart
+
+      def self.find(contact_id, *arguments)
+        @contact_id = contact_id
+        super(*arguments)
+      end
+
+    end
+  end
+end

data/lib/spark_api/models/saved_search.rb

@@ -8,6 +8,11 @@ module SparkApi
 
       attr_accessor :newsfeeds
 
+      # Newsfeed restriction criteria for saved searches:
+      # http://alpha.sparkplatform.com/docs/api_services/newsfeed/restrictions#criteria
+      QUALIFYING_FIELDS_FOR_NEWSFEED = %w(BathsTotal BedsTotal City CountyOrParish ListPrice Location MlsStatus 
+        PostalCode PropertyType RoomsTotal State)
+
       self.element_name="savedsearches"
 
       def initialize(attributes={})
@@ -19,12 +24,6 @@ module SparkApi
         Class.new(self).tap do |provided|
           provided.element_name = '/savedsearches'
           provided.prefix = '/provided'
-          def provided_search?
-            true
-          end
-          def newsfeeds
-            []
-          end
           SparkApi.logger.info("#{self.name}.path: #{provided.path}")
         end
       end
@@ -33,6 +32,10 @@ module SparkApi
         collect(connection.get("/#{self.element_name}/tags/#{tag}", arguments))
       end
 
+      def favorite?
+        @attributes["Tags"] && @attributes["Tags"].include?( "Favorites")
+      end
+
       # list contacts (private role)
       def contacts
         return [] unless persisted?
@@ -63,36 +66,23 @@ module SparkApi
       end
 
       def listings(args = {})
-        arguments = {:_filter => self.Filter}
-        arguments.merge!(:RequestMode => 'permissive') if provided_search?
+        arguments = {:_filter => "SavedSearch Eq '#{self.Id}'"}
+        arguments.merge!(:RequestMode => 'permissive') if Provided?
         @listings ||= Listing.collect(connection.get("/listings", arguments.merge(args)))
       end
 
       def newsfeeds
-        if @newsfeeds.nil?
-          response = SparkApi.client.get("/savedsearches/#{@attributes["Id"]}", :_expand => "NewsFeeds").first["NewsFeeds"]
-              # the response from the api is just a bunch of hashes, but we can turn them into Newsfeed instances
-          @newsfeeds = response.map { |hash| Newsfeed.new(hash) }
-        end
-        @newsfeeds
-      end
-
-      def provided_search?
-        false
+        Newsfeed.collect(connection.get("#{self.class.path}/#{@attributes["Id"]}", 
+          :_expand => "NewsFeeds").first["NewsFeeds"])
       end
 
       def can_have_newsfeed?
 
-        return false if provided_search? 
         return true  if has_active_newsfeed? || has_inactive_newsfeed?
 
-        # Newsfeed restriction criteria for saved searches:
-        # http://alpha.sparkplatform.com/docs/api_services/newsfeed/restrictions#criteria
-        standard_fields = %w(BathsTotal BedsTotal City CountyOrParish ListPrice Location MlsStatus PostalCode PropertyType RoomsTotal State)
-
         number_of_filters = 0
 
-        standard_fields.each do |field|
+        QUALIFYING_FIELDS_FOR_NEWSFEED.each do |field|
           number_of_filters += 1 if self.Filter.include? field
         end
         
@@ -101,24 +91,22 @@ module SparkApi
       end
 
       def has_active_newsfeed?
-        return false if provided_search? 
-
         if self.respond_to? "NewsFeedSubscriptionSummary"
           self.NewsFeedSubscriptionSummary['ActiveSubscription']
         else
-          saved_search = SavedSearch.find( self.Id, {"_expand" => "NewsFeedSubscriptionSummary"})
-          saved_search.NewsFeedSubscriptionSummary['ActiveSubscription']
+          search = connection.get "#{self.class.path}/#{@attributes['Id']}", 
+            {"_expand" => "NewsFeedSubscriptionSummary"}
+          search.first["NewsFeedSubscriptionSummary"]["ActiveSubscription"]
         end
       end
 
       def has_inactive_newsfeed?
-        return false if provided_search? 
-       
-        if self.respond_to? "NewsFeedSubscriptionSummary"
-          !self.NewsFeedSubscriptionSummary['ActiveSubscription']
+        if self.respond_to?("NewsFeeds") && self.respond_to?("NewsFeedSubscriptionSummary")
+          self.NewsFeeds.any? && !self.NewsFeedSubscriptionSummary['ActiveSubscription']
         else
-          saved_search = SavedSearch.find( self.Id, {"_expand" => "NewsFeedSubscriptionSummary"})
-          !saved_search.NewsFeedSubscriptionSummary['ActiveSubscription']
+          search = connection.get("#{self.class.path}/#{@attributes['Id']}", 
+            {"_expand" => "NewsFeedSubscriptionSummary, NewsFeeds"}).first
+          search["NewsFeeds"].any? && !search["NewsFeedSubscriptionSummary"]["ActiveSubscription"]
         end
       end
 

data/lib/spark_api/models/sort.rb

@@ -0,0 +1,11 @@
+module SparkApi
+  module Models
+    class Sort < Base
+      extend Finders
+
+      self.element_name="/sorts"
+      self.prefix="/searchtemplates"
+
+    end
+  end
+end

data/script/bootstrap

@@ -0,0 +1,7 @@
+#!/usr/bin/env bash
+
+ruby -v
+echo "==> Installing gems..."
+bundle check --path vendor/bundle 2>&1 > /dev/null || {
+  bundle install  --quiet --path vendor/bundle
+}

data/script/ci_build

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+set -e
+
+script/bootstrap
+
+
+export COVERAGE=on              # build rcov report when running tests
+export CI_REPORTS=test/reports  # output JUnit reports to std location
+
+echo "==> Running tests..."
+bundle exec rake ci:setup:rspec spec

data/script/release

@@ -0,0 +1,6 @@
+#!/usr/bin/env bash
+set -e
+
+rm -rf pkg/*
+bundle exec rake build
+gem push pkg/*.gem --key rubygems_production_key

data/spec/fixtures/listings/put_reorder_photo.json

@@ -0,0 +1,5 @@
+{
+  "D": {
+    "Photos": [{"Order" : "2"}]
+  }
+}

data/spec/fixtures/listings/reorder_photo.json

@@ -0,0 +1,20 @@
+{
+  "D": {
+    "Results": [
+        {
+            "Uri300": "http://photos.flexmls.com/fgo/20050505220032167405000000.jpg",
+            "ResourceUri": "/v1/listings/20050505200220759069000000/photos/20050505220032167405000000",
+            "Name": "Front",
+            "Primary": true,
+            "Uri800": "http://cdn.resize.flexmls.com/fgo/800x600/true/20050505220032167405000000-o.jpg",
+            "Id": "20050505220032167405000000",
+            "UriLarge": "http://photos.flexmls.com/fgo/20050505220032167405000000-o.jpg",
+            "Uri1024": "http://cdn.resize.flexmls.com/fgo/1024x768/true/20050505220032167405000000-o.jpg",
+            "Caption": "",
+            "Uri1280": "http://cdn.resize.flexmls.com/fgo/1280x1024/true/20050505220032167405000000-o.jpg",
+            "Uri640": "http://cdn.resize.flexmls.com/fgo/640x480/true/20050505220032167405000000-o.jpg",
+            "UriThumb": "http://photos.flexmls.com/fgo/20050505220032167405000000-t.jpg"
+        }
+    ]
+  }
+}

data/spec/fixtures/saved_searches/get.json

@@ -9,7 +9,8 @@
               "Filter": "City Eq 'Moorhead' And MlsStatus Eq 'Active' And PropertyType Eq 'A'",
               "ContactIds": [
                 "20100815220615294367000000"
-              ]
+              ],
+              "Provided": false
             },
             { 
               "ResourceUri": "/v1/savedsearches/20100615220615292711000000",

data/spec/fixtures/saved_searches/get_provided.json

@@ -0,0 +1,22 @@
+{
+    "D": {
+        "Success": true,
+        "Results": [
+            { 
+              "ResourceUri": "/v1/savedsearches/20100815220615294367000000",
+              "Id":  "20100815220615294367000000",
+              "Name": "Search name here",
+              "Filter": "City Eq 'Moorhead' And MlsStatus Eq 'Active' And PropertyType Eq 'A'",
+              "ContactIds": [
+                "20100815220615294367000000"
+              ],
+              "Provided": true
+            },
+            { 
+              "ResourceUri": "/v1/savedsearches/20100615220615292711000000",
+              "Id":  "20100615220615292711000000",
+              "Name": "Second search name here" 
+            }
+        ]
+    }
+}

data/spec/fixtures/saved_searches/without_newsfeed.json

@@ -0,0 +1,20 @@
+{
+    "D": {
+        "Success": true,
+        "Results": [
+            { 
+              "ResourceUri": "/v1/savedsearches/20100815220615294367000000",
+              "Id":  "20100815220615294367000000",
+              "Name": "Search name here",
+              "ContactIds": [
+                "20100815220615294367000000"
+              ],
+              "NewsFeedSubscriptionSummary": {
+                "ActiveSubscription": false
+              },
+              "NewsFeeds": []
+            }
+
+        ]
+    }
+}

data/spec/fixtures/sorts/get.json

@@ -0,0 +1,31 @@
+{
+    "D": {
+        "Results": [
+            {
+                "ResourceUri": "/v1/searchtemplates/sorts/20120717212004874996000000",
+                "Id": "20130717212004874996000000",
+                "Name": "My Custom Listing Sort",
+                "OwnerId": "20000426173054342350000000",
+                "MlsId": "20000426143505724628000000",
+                "Inheritable": true,
+                "Inherited": false,
+                "Fields": [
+                    {
+                        "Domain": "StandardFields",
+                        "GroupField": null,
+                        "Field": "ListPrice",
+                        "SortType": "Ascending"
+                    },
+                    {
+                        "Domain": "StandardFields",
+                        "GroupField": null,
+                        "Field": "MlsStatus",
+                        "SortType": "Descending"
+                    }
+                ],
+                "ModificationTimestamp": "2013-07-09T15:31:47Z"
+            }
+        ],
+        "Success": true
+    }
+}

data/spec/spec_helper.rb

@@ -1,5 +1,15 @@
-require "rubygems"
+if ENV['COVERAGE'] == "on"
+  require 'simplecov'
+  require 'simplecov-rcov'
+  SimpleCov.formatter = SimpleCov::Formatter::RcovFormatter
+  SimpleCov.start do
+    add_filter '/vendor'
+    add_filter '/spec'
+    add_filter '/test'
+  end
+end
 
+require "rubygems"
 require "rspec"
 require 'rspec/autorun'
 require 'webmock/rspec'

data/spec/unit/spark_api/models/base_spec.rb

@@ -1,9 +1,13 @@
 require './spec/spec_helper'
 
 # Sample resource models for testing the base class
-class MyExampleModel < Base
-  self.element_name = "example"
-  self.prefix = "/test/"
+module SparkApi
+  module Models
+    class MyExampleModel < Base
+      self.element_name = "example"
+      self.prefix = "/test/"
+    end
+  end
 end
 
 class MyDefaultModel < Base
@@ -153,4 +157,11 @@ describe Base, "Base model" do
 
   end
 
+  describe "to_partial_path" do
+    it "should return the partial path" do
+      model = MyExampleModel.new()
+      model.to_partial_path.should eq("my_example_models/my_example_model")
+    end
+  end
+
 end

data/spec/unit/spark_api/models/listing_cart_spec.rb

@@ -133,4 +133,43 @@ describe ListingCart do
     end
   end
 
+  describe "#listings" do 
+    it "should return the listings in the cart" do 
+      resource = subject.class.new Id: 5, ListingIds: ["1234"]
+      stub_api_get("/#{subject.class.element_name}/#{resource.Id}/listings", 'listings/multiple.json')
+      resource.listings.should be_a(Array)
+      resource.listings.first.should be_a(Listing)
+    end
+
+    it "should return an empty array if there aren't any listings" do 
+      resource = subject.class.new Id: 5
+      resource.listings.should be_a(Array)
+      resource.listings.count.should === 0
+    end
+  end
+
+  describe "filter" do
+    it "should return a filter string for the cart" do
+      resource = subject.class.new Id: 5
+      resource.filter.should eq("ListingCart Eq '5'")
+    end
+  end
+
+  describe "#deletable?" do
+    it "should return true for private custom carts" do
+      resource = subject.class.new
+      expect(resource.deletable?).to be_true
+    end
+    
+    it "should return true for custom vow carts" do
+      resource = subject.class.new PortalCartType: "Custom"
+      expect(resource.deletable?).to be_true
+    end
+
+    it "should return false for vow carts" do
+      resource = subject.class.new PortalCartType: "Favorites"
+      expect(resource.deletable?).to be_false
+    end
+  end
+
 end

data/spec/unit/spark_api/models/listing_spec.rb

@@ -251,6 +251,23 @@ describe Listing do
         l.errors.size.should eq(1)
       end
 
+      on_put_it "should reorder a photo" do
+        list_id = "20060725224713296297000000"
+        stub_api_get("/listings/#{list_id}", 'listings/with_photos.json')
+        stub_api_put("/listings/#{list_id}/photos/20110826220032167405000000", 'listings/put_reorder_photo.json', 'listings/reorder_photo.json')
+        l = Listing.find(list_id)
+        l.reorder_photo("20110826220032167405000000", "2")
+        l.photos.size.should eq(5)
+      end
+
+      on_put_it "should raise an exception when an index is not an Integer" do
+        list_id = "20060725224713296297000000"
+        stub_api_get("/listings/#{list_id}", 'listings/with_photos.json')
+        stub_api_put("/listings/#{list_id}/photos/2011082622003216740500000", 'listings/put_reorder_photo.json', 'listings/reorder_photo.json')
+        l = Listing.find(list_id)
+        expect{ l.reorder_photo("2011082622003216740500000", "asdf") }.to raise_error(ArgumentError)
+      end
+
       context "with pagination" do
         # This is really a bogus call, but we should make sure our
         # pagination collection impl still behaves sanely

data/spec/unit/spark_api/models/saved_search_spec.rb

@@ -104,25 +104,24 @@ describe SavedSearch do
       it "should return the searches listings" do
         stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
         stub_api_get("/listings", 'listings/multiple.json', 
-          {:_filter => "City Eq 'Moorhead' And MlsStatus Eq 'Active' And PropertyType Eq 'A'"})
+          {:_filter => "SavedSearch Eq '#{id}'"})
         listings = subject.class.find(id).listings
         listings.should be_an(Array)
         listings[0].should be_a(Listing)
       end
       
       it "should include the permissive parameter for provided searches" do
-        stub_api_get("/provided/savedsearches/#{id}", 'saved_searches/get.json')
+        stub_api_get("/provided/savedsearches/#{id}", 'saved_searches/get_provided.json')
         resource = subject.class.provided.find(id)
         expect(SparkApi.client).to receive(:get).with("/listings", 
-          {:_filter => resource.Filter, :RequestMode => 'permissive'})
+          {:_filter => "SavedSearch Eq '#{id}'", :RequestMode => 'permissive'})
         resource.listings
       end
       
       it "should not include the permissive parameter for saved searches" do
         stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
         resource = subject.class.find(id)
-        resource.stub(:provided_search?) { false }
-        expect(SparkApi.client).to receive(:get).with("/listings", {:_filter => resource.Filter})
+        expect(SparkApi.client).to receive(:get).with("/listings", {:_filter => "SavedSearch Eq '#{id}'"})
         resource.listings
       end
 
@@ -165,17 +164,25 @@ describe SavedSearch do
     end
   end
 
-  describe "can_have_newsfeed?" do
+  describe "favorite?" do
+    it "should return true if the search has been tagged as a favorite" do
+      search = SavedSearch.new(Tags: ["Favorites"])
+      search.should be_favorite
+    end
 
-    it "should return false for a provided search" do
-      stub_api_get("/provided/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
-      resource = subject.class.provided.find(id)
-      resource.can_have_newsfeed?.should == false
+    it "should return false if the search has not been tagged as a favorite" do
+      search = SavedSearch.new
+      search.should_not be_favorite
     end
+  end
+
+  describe "can_have_newsfeed?" do
 
     it "should return false without at least three filter parameters" do
       stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
       resource = subject.class.find(id)
+      resource.stub(:has_active_newsfeed?) { false }
+      resource.stub(:has_inactive_newsfeed?) { false }
       resource.Filter = "City Eq 'Moorhead' And MlsStatus Eq 'Active'"
       resource.can_have_newsfeed?.should == false
     end
@@ -183,7 +190,6 @@ describe SavedSearch do
     it "should return true with three filter parameters" do
       stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
       resource = subject.class.find(id)
-      resource.stub(:provided_search?) { false }
       resource.stub(:has_active_newsfeed?) { false }
       resource.stub(:has_inactive_newsfeed?) { false }
       resource.can_have_newsfeed?.should == true
@@ -197,13 +203,14 @@ describe SavedSearch do
       stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/with_newsfeed.json',
         { "_expand" => "NewsFeedSubscriptionSummary" } )
       resource = subject.class.find(id)
-      resource.stub(:provided_search?) { false }
       resource.has_active_newsfeed?.should == true
     end
 
-    it "should return false for a provided search" do
-      stub_api_get("/provided/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
-      resource = subject.class.provided.find(id)
+    it "should return false if the search doesn't have a newsfeed" do
+      stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
+      stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/without_newsfeed.json',
+        { "_expand" => "NewsFeedSubscriptionSummary" } )
+      resource = subject.class.find(id)
       resource.has_active_newsfeed?.should == false
     end
   end
@@ -214,15 +221,17 @@ describe SavedSearch do
       stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/with_inactive_newsfeed.json',
         { "_expand" => "NewsFeedSubscriptionSummary" } )
       resource = subject.class.find(id)
-      resource.stub(:provided_search?) { false }
       resource.has_inactive_newsfeed?.should == true
     end
 
-    it "should return false for a provided search" do
-      stub_api_get("/provided/#{subject.class.element_name}/#{id}", 'saved_searches/with_inactive_newsfeed.json')
-      resource = subject.class.provided.find(id)
+    it "should return false if the search doesn't have a newsfeed" do
+      stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
+      stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/without_newsfeed.json',
+        { "_expand" => "NewsFeedSubscriptionSummary, NewsFeeds" } )
+      resource = subject.class.find(id)
       resource.has_inactive_newsfeed?.should == false
     end
+
   end
 
   describe "newsfeed" do
@@ -235,4 +244,10 @@ describe SavedSearch do
     end
   end
 
+  describe "QUALIFYING_FIELDS_FOR_NEWSFEED" do
+    it "should return an array" do
+      subject.class::QUALIFYING_FIELDS_FOR_NEWSFEED.should be_an(Array)
+    end
+  end
+  
 end

data/spec/unit/spark_api/models/sort_spec.rb

@@ -0,0 +1,19 @@
+require './spec/spec_helper'
+
+describe Sort do
+  before(:each) do
+    stub_auth_request
+  end
+
+  it "should include the finders module" do
+    Sort.should respond_to(:find)
+  end
+
+  it "should return sorts" do
+    stub_api_get("/searchtemplates/sorts", 'sorts/get.json')
+    sorts = Sort.find(:all)
+    sorts.should be_an(Array)
+    sorts.length.should eq(1)
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spark_api
 version: !ruby/object:Gem::Version
-  version: 1.3.24
+  version: 1.3.25
 platform: ruby
 authors:
 - Brandon Hornseth
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-17 00:00:00.000000000 Z
+date: 2015-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -192,21 +192,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.9.9
 - !ruby/object:Gem::Dependency
-  name: flexmls_gems
+  name: rb-readline
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.2.5
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.2.5
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rb-readline
+  name: rb-fsevent
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
@@ -220,7 +220,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rb-fsevent
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov-rcov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
@@ -300,11 +314,13 @@ files:
 - lib/spark_api/models/open_house.rb
 - lib/spark_api/models/photo.rb
 - lib/spark_api/models/portal.rb
+- lib/spark_api/models/portal_listing_cart.rb
 - lib/spark_api/models/property_types.rb
 - lib/spark_api/models/rental_calendar.rb
 - lib/spark_api/models/saved_search.rb
 - lib/spark_api/models/search_template/quick_search.rb
 - lib/spark_api/models/shared_listing.rb
+- lib/spark_api/models/sort.rb
 - lib/spark_api/models/standard_fields.rb
 - lib/spark_api/models/subresource.rb
 - lib/spark_api/models/system_info.rb
@@ -319,10 +335,13 @@ files:
 - lib/spark_api/request.rb
 - lib/spark_api/response.rb
 - lib/spark_api/version.rb
+- script/bootstrap
+- script/ci_build
 - script/combined_flow_example.rb
 - script/console
 - script/example.rb
 - script/oauth2_example.rb
+- script/release
 - spec/fixtures/accounts/all.json
 - spec/fixtures/accounts/my.json
 - spec/fixtures/accounts/my_portal.json
@@ -387,7 +406,9 @@ files:
 - spec/fixtures/listings/photos/rotate.json
 - spec/fixtures/listings/put.json
 - spec/fixtures/listings/put_expiration_date.json
+- spec/fixtures/listings/put_reorder_photo.json
 - spec/fixtures/listings/rental_calendar.json
+- spec/fixtures/listings/reorder_photo.json
 - spec/fixtures/listings/shared_listing_get.json
 - spec/fixtures/listings/shared_listing_new.json
 - spec/fixtures/listings/shared_listing_post.json
@@ -437,13 +458,16 @@ files:
 - spec/fixtures/portal/post.json
 - spec/fixtures/property_types/property_types.json
 - spec/fixtures/saved_searches/get.json
+- spec/fixtures/saved_searches/get_provided.json
 - spec/fixtures/saved_searches/new.json
 - spec/fixtures/saved_searches/post.json
 - spec/fixtures/saved_searches/update.json
 - spec/fixtures/saved_searches/with_inactive_newsfeed.json
 - spec/fixtures/saved_searches/with_newsfeed.json
+- spec/fixtures/saved_searches/without_newsfeed.json
 - spec/fixtures/search_templates/quick_searches/get.json
 - spec/fixtures/session.json
+- spec/fixtures/sorts/get.json
 - spec/fixtures/standardfields/city.json
 - spec/fixtures/standardfields/nearby.json
 - spec/fixtures/standardfields/standardfields.json
@@ -487,6 +511,7 @@ files:
 - spec/unit/spark_api/models/saved_search_spec.rb
 - spec/unit/spark_api/models/search_template/quick_search_spec.rb
 - spec/unit/spark_api/models/shared_listing_spec.rb
+- spec/unit/spark_api/models/sort_spec.rb
 - spec/unit/spark_api/models/standard_fields_spec.rb
 - spec/unit/spark_api/models/subresource_spec.rb
 - spec/unit/spark_api/models/system_info_spec.rb
@@ -537,6 +562,7 @@ test_files:
 - spec/fixtures/fields/order.json
 - spec/fixtures/success.json
 - spec/fixtures/session.json
+- spec/fixtures/sorts/get.json
 - spec/fixtures/oauth2_error.json
 - spec/fixtures/base.json
 - spec/fixtures/idx_links/get.json
@@ -597,6 +623,8 @@ test_files:
 - spec/fixtures/saved_searches/update.json
 - spec/fixtures/saved_searches/new.json
 - spec/fixtures/saved_searches/with_newsfeed.json
+- spec/fixtures/saved_searches/get_provided.json
+- spec/fixtures/saved_searches/without_newsfeed.json
 - spec/fixtures/saved_searches/get.json
 - spec/fixtures/saved_searches/with_inactive_newsfeed.json
 - spec/fixtures/messages/post.json
@@ -604,6 +632,8 @@ test_files:
 - spec/fixtures/messages/new.json
 - spec/fixtures/messages/new_empty.json
 - spec/fixtures/messages/get.json
+- spec/fixtures/listings/put_reorder_photo.json
+- spec/fixtures/listings/reorder_photo.json
 - spec/fixtures/listings/constraints.json
 - spec/fixtures/listings/tour_of_homes_search.json
 - spec/fixtures/listings/tour_of_homes.json
@@ -679,6 +709,7 @@ test_files:
 - spec/unit/spark_api/models/account_spec.rb
 - spec/unit/spark_api/models/listing_spec.rb
 - spec/unit/spark_api/models/video_spec.rb
+- spec/unit/spark_api/models/sort_spec.rb
 - spec/unit/spark_api/models/saved_search_spec.rb
 - spec/unit/spark_api/models/contact_spec.rb
 - spec/unit/spark_api/models/portal_spec.rb