spark-component 1.0.0.pre.alpha.1 → 1.0.0.pre.alpha.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7531fb1b2668f9d7aa7fc2b76653f4f87638cbffb919d4fcc556192e14c87a5e
-  data.tar.gz: 34882f3cac0dbc33f6fbfcbebb9195c7564ffdd2e94a82145c7c76e4f8a24bea
+  metadata.gz: ec7ce0537ea5b7b2ca514cc478dc3a1bf49ba8fb7cd333e1a73bec5531bfedbc
+  data.tar.gz: dd62d7e6de7a10e1967131e7dcd0c1a9c619f3110b63fe04ee9ce7b501f3a6fe
 SHA512:
-  metadata.gz: be3f47247ba35d4ee29525eaa93ffee5025c605c4d585a7f7573e680a61d68ad43595e6ebf10ba8a79375f5aa9059577ec29161717cea1e2ffc02a5d2ffb3505
-  data.tar.gz: fe98c4fdab4bc3bf36c2e8748d695e725e4e6ab66bfbeb2c9f33d6c5657a009db5bcc02b197955fdd1b62a893ca7c42515f3bb343265b97564179570bc308dc1
+  metadata.gz: 304f0c80b85c11474524b3956659fd83fc5d3dec9f16092561120dbea608c31c11238557070e5448e8c8e6db8358441c4983eb383a7c3c2db77ed84e15519c80
+  data.tar.gz: 3099d522662b9dba6cbb1b837e3e07d0e6f87a823f6930887b819c22d45f65d0528eae2a309d653b693f8454f1fb542efa7199ecbd88c63c13599e50518a3213

data/.rubocop.yml

@@ -26,7 +26,7 @@ Metrics/ClassLength:
     - 'lib/spark_components/element.rb'
 
 Layout/TrailingBlankLines:
-  EnforcedStyle: final_blank_line
+  EnforcedStyle: final_newline
 
 Naming/VariableNumber:
   EnforcedStyle: snake_case

data/Gemfile

@@ -7,4 +7,3 @@ gemspec
 
 gem "pry-byebug", group: %i[development test]
 gem "rails", "~> 6.0.0"
-

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    spark-component (1.0.0.pre.alpha.1)
+    spark-component (1.0.0.pre.alpha.2)
 
 GEM
   remote: https://rubygems.org/

data/Rakefile

@@ -14,4 +14,3 @@ Rake::TestTask.new(:bench) do |t|
 end
 
 task default: :test
-

data/bin/console

@@ -13,4 +13,3 @@ require "spark/component"
 
 require "irb"
 IRB.start(__FILE__)
-

data/lib/spark/component/attr.rb

@@ -40,4 +40,3 @@ module Spark
     end
   end
 end
-

data/lib/spark/component/attribute.rb

@@ -58,6 +58,10 @@ module Spark
         base.extend(ClassMethods)
       end
 
+      def initialize(*attrs)
+        initialize_attributes(*attrs)
+      end
+
       # Assign instance variables for attributes defined by the class
       def initialize_attributes(attrs = nil)
         attrs ||= {}
@@ -194,4 +198,3 @@ module Spark
     end
   end
 end
-

data/lib/spark/component/classname.rb

@@ -54,4 +54,3 @@ module Spark
     end
   end
 end
-

data/lib/spark/component/element.rb

@@ -8,7 +8,6 @@ module Spark
       class Error < StandardError; end
 
       def self.included(base)
-        base.include(Spark::Component::Attribute)
         base.extend(Spark::Component::Element::ClassMethods)
 
         %i[_parent _block view_context].each do |name|
@@ -17,16 +16,23 @@ module Spark
         end
       end
 
+      # Initialize method on components must call super
       def initialize(attrs = nil)
         # Extract core element attributes
+        # Ensure that elements have references to their:
+        #  - parent: enables elements to interact with their parent component
+        #  - block: used in render_self
+        #  - view_context, sets the view context for an element (in Rails)
+        #
         unless attrs.nil? || attrs.empty?
           @_parent      = attrs.delete(:_parent)
           @_block       = attrs.delete(:_block)
           @view_context = attrs.delete(:_view)
         end
 
-        initialize_attributes(attrs)
         initialize_elements
+
+        # Call Attributes.initialze
         super
       end
 
@@ -193,7 +199,6 @@ module Spark
         # If an element extends a component, extend that component's class and include the necessary modules
         def extend_class(component, &config)
           base = Class.new(component || Spark::Component::Element::Base, &config)
-          # base.include(Spark::Component::Element)
           define_model_name(base) if defined?(ActiveModel)
 
           return base unless component
@@ -232,22 +237,9 @@ module Spark
       # Base class for non-component elements
       class Base
         include ActiveModel::Validations if defined?(ActiveModel)
-
-        def initialize(attrs = nil)
-          # Extract core element attributes
-          unless attrs.nil? || attrs.empty?
-            @_parent      = attrs.delete(:_parent)
-            @_block       = attrs.delete(:_block)
-            @view_context = attrs.delete(:_view)
-          end
-
-          initialize_attributes(attrs)
-          initialize_elements
-        end
-
+        include Spark::Component::Attribute
         include Spark::Component::Element
       end
     end
   end
 end
-

data/lib/spark/component/integration/action_view_component.rb

@@ -70,4 +70,3 @@ module Spark
     end
   end
 end
-

data/lib/spark/component/tag_attr.rb

@@ -42,4 +42,3 @@ module Spark
     end
   end
 end
-

data/lib/spark/component/version.rb

@@ -2,7 +2,6 @@
 
 module Spark
   module Component
-    VERSION = "1.0.0.pre.alpha.1"
+    VERSION = "1.0.0.pre.alpha.2"
   end
 end
-

data/lib/spark/component.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "spark/component/version"
+require "spark/component/attribute"
 require "spark/component/element"
 
 if defined?(ActionView::Component::Base)
@@ -10,7 +11,8 @@ end
 module Spark
   module Component
     def self.included(base)
-      base.include Spark::Component::Element unless base < Spark::Component::Element
+      base.include Spark::Component::Attribute
+      base.include Spark::Component::Element
 
       # If an Integration is defeind include its modules if the component extends
       # the defined base class
@@ -20,4 +22,3 @@ module Spark
     end
   end
 end
-

data/spark-component.gemspec

@@ -38,4 +38,3 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rubocop"
   spec.add_development_dependency "slim"
 end
-

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spark-component
 version: !ruby/object:Gem::Version
-  version: 1.0.0.pre.alpha.1
+  version: 1.0.0.pre.alpha.2
 platform: ruby
 authors:
 - Brandon Mathis