spare 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 936d9a097a732959b140e86baec575092a4aa84a
-  data.tar.gz: 7276ce1dc0323e3fe339542961bfe77181342752
+  metadata.gz: e6133fdf40c180092996247c0206ff5278ff0166
+  data.tar.gz: b608da7b494052e5b256c79430a0e981cd44fcb4
 SHA512:
-  metadata.gz: c14abbcd3286eb0b31c20387d6b9b8eae5cc9cdb014f85b0ab3d4c1efa9f7b5e86e79d631d1ef614c9a9d6399881d0f56425ad8ffd1fbc1d5d3c37cd1740a98a
-  data.tar.gz: b12e825ab02b15cefde63f18dab160b61ad62e9f221eb4d0ce4f3a7f80843eab1b89997692a25867b586dac7463c75e1eac13a168d4ac3c44526dcd6f16c330f
+  metadata.gz: 64c4fe6d1b26abef7503887f555df388c36cb9045f7002406c3e3072fa5d08d261884c94de93a703aa81c05e881a8b6520f522d9cdcca3eecc190704fe66bfda
+  data.tar.gz: 0252c0c7438670edc38276a9c1e232ddf02ef15debbbf512611f4ef09cc4ad4d27b5253616f67fe4a0a6189df74e4aacca6660bab7d27603c3d9d9ace1d9be04

data/lib/spare/core.rb

@@ -2,7 +2,7 @@ module Spare
   module Core
     # Returns a string like 'MyStoredProcedure(p_id:integer, p_title:string, p_body:text)'
     def inspect
-      if self == Base
+      if self == ActiveRecord::Base
         super
       elsif abstract_class?
         super

data/lib/spare/exceptions.rb

@@ -0,0 +1,4 @@
+require 'active_record'
+module ActiveRecord
+  class StoredProcedureNotFound < StandardError; end
+end

data/lib/spare/mysql_abstract_adapter.rb

@@ -1,3 +1,4 @@
+require 'spare/exceptions'
 require 'active_record/connection_adapters/abstract_mysql_adapter'
 module ActiveRecord
   module ConnectionAdapters
@@ -5,15 +6,15 @@ module ActiveRecord
 
       # Returns hash describing the stored procedure.
       def stored_procedure(name)#:nodoc:
-        name = name.split('.').reverse
+        sp_name = name.split('.').reverse
 
-        sql = "SELECT db,specific_name,param_list,db_collation FROM mysql.proc WHERE specific_name = #{quote(name[0])}"
-        sql << " AND db = #{quote(name[1])}" if name[1]
+        sql = "SELECT db,specific_name,param_list,db_collation FROM mysql.proc WHERE specific_name = #{quote(sp_name[0])}"
+        sql << " AND db = #{quote(sp_name[1])}" if sp_name[1]
 
         result = execute(sql)
         keys = result.fields.collect{|k| k.to_sym}
         values = result.to_a[0]
-        return nil unless values
+        raise ActiveRecord::StoredProcedureNotFound, "#{name} was not found" unless values
         sp = Hash[keys.zip(values)]
         sp[:param_list] = stored_procedure_params(sp[:param_list], sp[:db_collation])
         sp

data/lib/spare/version.rb

@@ -1,3 +1,3 @@
 module Spare
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/spare.rb

@@ -1,4 +1,5 @@
 require "active_record"
+require "spare/exceptions"
 require "spare/core"
 require "spare/attributes"
 require "spare/mysql_abstract_adapter"

data/spec/lib/spare/mysql_abstract_adapter_spec.rb

@@ -4,7 +4,7 @@ describe  ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter do
   describe '#stored_procedure' do
 
     context "stored procedure does not exist" do
-      it {expect(ActiveRecord::Base.connection.stored_procedure("bad")).to be_nil}
+      it {expect {ActiveRecord::Base.connection.stored_procedure("bad")}.to raise_error(ActiveRecord::StoredProcedureNotFound) }
     end
 
     context "stored procedure does exist" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spare
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Joshua Mckinney
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-10 00:00:00.000000000 Z
+date: 2015-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -138,6 +138,7 @@ files:
 - lib/spare.rb
 - lib/spare/attributes.rb
 - lib/spare/core.rb
+- lib/spare/exceptions.rb
 - lib/spare/model_schema.rb
 - lib/spare/mysql_abstract_adapter.rb
 - lib/spare/schema_cache.rb