spamtrap 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f1f9fa53d08c869e9952416e63376c31ed74f74584e9cf1e59f7439364c370d5
-  data.tar.gz: 4ecae5a00af343aa3c8856a3f2bcf04999bd37a0112d067d3d907e5b85b75e2a
+  metadata.gz: 7fe29ab4e860e6ec50177f3726bee89e12d1e04ad26f1690937134e2fd3bb3ec
+  data.tar.gz: ccb09fadb403aa131c826422d774f9ec0d72929ca9d3f8f737a9ddb84795ecfd
 SHA512:
-  metadata.gz: 825936fb38cb3095ecf504c42aff353081a8352539a535beff67d85ef2423fc4e7bac328c107d48d5d0ed092ea1b508be6bb06e7490c33cceb2f230a0c89e45a
-  data.tar.gz: c35648761da54aab75b8b8d587f24d4ccfbfb03210d23ed930fbdbea2743876de9a795d19980acac9bac45b92e7bbe94621f8419440031d2e15412b6876e041a
+  metadata.gz: '09de714c88709d90859cb25c8f129bb88efeba1a2c697519bca1aaa8df816894e3c442e37598c423fa8740832123af86c85b204ae5eec6eeb3115566a7fe74d4'
+  data.tar.gz: 65bda092b52a6bc5b0a58c61c5b08ad3e2f7723c1daf6418071582691eabfa0897998bf33bd7b473aae91708621cc9f0e368d1bf8e780bf14feb761c2a8f6f23

data/lib/spamtrap/helper.rb

@@ -50,6 +50,10 @@ module Spamtrap
             #   2. activerecord.attributes.Model.field (ActiveRecord models)
             #   3. helpers.label.object_name.field (plain objects / form_with)
             #   4. humanize fallback
+            # Discard any explicit nil that a subclass may have passed through
+            # (e.g. `super(method, nil, options)`) so it does not survive as a
+            # spurious positional argument in the final super call.
+            args.compact!
             unless args.first.is_a?(String)
               human_text =
                 if object.respond_to?(:to_model)

data/lib/spamtrap/version.rb

@@ -1,5 +1,5 @@
 module Spamtrap
 
-  VERSION = '0.3.4'
+  VERSION = '0.3.5'
 
 end

data/test/form_builder_mutation_test.rb

@@ -133,6 +133,38 @@ class FormBuilderMutationTest < ActionView::TestCase
     assert_match(/selected.*CA|CA.*selected/, html)
   end
 
+  # --- label ---
+
+  def test_label_does_not_raise_when_mutate_is_true
+    msg = Message.new('Alice', 'alice@example.com', 'Hello')
+    f   = build_form_builder(msg)
+    f.spamtrap(:trap, mutate: true)
+
+    assert_nothing_raised { f.label(:name) }
+  end
+
+  def test_label_with_explicit_nil_text_does_not_raise
+    # Regression: a subclass that calls super(method, nil, options) used to
+    # produce "wrong number of arguments (given 4, expected 1..3)" because the
+    # nil survived as a positional argument alongside the auto-generated text.
+    msg  = Message.new('Alice', 'alice@example.com', 'Hello')
+    base = build_form_builder(msg)
+    base.spamtrap(:trap, mutate: true)
+
+    # Simulate what a subclass does: call label with nil text explicitly.
+    assert_nothing_raised { base.label(:name, nil, class: 'my-label') }
+  end
+
+  def test_label_with_explicit_nil_text_uses_humanized_fallback
+    msg  = Message.new('Alice', 'alice@example.com', 'Hello')
+    base = build_form_builder(msg)
+    base.spamtrap(:trap, mutate: true)
+
+    html = base.label(:name, nil, class: 'my-label')
+
+    assert_includes html, 'Name'
+  end
+
   private
 
   # ActionView::TestCase helpers expect a #request method; provide a stub.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spamtrap
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Cedric Howe