spaceship 0.9.1 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cf8ca41ac0b946d578d855c3a431cae89fb3f0f2
-  data.tar.gz: 06a07235c238b5897db26524f4c7c08893f80bb9
+  metadata.gz: efa1b4e8b3db202da5e7986548e0dcea255001ee
+  data.tar.gz: 56647e6df8b7dba71255a2926f99877c67f6fc0d
 SHA512:
-  metadata.gz: 4b911d4da0a67be7a23ced00ec77d7d27dcdf9750f6197519f46ae2493bf4b15e191c2a74d22ea42deb162035b322c2d0439a61765b83989c7fe0d1c0f579db5
-  data.tar.gz: c2a748e0fb3bb4d7a6b648fc575d2709377aacbe58ea4ee4f68d08383095f8c280f6bc8421d311638758c465689e5e4266739733145c1bbb8637c8fedc60a23b
+  metadata.gz: f7726bf84f6a72ef2e2c166f81010496c044e4c7f24aca2aca660c180ebf872c85d230fcb4a504adf6776883c297826dba5671675668e015a424ec3a22f1a4e4
+  data.tar.gz: 448f9f093b28462f4ab451e5e0daa273a78b557b6c17aec50dcf738252267e7b47687b519322f765767714c7f2de32eef7a2ed0bc2e3bfa529431c62afb2c280

data/lib/spaceship/tunes/app_submission.rb

@@ -14,6 +14,8 @@ module Spaceship
       # @return (Boolean) Submitted for Review
       attr_accessor :submitted_for_review
 
+      # To pass from the user
+
       # @return (Boolean) Ad ID Info - Limits ads tracking
       attr_accessor :add_id_info_limits_tracking
 
@@ -66,7 +68,6 @@ module Spaceship
       attr_accessor :export_compliance_platform
 
       attr_mapping({
-
         # Ad ID Info Section
         'adIdInfo.limitsTracking.value' => :add_id_info_limits_tracking,
         'adIdInfo.servesAds.value' => :add_id_info_serves_ads,

data/lib/spaceship/tunes/app_version.rb

@@ -2,6 +2,7 @@ module Spaceship
   module Tunes
     # Represents an editable version of an iTunes Connect Application
     # This can either be the live or the edit version retrieved via the app
+    # rubocop:disable Metrics/ClassLength
     class AppVersion < TunesBase
       # @return (Spaceship::Tunes::Application) A reference to the application
       #   this version is for
@@ -173,35 +174,27 @@ module Spaceship
       # Call this method to make sure the given languages are available for this app
       # You should call this method before accessing the name, description and other localized values
       # This will create the new language if it's not available yet and do nothing if everything's there
-      # def create_languages!(languages)
-      #   raise "Please pass an array" unless languages.kind_of?Array
-
-      #   copy_from = self.languages.first
-      #   languages.each do |language|
-      #     # First, see if it's already available
-      #     found = self.languages.find do |local|
-      #       local['language'] == language
-      #     end
-
-      #     unless found
-      #       new_language = copy_from.dup
-      #       new_language['language'] = language
-      #       [:description, :releaseNotes, :keywords].each do |key|
-      #         new_language[key.to_s]['value'] = nil
-      #       end
-
-      #       self.languages << new_language
-      #       unfold_languages
-
-      #       # Now we need to set a useless `pageLanguageValue` value because iTC says so, after adding a new version
-      #       self.languages.each do |current|
-      #         current['pageLanguageValue'] = current['language']
-      #       end
-      #     end
-      #   end
-
-      #   languages
-      # end
+      # Important: Due to a bug you have to fetch the `edit_version` again, as it doesn't get refreshed immediately
+      def create_languages(languages)
+        languages = [languages] if languages.kind_of?(String)
+        raise "Please pass an array" unless languages.kind_of? Array
+
+        copy_from = self.languages.find { |a| a['language'] == 'en-US' } || self.languages.first
+
+        languages.each do |language|
+          # First, see if it's already available
+          found = self.languages.find do |local|
+            local['language'] == language
+          end
+          next if found
+
+          new_language = copy_from.clone
+          new_language['language'] = language
+
+          self.languages << new_language
+        end
+        nil
+      end
 
       # Returns an array of all builds that can be sent to review
       def candidate_builds
@@ -224,9 +217,52 @@ module Spaceship
         true
       end
 
+      # Set the age restriction rating
+      # Call it like this:
+      # v.update_rating({
+      #   'CARTOON_FANTASY_VIOLENCE' => 0,
+      #   'MATURE_SUGGESTIVE' => 2,
+      #   'UNRESTRICTED_WEB_ACCESS' => 0,
+      #   'GAMBLING_CONTESTS' => 0
+      # })
+      #
+      # Available Values
+      # https://github.com/KrauseFx/deliver/blob/master/Reference.md
+      def update_rating(hash)
+        raise "Must be a hash" unless hash.kind_of?(Hash)
+
+        hash.each do |key, value|
+          to_edit = self.raw_data['ratings']['nonBooleanDescriptors'].find do |current|
+            current['name'].include?(key)
+          end
+
+          if to_edit
+            to_set = "NONE" if value == 0
+            to_set = "INFREQUENT_MILD" if value == 1
+            to_set = "FREQUENT_INTENSE" if value == 2
+            raise "Invalid value '#{value}' for '#{key}', must be 0-2" unless to_set
+            to_edit['level'] = "ITC.apps.ratings.level.#{to_set}"
+          else
+            # Maybe it's a boolean descriptor?
+            to_edit = self.raw_data['ratings']['booleanDescriptors'].find do |current|
+              current['name'].include?(key)
+            end
+
+            if to_edit
+              to_set = "NO"
+              to_set = "YES" if value.to_i > 0
+              to_edit['level'] = "ITC.apps.ratings.level.#{to_set}"
+            else
+              raise "Could not find option '#{key}' in the list of available options"
+            end
+          end
+        end
+        true
+      end
+
       # Push all changes that were made back to iTunes Connect
       def save!
-        client.update_app_version!(application.apple_id, is_live?, raw_data)
+        client.update_app_version!(application.apple_id, self.version_id, raw_data)
       end
 
       # @return (String) An URL to this specific resource. You can enter this URL into your browser
@@ -533,5 +569,6 @@ module Spaceship
         raw_data["details"]["value"]
       end
     end
+    # rubocop:enable Metrics/ClassLength
   end
 end

data/lib/spaceship/tunes/application.rb

@@ -165,6 +165,25 @@ module Spaceship
         # Future: implemented -reload method
       end
 
+      # Will make sure the current edit_version matches the given version number
+      # This will either create a new version or change the version number
+      # from an existing version
+      # @return (Bool) Was something changed?
+      def ensure_version!(version_number)
+        if (e = edit_version)
+          if e.version.to_s != version_number.to_s
+            # Update an existing version
+            e.version = version_number
+            e.save!
+            return true
+          end
+          return false
+        else
+          create_version!(version_number)
+          return true
+        end
+      end
+
       # set the price tier. This method doesn't require `save` to be called
       def update_price_tier!(price_tier)
         client.update_price_tier!(self.apple_id, price_tier)

data/lib/spaceship/tunes/tunes_client.rb

@@ -223,12 +223,17 @@ module Spaceship
 
     def create_version!(app_id, version_number)
       r = request(:post) do |req|
-        req.url "ra/apps/version/create/#{app_id}"
-        req.body = { version: version_number.to_s }.to_json
+        req.url "ra/apps/#{app_id}/platforms/ios/versions/create/"
+        req.body = {
+          version: {
+            value: version_number.to_s
+          }
+        }.to_json
         req.headers['Content-Type'] = 'application/json'
       end
 
-      parse_response(r, 'data')
+      data = parse_response(r, 'data')
+      handle_itc_response(data)
     end
 
     def get_resolution_center(app_id)
@@ -257,13 +262,12 @@ module Spaceship
       parse_response(r, 'data')
     end
 
-    def update_app_version!(app_id, is_live, data)
+    def update_app_version!(app_id, version_id, data)
       raise "app_id is required" unless app_id
-
-      v_text = (is_live ? 'live' : nil)
+      raise "version_id is required" unless version_id.to_i > 0
 
       r = request(:post) do |req|
-        req.url "ra/apps/version/save/#{app_id}?v=#{v_text}"
+        req.url "ra/apps/#{app_id}/platforms/ios/versions/#{version_id}"
         req.body = data.to_json
         req.headers['Content-Type'] = 'application/json'
       end
@@ -557,6 +561,13 @@ module Spaceship
       end
 
       handle_itc_response(r.body)
+
+      if r.body.fetch('messages').fetch('info').last == "Successful POST"
+        # success
+      else
+        raise "Something went wrong when submitting the app for review. Make sure to pass valid options to submit your app for review"
+      end
+
       parse_response(r, 'data')
     end
 

data/lib/spaceship/version.rb

@@ -1,3 +1,3 @@
 module Spaceship
-  VERSION = "0.9.1"
+  VERSION = "0.10.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spaceship
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.10.0
 platform: ruby
 authors:
 - Felix Krause
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-28 00:00:00.000000000 Z
+date: 2015-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: credentials_manager