spaceship 0.38.1 → 0.38.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9ccb25cc6bac20555b7301bc25aae3475b6d2d49
-  data.tar.gz: b83f4bb660b5e8e67bc695b0a8754e76a2740552
+  metadata.gz: 0d6e5eb4de7b6f8e0a32ebbbd5117477d8647f10
+  data.tar.gz: 9694bc300c94f5690cfc302a84d863f3639942e0
 SHA512:
-  metadata.gz: 8bc3d0c2c3fa385c274841760584d3c174350ad1bb4bf36af481e6178a290c380be765da71fa203c89b89d67d5a030ad92122121ca94fe253288f120d90de3e0
-  data.tar.gz: c29023f15cad38990e9e1f042e331232f5021172b6617738c9eb74735e75bafc12506dc4cb826a4e3fbc3c430e737ff620da67a394dfb1ffc3d1f703d4db2e6b
+  metadata.gz: db4a4ee41976c6396ce0316ea2143c198e0f40acf61599607e923c4957ad1045faec4207cc96d4da4b7e768daec4fb15e73603e94438311b8b2624df0a223338
+  data.tar.gz: 84b16e823c2e9e3c77893d74e476bd94921207903100aad5aeb08a3ca07b23d5569acae113e00719fc486fcb10204bd84459c2780c74f2da25f3af5075275ed4

data/lib/assets/languageMapping.json

@@ -2,12 +2,14 @@
     {
         "locale": "cmn-Hans",
         "name": "Simplified Chinese",
-        "game-center": true
+        "game-center": true,
+        "itc_locale": "zh-Hans"        
     },
     {
         "locale": "cmn-Hant",
         "name": "Traditional Chinese",
-        "game-center": true
+        "game-center": true,
+        "itc_locale": "zh-Hant"
     },
     {
         "locale": "da-DK",
@@ -15,7 +17,8 @@
         "game-center": true,
         "alternatives": [
             "da"
-        ]
+        ],
+        "itc_locale": "da"
     },
     {
         "locale": "nl-NL",
@@ -66,7 +69,8 @@
         "game-center": true,
         "alternatives": [
             "fi"
-        ]
+        ],
+        "itc_locale": "fin"
     },
     {
         "locale": "fr-CA",
@@ -100,7 +104,8 @@
         "game-center": true,
         "alternatives": [
             "el"
-        ]
+        ],
+        "itc_locale": "el"
     },
     {
         "locale": "id-ID",
@@ -108,7 +113,8 @@
         "game-center": true,
         "alternatives": [
             "id"
-        ]
+        ],
+        "itc_locale": "id"
     },
     {
         "locale": "it-IT",
@@ -116,7 +122,8 @@
         "game-center": true,
         "alternatives": [
             "it"
-        ]
+        ],
+        "itc_locale": "it"
     },
     {
         "locale": "ja-JP",
@@ -124,7 +131,8 @@
         "game-center": true,
         "alternatives": [
             "ja"
-        ]
+        ],
+        "itc_locale": "ja"
     },
     {
         "locale": "ko-KR",
@@ -132,7 +140,8 @@
         "game-center": true,
         "alternatives": [
             "ko"
-        ]
+        ],
+        "itc_locale": "ko"
     },
     {
         "locale": "ms-MY",
@@ -140,7 +149,8 @@
         "game-center": true,
         "alternatives": [
             "ms"
-        ]
+        ],
+        "itc_locale": "ms"
     },
     {
         "locale": "no-NO",
@@ -148,7 +158,8 @@
         "game-center": true,
         "alternatives": [
             "no"
-        ]
+        ],
+        "itc_locale": "no"
     },
     {
         "locale": "pt-BR",
@@ -169,7 +180,8 @@
         "game-center": true,
         "alternatives": [
             "ru"
-        ]
+        ],
+        "itc_locale": "ru"
     },
     {
         "locale": "es-MX",
@@ -195,7 +207,8 @@
         "game-center": true,
         "alternatives": [
             "sv"
-        ]
+        ],
+        "itc_locale": "sv"
     },
     {
         "locale": "th-TH",
@@ -203,7 +216,8 @@
         "game-center": true,
         "alternatives": [
             "th"
-        ]
+        ],
+        "itc_locale": "th"
     },
     {
         "locale": "tr-TR",
@@ -211,7 +225,8 @@
         "game-center": true,
         "alternatives": [
             "tr"
-        ]
+        ],
+        "itc_locale": "tr"
     },
     {
         "locale": "vi-VI",
@@ -219,6 +234,7 @@
         "game-center": true,
         "alternatives": [
             "vi"
-        ]
+        ],
+        "itc_locale": "vi"
     }
 ]

data/lib/spaceship/client.rb

@@ -6,6 +6,7 @@ require 'spaceship/ui'
 require 'spaceship/helper/plist_middleware'
 require 'spaceship/helper/net_http_generic_request'
 require 'tmpdir'
+require "babosa"
 
 Faraday::Utils.default_params_encoder = Faraday::FlatParamsEncoder
 

data/lib/spaceship/portal/portal_client.rb

@@ -132,6 +132,18 @@ module Spaceship
       details_for_app(app)
     end
 
+    def valid_name_for(input)
+      latinazed = input.to_slug.transliterate
+      latinazed = latinazed.gsub(/[^0-9A-Za-z\d\s]/, '') # remove non-valid characters
+      # Check if the input string was modified, since it might be empty now
+      # (if it only contained non-latin symbols) or the duplicate of another app
+      if latinazed != input
+        latinazed << " "
+        latinazed << Digest::MD5.hexdigest(input)
+      end
+      latinazed
+    end
+
     def create_app!(type, name, bundle_id, mac: false)
       # We moved the ensure_csrf to the top of this method
       # as we got some users with issues around creating new apps
@@ -155,7 +167,7 @@ module Spaceship
                      end
 
       params = {
-        name: name,
+        name: valid_name_for(name),
         teamId: team_id
       }
 

data/lib/spaceship/tunes/language_converter.rb

@@ -8,6 +8,12 @@ module Spaceship
           (result || {}).fetch('locale', nil)
         end
 
+        # Converts the Language "UK English" to itc locale en-GB
+        def from_standard_to_itc_locale(from)
+          result = mapping.find { |a| a['name'] == from } || {}
+          return result['itc_locale'] || result['locale']
+        end
+
         # Converts the language short codes: (en-US, de-DE) to the iTC format (English_CA, Brazilian Portuguese)
         def from_standard_to_itc(from)
           result = mapping.find { |a| a['locale'] == from || (a['alternatives'] || []).include?(from) }
@@ -47,6 +53,10 @@ class String
     Spaceship::Tunes::LanguageConverter.from_itc_to_standard(self)
   end
 
+  def to_itc_locale
+    Spaceship::Tunes::LanguageConverter.from_standard_to_itc_locale(self)
+  end
+
   def to_full_language
     Spaceship::Tunes::LanguageConverter.from_standard_to_itc(self)
   end

data/lib/spaceship/tunes/tunes_client.rb

@@ -277,7 +277,7 @@ module Spaceship
       data['name'] = { value: name }
       data['bundleId'] = { value: bundle_id }
       data['primaryLanguage'] = { value: primary_language }
-      data['primaryLocaleCode'] = { value: primary_language.to_language_code }
+      data['primaryLocaleCode'] = { value: primary_language.to_itc_locale }
       data['vendorId'] = { value: sku }
       data['bundleIdSuffix'] = { value: bundle_id_suffix }
       data['companyName'] = { value: company_name } if company_name

data/lib/spaceship/version.rb

@@ -1,4 +1,4 @@
 module Spaceship
-  VERSION = "0.38.1".freeze
+  VERSION = "0.38.2".freeze
   DESCRIPTION = "Ruby library to access the Apple Dev Center and iTunes Connect".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spaceship
 version: !ruby/object:Gem::Version
-  version: 0.38.1
+  version: 0.38.2
 platform: ruby
 authors:
 - Felix Krause
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-25 00:00:00.000000000 Z
+date: 2016-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: credentials_manager
@@ -115,6 +115,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
+- !ruby/object:Gem::Dependency
+  name: babosa
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: colored
   requirement: !ruby/object:Gem::Requirement
@@ -402,7 +416,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Ruby library to access the Apple Dev Center and iTunes Connect