spaceship 0.32.3 → 0.32.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f86e2d7063e85473a86952fb951e76229f569ef1
-  data.tar.gz: c9eaae0e51a6afa2f528b7c9dc1e479425b50e33
+  metadata.gz: c1ed1ed0e0ca3f83e0938bfef281e22c419dda58
+  data.tar.gz: 671c565c25a2f2f36471ad8a11409a6f2d857067
 SHA512:
-  metadata.gz: d3b222516451a9fe5e7cb22c8d0bd27a13e1bcc394bf1aa182859d22305594dd819310d7a3d0e8668f7a675086497a8ca180d78959859112a0b45c56dfdbdf82
-  data.tar.gz: fc66e1542b2ee6879e5255258ad25b001a88fef898f122a8995a9e01d47b911bf070e265662bc3227d178be18aae97670e2bdee4506a7da1881b7a808f51c2a5
+  metadata.gz: cd6289e6ba47c42d84ed2f6e077f891510b4c03538e3d786a434610755768ef995f34aa87846e5c8a454fc4bb86e267971d3724276f5e0a87dbc45653446bee1
+  data.tar.gz: cd6b1a3daa56dbc8ab755e8f49ca653c2992988572e586c521e111b98c85d9d4ff11459f98051becb66891a0c4e61fad3a17b59039eb65c51af84a90a5ea23a0

data/lib/spaceship/portal/provisioning_profile.rb

@@ -119,6 +119,11 @@ module Spaceship
       #  profile.devices.first.name
       attr_accessor :devices
 
+      # This is the second level request, which is done before creating the object
+      # this includes information about the devices and the certificates
+      # more information on this issue https://github.com/fastlane/fastlane/issues/6137
+      attr_accessor :profile_details
+
       attr_mapping({
         'provisioningProfileId' => :id,
         'UUID' => :uuid,
@@ -148,7 +153,12 @@ module Spaceship
         # This is used to create a new object based on the server response.
         def factory(attrs)
           # Ad Hoc Profiles look exactly like App Store profiles, but usually include devices
-          attrs['distributionMethod'] = 'adhoc' if attrs['distributionMethod'] == 'store' && attrs['devices'].size > 0
+          profile_details = client.provisioning_profile_details(provisioning_profile_id: attrs["provisioningProfileId"])
+
+          # The only difference between App Store and Ad Hoc provisioniong profile is the devices that are attached
+          if attrs['distributionMethod'] == 'store' && (profile_details['devices'] || []).size > 0
+            attrs['distributionMethod'] = 'adhoc'
+          end
           # available values of `distributionMethod` at this point: ['adhoc', 'store', 'limited']
 
           klass = case attrs['distributionMethod']
@@ -164,12 +174,30 @@ module Spaceship
                     raise "Can't find class '#{attrs['distributionMethod']}'"
                   end
 
-          # eagerload the Apps and Devices using the same client if we have to.
+          # eagerload the Apps using the same client if we have to.
           attrs['appId'] = App.set_client(@client).factory(attrs['appId'])
-          attrs['devices'].map! { |device| Device.set_client(@client).factory(device) }
 
           klass.client = @client
-          klass.new(attrs)
+          obj = klass.new(attrs)
+
+          # Set the response of the details request, in case we want to access it later on
+          obj.profile_details = profile_details
+
+          # Since 15th September 2016 certificates and devices are hidden behind another request
+          # see https://github.com/fastlane/fastlane/issues/6137 for more information
+          # That's why we set it here
+
+          # Parse all the devices from the details request
+          obj.devices = (profile_details["devices"] || []).collect do |device|
+            Device.set_client(client).factory(device)
+          end
+
+          # Parse all the certificates from the details request
+          obj.certificates = (profile_details["certificates"] || []).collect do |cert|
+            Certificate.set_client(client).factory(cert)
+          end
+
+          return obj
         end
 
         # @return (String) The human readable name of this profile type.
@@ -390,19 +418,6 @@ module Spaceship
       def mac?
         platform == 'mac'
       end
-
-      # Since 15th September 2016 this hidden behind another request
-      # see https://github.com/fastlane/fastlane/issues/6137 for more information
-      def certificates
-        @internal_certificates ||= (details["certificates"] || []).collect do |cert|
-          Certificate.set_client(client).factory(cert)
-        end
-      end
-
-      # This is data that can only be fetched from the getProvisioningProfile.action API endpoint
-      def details
-        @details ||= client.provisioning_profile_details(provisioning_profile_id: self.id)
-      end
     end
   end
 end

data/lib/spaceship/version.rb

@@ -1,4 +1,4 @@
 module Spaceship
-  VERSION = "0.32.3".freeze
+  VERSION = "0.32.4".freeze
   DESCRIPTION = "Ruby library to access the Apple Dev Center and iTunes Connect".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spaceship
 version: !ruby/object:Gem::Version
-  version: 0.32.3
+  version: 0.32.4
 platform: ruby
 authors:
 - Felix Krause
@@ -392,7 +392,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.6
 signing_key: 
 specification_version: 4
 summary: Ruby library to access the Apple Dev Center and iTunes Connect