spaceship 0.3.4 → 0.4.0

data/lib/spaceship/tunes/app_version.rb

@@ -124,7 +124,6 @@ module Spaceship
       # @return (Hash) Represents the screenshots of this app version (read-only)
       attr_reader :screenshots
 
-
       attr_mapping({
         'canBetaTest' => :can_beta_test,
         'canPrepareForUpload' => :can_prepare_for_upload,
@@ -229,7 +228,6 @@ module Spaceship
         "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/ng/app/#{self.application.apple_id}/" + (self.is_live? ? "cur" : "")
       end
 
-
       # Private methods
       def setup
         # Properly parse the AppStatus
@@ -244,7 +242,6 @@ module Spaceship
         end
       end
 
-
       # Prefill name, keywords, etc...
       def unfold_languages
         {
@@ -271,64 +268,60 @@ module Spaceship
       end
 
       def primary_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
-        super(value)
-      end
-
-      def primary_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       def primary_first_sub_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       def primary_second_sub_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       def secondary_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       def secondary_first_sub_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       def secondary_second_sub_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       private
+
         # generates the nested data structure to represent screenshots
-        def setup_screenshots(row)
-          screenshots = row.fetch('screenshots', {}).fetch('value', nil)
-          return [] unless screenshots
-
-          result = []
-
-          screenshots.each do |device_type, value|
-            value['value'].each do |screenshot|
-              screenshot = screenshot['value']
-              result << Tunes::AppScreenshot.new({
-                url: screenshot['url'],
-                thumbnail_url: screenshot['thumbNailUrl'],
-                sort_order: screenshot['sortOrder'],
-                original_file_name: screenshot['originalFileName'],
-                device_type: device_type,
-                language: row['language']
-              })
-            end
+      def setup_screenshots(row)
+        screenshots = row.fetch('screenshots', {}).fetch('value', nil)
+        return [] unless screenshots
+
+        result = []
+
+        screenshots.each do |device_type, value|
+          value['value'].each do |screenshot|
+            screenshot = screenshot['value']
+            result << Tunes::AppScreenshot.new({
+              url: screenshot['url'],
+              thumbnail_url: screenshot['thumbNailUrl'],
+              sort_order: screenshot['sortOrder'],
+              original_file_name: screenshot['originalFileName'],
+              device_type: device_type,
+              language: row['language']
+            })
           end
-
-          return result
         end
+
+        return result
+      end
     end
   end
 end

data/lib/spaceship/tunes/application.rb

@@ -1,9 +1,9 @@
 module Spaceship
   module Tunes
     class Application < TunesBase
-      
+
       # @return (String) The App identifier of this app, provided by iTunes Connect
-      # @example 
+      # @example
       #   "1013943394"
       attr_accessor :apple_id
 
@@ -13,17 +13,17 @@ module Spaceship
       attr_accessor :name
 
       # @return (String) the supported platform of this app
-      # @example 
+      # @example
       #   "ios"
       attr_accessor :platform
 
       # @return (String) The Vendor ID provided by iTunes Connect
-      # @example 
+      # @example
       #   "1435592086"
       attr_accessor :vendor_id
 
       # @return (String) The bundle_id (app identifier) of your app
-      # @example 
+      # @example
       #   "com.krausefx.app"
       attr_accessor :bundle_id
 
@@ -34,7 +34,7 @@ module Spaceship
       attr_accessor :issues_count
 
       # @return (String) The URL to a low resolution app icon of this app (340x340px). Might be nil
-      # @example 
+      # @example
       #   "https://is1-ssl.mzstatic.com/image/thumb/Purple7/v4/cd/a3/e2/cda3e2ac-4034-c6af-ee0c-3e4d9a0bafaa/pr_source.png/340x340bb-80.png"
       # @example
       #   nil
@@ -50,7 +50,7 @@ module Spaceship
         'issuesCount' => :issues_count,
         'iconUrl' => :app_icon_preview_url
       )
-      
+
       class << self
         # Create a new object based on a hash.
         # This is used to create a new object based on the server response.
@@ -72,22 +72,22 @@ module Spaceship
         end
 
         # Creates a new application on iTunes Connect
-        # @param name (String): The name of your app as it will appear on the App Store. 
+        # @param name (String): The name of your app as it will appear on the App Store.
         #   This can't be longer than 255 characters.
-        # @param primary_language (String): If localized app information isn't available in an 
+        # @param primary_language (String): If localized app information isn't available in an
         #   App Store territory, the information from your primary language will be used instead.
-        # @param version (String): The version number is shown on the App Store and should 
+        # @param version (String): The version number is shown on the App Store and should
         #   match the one you used in Xcode.
         # @param sku (String): A unique ID for your app that is not visible on the App Store.
-        # @param bundle_id (String): The bundle ID must match the one you used in Xcode. It 
+        # @param bundle_id (String): The bundle ID must match the one you used in Xcode. It
         #   can't be changed after you submit your first build.
         # @param company_name (String): The company name or developer name to display on the App Store for your apps.
         # It cannot be changed after you create your first app.
         def create!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil)
-          client.create_application!(name: name, 
-                         primary_language: primary_language, 
-                                  version: version, 
-                                      sku: sku, 
+          client.create_application!(name: name,
+                         primary_language: primary_language,
+                                  version: version,
+                                      sku: sku,
                                 bundle_id: bundle_id,
                                 bundle_id_suffix: bundle_id_suffix,
                                 company_name: company_name)
@@ -99,7 +99,7 @@ module Spaceship
       #####################################################
 
       # @return (Spaceship::AppVersion) Receive the version that is currently live on the
-      #  App Store. You can't modify all values there, so be careful. 
+      #  App Store. You can't modify all values there, so be careful.
       def live_version
         v = Spaceship::AppVersion.find(self, self.apple_id, true)
       end
@@ -127,7 +127,7 @@ module Spaceship
         "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/ng/app/#{self.apple_id}"
       end
 
-      # @return (Hash) Contains the reason for rejection. 
+      # @return (Hash) Contains the reason for rejection.
       #  if everything is alright, the result will be
       #  `{"sectionErrorKeys"=>[], "sectionInfoKeys"=>[], "sectionWarningKeys"=>[], "replyConstraints"=>{"minLength"=>1, "maxLength"=>4000}, "appNotes"=>{"threads"=>[]}, "betaNotes"=>{"threads"=>[]}, "appMessages"=>{"threads"=>[]}}`
       def resolution_center
@@ -137,7 +137,7 @@ module Spaceship
       #####################################################
       # @!group Modifying
       #####################################################
-     
+
       # Create a new version of your app
       # Since we have stored the outdated raw_data, we need to refresh this object
       # otherwise `edit_version` will return nil
@@ -166,7 +166,7 @@ module Spaceship
       #   Those builds can also be the builds that are stuck on iTC.
       def pre_processing_builds
         data = client.build_trains(apple_id) # we need to fetch all trains here to get the builds
-        
+
         data.fetch('processingBuilds', []).collect do |attrs|
           attrs.merge!(build_train: self)
           Tunes::ProcessingBuild.factory(attrs)
@@ -177,7 +177,7 @@ module Spaceship
       #   this include pre-processing or standard processing
       def all_processing_builds
         builds = self.pre_processing_builds
-      
+
         self.build_trains.each do |version_number, train|
           train.processing_builds.each do |build|
             builds << build
@@ -203,13 +203,13 @@ module Spaceship
       #####################################################
       # @!group Submit for Review
       #####################################################
-      
+
       def create_submission
         version = self.latest_version
         if version.nil?
           raise "Could not find a valid version to submit for review"
         end
-        
+
         Spaceship::AppSubmission.create(self, self.apple_id, version)
       end
 
@@ -229,7 +229,6 @@ module Spaceship
       # @!group General
       #####################################################
       def setup
-        
       end
 
       #####################################################
@@ -273,8 +272,8 @@ module Spaceship
       def add_external_tester!(email: nil, first_name: nil, last_name: nil)
         raise "Tester is already on #{self.name} betatesters" if find_external_tester(email)
 
-        tester = Tunes::Tester.external.find(email) || Tunes::Tester.external.create!(email: email, 
-                                                                                 first_name: first_name, 
+        tester = Tunes::Tester.external.find(email) || Tunes::Tester.external.create!(email: email,
+                                                                                 first_name: first_name,
                                                                                   last_name: last_name)
         tester.add_to_app!(self.apple_id)
       end

data/lib/spaceship/tunes/build.rb

@@ -6,7 +6,7 @@ module Spaceship
       #####################################################
       # @!group General metadata
       #####################################################
-      
+
       # @return (Spaceship::Tunes::BuildTrain) A reference to the build train this build is contained in
       attr_accessor :build_train
 
@@ -44,11 +44,10 @@ module Spaceship
       #   this is only true after the build was approved by Apple
       attr_accessor :external_testing_enabled
 
-
       # @return (Bool) Does this build support WatchKit?
       attr_accessor :watch_kit_enabled
 
-      # @return (Bool): 
+      # @return (Bool):
       attr_accessor :ready_to_install
 
       #####################################################
@@ -88,7 +87,7 @@ module Spaceship
         'internalExpiry' => :internal_expiry_date,
         'externalExpiry' => :external_expiry_date,
         'watchKitEnabled' => :watch_kit_enabled,
-        'readyToInstall' => :ready_to_install,
+        'readyToInstall' => :ready_to_install
       )
 
       class << self
@@ -129,9 +128,9 @@ module Spaceship
       def submit_for_beta_review!(metadata)
         # First, enable beta testing for this train (per iTC requirement)
         self.build_train.update_testing_status!(true)
-        
+
         parameters = {
-          app_id: self.build_train.application.apple_id, 
+          app_id: self.build_train.application.apple_id,
           train: self.build_train.version_string,
           build_number: self.build_version,
 
@@ -182,7 +181,7 @@ module Spaceship
 
       # This will cancel the review process for this TestFlight build
       def cancel_beta_review!
-        client.remove_testflight_build_from_review!(app_id: self.build_train.application.apple_id, 
+        client.remove_testflight_build_from_review!(app_id: self.build_train.application.apple_id,
                                                      train: self.build_train.version_string,
                                               build_number: self.build_version)
       end

data/lib/spaceship/tunes/build_train.rb

@@ -54,7 +54,7 @@ module Spaceship
       # Setup all the builds and processing builds
       def setup
         super
-        
+
         @builds = self.raw_data['builds'].collect do |attrs|
           attrs.merge!(build_train: self)
           Tunes::Build.factory(attrs)
@@ -78,4 +78,4 @@ module Spaceship
       end
     end
   end
-end
+end

data/lib/spaceship/tunes/language_converter.rb

@@ -28,23 +28,24 @@ module Spaceship
         end
 
         private
+
           # Path to the gem to fetch resoures
-          def spaceship_gem_path
-            if Gem::Specification::find_all_by_name('spaceship').any?
-              return Gem::Specification.find_by_name('spaceship').gem_dir
-            else
-              return './'
-            end
+        def spaceship_gem_path
+          if Gem::Specification::find_all_by_name('spaceship').any?
+            return Gem::Specification.find_by_name('spaceship').gem_dir
+          else
+            return './'
           end
+        end
 
           # Get the mapping JSON parsed
-          def mapping
-            @languages ||= JSON.parse(File.read(File.join(spaceship_gem_path, "lib", "assets", "languageMapping.json")))
-          end
+        def mapping
+          @languages ||= JSON.parse(File.read(File.join(spaceship_gem_path, "lib", "assets", "languageMapping.json")))
+        end
 
-          def readable_mapping
-            @readable ||= JSON.parse(File.read(File.join(spaceship_gem_path, "lib", "assets", "languageMappingReadable.json")))
-          end
+        def readable_mapping
+          @readable ||= JSON.parse(File.read(File.join(spaceship_gem_path, "lib", "assets", "languageMappingReadable.json")))
+        end
       end
     end
   end
@@ -58,4 +59,4 @@ class String
   def to_full_language
     Spaceship::Tunes::LanguageConverter.from_standard_to_itc(self)
   end
-end
+end

data/lib/spaceship/tunes/language_item.rb

@@ -51,4 +51,4 @@ module Spaceship
       end
     end
   end
-end
+end

data/lib/spaceship/tunes/processing_build.rb

@@ -27,4 +27,4 @@ module Spaceship
       end
     end
   end
-end
+end

data/lib/spaceship/tunes/spaceship.rb

@@ -8,19 +8,19 @@ module Spaceship
       # Authenticates with Apple's web services. This method has to be called once
       # to generate a valid session. The session will automatically be used from then
       # on.
-      # 
+      #
       # This method will automatically use the username from the Appfile (if available)
       # and fetch the password from the Keychain (if available)
-      # 
+      #
       # @param user (String) (optional): The username (usually the email address)
       # @param password (String) (optional): The password
-      # 
+      #
       # @raise InvalidUserCredentialsError: raised if authentication failed
-      # 
+      #
       # @return (Spaceship::Client) The client the login method was called for
       def login(user = nil, password = nil)
         @client = TunesClient.login(user, password)
       end
     end
   end
-end
+end

data/lib/spaceship/tunes/tester.rb

@@ -3,22 +3,22 @@ module Spaceship
     class Tester < TunesBase
 
       # @return (String) The identifier of this tester, provided by iTunes Connect
-      # @example 
+      # @example
       #   "60f858b4-60a8-428a-963a-f943a3d68d17"
       attr_accessor :tester_id
 
       # @return (String) The email of this tester
-      # @example 
+      # @example
       #   "tester@spaceship.com"
       attr_accessor :email
-      
+
       # @return (String) The first name of this tester
-      # @example 
+      # @example
       #   "Cary"
       attr_accessor :first_name
 
       # @return (String) The last name of this tester
-      # @example 
+      # @example
       #   "Bennett"
       attr_accessor :last_name
 
@@ -32,7 +32,6 @@ module Spaceship
       #    }]
       attr_accessor :devices
 
-
       # Information about the most recent beta install
       # @return [Integer] The ID of the most recently installed app
       attr_accessor :latest_install_app_id
@@ -56,7 +55,7 @@ module Spaceship
         'latestInstalledAppAdamId' => :latest_install_app_id,
         'latestInstalledDate' => :latest_install_date,
         'latestInstalledVersion' => :latest_installed_version_number,
-        'latestInstalledShortVersion' => :latest_installed_build_number,
+        'latestInstalledShortVersion' => :latest_installed_build_number
       )
 
       class << self
@@ -90,10 +89,10 @@ module Spaceship
         # @param email (String) (required): The email of the new tester
         # @param first_name (String) (optional): The first name of the new tester
         # @param last_name (String) (optional): The last name of the new tester
-        # @example 
+        # @example
         #   Spaceship::Tunes::Tester.external.create!(email: "tester@mathiascarignani.com", first_name: "Cary", last_name:"Bennett")
         # @return (Tester): The newly created tester
-        def create!(email: nil, first_name: nil, last_name: nil) 
+        def create!(email: nil, first_name: nil, last_name: nil)
           data = client.create_tester!(tester: self,
                                         email: email,
                                    first_name: first_name,
@@ -107,7 +106,7 @@ module Spaceship
 
         # @return (Array) Returns all beta testers available for this account filtered by app
         # @param app_id (String) (required): The app id to filter the testers
-        def all_by_app(app_id) 
+        def all_by_app(app_id)
           client.testers_by_app(self, app_id).map { |tester| self.factory(tester) }
         end
 
@@ -128,7 +127,7 @@ module Spaceship
             begin
               tester.add_to_app!(app_id)
             rescue => ex
-              if ex.to_s.include?"testerEmailExistsInternal" or ex.to_s.include?"duplicate.email"
+              if ex.to_s.include? "testerEmailExistsInternal" or ex.to_s.include? "duplicate.email"
                 # That's a non-relevant error message by iTC
                 # ignore that
               else
@@ -146,7 +145,7 @@ module Spaceship
       #####################################################
       # @!group Subclasses
       #####################################################
-      class External < Tester 
+      class External < Tester
         def self.url(app_id = nil)
           {
             index: "ra/users/pre/ext",
@@ -158,7 +157,7 @@ module Spaceship
         end
       end
 
-      class Internal < Tester 
+      class Internal < Tester
         def self.url(app_id = nil)
           {
             index: "ra/users/pre/int",
@@ -171,7 +170,7 @@ module Spaceship
       end
 
       # Delete current tester
-      def delete! 
+      def delete!
         client.delete_tester!(self)
       end
 
@@ -192,4 +191,4 @@ module Spaceship
       end
     end
   end
-end
+end