spaceship 0.3.2 → 0.4.0

data/lib/spaceship/portal/spaceship.rb

@@ -8,30 +8,30 @@ module Spaceship
       # Authenticates with Apple's web services. This method has to be called once
       # to generate a valid session. The session will automatically be used from then
       # on.
-      # 
+      #
       # This method will automatically use the username from the Appfile (if available)
       # and fetch the password from the Keychain (if available)
-      # 
+      #
       # @param user (String) (optional): The username (usually the email address)
       # @param password (String) (optional): The password
-      # 
+      #
       # @raise InvalidUserCredentialsError: raised if authentication failed
-      # 
+      #
       # @return (Spaceship::Client) The client the login method was called for
       def login(user = nil, password = nil)
         @client = PortalClient.login(user, password)
       end
 
       # Open up the team selection for the user (if necessary).
-      # 
+      #
       # If the user is in multiple teams, a team selection is shown.
       # The user can then select a team by entering the number
-      # 
+      #
       # Additionally, the team ID is shown next to each team name
       # so that the user can use the environment variable `FASTLANE_TEAM_ID`
       # for future user.
-      # 
-      # @return (String) The ID of the select team. You also get the value if 
+      #
+      # @return (String) The ID of the select team. You also get the value if
       #   the user is only in one team.
       def select_team
         @client.select_team
@@ -44,6 +44,16 @@ module Spaceship
         Spaceship::App.set_client(@client)
       end
 
+      # @return (Class) Access the app groups for the spaceship
+      def app_group
+        Spaceship::AppGroup.set_client(@client)
+      end
+
+      # @return (Class) Access app services for the spaceship
+      def app_service
+        Spaceship::AppService
+      end
+
       # @return (Class) Access the devices for the spaceship
       def device
         Spaceship::Device.set_client(@client)
@@ -75,6 +85,14 @@ module Spaceship
       Spaceship::Portal.app
     end
 
+    def app_group
+      Spaceship::Portal.app_group
+    end
+
+    def app_service
+      Spaceship::Portal.app_service
+    end
+
     def device
       Spaceship::Portal.device
     end
@@ -91,4 +109,4 @@ module Spaceship
       Spaceship::Portal.client
     end
   end
-end
+end

data/lib/spaceship/portal/ui/select_team.rb

@@ -8,11 +8,11 @@ module Spaceship
       #   "type"=>"Company/Organization",
       #   "extendedTeamAttributes"=>{},
       #   "teamAgent"=>{
-      #       "personId"=>15534241111, 
-      #       "firstName"=>"Felix", 
-      #       "lastName"=>"Krause", 
-      #       "email"=>"spaceship@krausefx.com", 
-      #       "developerStatus"=>"active", 
+      #       "personId"=>15534241111,
+      #       "firstName"=>"Felix",
+      #       "lastName"=>"Krause",
+      #       "email"=>"spaceship@krausefx.com",
+      #       "developerStatus"=>"active",
       #       "teamMemberId"=>"5Y354CXAAA"},
       #   "memberships"=>
       #    [{"membershipId"=>"HJ5WHYC5CE",
@@ -57,10 +57,8 @@ module Spaceship
           puts "Couldn't find team with Name '#{team_name}'"
         end
 
-
         return teams[0]['teamId'] if teams.count == 1 # user is just in one team
 
-
         # User Selection
         loop do
           # Multiple teams, user has to select
@@ -77,4 +75,4 @@ module Spaceship
       end
     end
   end
-end
+end

data/lib/spaceship/tunes/app_screenshot.rb

@@ -25,4 +25,4 @@ module Spaceship
       end
     end
   end
-end
+end

data/lib/spaceship/tunes/app_status.rb

@@ -1,7 +1,7 @@
 module Spaceship
   module Tunes
     # Defines the different states of the app
-    # 
+    #
     # As specified by Apple: https://developer.apple.com/library/ios/documentation/LanguagesUtilities/Conceptual/iTunesConnect_Guide/Chapters/ChangingAppStatus.html
     module AppStatus
       # You can edit this version, upload new binaries and more
@@ -23,7 +23,7 @@ module Spaceship
       DEVELOPER_REMOVED_FROM_SALE = "Developer Removed From Sale"
 
       # Developer rejected this version/binary
-      DEVELOPER_REJECTED = "Developer Rejected" 
+      DEVELOPER_REJECTED = "Developer Rejected"
 
       # You have to renew your Apple account to keep using iTunes Connect
       PENDING_CONTRACT = "Pending Contract"
@@ -34,13 +34,12 @@ module Spaceship
 
       # Unused app states
       # PENDING_APPLE_RELASE = "Pending Apple Release"
-      
+
       # WAITING_FOR_EXPORT_COMPLIANCE = "Waiting For Export Compliance"
       # METADATA_REJECTED = "Metadata Rejected"
       # REMOVED_FROM_SALE = "Removed From Sale"
       # INVALID_BINARY = "Invalid Binary"
 
-
       # Get the app status matching based on a string (given by iTunes Connect)
       def self.get_from_string(text)
         mapping = {
@@ -52,7 +51,7 @@ module Spaceship
           'waitingForReview' => WAITING_FOR_REVIEW
         }
 
-        mapping.each do |k, v| 
+        mapping.each do |k, v|
           return v if k == text
         end
 
@@ -60,4 +59,4 @@ module Spaceship
       end
     end
   end
-end
+end

data/lib/spaceship/tunes/app_submission.rb

@@ -1,3 +1,4 @@
+
 module Spaceship
   module Tunes
     # Represents a submission for review of an iTunes Connect Application
@@ -9,61 +10,61 @@ module Spaceship
 
       # @return (AppVersion) The version to use for this submission
       attr_accessor :version
-      
+
       # @return (String) The stage of this submission (start, complete)
       attr_accessor :stage
-      
+
       # @return (Boolean) Submitted for Review
       attr_accessor :submitted_for_review
 
       # @return (Boolean) Ad ID Info - Limits ads tracking
       attr_accessor :add_id_info_limits_tracking
-      
+
       # @return (Boolean) Ad ID Info - Serves ads
       attr_accessor :add_id_info_serves_ads
-      
+
       # @return (Boolean) Ad ID Info - Tracks actions
       attr_accessor :add_id_info_tracks_action
-      
+
       # @return (Boolean) Ad ID Info - Tracks installs
       attr_accessor :add_id_info_tracks_install
-      
+
       # @return (Boolean) Ad ID Info - Uses idfa
       attr_accessor :add_id_info_uses_idfa
-      
+
       # @return (Boolean) Content Rights - Contains third party content
       attr_accessor :content_rights_contains_third_party_content
-      
+
       # @return (Boolean) Content Rights - Has rights of content
       attr_accessor :content_rights_has_rights
-            
+
       # @return (Boolean) Export Compliance - Available on French Store
       attr_accessor :export_compliance_available_on_french_store
-      
-      # @return (@TODO) Export Compliance - CCAT File
+
+      # @return (Not Yet Implemented) Export Compliance - CCAT File
       attr_accessor :export_compliance_ccat_file
-      
+
       # @return (Boolean) Export Compliance - Contains proprietary cryptography
       attr_accessor :export_compliance_contains_proprietary_cryptography
-      
+
       # @return (Boolean) Export Compliance - Contains third-party cryptography
       attr_accessor :export_compliance_contains_third_party_cryptography
-      
+
       # @return (Boolean) Export Compliance - Is exempt
       attr_accessor :export_compliance_is_exempt
-      
+
       # @return (Boolean) Export Compliance - Uses encryption
       attr_accessor :export_compliance_uses_encryption
 
       # @return (String) Export Compliance - App type
       attr_accessor :export_compliance_app_type
-      
+
       # @return (Boolean) Export Compliance - Encryption Updated
       attr_accessor :export_compliance_encryption_updated
-      
+
       # @return (Boolean) Export Compliance - Compliance Required
       attr_accessor :export_compliance_compliance_required
-      
+
       # @return (String) Export Compliance - Platform
       attr_accessor :export_compliance_platform
 
@@ -75,11 +76,11 @@ module Spaceship
         'adIdInfo.tracksAction.value' => :add_id_info_tracks_action,
         'adIdInfo.tracksInstall.value' => :add_id_info_tracks_install,
         'adIdInfo.usesIdfa.value' => :add_id_info_uses_idfa,
-        
+
         # Content Rights Section
         'contentRights.containsThirdPartyContent.value' => :content_rights_contains_third_party_content,
         'contentRights.hasRights.value' => :content_rights_has_rights,
-        
+
         # Export Compliance Section
         'exportCompliance.availableOnFrenchStore.value' => :export_compliance_available_on_french_store,
         'exportCompliance.ccatFile.value' => :export_compliance_ccat_file,
@@ -98,7 +99,7 @@ module Spaceship
         # This is used to create a new object based on the server response.
         def factory(attrs)
           orig = attrs.dup
-          
+
           # fill content rights section if iTC returns nil
           if attrs["contentRights"].nil?
             attrs.merge!("contentRights" => {
@@ -110,11 +111,11 @@ module Spaceship
               }
             })
           end
-          
+
           obj = self.new(attrs)
           return obj
         end
-        
+
         # @param application (Spaceship::Tunes::Application) The app this submission is for
         # @param app_id (String) The unique Apple ID of this app
         def create(application, app_id, version)
@@ -127,7 +128,7 @@ module Spaceship
           return self.factory(attrs)
         end
       end
-      
+
       # Save and complete the app submission
       def complete!
         @stage = "complete"

data/lib/spaceship/tunes/app_version.rb

@@ -69,9 +69,6 @@ module Spaceship
       # @return (Integer) a unqiue ID for this version generated by iTunes Connect
       attr_accessor :version_id
 
-      # @return TODO
-      attr_accessor :company_information
-
       ####
       # App Review Information
       ####
@@ -127,7 +124,6 @@ module Spaceship
       # @return (Hash) Represents the screenshots of this app version (read-only)
       attr_reader :screenshots
 
-
       attr_mapping({
         'canBetaTest' => :can_beta_test,
         'canPrepareForUpload' => :can_prepare_for_upload,
@@ -232,7 +228,6 @@ module Spaceship
         "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/ng/app/#{self.application.apple_id}/" + (self.is_live? ? "cur" : "")
       end
 
-
       # Private methods
       def setup
         # Properly parse the AppStatus
@@ -247,7 +242,6 @@ module Spaceship
         end
       end
 
-
       # Prefill name, keywords, etc...
       def unfold_languages
         {
@@ -274,64 +268,60 @@ module Spaceship
       end
 
       def primary_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
-        super(value)
-      end
-
-      def primary_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
-      def primary_first_sub_cate=(value)gory
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+      def primary_first_sub_category=(value)
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
-      def primary_second_sub_cat=(value)egory
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+      def primary_second_sub_category=(value)
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       def secondary_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
-      def secondary_first_sub_ca=(value)tegory
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+      def secondary_first_sub_category=(value)
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
-      def secondary_second_sub_c=(value)ategory
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+      def secondary_second_sub_category=(value)
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       private
+
         # generates the nested data structure to represent screenshots
-        def setup_screenshots(row)
-          screenshots = row.fetch('screenshots', {}).fetch('value', nil)
-          return [] unless screenshots
-
-          result = []
-
-          screenshots.each do |device_type, value|
-            value['value'].each do |screenshot|
-              screenshot = screenshot['value']
-              result << Tunes::AppScreenshot.new({
-                url: screenshot['url'],
-                thumbnail_url: screenshot['thumbNailUrl'],
-                sort_order: screenshot['sortOrder'],
-                original_file_name: screenshot['originalFileName'],
-                device_type: device_type,
-                language: row['language']
-              })
-            end
+      def setup_screenshots(row)
+        screenshots = row.fetch('screenshots', {}).fetch('value', nil)
+        return [] unless screenshots
+
+        result = []
+
+        screenshots.each do |device_type, value|
+          value['value'].each do |screenshot|
+            screenshot = screenshot['value']
+            result << Tunes::AppScreenshot.new({
+              url: screenshot['url'],
+              thumbnail_url: screenshot['thumbNailUrl'],
+              sort_order: screenshot['sortOrder'],
+              original_file_name: screenshot['originalFileName'],
+              device_type: device_type,
+              language: row['language']
+            })
           end
-
-          return result
         end
+
+        return result
+      end
     end
   end
 end

data/lib/spaceship/tunes/application.rb

@@ -1,9 +1,9 @@
 module Spaceship
   module Tunes
     class Application < TunesBase
-      
+
       # @return (String) The App identifier of this app, provided by iTunes Connect
-      # @example 
+      # @example
       #   "1013943394"
       attr_accessor :apple_id
 
@@ -13,17 +13,17 @@ module Spaceship
       attr_accessor :name
 
       # @return (String) the supported platform of this app
-      # @example 
+      # @example
       #   "ios"
       attr_accessor :platform
 
       # @return (String) The Vendor ID provided by iTunes Connect
-      # @example 
+      # @example
       #   "1435592086"
       attr_accessor :vendor_id
 
       # @return (String) The bundle_id (app identifier) of your app
-      # @example 
+      # @example
       #   "com.krausefx.app"
       attr_accessor :bundle_id
 
@@ -34,7 +34,7 @@ module Spaceship
       attr_accessor :issues_count
 
       # @return (String) The URL to a low resolution app icon of this app (340x340px). Might be nil
-      # @example 
+      # @example
       #   "https://is1-ssl.mzstatic.com/image/thumb/Purple7/v4/cd/a3/e2/cda3e2ac-4034-c6af-ee0c-3e4d9a0bafaa/pr_source.png/340x340bb-80.png"
       # @example
       #   nil
@@ -50,7 +50,7 @@ module Spaceship
         'issuesCount' => :issues_count,
         'iconUrl' => :app_icon_preview_url
       )
-      
+
       class << self
         # Create a new object based on a hash.
         # This is used to create a new object based on the server response.
@@ -72,22 +72,22 @@ module Spaceship
         end
 
         # Creates a new application on iTunes Connect
-        # @param name (String): The name of your app as it will appear on the App Store. 
+        # @param name (String): The name of your app as it will appear on the App Store.
         #   This can't be longer than 255 characters.
-        # @param primary_language (String): If localized app information isn't available in an 
+        # @param primary_language (String): If localized app information isn't available in an
         #   App Store territory, the information from your primary language will be used instead.
-        # @param version (String): The version number is shown on the App Store and should 
+        # @param version (String): The version number is shown on the App Store and should
         #   match the one you used in Xcode.
         # @param sku (String): A unique ID for your app that is not visible on the App Store.
-        # @param bundle_id (String): The bundle ID must match the one you used in Xcode. It 
+        # @param bundle_id (String): The bundle ID must match the one you used in Xcode. It
         #   can't be changed after you submit your first build.
         # @param company_name (String): The company name or developer name to display on the App Store for your apps.
         # It cannot be changed after you create your first app.
         def create!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil)
-          client.create_application!(name: name, 
-                         primary_language: primary_language, 
-                                  version: version, 
-                                      sku: sku, 
+          client.create_application!(name: name,
+                         primary_language: primary_language,
+                                  version: version,
+                                      sku: sku,
                                 bundle_id: bundle_id,
                                 bundle_id_suffix: bundle_id_suffix,
                                 company_name: company_name)
@@ -99,7 +99,7 @@ module Spaceship
       #####################################################
 
       # @return (Spaceship::AppVersion) Receive the version that is currently live on the
-      #  App Store. You can't modify all values there, so be careful. 
+      #  App Store. You can't modify all values there, so be careful.
       def live_version
         v = Spaceship::AppVersion.find(self, self.apple_id, true)
       end
@@ -127,7 +127,7 @@ module Spaceship
         "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/ng/app/#{self.apple_id}"
       end
 
-      # @return (Hash) Contains the reason for rejection. 
+      # @return (Hash) Contains the reason for rejection.
       #  if everything is alright, the result will be
       #  `{"sectionErrorKeys"=>[], "sectionInfoKeys"=>[], "sectionWarningKeys"=>[], "replyConstraints"=>{"minLength"=>1, "maxLength"=>4000}, "appNotes"=>{"threads"=>[]}, "betaNotes"=>{"threads"=>[]}, "appMessages"=>{"threads"=>[]}}`
       def resolution_center
@@ -137,8 +137,10 @@ module Spaceship
       #####################################################
       # @!group Modifying
       #####################################################
-     
+
       # Create a new version of your app
+      # Since we have stored the outdated raw_data, we need to refresh this object
+      # otherwise `edit_version` will return nil
       def create_version!(version_number)
         if edit_version
           raise "Cannot create a new version for this app as there already is an `edit_version` available"
@@ -146,9 +148,7 @@ module Spaceship
 
         client.create_version!(apple_id, version_number)
 
-        # Since we have stored the outdated raw_data, we need to refresh this object
-        # otherwise `edit_version` will return nil
-        # TODO: implemented -reload method
+        # Future: implemented -reload method
       end
 
       #####################################################
@@ -166,7 +166,7 @@ module Spaceship
       #   Those builds can also be the builds that are stuck on iTC.
       def pre_processing_builds
         data = client.build_trains(apple_id) # we need to fetch all trains here to get the builds
-        
+
         data.fetch('processingBuilds', []).collect do |attrs|
           attrs.merge!(build_train: self)
           Tunes::ProcessingBuild.factory(attrs)
@@ -177,7 +177,7 @@ module Spaceship
       #   this include pre-processing or standard processing
       def all_processing_builds
         builds = self.pre_processing_builds
-      
+
         self.build_trains.each do |version_number, train|
           train.processing_builds.each do |build|
             builds << build
@@ -203,13 +203,13 @@ module Spaceship
       #####################################################
       # @!group Submit for Review
       #####################################################
-      
+
       def create_submission
         version = self.latest_version
         if version.nil?
           raise "Could not find a valid version to submit for review"
         end
-        
+
         Spaceship::AppSubmission.create(self, self.apple_id, version)
       end
 
@@ -229,7 +229,6 @@ module Spaceship
       # @!group General
       #####################################################
       def setup
-        
       end
 
       #####################################################
@@ -273,8 +272,8 @@ module Spaceship
       def add_external_tester!(email: nil, first_name: nil, last_name: nil)
         raise "Tester is already on #{self.name} betatesters" if find_external_tester(email)
 
-        tester = Tunes::Tester.external.find(email) || Tunes::Tester.external.create!(email: email, 
-                                                                                 first_name: first_name, 
+        tester = Tunes::Tester.external.find(email) || Tunes::Tester.external.create!(email: email,
+                                                                                 first_name: first_name,
                                                                                   last_name: last_name)
         tester.add_to_app!(self.apple_id)
       end

data/lib/spaceship/tunes/build.rb

@@ -6,7 +6,7 @@ module Spaceship
       #####################################################
       # @!group General metadata
       #####################################################
-      
+
       # @return (Spaceship::Tunes::BuildTrain) A reference to the build train this build is contained in
       attr_accessor :build_train
 
@@ -44,11 +44,10 @@ module Spaceship
       #   this is only true after the build was approved by Apple
       attr_accessor :external_testing_enabled
 
-
       # @return (Bool) Does this build support WatchKit?
       attr_accessor :watch_kit_enabled
 
-      # @return (Bool): 
+      # @return (Bool):
       attr_accessor :ready_to_install
 
       #####################################################
@@ -88,7 +87,7 @@ module Spaceship
         'internalExpiry' => :internal_expiry_date,
         'externalExpiry' => :external_expiry_date,
         'watchKitEnabled' => :watch_kit_enabled,
-        'readyToInstall' => :ready_to_install,
+        'readyToInstall' => :ready_to_install
       )
 
       class << self
@@ -129,9 +128,9 @@ module Spaceship
       def submit_for_beta_review!(metadata)
         # First, enable beta testing for this train (per iTC requirement)
         self.build_train.update_testing_status!(true)
-        
+
         parameters = {
-          app_id: self.build_train.application.apple_id, 
+          app_id: self.build_train.application.apple_id,
           train: self.build_train.version_string,
           build_number: self.build_version,
 
@@ -182,7 +181,7 @@ module Spaceship
 
       # This will cancel the review process for this TestFlight build
       def cancel_beta_review!
-        client.remove_testflight_build_from_review!(app_id: self.build_train.application.apple_id, 
+        client.remove_testflight_build_from_review!(app_id: self.build_train.application.apple_id,
                                                      train: self.build_train.version_string,
                                               build_number: self.build_version)
       end

data/lib/spaceship/tunes/build_train.rb

@@ -54,7 +54,7 @@ module Spaceship
       # Setup all the builds and processing builds
       def setup
         super
-        
+
         @builds = self.raw_data['builds'].collect do |attrs|
           attrs.merge!(build_train: self)
           Tunes::Build.factory(attrs)
@@ -78,4 +78,4 @@ module Spaceship
       end
     end
   end
-end
+end