spaceship 0.28.0 → 0.29.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (5) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +2 -3
  3. data/lib/spaceship/tunes/tunes_client.rb +35 -49
  4. data/lib/spaceship/version.rb +1 -1
  5. metadata +3 -3
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: b42bd9f6a910c25ea6c6ef27d9894f05fd7cc965
4
- data.tar.gz: cad77851c906d20e2f67795e3c869e69c1f87835
3
+ metadata.gz: eae3feb9981665a4c1ab881b0b388dad7cf18e07
4
+ data.tar.gz: b94057f0579d52aa1658244944b13c9553ed6150
5
5
  SHA512:
6
- metadata.gz: addd2db721db37ec21d77350976a70d060e6276585ea5e2247bc46a020d5486de39458108838fccf5dd3741d678a4fc83c7c8d66c92213b942ca4116a7d5df86
7
- data.tar.gz: d507f75e1fdd08c9826373b9bf0e401af70bcee1f3a7e6f66db6c9c53ee0845f60ead4b53137465bf5b1133659d5deec55bc8d1b0f758f8ab64561b699ffd472
6
+ metadata.gz: dca1b41a65a90c33366fa1889877206eafb0a062623fd1ad2ea5438d277c3dbc4e9ef739eca56bee5fce4f166e8989582d6ac56b031e0684b80fc6a11200f901
7
+ data.tar.gz: bb10252ca997c580e1770d31e28c63636f91689c59b0df4c1997d242495561c7fbaea4454450a992a6ddf7576e8d41976878191c8f5ca7fc1d3208489b2071e6
data/README.md CHANGED
@@ -29,7 +29,6 @@
29
29
 
30
30
  [![Twitter: @FastlaneTools](https://img.shields.io/badge/contact-@KrauseFx-blue.svg?style=flat)](https://twitter.com/KrauseFx)
31
31
  [![License](http://img.shields.io/badge/license-MIT-green.svg?style=flat)](https://github.com/fastlane/fastlane/blob/master/spaceship/LICENSE)
32
- [![Coverage Status](https://coveralls.io/repos/fastlane/spaceship/badge.svg?branch=master&t=ldL8gg)](https://coveralls.io/r/fastlane/spaceship?branch=master)
33
32
  [![Gem](https://img.shields.io/gem/v/spaceship.svg?style=flat)](http://rubygems.org/gems/spaceship)
34
33
  [![Build Status](https://img.shields.io/circleci/project/fastlane/fastlane/master.svg?style=flat)](https://circleci.com/gh/fastlane/fastlane)
35
34
 
@@ -121,13 +120,13 @@ Since your CI system probably doesn't allow you to input values (like the verifi
121
120
  spaceauth -u apple@krausefx.com
122
121
  ```
123
122
 
124
- This will authenticate you and provide a string that can be transfered to your CI system:
123
+ This will authenticate you and provide a string that can be transferred to your CI system:
125
124
 
126
125
  ```
127
126
  export FASTLANE_SESSION='---\n- !ruby/object:HTTP::Cookie\n name: DES5c148586dfd451e55afbaaa5f62418f91\n value: HSARMTKNSRVTWFla1+yO4gVPowH17VaaaxPFnUdMUegQZxqy1Ie1c2v6bM1vSOzIbuOmrl/FNenlScsd/NbF7/Lw4cpnL15jsyg0TOJwP32tC/NguPiyOaaaU+jrj4tf4uKdIywVaaaFSRVT\n domain: idmsa.apple.com\n for_domain: true\n path: "/"\n secure: true\n httponly: true\n expires: 2016-04-27 23:55:56.000000000 Z\n max_age: \n created_at: 2016-03-28 16:55:57.032086000 -07:00\n accessed_at: 2016-03-28 19:11:17.828141000 -07:00\n'
128
127
  ```
129
128
 
130
- Copy everything from `---\n` to your CI server and provide it as environment variable named `FASTLANE_SESSION`.
129
+ Copy everything from `---\n` to your CI server and provide it as environment variable named `FASTLANE_SESSION`.
131
130
 
132
131
  ### Spaceship in use
133
132
 
data/lib/spaceship/tunes/tunes_client.rb CHANGED
@@ -565,13 +565,8 @@ module Spaceship
565
565
  feedback_email: nil,
566
566
  platform: 'ios')
567
567
  url = "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/testInformation"
568
- r = request(:get) do |req|
569
- req.url url
570
- req.headers['Content-Type'] = 'application/json'
571
- end
572
- handle_itc_response(r.body)
573
568
 
574
- build_info = r.body['data']
569
+ build_info = get_build_info_for_review(app_id: app_id, train: train, build_number: build_number, platform: platform)
575
570
  build_info["details"].each do |current|
576
571
  current["whatsNew"]["value"] = whats_new if whats_new
577
572
  current["description"]["value"] = description if description
@@ -609,13 +604,17 @@ module Spaceship
609
604
  review_user_name: nil,
610
605
  review_password: nil,
611
606
  review_notes: nil,
612
- encryption: false)
607
+ encryption: false,
608
+ encryption_updated: false,
609
+ is_exempt: false,
610
+ proprietary: false,
611
+ third_party: false)
613
612
 
614
613
  build_info = get_build_info_for_review(app_id: app_id, train: train, build_number: build_number, platform: platform)
615
614
  # Now fill in the values provided by the user
616
615
 
617
616
  # First the localised values:
618
- build_info['testInfo']['details'].each do |current|
617
+ build_info['details'].each do |current|
619
618
  current['whatsNew']['value'] = changelog if changelog
620
619
  current['description']['value'] = description if description
621
620
  current['feedbackEmail']['value'] = feedback_email if feedback_email
@@ -623,38 +622,45 @@ module Spaceship
623
622
  current['privacyPolicyUrl']['value'] = privacy_policy_url if privacy_policy_url
624
623
  current['pageLanguageValue'] = current['language'] # There is no valid reason why we need this, only iTC being iTC
625
624
  end
626
- build_info['significantChange'] ||= {}
627
- build_info['significantChange']['value'] = significant_change
628
- build_info['testInfo']['reviewFirstName']['value'] = first_name if first_name
629
- build_info['testInfo']['reviewLastName']['value'] = last_name if last_name
630
- build_info['testInfo']['reviewPhone']['value'] = phone_number if phone_number
631
- build_info['testInfo']['reviewEmail']['value'] = review_email if review_email
632
- build_info['testInfo']['reviewAccountRequired']['value'] = (review_user_name.to_s + review_password.to_s).length > 0
633
- build_info['testInfo']['reviewUserName']['value'] = review_user_name if review_user_name
634
- build_info['testInfo']['reviewPassword']['value'] = review_password if review_password
635
- build_info['testInfo']['reviewNotes']['value'] = review_notes if review_notes
625
+
626
+ review_info = {
627
+ "significantChange" => {
628
+ "value" => significant_change
629
+ },
630
+ "buildTestInformationTO" => build_info,
631
+ "exportComplianceTO" => {
632
+ "usesEncryption" => {
633
+ "value" => encryption
634
+ },
635
+ "encryptionUpdated" => {
636
+ "value" => encryption_updated
637
+ },
638
+ "isExempt" => {
639
+ "value" => is_exempt
640
+ },
641
+ "containsProprietaryCryptography" => {
642
+ "value" => proprietary
643
+ },
644
+ "containsThirdPartyCryptography" => {
645
+ "value" => third_party
646
+ }
647
+ }
648
+ }
636
649
 
637
650
  r = request(:post) do |req| # same URL, but a POST request
638
- req.url "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/submit/start"
651
+ req.url "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/review/submit"
639
652
 
640
- req.body = build_info.to_json
653
+ req.body = review_info.to_json
641
654
  req.headers['Content-Type'] = 'application/json'
642
655
  end
643
656
  handle_itc_response(r.body)
644
-
645
- encryption_info = r.body['data']
646
- update_encryption_compliance(app_id: app_id,
647
- train: train,
648
- build_number: build_number,
649
- platform: platform,
650
- encryption_info: encryption_info,
651
- encryption: encryption)
652
657
  end
653
658
  # rubocop:enable Metrics/ParameterLists
654
659
 
655
660
  def get_build_info_for_review(app_id: nil, train: nil, build_number: nil, platform: 'ios')
661
+ url = "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/testInformation"
656
662
  r = request(:get) do |req|
657
- req.url "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/submit/start"
663
+ req.url url
658
664
  req.headers['Content-Type'] = 'application/json'
659
665
  end
660
666
  handle_itc_response(r.body)
@@ -662,26 +668,6 @@ module Spaceship
662
668
  r.body['data']
663
669
  end
664
670
 
665
- def update_encryption_compliance(app_id: nil, train: nil, build_number: nil, platform: 'ios', encryption_info: nil, encryption: nil, is_exempt: true, proprietary: false, third_party: false)
666
- return unless encryption_info['exportComplianceRequired']
667
- # only sometimes this is required
668
-
669
- encryption_info['usesEncryption']['value'] = encryption
670
- encryption_info['encryptionUpdated'] ||= {}
671
- encryption_info['encryptionUpdated']['value'] = encryption
672
- encryption_info['isExempt']['value'] = is_exempt
673
- encryption_info['containsProprietaryCryptography']['value'] = proprietary
674
- encryption_info['containsThirdPartyCryptography']['value'] = third_party
675
-
676
- r = request(:post) do |req|
677
- req.url "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/submit/complete"
678
- req.body = encryption_info.to_json
679
- req.headers['Content-Type'] = 'application/json'
680
- end
681
-
682
- handle_itc_response(r.body)
683
- end
684
-
685
671
  #####################################################
686
672
  # @!group Submit for Review
687
673
  #####################################################
data/lib/spaceship/version.rb CHANGED
@@ -1,4 +1,4 @@
1
1
  module Spaceship
2
- VERSION = "0.28.0".freeze
2
+ VERSION = "0.29.0".freeze
3
3
  DESCRIPTION = "Ruby library to access the Apple Dev Center and iTunes Connect".freeze
4
4
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: spaceship
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.28.0
4
+ version: 0.29.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Felix Krause
@@ -9,7 +9,7 @@ authors:
9
9
  autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2016-07-02 00:00:00.000000000 Z
12
+ date: 2016-07-27 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: credentials_manager
@@ -391,7 +391,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
391
391
  version: '0'
392
392
  requirements: []
393
393
  rubyforge_project:
394
- rubygems_version: 2.5.1
394
+ rubygems_version: 2.4.5.1
395
395
  signing_key:
396
396
  specification_version: 4
397
397
  summary: Ruby library to access the Apple Dev Center and iTunes Connect