spaceship 0.19.3 → 0.19.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eef0b3daccd7d674a5e4262b3e53ac22b217c45a
-  data.tar.gz: 3f880a9b11397d309969408d2c3cf3204692d446
+  metadata.gz: 4693da7e9b3b4cee2808c01b9aca5756699271ac
+  data.tar.gz: e0cf96db5506284940c11e489da1a43f1a1a6607
 SHA512:
-  metadata.gz: b793b4ec731b8f47a32cb97b44d8ee316424d2fcd55a642ebea0cb3275ca355eeac2acbc21afa799f0f0c42f647882de347ad8f2ba2cd270c825aae54576d2fe
-  data.tar.gz: 12f2544aecadb004e3ceb516c2a68ca420ebac1acb90589a5c22d691ccc4c8fc55fcd9910ee5403cfb815db12c2796e492f99f0a1dc6f8d4430683ffed19dd23
+  metadata.gz: dd750685e85559d693d15373cb2f7944353c42a793b8be318ef9b5714ce04e9a8e1e2f95904978baccde06e29e22faf681e848f16cd0ac69ded0a17002676230
+  data.tar.gz: 8a53dbea6ef84b06fba11c3b6caaa0b6fa0ab5dadec16768b76713902a9705a060af3e7639121ef1a30dd2641ab6f236350c616b6d8eeb637f52462dadb8b4af

data/README.md

@@ -186,6 +186,9 @@ The initial release was sponsored by [ZeroPush](https://zeropush.com).
 
 ##### [Like this tool? Be the first to know about updates and new fastlane tools](https://tinyletter.com/krausefx)
 
+# Code of Conduct
+Help us keep `fastlane` open and inclusive. Please read and follow our [Code of Conduct](https://github.com/fastlane/code-of-conduct).
+
 # License
 This project is licensed under the terms of the MIT license. See the LICENSE file.
 

data/lib/spaceship/portal/device.rb

@@ -147,9 +147,8 @@ module Spaceship
           end
 
           # Find the device by UDID, raise an exception if it already exists
-          if self.find_by_udid(udid, mac: mac)
-            raise "The device UDID '#{udid}' already exists on this team."
-          end
+          existing = self.find_by_udid(udid, mac: mac)
+          return existing if existing
 
           # It is valid to have the same name for multiple devices
 

data/lib/spaceship/portal/portal_client.rb

@@ -377,6 +377,14 @@ module Spaceship
     end
 
     def delete_provisioning_profile!(profile_id, mac: false)
+      if csrf_tokens.count == 0
+        r = request(:post, "account/#{platform_slug(mac)}/profile/getProvisioningProfile.action", {
+          teamId: team_id,
+          provisioningProfileId: profile_id
+        })
+        parse_response(r)
+      end
+
       r = request(:post, "account/#{platform_slug(mac)}/profile/deleteProvisioningProfile.action", {
         teamId: team_id,
         provisioningProfileId: profile_id

data/lib/spaceship/portal/ui/select_team.rb

@@ -62,7 +62,7 @@ module Spaceship
         # User Selection
         loop do
           # Multiple teams, user has to select
-          puts "Multiple teams found, please enter the number of the team you want to use: "
+          puts "Multiple teams found on the Developer Portal, please enter the number of the team you want to use: "
           teams.each_with_index do |team, i|
             puts "#{i + 1}) #{team['teamId']} \"#{team['name']}\" (#{team['type']})"
           end

data/lib/spaceship/tunes/build.rb

@@ -118,7 +118,8 @@ module Spaceship
         parameters = {
           app_id: self.build_train.application.apple_id,
           train: self.build_train.version_string,
-          build_number: self.build_version
+          build_number: self.build_version,
+          platform: self.platform
         }.merge({
           whats_new: whats_new,
           description: description,

data/lib/spaceship/tunes/build_train.rb

@@ -92,11 +92,11 @@ module Spaceship
           train["#{testing_type}Testing"]['value'] = false
           train["#{testing_type}Testing"]['value'] = new_value if train['versionString'] == version_string
 
-          # also update the builds
+          # find correct build
+          train['builds'].select! { |b| !b["#{testing_type}Testing"].nil? && !build.nil? && b['buildVersion'] == build.build_version }
+
+          # also update the build if it was found
           train['builds'].each do |b|
-            next if b["#{testing_type}Testing"].nil?
-            next if build.nil?
-            next if b["buildVersion"] != build.build_version
             b["#{testing_type}Testing"]['value'] = false
             b["#{testing_type}Testing"]['value'] = new_value if b['trainVersion'] == version_string
           end

data/lib/spaceship/tunes/tester.rb

@@ -76,10 +76,10 @@ module Spaceship
 
         # @return (Spaceship::Tunes::Tester) Returns the tester matching the parameter
         #   as either the Tester id or email
-        # @param identifier (String) (required): Value used to filter the tester
+        # @param identifier (String) (required): Value used to filter the tester, case insensitive
         def find(identifier)
           all.find do |tester|
-            (tester.tester_id == identifier.to_s or tester.email == identifier)
+            (tester.tester_id.to_s.casecmp(identifier.to_s).zero? or tester.email.to_s.casecmp(identifier.to_s).zero?)
           end
         end
 
@@ -111,10 +111,10 @@ module Spaceship
         # @return (Spaceship::Tunes::Tester) Returns the tester matching the parameter
         #   as either the Tester id or email
         # @param app_id (String) (required): The app id to filter the testers
-        # @param identifier (String) (required): Value used to filter the tester
+        # @param identifier (String) (required): Value used to filter the tester, case insensitive
         def find_by_app(app_id, identifier)
           all_by_app(app_id).find do |tester|
-            (tester.tester_id == identifier.to_s or tester.email == identifier)
+            (tester.tester_id.to_s.casecmp(identifier.to_s).zero? or tester.email.to_s.casecmp(identifier.to_s).zero?)
           end
         end
 

data/lib/spaceship/tunes/tunes_client.rb

@@ -90,7 +90,7 @@ module Spaceship
 
       # user didn't specify a team... #thisiswhywecanthavenicethings
       loop do
-        puts "Multiple teams found, please enter the number of the team you want to use: "
+        puts "Multiple iTunes Connect teams found, please enter the number of the team you want to use: "
         teams.each_with_index do |team, i|
           puts "#{i + 1}) \"#{team['contentProvider']['name']}\" (#{team['contentProvider']['contentProviderId']})"
         end
@@ -528,7 +528,7 @@ module Spaceship
 
     def remove_testflight_build_from_review!(app_id: nil, train: nil, build_number: nil)
       r = request(:post) do |req|
-        req.url "ra/apps/#{app_id}/trains/#{train}/builds/#{build_number}/reject"
+        req.url "ra/apps/#{app_id}/platforms/ios/trains/#{train}/builds/#{build_number}/reject"
         req.body = {}.to_json
         req.headers['Content-Type'] = 'application/json'
       end
@@ -542,8 +542,9 @@ module Spaceship
                                   # optional:
                                   whats_new: nil,
                                   description: nil,
-                                  feedback_email: nil)
-      url = "ra/apps/#{app_id}/platforms/ios/trains/#{train}/builds/#{build_number}/testInformation"
+                                  feedback_email: nil,
+                                  platform: 'ios')
+      url = "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/testInformation"
       r = request(:get) do |req|
         req.url url
         req.headers['Content-Type'] = 'application/json'
@@ -606,7 +607,7 @@ module Spaceship
       build_info['testInfo']['reviewPassword']['value'] = review_password
 
       r = request(:post) do |req| # same URL, but a POST request
-        req.url "ra/apps/#{app_id}/trains/#{train}/builds/#{build_number}/submit/start"
+        req.url "ra/apps/#{app_id}/platforms/ios/trains/#{train}/builds/#{build_number}/submit/start"
 
         req.body = build_info.to_json
         req.headers['Content-Type'] = 'application/json'
@@ -623,7 +624,7 @@ module Spaceship
 
     def get_build_info_for_review(app_id: nil, train: nil, build_number: nil)
       r = request(:get) do |req|
-        req.url "ra/apps/#{app_id}/trains/#{train}/builds/#{build_number}/submit/start"
+        req.url "ra/apps/#{app_id}/platforms/ios/trains/#{train}/builds/#{build_number}/submit/start"
         req.headers['Content-Type'] = 'application/json'
       end
       handle_itc_response(r.body)
@@ -640,7 +641,7 @@ module Spaceship
       encryption_info['encryptionUpdated']['value'] = encryption
 
       r = request(:post) do |req|
-        req.url "ra/apps/#{app_id}/trains/#{train}/builds/#{build_number}/submit/complete"
+        req.url "ra/apps/#{app_id}/platforms/ios/trains/#{train}/builds/#{build_number}/submit/complete"
         req.body = encryption_info.to_json
         req.headers['Content-Type'] = 'application/json'
       end

data/lib/spaceship/version.rb

@@ -1,3 +1,3 @@
 module Spaceship
-  VERSION = "0.19.3"
+  VERSION = "0.19.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spaceship
 version: !ruby/object:Gem::Version
-  version: 0.19.3
+  version: 0.19.4
 platform: ruby
 authors:
 - Felix Krause
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-22 00:00:00.000000000 Z
+date: 2016-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: credentials_manager
@@ -328,7 +328,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.0
 signing_key: 
 specification_version: 4
 summary: Because you would rather spend your time building stuff than fighting provisioning