spaceship 0.13.1 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 49b906e19473b4638c1dbffbac020229a5006e6c
-  data.tar.gz: 5e196ab71b5968a848187769fd8d62dc7533ea16
+  metadata.gz: 370ec337b82d693b4f075578ab84890ab2902e5f
+  data.tar.gz: 5e2606ea51d5c94ef8ec6f4f965f30c33a791ef8
 SHA512:
-  metadata.gz: acf0ee0634a46f5993255c8d418c3456f5bc1016556cd895e643191a8866060d744ee29a4e87b31d20abb470b0d2b60c7988b7abe1c26bf01acabbd223fed5d0
-  data.tar.gz: b138f95e93e2141f86ed4f9b45c88cbc2e3958731b93fc7edbbd5cf628b711f79400e483fe4ddfb4f3541763c47f86d95872289083de537628eb2d0485724c73
+  metadata.gz: df4dcbb65bea1cf44d5d67e2f07131970efef005f3467ea4d0311a1800496be35ba21478e10fb9fd6166670369ead31a2395163fef4db86f8f6523addb5fdd9f
+  data.tar.gz: ebb2ecb1788a9c54a0613faf5d313c6ee12616c5373b66641c8deb7cabce6fa72690f3bdc3cf4be2cf3b271c50191da9e1306500617b1b83c814b5eaef18e069

data/README.md

@@ -154,7 +154,7 @@ I won't go into too much technical details about the various API endpoints, but
  - Managing apps
  - Managing beta testers
  - Submitting updates to review
- - Manaing app metadata
+ - Managing app metadata
 - `https://du-itc.itunesconnect.apple.com`:
  - Upload icons, screenshots, trailers ...
 

data/lib/spaceship/base.rb

@@ -203,7 +203,7 @@ module Spaceship
       @attributes ||= []
       par = []
 
-      par = (self.superclass.attributes || []) unless (self == Base)
+      par = (self.superclass.attributes || []) unless self == Base
 
       @attributes + par
     end

data/lib/spaceship/portal/certificate.rb

@@ -197,7 +197,7 @@ module Spaceship
         #  If this is called from a subclass of Certificate, this will
         #  only include certificates matching the current type.
         def all
-          if (self == Certificate) # are we the base-class?
+          if self == Certificate # are we the base-class?
             types = CERTIFICATE_TYPE_IDS.keys
           else
             types = [CERTIFICATE_TYPE_IDS.key(self)]

data/lib/spaceship/portal/portal_client.rb

@@ -225,14 +225,14 @@ module Spaceship
       end
     end
 
-    def devices_by_class(deviceClass)
+    def devices_by_class(device_class)
       paging do |page_number|
         r = request(:post, 'account/ios/device/listDevices.action', {
           teamId: team_id,
           pageNumber: page_number,
           pageSize: page_size,
           sort: 'name=asc',
-          deviceClasses: deviceClass
+          deviceClasses: device_class
         })
         parse_response(r, 'devices')
       end

data/lib/spaceship/portal/ui/select_team.rb

@@ -43,8 +43,8 @@ module Spaceship
           # User provided a value, let's see if it's valid
           teams.each_with_index do |team, i|
             # There are 2 different values - one from the login page one from the Dev Team Page
-            return team['teamId'] if (team['teamId'].strip == team_id)
-            return team['teamId'] if (team['currentTeamMember']['teamMemberId'].to_s.strip == team_id)
+            return team['teamId'] if team['teamId'].strip == team_id
+            return team['teamId'] if team['currentTeamMember']['teamMemberId'].to_s.strip == team_id
           end
           puts "Couldn't find team with ID '#{team_id}'"
         end
@@ -52,7 +52,7 @@ module Spaceship
         if team_name.length > 0
           # User provided a value, let's see if it's valid
           teams.each_with_index do |team, i|
-            return team['teamId'] if (team['name'].strip == team_name)
+            return team['teamId'] if team['name'].strip == team_name
           end
           puts "Couldn't find team with Name '#{team_name}'"
         end

data/lib/spaceship/tunes/app_version.rb

@@ -566,7 +566,7 @@ module Spaceship
         expected_resolution = TunesClient.video_preview_resolution_for(device, is_portrait)
         actual_resolution = Utilities.resolution(preview_screenshot_path)
         orientation = is_portrait ? "portrait" : "landscape"
-        raise "Invalid #{orientation} screenshot resolution for device #{device}. Should be #{expected_resolution}" unless (actual_resolution == expected_resolution)
+        raise "Invalid #{orientation} screenshot resolution for device #{device}. Should be #{expected_resolution}" unless actual_resolution == expected_resolution
       end
 
       def raw_data_details

data/lib/spaceship/tunes/build.rb

@@ -165,6 +165,7 @@ module Spaceship
           last_name: "Krause",
           review_email: "contact@company.com",
           phone_number: "0123456789",
+          significant_change: false,
 
           # Optional Metadata:
           privacy_policy_url: nil,

data/lib/spaceship/tunes/build_train.rb

@@ -72,13 +72,29 @@ module Spaceship
         end
       end
 
+      # @return (Spaceship::Tunes::Build) The latest build for this train, sorted by upload time.
+      def latest_build
+        @builds.max_by(&:upload_date)
+      end
+
       # @param (testing_type) internal or external
-      def update_testing_status!(new_value, testing_type)
+      def update_testing_status!(new_value, testing_type, build = nil)
         data = client.build_trains(self.application.apple_id, testing_type)
 
+        build ||= latest_build if testing_type == 'external'
+
         data['trains'].each do |train|
           train["#{testing_type}Testing"]['value'] = false
           train["#{testing_type}Testing"]['value'] = new_value if train['versionString'] == version_string
+
+          # also update the builds
+          train['builds'].each do |b|
+            next if b["#{testing_type}Testing"].nil?
+            next if build.nil?
+            next if b["buildVersion"] != build.build_version
+            b["#{testing_type}Testing"]['value'] = false
+            b["#{testing_type}Testing"]['value'] = new_value if b['trainVersion'] == version_string
+          end
         end
 
         result = client.update_build_trains!(application.apple_id, testing_type, data)

data/lib/spaceship/tunes/tunes_client.rb

@@ -38,33 +38,39 @@ module Spaceship
       "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/"
     end
 
-    # Fetches the latest login URL from iTunes Connect
-    def login_url
-      cache_path = "/tmp/spaceship_itc_login_url.txt"
-      begin
-        cached = File.read(cache_path)
-      rescue Errno::ENOENT
-      end
-      return cached if cached
+    # returns wosinst, wosid and itctx
+    def login_overhead_cookies(myacinfo)
+      return @login_overhead_cookies if @login_overhead_cookies
+
+      response = request(:get, "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/wa/route?noext") # for woinst and wosid
+      cookies = {
+        woinst: response['Set-Cookie'].match(/woinst=([^;]*)/)[1],
+        wosid: response['Set-Cookie'].match(/wosid=([^;]*)/)[1],
+        myacinfo: myacinfo
+      }
 
-      host = "https://itunesconnect.apple.com"
-      begin
-        url = host + request(:get, self.class.hostname).body.match(%r{action="(/WebObjects/iTunesConnect.woa/wo/.*)"})[1]
-        raise "" unless url.length > 0
-
-        File.write(cache_path, url)
-        return url
-      rescue => ex
-        puts ex
-        raise "Could not fetch the login URL from iTunes Connect, the server might be down"
+      # The second request has to be after getting the woinst and wois
+      woa = request(:get) do |req|
+        req.url "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa"
+        req.headers["Cookie"] = cookies.collect { |k, v| "#{k}=#{v}; " }.join("")
       end
+      cookies[:itctx] = woa['Set-Cookie'].match(/itctx=([^;]*)/)[1]
+
+      return @login_overhead_cookies ||= cookies
     end
 
     def send_login_request(user, password)
-      response = request(:post, login_url, {
-        theAccountName: user,
-        theAccountPW: password
-      })
+      data = {
+        accountName: user,
+        password: password,
+        rememberMe: true
+      }
+
+      response = request(:post) do |req|
+        req.url "https://idmsa.apple.com/appleauth/auth/signin"
+        req.body = data.to_json
+        req.headers['Content-Type'] = 'application/json'
+      end
 
       if response['Set-Cookie'] =~ /myacinfo=(\w+);/
         # To use the session properly we'll need the following cookies:
@@ -74,15 +80,10 @@ module Spaceship
         #  - itctx
         begin
           re = response['Set-Cookie']
+          myacinfo = re.match(/myacinfo=([^;]*)/)[1]
+          cookies = login_overhead_cookies(myacinfo)
 
-          to_use = [
-            "myacinfo=" + re.match(/myacinfo=([^;]*)/)[1],
-            "woinst=" + re.match(/woinst=([^;]*)/)[1],
-            "itctx=" + re.match(/itctx=([^;]*)/)[1],
-            "wosid=" + re.match(/wosid=([^;]*)/)[1]
-          ]
-
-          @cookie = to_use.join(';')
+          @cookie = cookies.collect { |k, v| "#{k}=#{v}; " }.join("")
         rescue
           raise ITunesConnectError.new, [response.body, response['Set-Cookie']].join("\n")
         end
@@ -499,7 +500,6 @@ module Spaceship
       handle_itc_response(r.body)
     end
 
-    # rubocop:disable Metrics/AbcSize
     def submit_testflight_build_for_review!( # Required:
                                             app_id: nil,
                                             train: nil,
@@ -514,6 +514,7 @@ module Spaceship
                                             last_name: nil,
                                             review_email: nil,
                                             phone_number: nil,
+                                            significant_change: false,
 
                                             # Optional Metadata:
                                             privacy_policy_url: nil,
@@ -540,6 +541,7 @@ module Spaceship
         current['privacyPolicyUrl']['value'] = privacy_policy_url
         current['pageLanguageValue'] = current['language'] # There is no valid reason why we need this, only iTC being iTC
       end
+      build_info['significantChange']['value'] = significant_change
       build_info['testInfo']['reviewFirstName']['value'] = first_name
       build_info['testInfo']['reviewLastName']['value'] = last_name
       build_info['testInfo']['reviewPhone']['value'] = phone_number
@@ -559,6 +561,7 @@ module Spaceship
         # only sometimes this is required
 
         encryption_info['usesEncryption']['value'] = encryption
+        encryption_info['encryptionUpdated']['value'] = encryption
 
         r = request(:post) do |req|
           req.url "ra/apps/#{app_id}/trains/#{train}/builds/#{build_number}/submit/complete"
@@ -569,7 +572,6 @@ module Spaceship
         handle_itc_response(r.body)
       end
     end
-    # rubocop:enable Metrics/AbcSize
 
     #####################################################
     # @!group Submit for Review

data/lib/spaceship/version.rb

@@ -1,3 +1,3 @@
 module Spaceship
-  VERSION = "0.13.1"
+  VERSION = "0.14.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spaceship
 version: !ruby/object:Gem::Version
-  version: 0.13.1
+  version: 0.14.0
 platform: ruby
 authors:
 - Felix Krause
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-06 00:00:00.000000000 Z
+date: 2015-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: credentials_manager
@@ -314,7 +314,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.0
+rubygems_version: 2.4.0
 signing_key: 
 specification_version: 4
 summary: Because you would rather spend your time building stuff than fighting provisioning