space-architect 5.4.0 → 5.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 20aaf646a8056b8d5975cb789f55a49f9f9c0ca5deca38f9866a0e3e220e8904
-  data.tar.gz: a89104abc977aaeae263c09f922800252867df448050262c557d6f60780275f0
+  metadata.gz: 71935f28a32069832af5b4d25f368d33c7efc505267a98c4f4b49f75a0084861
+  data.tar.gz: 2b067fdbdd5a950b204ef9fb16a3484a634e0b6acd2f9ca467e8f47adec29902
 SHA512:
-  metadata.gz: f0a104ab6b75ec7170e5c4bc7a57c4406f002e167ba13b3d913d21a97f3c020a13d3912d2f2fada42edcd0ffeac876a8fdff2fe0c38ad163f617700927767493
-  data.tar.gz: ea287608ae6cb4a560d3b38e51e4d8b0c3d4dc04985e429046fe83b1588c8f7dd34608a7ede28ed45457ff8e0456226d4130ddfb6b9541dde875cc3976898a1b
+  metadata.gz: 66a47fc8027809c4132ba9e5365694ab530d646be68b0cacec80d527e81dcb28f7d192afb4e76ea1e9b0489bada20013af2c32da066075e28f39bb407fc89243
+  data.tar.gz: f10a02847f4dafb408b98eb6a79f4b911bc0db7bf1856fbef18b751928f2e824ee5a5596db82ca94641f2fa5f55b037a671d9fed4daf0c8b54a374735b5d4baf

data/CHANGELOG.md

@@ -5,6 +5,91 @@ All notable changes to this project are documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [5.5.1] - 2026-07-25
+
+### Fixed
+
+- **Lane in-bounds check no longer false-FAILs on dotfile directories** — the
+  `touch_set` matcher built its `fnmatch` flags without `File::FNM_DOTMATCH`, so
+  a `dir/**` touch glob never matched a path with a dot-prefixed segment. Any
+  lane creating `.github/workflows/ci.yml` *inside its own declared directory*
+  was reported out-of-bounds by `architect verify` check (d) and hard-blocked by
+  `architect integrate` ("wrote outside its declared touch set"), with no
+  override — the touch set is frozen at spec time, so neither side of the
+  comparison could be adjusted legitimately and the merges had to be done by
+  hand. `merge_lane!`'s conflict classification carried the identical blind spot;
+  both sites now share one `in_touch_set?` predicate so the flags cannot drift
+  again.
+
+## [5.5.0] - 2026-07-22
+
+### Added
+
+- **`architect jobs list` provenance columns** — the table gains Harness /
+  Model / Lane (sourced from the list JSON's existing fields), blank when an
+  older row lacks them, so parallel lanes are tellable apart at a glance.
+- **Server: pagination on the jobs, runs, and conversations indexes** — 50
+  rows per page with a `?page=N` param and Prev/Next controls; runs and
+  conversations were previously unbounded fetches. Conversations order
+  newest-updated first, and the index still never loads messages.
+- **Server: job re-run prefill** — `GET /jobs/new?from=<job id>` (owner-gated)
+  prefills the new-job form field-for-field from that job's spec via the same
+  mapping profile application uses; Jobs/Show gains a "Run again" link.
+- **Server: embedded live run view** — the run stream (SSE + rendering) is
+  extracted into a shared `RunStream` component and embedded on Jobs/Show
+  whenever the job has a run, so watching a job live no longer requires
+  leaving the job page.
+- **Server: browser cancel + honest canceled lifecycle** — Jobs/Show renders a
+  Cancel control while a job is queued/running; runs gain a distinct terminal
+  status `canceled(4)` (a canceled job's run no longer reports `failed`), and
+  a cancel arriving during the env-image build skips the container spawn (and
+  secret resolution) entirely.
+
+### Changed
+
+- **`architect sessions agent install` emits a launchd-proof plist** — the
+  agent's ProgramArguments now open with the installing interpreter's absolute
+  ruby path (`RbConfig.ruby`) ahead of the absolute bin path, and the agent
+  environment carries a homebrew-inclusive PATH, so launchd's bare PATH can no
+  longer resolve macOS system Ruby via an env shebang (LoadError, agent exit
+  1). Reinstall existing agents to migrate; wrapper-script workarounds are
+  obsolete.
+- **`architect dispatch --as-job` requires `--job-model`** — the missing model
+  now fails fast at dispatch with an error naming the flag, instead of
+  composing a spec the server rejects with a late 422.
+
+### Fixed
+
+- **Server: bulk session syncs no longer strand conversations at pending** —
+  transient DB-infrastructure errors (pool timeout, connection loss) inside an
+  import now re-raise so the queue's retry re-fires them, instead of being
+  swallowed as permanent failures; import concurrency is bounded below the DB
+  connection pool so a bulk backfill can't starve it.
+- **Server: NUL bytes can no longer fail imports or live persists** — one
+  shared scrub now covers the claude_code, codex, and pi importers and the
+  live run persistor (Postgres jsonb rejects NUL outright;
+  `PG::UntranslatableCharacter` was failing real claude_code transcripts with
+  NUL in tool-block content).
+- **Server: executor hardening** — a requeued job's raw Redis stream is
+  deleted at execution start (a surviving stale stream silently corrupted the
+  transcript); truncated failure evidence is scrubbed back to valid UTF-8 when
+  the byte boundary splits a multibyte character; the default sandbox base
+  image is `space-claude-base:v1` everywhere (dev bins previously defaulted to
+  `debian:stable-slim`).
+- **Server: models-proxy timeout covers key resolution** — `op://` key
+  resolution now runs inside the same 10s budget as the upstream fetch, and
+  the providers/models action only rescues the operation's own failure
+  classes, so genuine bugs propagate instead of masquerading as
+  `upstream_error`.
+- **Server: `parent_session_id` is clearable** — a re-import whose content no
+  longer implies a parent now nulls the stored link instead of preserving it
+  forever.
+- **Server: theme-aware transcript turn bands** — per-turn tint colors ride
+  CSS custom properties with light and dark definitions (bands were
+  dark-calibrated and near-invisible in light mode); a mid-fetch form edit no
+  longer gets clobbered by the pi-extension sync on the job/profile forms; the
+  generated pi extension places `compat` per-model per the upstream types.
+
 ## [5.4.0] - 2026-07-21
 
 ### Changed

data/lib/space_architect/architect_project.rb

@@ -42,6 +42,13 @@ module Space::Architect
     # Hard per-gate timeout. Generous relative to the full suite (~55s).
     DEFAULT_GATE_TIMEOUT = 900
 
+    # Flags for matching a changed path against a lane's touch_set globs.
+    # PATHNAME keeps a single `*` from crossing `/`; EXTGLOB enables `{a,b}`;
+    # DOTMATCH lets a glob reach dotfile segments, so a `dir/**` touch set covers
+    # `dir/.github/workflows/ci.yml` — the standard deliverable for a lane preparing
+    # a directory to become a repo root.
+    TOUCH_FNM = File::FNM_PATHNAME | File::FNM_EXTGLOB | File::FNM_DOTMATCH
+
     # Legacy sentinel: worktree_add used to seed prompt.md with this placeholder
     # (dropped — the blind-overwrite tripped harness read-before-write guards, #48).
     # dispatch still refuses to launch on this content, so stubs in old spaces
@@ -404,10 +411,7 @@ module Space::Architect
         git_capture("-C", repo_path.to_s, "merge", "--abort")
         conflict_files = conflicts.split
         lane_touch_set = lane_entry["touch_set"] || []
-        fnm = File::FNM_PATHNAME | File::FNM_EXTGLOB
-        outside = conflict_files.reject do |f|
-          lane_touch_set.any? { |g| File.fnmatch(g, f, fnm) || (g.end_with?("/**") && File.fnmatch("#{g}/*", f, fnm)) }
-        end
+        outside = conflict_files.reject { |f| in_touch_set?(f, lane_touch_set) }
         if !lane_touch_set.empty? && outside.empty?
           raise Space::Core::Error,
             "Merge conflict integrating lane '#{lane}' (#{conflict_files.join(", ")}) — the lane plan was " \
@@ -939,6 +943,7 @@ module Space::Architect
         resolve_dispatch_harness(lane_entry, model: model, harness: harness, effort: effort, force: force, err: err)
       raise Space::Core::Error, "--as-job only supports the claude-code harness (lane '#{lane}' resolves to '#{resolved_harness}')" \
         unless resolved_harness == "claude-code"
+      raise Space::Core::Error, "--job-model is required with --as-job" unless job_model
 
       id = iteration_id(entry)
       wt_path = space.path.join(lane_entry["worktree"] || "build/#{id}-#{lane}/wt")
@@ -1297,18 +1302,23 @@ module Space::Architect
           i += 1
           changed << orig if orig && !orig.empty?
         end
-        fnm = File::FNM_PATHNAME | File::FNM_EXTGLOB
-        changed.all? do |f|
-          touch_set.any? do |g|
-            File.fnmatch(g, f, fnm) ||
-              (g.end_with?("/**") && File.fnmatch("#{g}/*", f, fnm))
-          end
-        end
+        changed.all? { |f| in_touch_set?(f, touch_set) }
       end
 
       checks
     end
 
+    # Is a changed path inside a lane's declared touch set? Single-sourced so the
+    # in-bounds check (d) and merge_lane!'s conflict classification can never drift.
+    # A trailing `dir/**` is matched twice: bare (PATHNAME stops it at direct
+    # children) and as `dir/**/*`, whose whole-component `**/` does cross `/`.
+    def in_touch_set?(path, globs)
+      globs.any? do |g|
+        File.fnmatch(g, path, TOUCH_FNM) ||
+          (g.end_with?("/**") && File.fnmatch("#{g}/*", path, TOUCH_FNM))
+      end
+    end
+
     # Replace (or, with append:, extend) the body of a "## Heading" section, leaving
     # every other section byte-untouched. Append replaces a placeholder body (only a
     # template comment) the first time, then stacks subsections after it. A supplied

data/lib/space_architect/cli/architect.rb

@@ -349,6 +349,7 @@ module Space::Architect
             if as_job
               Jobs.require_credentials!(host, token)
               raise Space::Core::Error, "--backend-url is required with --as-job" unless backend_url
+              raise Space::Core::Error, "--job-model is required with --as-job" unless job_model
               raise Space::Core::Error, "--as-job cannot be combined with --push-url/--push-token/--push-host/--detach" \
                 if push_url || push_token || push_host || detach
             end
@@ -884,8 +885,11 @@ module Space::Architect
               if jobs.empty?
                 terminal.say "No jobs"
               else
-                rows = jobs.map { |j| [j["id"], j["status"], j["run_id"], j["created_at"]] }
-                terminal.say terminal.table(%w[ID Status RunID CreatedAt], rows)
+                rows = jobs.map do |j|
+                  [j["id"], j["status"], j["run_id"], j["created_at"],
+                   j["harness"], j["model"], j.dig("provenance", "lane")]
+                end
+                terminal.say terminal.table(%w[ID Status RunID CreatedAt Harness Model Lane], rows)
               end
               CLI.record_outcome(Outcome.new(exit_code: 0))
             end
@@ -1012,6 +1016,7 @@ module Space::Architect
                   refresh_interval: interval.to_i,
                   log_dir: SessionSync.log_dir,
                   bin_path: SessionSync::BinPath.detect,
+                  ruby_bin: RbConfig.ruby,
                   host: host,
                   env: {SessionSync::TOKEN_ENV => resolved_token}
                 )

data/lib/space_architect/session_sync/plist.rb

@@ -3,12 +3,15 @@
 module Space::Architect
   module SessionSync
     # Hand-rolled launchd plist emitter for the session-sync agent, imitating
-    # Space::Src::Launchd::Plist's shape. Unlike that emitter, this one does
-    # NOT wrap the invocation in mise/ruby toolchain resolution: the
-    # `architect` executable is a rubygems binstub (or the dev exe/architect
-    # script, which sets up Bundler itself) and needs no toolchain pinning to
-    # run non-interactively, so ProgramArguments invokes it directly.
+    # Space::Src::Launchd::Plist's shape. Under launchd's bare PATH, a bare
+    # env-relative ruby binstub shebang resolves to macOS system Ruby instead
+    # of the caller's toolchain, so ProgramArguments names the interpreter
+    # explicitly (ruby_bin) rather than relying on shebang resolution — no
+    # mise wrapping needed, since the sync itself pins no toolchain at run
+    # time.
     class Plist
+      DEFAULT_PATH = "/opt/homebrew/bin:/usr/local/bin:/usr/bin:/bin"
+
       HEADER = <<~XML
         <?xml version="1.0" encoding="UTF-8"?>
         <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
@@ -22,15 +25,17 @@ module Space::Architect
         # @param refresh_interval [Integer] StartInterval in seconds (must be > 0).
         # @param log_dir [String]          Absolute directory for stdout/stderr logs.
         # @param bin_path [String]         Absolute path to the architect bin script.
+        # @param ruby_bin [String]         Absolute path to the ruby to run bin_path under.
         # @param host [String]             --host value passed to `sessions sync`.
         # @param env [Hash]                EnvironmentVariables dict; must contain a non-empty
         #                                  SessionSync::TOKEN_ENV value (resolved by the caller —
-        #                                  never resolved here).
+        #                                  never resolved here). PATH defaults to DEFAULT_PATH
+        #                                  unless the caller supplies its own.
         # @return [String] the full plist XML.
-        def call(label:, refresh_interval:, log_dir:, bin_path:, host:, env:)
+        def call(label:, refresh_interval:, log_dir:, bin_path:, ruby_bin:, host:, env:)
           raise ArgumentError, "label is required" if label.to_s.empty?
           raise ArgumentError, "refresh_interval must be > 0" unless refresh_interval.is_a?(Integer) && refresh_interval > 0
-          %w[log_dir bin_path].each do |k|
+          %w[log_dir bin_path ruby_bin].each do |k|
             v = binding.local_variable_get(k)
             raise ArgumentError, "#{k} must be absolute (got #{v.inspect})" unless v.is_a?(String) && File.absolute_path?(v)
           end
@@ -43,12 +48,13 @@ module Space::Architect
           body = +""
           body << key("Label") << string(label) << "\n"
           body << key("ProgramArguments") << "\n" << array([
+            ruby_bin,
             bin_path,
             "sessions",
             "sync",
             "--host", host
           ])
-          body << key("EnvironmentVariables") << "\n" << dict(env)
+          body << key("EnvironmentVariables") << "\n" << dict({"PATH" => DEFAULT_PATH}.merge(env.to_h))
           body << key("StartInterval") << integer(refresh_interval) << "\n"
           body << key("RunAtLoad") << boolean(true) << "\n"
           body << key("ProcessType") << string("Background") << "\n"

data/lib/space_core/version.rb

@@ -2,6 +2,6 @@
 
 module Space
   module Core
-    VERSION = "5.4.0"
+    VERSION = "5.5.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: space-architect
 version: !ruby/object:Gem::Version
-  version: 5.4.0
+  version: 5.5.1
 platform: ruby
 authors:
 - Eric Jacobs