source_monitor 0.7.1 → 0.8.1

data/.vbw-planning/milestones/default/STATE.md

@@ -1,82 +0,0 @@
-<!-- VBW STATE TEMPLATE (ARTF-05) -- Session dashboard, auto-updated -->
-<!-- Updated after each plan completion and at checkpoints -->
-
-# Project State
-
-## Project Reference
-
-See: .vbw-planning/PROJECT.md (updated 2026-02-09)
-
-**Core value:** Drop-in Rails engine for feed monitoring, content scraping, and operational dashboards.
-**Current focus:** All phases complete
-
-## Current Position
-
-Phase: 4 of 4 (Code Quality & Conventions Cleanup)
-Plan: 3 of 3 in current phase
-Status: Built
-Last activity: 2026-02-10 -- Phase 4 complete (3/3 plans done)
-
-Progress: [##########] 100%
-
-## Codebase Profile
-
-- **Total source files:** 535
-- **Primary language:** Ruby (330 files)
-- **Templates:** ERB (48 files)
-- **Tests:** 137 test files detected
-- **Test suite:** 841 runs, 2776 assertions, 0 failures (up from 473 runs in Phase 1)
-- **Coverage:** 86.97% line, 58.84% branch (510 uncovered lines, down from 2117)
-- **CI/CD:** GitHub Actions (1 workflow)
-- **Docker:** Yes (2 files)
-- **Monorepo:** No
-- **Stack:** Ruby on Rails 8 engine, Solid Queue, Hotwire, Tailwind CSS, PostgreSQL, Minitest, RuboCop, Brakeman
-
-## Accumulated Context
-
-### Decisions
-
-- [bootstrap]: Focus on coverage + refactoring before new features
-- [bootstrap]: Keep PostgreSQL-only for now
-- [bootstrap]: Keep host-app auth model
-- [phase-1]: Omakase RuboCop config only enables 45/775 cops; all Metrics cops disabled
-- [phase-1]: No .rubocop.yml exclusions needed for large files (Metrics cops off)
-- [phase-2]: PG parallel fork segfault when running single test files; use PARALLEL_WORKERS=1 or full suite
-- [phase-2]: Configuration tests (Plan 03) were committed under mislabeled "dev-plan05" commit; corrected in summaries
-- [phase-3]: FeedFetcher extraction (Plan 01) was committed under mislabeled "plan-04" commit (2f00274); corrected in summaries
-- [phase-3]: Ruby autoload used instead of Zeitwerk for lib/ modules -- safest drop-in replacement for eager requires
-- [phase-3]: 11 boot-critical requires kept explicit; 71 autoload declarations replace 66 eager requires
-- [phase-4]: ItemCreator extracted from 601 to 174 lines (EntryParser + ContentExtractor sub-modules)
-- [phase-4]: Fix-everything approach for public API convention violations
-- [phase-4]: 3 files slightly exceed 300 lines (entry_parser 390, queries 356, application_helper 346) -- all single-responsibility, cannot be split further
-
-
-None
-
-### Blockers/Concerns
-
-None
-
-### Skills
-
-**Installed:**
-- agent-browser (global)
-- flowdeck (global)
-- ralph-tui-create-json (global)
-- ralph-tui-prd (global)
-- vastai (global)
-- find-skills (global)
-
-**Suggested (not installed):**
-- dhh-rails-style (registry) -- DHH-style Rails conventions
-- ruby-rails (registry) -- Ruby on Rails development
-- github-actions (registry) -- GitHub Actions workflow
-
-**Stack detected:** Ruby on Rails 8 engine, Solid Queue, Hotwire (Turbo + Stimulus), Tailwind CSS, PostgreSQL, ESLint, GitHub Actions, Minitest, RuboCop, Brakeman
-**Registry available:** yes
-
-## Session Continuity
-
-Last session: 2026-02-10
-Stopped at: All 4 phases complete
-Resume file: none

data/.vbw-planning/milestones/default/phases/01-coverage-analysis-quick-wins/PLAN-01-SUMMARY.md

@@ -1,56 +0,0 @@
-# PLAN-01 Summary: frozen-string-literal-audit
-
-## Status: COMPLETE
-
-## Commit
-
-- **Hash:** `5f02db8`
-- **Message:** `style(frozen-string-literal): add pragma to all Ruby files`
-- **Files changed:** 113 files, 223 insertions
-
-## Tasks Completed
-
-### Task 1: Add frozen_string_literal to app/ and lib/ source files
-- Added pragma to all 29 app/ and lib/ `.rb` files
-- No shebang lines encountered in any files
-
-### Task 2: Add frozen_string_literal to config and migration files
-- Added pragma to `config/routes.rb` and 4 migration files
-
-### Task 3: Add frozen_string_literal to test files (excluding test/dummy and test/tmp)
-- Added pragma to all 43 test `.rb` files
-- `test/test_helper.rb` had no shebang, straightforward prepend
-
-### Task 4: Add frozen_string_literal to test/dummy files
-- Added pragma to all 22 dummy app `.rb` files
-
-### Task 5: Validate full codebase compliance and run tests
-- `git ls-files -- '*.rb' | ... | grep -cv 'frozen_string_literal: true'` returns **0**
-- `bin/rubocop --only Style/FrozenStringLiteralComment` exits **0** (341 files, no offenses)
-- `bin/rails test` passes: **473 runs, 1927 assertions, 0 failures, 0 errors**
-
-## Deviations
-
-### DEVN-02: Non-.rb Ruby files also needed the pragma (14 additional files)
-
-The plan scoped only `.rb` files, but the success criterion requires `bin/rubocop --only Style/FrozenStringLiteralComment` to pass. RuboCop also inspects non-`.rb` Ruby files: `Gemfile`, `Rakefile`, `source_monitor.gemspec`, 3 `.rake` files, `test/dummy/Gemfile`, `test/dummy/Rakefile`, 5 `test/dummy/bin/*` scripts, and `test/dummy/config.ru`. All 14 were given the pragma.
-
-### DEVN-02: test/tmp/ excluded from RuboCop
-
-RuboCop was scanning 179 files under `test/tmp/` (untracked generated host app templates) which all lacked the pragma. Since these are not git-tracked and are generated artifacts, added `test/tmp/**/*` to `.rubocop.yml` AllCops Exclude list rather than modifying generated files.
-
-### DEVN-01: Shebang handling for bin scripts
-
-Five `test/dummy/bin/*` files had shebang lines. The pragma was correctly inserted after the shebang on line 2. Two files (`bin/dev`, `bin/jobs`) had a blank line between the shebang and the first require, which would have created a double blank line; these were cleaned up to have a single blank line separator.
-
-## Decisions
-
-1. **Included non-.rb Ruby files** -- To satisfy the RuboCop success criterion, all Ruby-like files RuboCop inspects needed the pragma, not just `.rb` files.
-2. **Excluded test/tmp/ from RuboCop** -- These are generated Rails app templates that are not git-tracked and should not be linted. This is a minimal `.rubocop.yml` change.
-3. **Did not modify test/lib/tmp/install_generator/config/routes.rb** -- This file is not git-tracked (despite the path existing on disk from a previous test run), so it was left as-is.
-
-## Success Criteria
-
-- [x] Every git-tracked `.rb` file has `# frozen_string_literal: true` (REQ-13)
-- [x] RuboCop `Style/FrozenStringLiteralComment` cop passes with zero offenses
-- [x] No test regressions introduced (473 tests, 0 failures)

data/.vbw-planning/milestones/default/phases/01-coverage-analysis-quick-wins/PLAN-01.md

@@ -1,187 +0,0 @@
----
-phase: 1
-plan: 1
-title: frozen-string-literal-audit
-wave: 1
-depends_on: []
-skills_used: []
-must_haves:
-  truths:
-    - "Every git-tracked `.rb` file begins with `# frozen_string_literal: true` as its first line (verified by `git ls-files -- '*.rb' | xargs head -1 | grep -cv 'frozen_string_literal: true'` returning 0)"
-    - "`bin/rubocop --only Style/FrozenStringLiteralComment` exits 0 with zero offenses"
-    - "All existing tests pass (`bin/rails test` exits 0)"
-  artifacts:
-    - "98 Ruby files modified to add the `# frozen_string_literal: true` pragma"
-  key_links:
-    - "REQ-13 fully satisfied by this plan"
----
-
-# Plan 01: frozen-string-literal-audit
-
-## Objective
-
-Add the `# frozen_string_literal: true` magic comment to every git-tracked Ruby file that is currently missing it. This is a mechanical, low-risk change that brings the codebase into full compliance with REQ-13 and prepares for the RuboCop audit in Plan 02.
-
-## Context
-
-<context>
-@.vbw-planning/REQUIREMENTS.md -- REQ-13: frozen_string_literal consistency
-@.vbw-planning/codebase/CONVENTIONS.md -- documents existing frozen_string_literal convention
-@.rubocop.yml -- RuboCop configuration (omakase base)
-
-**Decomposition rationale:** This plan is separated from the RuboCop audit because (a) frozen_string_literal changes touch nearly 100 files and are purely mechanical, making them ideal for a single focused commit, and (b) completing this first removes a large category of RuboCop violations, simplifying Plan 02's scope.
-
-**Current state:**
-- 325 git-tracked Ruby files total
-- 227 already have `# frozen_string_literal: true`
-- 98 are missing it
-- Missing files span: app/ (5), lib/ (24 including setup/, engine, version, assets), test/ (43 non-dummy test files), test/dummy/ (22), config/ (1), db/migrate/ (4)
-- The codebase convention (per CONVENTIONS.md) is to use frozen_string_literal consistently, but it has drifted in setup/, engine infrastructure, test files, and dummy app files
-
-**Constraints:**
-- Do NOT modify files under `test/tmp/` (generated artifacts, not tracked in git)
-- The `test/lib/tmp/install_generator/config/initializers/source_monitor.rb` already has the pragma (verified)
-- Migration files and config/routes.rb need the pragma too
-- Some files may have a shebang line (`#!/usr/bin/env ruby`) as line 1 -- the pragma must go AFTER the shebang
-- `test/dummy/db/schema.rb` is excluded from RuboCop in `.rubocop.yml` but should still get the pragma for consistency
-</context>
-
-## Tasks
-
-### Task 1: Add frozen_string_literal to app/ and lib/ source files
-
-- **name:** add-frozen-pragma-to-source-files
-- **files:**
-  - `app/controllers/source_monitor/application_controller.rb`
-  - `app/controllers/source_monitor/health_controller.rb`
-  - `app/helpers/source_monitor/application_helper.rb`
-  - `app/jobs/source_monitor/application_job.rb`
-  - `app/models/source_monitor/application_record.rb`
-  - `lib/source_monitor.rb`
-  - `lib/source_monitor/assets.rb`
-  - `lib/source_monitor/assets/bundler.rb`
-  - `lib/source_monitor/engine.rb`
-  - `lib/source_monitor/version.rb`
-  - `lib/source_monitor/setup/initializer_patcher.rb`
-  - `lib/source_monitor/setup/bundle_installer.rb`
-  - `lib/source_monitor/setup/workflow.rb`
-  - `lib/source_monitor/setup/gemfile_editor.rb`
-  - `lib/source_monitor/setup/requirements.rb`
-  - `lib/source_monitor/setup/detectors.rb`
-  - `lib/source_monitor/setup/shell_runner.rb`
-  - `lib/source_monitor/setup/cli.rb`
-  - `lib/source_monitor/setup/verification/printer.rb`
-  - `lib/source_monitor/setup/verification/telemetry_logger.rb`
-  - `lib/source_monitor/setup/verification/solid_queue_verifier.rb`
-  - `lib/source_monitor/setup/verification/result.rb`
-  - `lib/source_monitor/setup/verification/action_cable_verifier.rb`
-  - `lib/source_monitor/setup/verification/runner.rb`
-  - `lib/source_monitor/setup/install_generator.rb`
-  - `lib/source_monitor/setup/dependency_checker.rb`
-  - `lib/source_monitor/setup/prompter.rb`
-  - `lib/source_monitor/setup/migration_installer.rb`
-  - `lib/source_monitor/setup/node_installer.rb`
-- **action:** Prepend `# frozen_string_literal: true\n\n` to each file listed above. If the file already begins with a shebang (`#!`), insert the pragma on line 2 (after the shebang) with a blank line separating them. For `lib/source_monitor.rb` specifically, note it starts with `require` statements -- the pragma goes before all requires.
-- **verify:** Run `grep -cL 'frozen_string_literal: true' app/**/*.rb lib/**/*.rb` returns no results (all files have the pragma). Additionally run `ruby -c lib/source_monitor.rb` to confirm syntax validity.
-- **done:** All 29 app/ and lib/ Ruby files have `# frozen_string_literal: true` as their first non-shebang line.
-
-### Task 2: Add frozen_string_literal to config and migration files
-
-- **name:** add-frozen-pragma-to-config-and-migrations
-- **files:**
-  - `config/routes.rb`
-  - `db/migrate/20251009103000_add_feed_content_readability_to_sources.rb`
-  - `db/migrate/20251014171659_add_performance_indexes.rb`
-  - `db/migrate/20251014172525_add_fetch_status_check_constraint.rb`
-  - `db/migrate/20251108120116_refresh_fetch_status_constraint.rb`
-- **action:** Prepend `# frozen_string_literal: true\n\n` to each file. These are small files (migration class definitions and route definitions).
-- **verify:** Run `head -1` on each file to confirm the pragma is present. Run `ruby -c config/routes.rb` to confirm syntax validity (it will fail since it references SourceMonitor::Engine, so instead just visually confirm the pragma is on line 1).
-- **done:** All 5 config/ and db/migrate/ files have the pragma.
-
-### Task 3: Add frozen_string_literal to test files (excluding test/dummy and test/tmp)
-
-- **name:** add-frozen-pragma-to-test-files
-- **files:**
-  - `test/test_helper.rb`
-  - `test/source_monitor_test.rb`
-  - `test/gemspec_test.rb`
-  - `test/application_system_test_case.rb`
-  - `test/system/dropdown_fallback_test.rb`
-  - `test/integration/engine_mounting_test.rb`
-  - `test/integration/navigation_test.rb`
-  - `test/controllers/source_monitor/health_controller_test.rb`
-  - `test/jobs/source_monitor/fetch_feed_job_test.rb`
-  - `test/jobs/source_monitor/item_cleanup_job_test.rb`
-  - `test/jobs/source_monitor/log_cleanup_job_test.rb`
-  - All files under `test/lib/source_monitor/setup/` (12 files)
-  - All files under `test/lib/source_monitor/setup/verification/` (5 files)
-  - `test/lib/source_monitor/instrumentation_test.rb`
-  - `test/lib/source_monitor/feedjira_configuration_test.rb`
-  - `test/lib/source_monitor/metrics_test.rb`
-  - `test/lib/source_monitor/scheduler_test.rb`
-  - `test/lib/source_monitor/release/runner_test.rb`
-  - `test/lib/source_monitor/release/changelog_test.rb`
-  - `test/lib/source_monitor/items/item_creator_test.rb`
-  - `test/lib/source_monitor/items/retention_pruner_test.rb`
-  - `test/lib/source_monitor/events/event_system_test.rb`
-  - `test/lib/source_monitor/assets/bundler_test.rb`
-  - `test/lib/source_monitor/engine_assets_configuration_test.rb`
-  - `test/lib/source_monitor/http_test.rb`
-  - `test/lib/source_monitor/fetching/feed_fetcher_test.rb`
-  - `test/lib/source_monitor/fetching/fetch_runner_test.rb`
-- **action:** Prepend `# frozen_string_literal: true\n\n` to each file. The `test/test_helper.rb` file may have a shebang or special first lines -- check and handle accordingly.
-- **verify:** Run `find test -name '*.rb' -not -path 'test/tmp/*' -not -path 'test/dummy/*' -exec head -1 {} \; | grep -cv 'frozen_string_literal'` returns 0.
-- **done:** All 43 test files (excluding dummy and tmp) have the pragma.
-
-### Task 4: Add frozen_string_literal to test/dummy files
-
-- **name:** add-frozen-pragma-to-dummy-app
-- **files:**
-  - `test/dummy/app/controllers/application_controller.rb`
-  - `test/dummy/app/controllers/test_support_controller.rb`
-  - `test/dummy/app/helpers/application_helper.rb`
-  - `test/dummy/app/jobs/application_job.rb`
-  - `test/dummy/app/mailers/application_mailer.rb`
-  - `test/dummy/app/models/application_record.rb`
-  - `test/dummy/app/models/user.rb`
-  - `test/dummy/config/application.rb`
-  - `test/dummy/config/boot.rb`
-  - `test/dummy/config/environment.rb`
-  - `test/dummy/config/environments/development.rb`
-  - `test/dummy/config/environments/production.rb`
-  - `test/dummy/config/environments/test.rb`
-  - `test/dummy/config/importmap.rb`
-  - `test/dummy/config/puma.rb`
-  - `test/dummy/config/routes.rb`
-  - `test/dummy/config/initializers/assets.rb`
-  - `test/dummy/config/initializers/content_security_policy.rb`
-  - `test/dummy/config/initializers/filter_parameter_logging.rb`
-  - `test/dummy/config/initializers/inflections.rb`
-  - `test/dummy/db/migrate/20251124080000_create_users.rb`
-  - `test/dummy/db/schema.rb`
-- **action:** Prepend `# frozen_string_literal: true\n\n` to each file. The `test/dummy/db/schema.rb` may be auto-generated by Rails -- still add the pragma since it is git-tracked and part of the project.
-- **verify:** Run `find test/dummy -name '*.rb' -exec head -1 {} \; | grep -cv 'frozen_string_literal'` returns 0.
-- **done:** All 22 dummy app Ruby files have the pragma.
-
-### Task 5: Validate full codebase compliance and run tests
-
-- **name:** validate-frozen-pragma-compliance
-- **files:** (no files modified -- validation only)
-- **action:** Run three verification commands: (1) Count git-tracked Ruby files without the pragma -- must be 0. (2) Run `bin/rubocop --only Style/FrozenStringLiteralComment` to confirm zero RuboCop offenses for this cop. (3) Run the test suite to confirm no regressions from adding the pragma.
-- **verify:**
-  - `git ls-files -- '*.rb' | xargs head -1 | grep -cv 'frozen_string_literal: true'` outputs `0`
-  - `bin/rubocop --only Style/FrozenStringLiteralComment` exits 0
-  - `bin/rails test` exits 0 (or at minimum no new failures)
-- **done:** Full codebase compliance confirmed. REQ-13 is satisfied.
-
-## Verification
-
-1. `git ls-files -- '*.rb' | xargs head -1 | grep -cv 'frozen_string_literal: true'` returns `0`
-2. `bin/rubocop --only Style/FrozenStringLiteralComment` exits 0 with zero offenses
-3. Test suite passes with no regressions
-
-## Success Criteria
-
-- [x] Every git-tracked Ruby file has `# frozen_string_literal: true` (REQ-13)
-- [x] RuboCop `Style/FrozenStringLiteralComment` cop passes with zero offenses
-- [x] No test regressions introduced

data/.vbw-planning/milestones/default/phases/01-coverage-analysis-quick-wins/PLAN-02-SUMMARY.md

@@ -1,64 +0,0 @@
-# Plan 02 Summary: rubocop-audit-and-fix
-
-## Status: complete
-
-## Result
-
-The codebase already passes RuboCop with zero offenses against the `rubocop-rails-omakase` ruleset. No code changes were required.
-
-## Tasks Completed
-
-| Task | Name | Result |
-|------|------|--------|
-| 1 | rubocop-audit-categorize-violations | 341 files inspected, 0 offenses |
-| 2 | apply-safe-rubocop-autocorrect | No-op (no violations to fix) |
-| 3 | fix-remaining-rubocop-violations | No-op (no violations to fix) |
-| 4 | configure-rubocop-exclusions-for-phase3 | No-op (Metrics cops disabled in omakase) |
-| 5 | validate-rubocop-zero-offenses | All checks pass |
-
-## Violation Counts
-
-- **Before:** 0 offenses (341 files inspected)
-- **After:** 0 offenses (341 files inspected)
-
-## Commit
-
-No commit created -- no code changes were needed.
-
-## Verification Results
-
-| Check | Result |
-|-------|--------|
-| `bin/rubocop -f simple` | 341 files inspected, no offenses detected |
-| `bin/rubocop -f github` | Exit 0 |
-| `bin/rails test` | 473 runs, 1927 assertions, 0 failures, 0 errors, 0 skips |
-| Coverage baseline (`config/coverage_baseline.json`) | 2328 lines (unchanged) |
-
-## Key Findings
-
-1. **Omakase config is minimal by design.** The `rubocop-rails-omakase` gem enables only 45 cops (out of 775 available). It focuses on essential layout and style rules, not metrics or complex analysis.
-
-2. **Metrics cops are all disabled.** `Metrics/ClassLength`, `Metrics/MethodLength`, `Metrics/BlockLength`, and all other Metrics cops are set to `Enabled: false` in the omakase config. This means the large files (FeedFetcher 627 lines, Configuration 655 lines, ImportSessionsController 792 lines) do not trigger any violations. No `.rubocop.yml` exclusions were needed.
-
-3. **Plan 01 was the key enabler.** The frozen_string_literal pragma work (Plan 01, commit 5f02db8, 113 files) was likely the primary source of violations. After that was completed, the remaining code was already compliant with the 45 enabled cops.
-
-4. **Enabled cop categories:**
-   - Layout (27 cops): indentation, spacing, whitespace
-   - Style (12 cops): string literals, hash syntax, parentheses, semicolons
-   - Lint (4 cops): string coercion, require parentheses, syntax, URI escape
-   - Performance (1 cop): flat_map
-   - Migration (1 cop): department name
-
-## Deviations
-
-| ID | Description | Impact |
-|----|-------------|--------|
-| DEVN-01 | Tasks 2-4 were no-ops because no violations existed | None -- plan designed for worst case, actual state was already compliant |
-| DEVN-01 | No git commit created (no code changes) | None -- the success criteria (zero offenses, tests pass) are satisfied without changes |
-| DEVN-01 | No `.rubocop.yml` exclusions added for Phase 3 files | None -- Metrics cops are disabled in omakase, so exclusions would be meaningless |
-
-## REQ-14 Status
-
-**REQ-14 (Audit and fix any RuboCop violations against omakase ruleset): SATISFIED**
-
-The audit confirms zero violations exist. The CI lint job (`bin/rubocop -f github`) exits 0.

data/.vbw-planning/milestones/default/phases/01-coverage-analysis-quick-wins/PLAN-02.md

@@ -1,137 +0,0 @@
----
-phase: 1
-plan: 2
-title: rubocop-audit-and-fix
-wave: 2
-depends_on: [1]
-skills_used: []
-must_haves:
-  truths:
-    - "`bin/rubocop` exits 0 with zero offenses (verified by `bin/rubocop -f simple` output showing `no offenses detected`)"
-    - "All existing tests pass (`bin/rails test` exits 0 with no new failures)"
-    - "CI lint job would pass (`bin/rubocop -f github` exits 0)"
-  artifacts:
-    - "All Ruby files in app/, lib/, test/, config/, db/ comply with rubocop-rails-omakase rules"
-    - "`.rubocop.yml` may have additional targeted exclusions if auto-generated files legitimately violate rules"
-  key_links:
-    - "REQ-14 fully satisfied by this plan"
-    - "Depends on Plan 01 (frozen_string_literal already resolved -- largest category of violations removed)"
----
-
-# Plan 02: rubocop-audit-and-fix
-
-## Objective
-
-Audit the entire codebase with RuboCop using the `rubocop-rails-omakase` configuration and fix all violations, achieving zero offenses. This satisfies REQ-14 and ensures the CI lint job passes cleanly.
-
-## Context
-
-<context>
-@.vbw-planning/REQUIREMENTS.md -- REQ-14: RuboCop audit against omakase ruleset
-@.vbw-planning/codebase/CONVENTIONS.md -- Rails omakase style guide, existing patterns
-@.rubocop.yml -- inherits from rubocop-rails-omakase, excludes test/dummy/db/schema.rb
-@Gemfile -- rubocop-rails-omakase gem included
-@bin/rubocop -- wrapper script that forces config path
-@.github/workflows/ci.yml -- lint job runs `bin/rubocop -f github`
-
-**Decomposition rationale:** This plan depends on Plan 01 because `Style/FrozenStringLiteralComment` is typically the most voluminous cop violation. By completing Plan 01 first, this plan deals with a much smaller and more varied set of violations that require more careful, contextual fixes.
-
-**Current state:**
-- The project uses `rubocop-rails-omakase` as its base ruleset (inherits the gem's rubocop.yml)
-- Only one exclusion exists: `test/dummy/db/schema.rb`
-- After Plan 01 completes, `Style/FrozenStringLiteralComment` violations will be resolved
-- Remaining violations are unknown until the audit is run, but likely categories include:
-  - `Style/StringLiterals` (single vs double quotes)
-  - `Layout/*` (indentation, spacing, line length)
-  - `Metrics/*` (method/class length -- may need exclusions for large files targeted in Phase 3)
-  - `Naming/*` (variable/method naming conventions)
-  - `Rails/*` cops from the omakase set
-- Large files (FeedFetcher 627 lines, Configuration 655 lines, ImportSessionsController 792 lines) may trigger `Metrics/ClassLength` or `Metrics/MethodLength` -- these should be addressed with targeted `.rubocop.yml` exclusions since Phase 3 handles the actual refactoring
-
-**Constraints:**
-- Fix violations using RuboCop auto-correct where safe (`rubocop -a` for safe corrections, `-A` for aggressive only when reviewed)
-- Do NOT refactor large files to satisfy Metrics cops -- instead exclude them in `.rubocop.yml` with a comment referencing Phase 3
-- Preserve all existing behavior -- style-only changes
-- The `test/dummy/db/schema.rb` exclusion must remain (Rails-generated)
-- Test files in `test/tmp/` are not git-tracked and not subject to RuboCop
-</context>
-
-## Tasks
-
-### Task 1: Run RuboCop audit and categorize violations
-
-- **name:** rubocop-audit-categorize-violations
-- **files:** (no files modified -- analysis only)
-- **action:** Run `bin/rubocop -f json -o tmp/rubocop_report.json` and `bin/rubocop -f simple` to get a complete picture of all violations. Categorize them by: (a) auto-correctable with `-a` (safe), (b) auto-correctable with `-A` (unsafe, needs review), (c) manual fix required, (d) should be excluded (Metrics cops on large files destined for Phase 3 refactoring). Document the count and category of each cop violation type.
-- **verify:** The audit report exists and lists all violations. Categorization is complete.
-- **done:** Full understanding of the violation landscape. Clear plan for which files need which type of fix.
-
-### Task 2: Apply safe auto-corrections
-
-- **name:** apply-safe-rubocop-autocorrect
-- **files:** All Ruby files flagged by RuboCop safe auto-correct
-- **action:** Run `bin/rubocop -a` to apply all safe auto-corrections across the codebase. This handles cops like `Style/StringLiterals`, `Layout/TrailingWhitespace`, `Layout/EmptyLineAfterMagicComment`, `Layout/SpaceInsideBlockBraces`, etc. Review the diff to confirm no behavioral changes -- only formatting/style changes. If any auto-correction looks wrong, revert that specific change and handle it manually in Task 3.
-- **verify:** Run `git diff --stat` to see scope of changes. Run `bin/rails test` to confirm no test regressions. Run `bin/rubocop -f simple` to see remaining violations after safe auto-correct.
-- **done:** All safe auto-correctable violations are fixed. Test suite still passes.
-
-### Task 3: Fix remaining violations manually
-
-- **name:** fix-remaining-rubocop-violations
-- **files:** Files with violations that were not auto-correctable or were unsafe auto-corrections
-- **action:** For each remaining violation:
-  - **Style cops**: Fix manually following the omakase conventions (single quotes for simple strings, double quotes when interpolation needed, etc.)
-  - **Layout cops**: Fix indentation, spacing, alignment manually
-  - **Naming cops**: Rename variables/methods to comply (ensure test references are updated)
-  - **Rails cops**: Fix any Rails-specific violations (e.g., `Rails/HttpPositionalArguments`)
-  - If a violation is in a file that is inherently non-compliant due to its nature (e.g., a migration with unusual structure), add a targeted inline `# rubocop:disable` comment with an explanation
-- **verify:** Run `bin/rubocop -f simple` after each batch of fixes. The violation count should decrease monotonically. Run `bin/rails test` after all manual fixes.
-- **done:** All non-Metrics violations are resolved either by code changes or justified inline disables.
-
-### Task 4: Configure exclusions for large files (Phase 3 targets)
-
-- **name:** configure-rubocop-exclusions-for-phase3
-- **files:**
-  - `.rubocop.yml`
-- **action:** If `Metrics/ClassLength`, `Metrics/MethodLength`, or `Metrics/BlockLength` violations remain for the three large files targeted for refactoring in Phase 3, add targeted exclusions to `.rubocop.yml`:
-  ```yaml
-  # Phase 3 refactoring targets -- remove exclusions after extraction
-  Metrics/ClassLength:
-    Exclude:
-      - "lib/source_monitor/fetching/feed_fetcher.rb"
-      - "lib/source_monitor/configuration.rb"
-      - "app/controllers/source_monitor/import_sessions_controller.rb"
-  ```
-  Add a comment explaining these are temporary exclusions that will be removed in Phase 3. Do NOT exclude any other files -- only the three identified large files.
-- **verify:** Run `bin/rubocop` and confirm it exits 0 with zero offenses. The exclusions should only cover the Phase 3 target files.
-- **done:** `.rubocop.yml` has targeted, documented exclusions. Zero RuboCop offenses across the entire codebase.
-
-### Task 5: Final validation and CI readiness check
-
-- **name:** validate-rubocop-zero-offenses
-- **files:** (no files modified -- validation only)
-- **action:** Run the full validation suite: (1) `bin/rubocop -f simple` -- must show `no offenses detected`. (2) `bin/rubocop -f github` -- must exit 0 (this is what CI runs). (3) `bin/rails test` -- full test suite must pass. (4) Verify the coverage baseline has not grown (run `wc -l config/coverage_baseline.json` and confirm it is still approximately 2328 lines -- style changes should not affect coverage).
-- **verify:**
-  - `bin/rubocop` exits 0
-  - `bin/rubocop -f github` exits 0
-  - `bin/rails test` exits 0
-  - Coverage baseline line count has not increased
-- **done:** Zero RuboCop violations. CI-ready. REQ-14 satisfied.
-
-## Verification
-
-1. `bin/rubocop -f simple` outputs `no offenses detected`
-2. `bin/rubocop -f github` exits 0 (CI lint format)
-3. `bin/rails test` exits 0 with no regressions
-4. Coverage baseline (`config/coverage_baseline.json`) has not grown in line count
-
-## Success Criteria
-
-- [x] Zero RuboCop violations against the omakase ruleset (REQ-14)
-- [x] Any `.rubocop.yml` exclusions are limited to Phase 3 target files with documenting comments
-- [x] CI lint job (`bin/rubocop -f github`) passes
-- [x] No test regressions
-- [x] No behavioral changes -- all fixes are style/formatting only
-
-## Phase 1 Coverage Note
-
-Phase 1 success criterion #3 ("Coverage baseline shrinks by at least 10%") is not directly addressed by Plans 01 or 02, which focus on code quality (REQ-13, REQ-14). The coverage baseline may shrink slightly if RuboCop fixes remove dead branches or simplify code paths. After Plan 02 completes, regenerate the baseline with `bin/update-coverage-baseline` and measure the delta. The 10% reduction target (from 2328 uncovered lines to ~2095 or fewer) will primarily be achieved in Phase 2 when dedicated test coverage plans execute.

data/.vbw-planning/milestones/default/phases/02-critical-path-test-coverage/PLAN-01-SUMMARY.md

@@ -1,67 +0,0 @@
-# PLAN-01 Summary: feed-fetcher-tests
-
-## Status: COMPLETE
-
-## Commit
-
-- **Hash:** `8d4e8d3`
-- **Message:** `test(feed-fetcher): close coverage gaps for retry, errors, headers, entries, helpers [dev-plan01]`
-- **Files changed:** 1 file, 734 insertions
-
-## Tasks Completed
-
-### Task 1: Test retry strategy and circuit breaker transitions
-- Added tests for reset_retry_state!, apply_retry_strategy!, circuit breaker open/close
-- Verified first timeout sets fetch_retry_attempt to 1
-- Verified exhausting retries opens circuit (sets fetch_circuit_opened_at, fetch_circuit_until)
-- Verified successful fetch resets retry state
-- Tested RetryPolicy error handling fallback
-
-### Task 2: Test Faraday error wrapping and connection failures
-- Tested Faraday::ConnectionFailed raises ConnectionError with original_error preserved
-- Tested Faraday::SSLError raises ConnectionError
-- Tested Faraday::ClientError with response hash builds HTTPError via build_http_error_from_faraday
-- Tested generic Faraday::Error raises FetchError
-- Tested non-Faraday StandardError wrapped in UnexpectedResponseError
-
-### Task 3: Test Last-Modified header handling and request headers
-- Tested If-Modified-Since header sent when source.last_modified is set
-- Tested Last-Modified response header parsed and stored on source
-- Tested malformed Last-Modified headers silently ignored
-- Tested custom_headers from source passed through to request
-- Tested ETag and Last-Modified preserved on 304 responses
-
-### Task 4: Test entry processing edge cases and error normalization
-- Tested feed without entries returns zero counts
-- Tested Events.run_item_processors called for each entry
-- Tested Events.after_item_created called only for created items
-- Tested normalize_item_error extracts guid via entry_id/id fallbacks
-- Tested safe_entry_title returns nil for entries without title
-
-### Task 5: Test jitter, interval helpers, and metadata management
-- Tested jitter_offset returns 0 when interval_seconds <= 0
-- Tested jitter_offset uses jitter_proc when provided
-- Tested body_digest returns nil for blank body, SHA256 for non-blank
-- Tested updated_metadata preserves existing metadata
-- Tested configured_seconds, extract_numeric edge cases
-
-## Deviations
-
-None -- plan executed as specified.
-
-## Verification Results
-
-| Check | Result |
-|-------|--------|
-| `bin/rails test test/lib/source_monitor/fetching/feed_fetcher_test.rb` | All tests pass |
-| `bin/rails test` | 760 runs, 2626 assertions, 0 failures, 0 errors, 0 skips |
-
-## Success Criteria
-
-- [x] 48 new tests added (734 lines)
-- [x] All retry/circuit breaker branches tested
-- [x] All Faraday error wrapping branches tested
-- [x] All header handling branches tested
-- [x] Entry processing and error normalization branches tested
-- [x] Jitter, interval helpers, and metadata management tested
-- [x] REQ-01 substantially satisfied