source_monitor 0.4.0 → 0.5.1

data/CHANGELOG.md

@@ -15,6 +15,31 @@ All notable changes to this project are documented below. The format follows [Ke
 
 - No unreleased changes yet.
 
+## [0.5.1] - 2026-02-13
+
+### Changed
+
+- Bumped puma from 7.1.0 to 7.2.0 (17% faster HTTP parsing, `workers :auto`, GC-compactible C extension).
+- Bumped solid_queue from 1.2.4 to 1.3.1 (async mode, bug fixes).
+- Bumped turbo-rails from 2.0.20 to 2.0.23 (broadcast suppression fix, navigator clobbering fix).
+
+## [0.5.0] - 2026-02-13
+
+### Added
+
+- `bin/source_monitor upgrade` command: detects version changes since last install, copies new migrations, re-runs the generator, runs verification, and reports what changed. Uses a `.source_monitor_version` marker file for version tracking.
+- `PendingMigrationsVerifier` checks for unmigrated SourceMonitor tables in the verification suite, integrated into both `bin/source_monitor verify` and the upgrade flow.
+- Configuration deprecation framework: engine developers can register deprecated config options with `DeprecationRegistry.register`. At boot time, stale options trigger `:warning` (renamed) or `:error` (removed) messages with actionable replacement paths.
+- `sm-upgrade` AI skill guides agents through post-update workflows: CHANGELOG parsing, running the upgrade command, interpreting verification results, and handling deprecation warnings.
+- `docs/upgrade.md` versioned upgrade guide with general steps, version-specific notes (0.1.x through 0.4.x), and troubleshooting.
+- `sm-host-setup` skill cross-references the upgrade workflow.
+
+### Testing
+
+- 1,003 tests, 0 failures (up from 973 in 0.4.0).
+- RuboCop: 397 files, 0 offenses.
+- Brakeman: 0 warnings.
+
 ## [0.4.0] - 2026-02-12
 
 ### Added

data/CLAUDE.md

@@ -4,9 +4,10 @@
 
 ## Active Context
 
-**Milestone:** none (archived)
-**Last shipped:** default (2026-02-10) -- 4 phases, 14 plans, 841 tests
-**Next action:** /vbw:plan to start new milestone
+**Milestone:** (none active)
+**Last shipped:** upgrade-assurance (2026-02-13) -- 3 phases, 14 tasks, 12 commits
+**Previous:** generator-enhancements (2026-02-12) -- v0.4.0
+**Next action:** /vbw:vibe to start a new milestone
 
 ## Key Decisions
 
@@ -192,6 +193,7 @@ Engine-specific skills (`sm-*` prefix). Consumer skills install by default; cont
 | `sm-event-handler` | Lifecycle callbacks (after_item_created, etc.) |
 | `sm-model-extension` | Extend engine models from host app |
 | `sm-dashboard-widget` | Dashboard queries, presenters, Turbo broadcasts |
+| `sm-upgrade` | Gem upgrade workflow with CHANGELOG parsing |
 
 ### Contributor Skills (opt-in)
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    source_monitor (0.4.0)
+    source_monitor (0.5.1)
       cssbundling-rails (~> 1.4)
       faraday (~> 2.9)
       faraday-follow_redirects (~> 0.4)
@@ -241,7 +241,7 @@ GEM
       date
       stringio
     public_suffix (6.0.2)
-    puma (7.1.0)
+    puma (7.2.0)
       nio4r (~> 2.0)
     raabro (1.4.0)
     racc (1.8.1)
@@ -349,7 +349,7 @@ GEM
       activejob (>= 7.2)
       activerecord (>= 7.2)
       railties (>= 7.2)
-    solid_queue (1.2.4)
+    solid_queue (1.3.1)
       activejob (>= 7.1)
       activerecord (>= 7.1)
       concurrent-ruby (>= 1.3.1)
@@ -362,7 +362,7 @@ GEM
     thor (1.5.0)
     timeout (0.6.0)
     tsort (0.2.0)
-    turbo-rails (2.0.20)
+    turbo-rails (2.0.23)
       actionpack (>= 7.1.0)
       railties (>= 7.1.0)
     tzinfo (2.0.6)

data/VERSION

@@ -1 +1 @@
-0.4.0
+0.5.1

data/docs/upgrade.md

@@ -0,0 +1,140 @@
+# SourceMonitor Upgrade Guide
+
+This guide covers upgrading SourceMonitor to a new gem version in your host Rails application.
+
+## General Upgrade Steps
+
+1. Review the [CHANGELOG](../CHANGELOG.md) for changes between your current and target versions
+2. Update your Gemfile version constraint and run `bundle update source_monitor`
+3. Run the upgrade command: `bin/source_monitor upgrade`
+4. Apply database migrations if new ones were copied: `bin/rails db:migrate`
+5. Address any deprecation warnings in your initializer (see Deprecation Handling below)
+6. Run verification: `bin/source_monitor verify`
+7. Restart your web server and background workers
+
+## Quick Upgrade (Most Cases)
+
+```bash
+# 1. Update the gem
+bundle update source_monitor
+
+# 2. Run the upgrade command (handles migrations, generator, verification)
+bin/source_monitor upgrade
+
+# 3. Migrate if needed
+bin/rails db:migrate
+
+# 4. Restart
+# (restart web server and Solid Queue workers)
+```
+
+## Deprecation Handling
+
+When upgrading, you may see deprecation warnings in your Rails log:
+
+```
+[SourceMonitor] DEPRECATION: 'http.old_option' was deprecated in v0.5.0 and replaced by 'http.new_option'.
+```
+
+To resolve:
+1. Open `config/initializers/source_monitor.rb`
+2. Find the deprecated option (e.g., `config.http.old_option = value`)
+3. Replace with the new option from the warning message (e.g., `config.http.new_option = value`)
+4. Restart and verify the warning is gone
+
+If a removed option raises an error (`SourceMonitor::DeprecatedOptionError`), you must update the initializer before the app can boot.
+
+## Version-Specific Notes
+
+### Upgrading to 0.4.0 (from 0.3.x)
+
+**Released:** 2026-02-12
+
+**What changed:**
+- Install generator now auto-patches `Procfile.dev` with a Solid Queue `jobs:` entry
+- Install generator now patches `config/queue.yml` dispatcher with `recurring_schedule: config/recurring.yml`
+- Active Storage image download feature added (opt-in)
+- SSL certificate configuration added to HTTP settings
+- Enhanced verification messages for SolidQueue and RecurringSchedule verifiers
+
+**Upgrade steps:**
+```bash
+bundle update source_monitor
+bin/source_monitor upgrade
+bin/rails db:migrate
+```
+
+**Notes:**
+- No breaking changes. All existing configuration remains valid.
+- Re-running the generator (`bin/rails generate source_monitor:install`) will add missing `Procfile.dev` and `queue.yml` entries without overwriting existing config.
+- New optional features: `config.images.download_to_active_storage = true`, `config.http.ssl_ca_file`, `config.http.ssl_ca_path`, `config.http.ssl_verify`.
+
+### Upgrading to 0.3.0 (from 0.2.x)
+
+**Released:** 2026-02-10
+
+**What changed:**
+- Internal refactoring: FeedFetcher, Configuration, ImportSessionsController, and ItemCreator extracted into smaller modules
+- Eager requires replaced with Ruby autoload
+- Skills system added (14 `sm-*` Claude Code skills)
+
+**Upgrade steps:**
+```bash
+bundle update source_monitor
+bin/source_monitor upgrade
+bin/rails db:migrate
+```
+
+**Notes:**
+- No breaking changes to the public API.
+- If you referenced internal classes directly (e.g., `SourceMonitor::FeedFetcher` internals), verify your code against the new module structure.
+- Optionally install AI skills: `bin/rails source_monitor:skills:install`
+
+### Upgrading to 0.2.0 (from 0.1.x)
+
+**Released:** 2025-11-25
+
+**What changed:**
+- OPML import wizard with multi-step flow
+- New `ImportHistory` model and associated migrations
+
+**Upgrade steps:**
+```bash
+bundle update source_monitor
+bin/rails railties:install:migrations FROM=source_monitor
+bin/rails db:migrate
+```
+
+**Notes:**
+- New database tables required. Run migrations after updating.
+- No configuration changes needed.
+
+## Troubleshooting
+
+### "Already up to date" but I expected changes
+- Verify the gem version actually changed: `bundle show source_monitor`
+- Check `Gemfile.lock` for the resolved version
+- If the `.source_monitor_version` marker was manually edited, delete it and re-run upgrade
+
+### Migrations fail with duplicate timestamps
+- Remove the duplicate migration file from `db/migrate/` (keep the newer one)
+- Re-run `bin/rails db:migrate`
+
+### Deprecation error prevents boot
+- Read the error message for the replacement option
+- Update your initializer before restarting
+- If unsure which option to use, consult [Configuration Reference](configuration.md)
+
+### Verification failures after upgrade
+- **PendingMigrations:** Run `bin/rails db:migrate`
+- **SolidQueue:** Ensure workers are running. Check `Procfile.dev` for a `jobs:` entry.
+- **RecurringSchedule:** Re-run `bin/rails generate source_monitor:install` to patch `config/queue.yml`
+- **ActionCable:** Configure Solid Cable or Redis adapter
+
+For additional help, see [Troubleshooting](troubleshooting.md).
+
+## See Also
+- [Setup Guide](setup.md) -- Initial installation
+- [Configuration Reference](configuration.md) -- All configuration options
+- [Troubleshooting](troubleshooting.md) -- Common issues and fixes
+- [CHANGELOG](../CHANGELOG.md) -- Full version history

data/lib/source_monitor/configuration/deprecation_registry.rb

@@ -0,0 +1,237 @@
+# frozen_string_literal: true
+
+module SourceMonitor
+  class DeprecatedOptionError < StandardError; end
+
+  class Configuration
+    # Registry for deprecated configuration options.
+    #
+    # Engine developers register deprecations at boot time via the DSL:
+    #
+    #   SourceMonitor::Configuration::DeprecationRegistry.register(
+    #     "http.old_proxy_url",
+    #     removed_in: "0.5.0",
+    #     replacement: "http.proxy",
+    #     severity: :warning,
+    #     message: "Use config.http.proxy instead"
+    #   )
+    #
+    # When a host app's initializer accesses a deprecated option, the
+    # trapping method fires automatically:
+    #   - :warning  -- logs via Rails.logger.warn and forwards to replacement
+    #   - :error    -- raises SourceMonitor::DeprecatedOptionError
+    #
+    class DeprecationRegistry
+      # Maps settings accessor names (as used on Configuration) to their classes.
+      SETTINGS_CLASSES = {
+        "http" => "HTTPSettings",
+        "fetching" => "FetchingSettings",
+        "health" => "HealthSettings",
+        "scraping" => "ScrapingSettings",
+        "retention" => "RetentionSettings",
+        "realtime" => "RealtimeSettings",
+        "authentication" => "AuthenticationSettings",
+        "images" => "ImagesSettings",
+        "scrapers" => "ScraperRegistry",
+        "events" => "Events",
+        "models" => "Models"
+      }.freeze
+
+      class << self
+        # Register a deprecated configuration option.
+        #
+        # @param path [String] dot-notation path, e.g. "http.old_proxy_url" or "old_queue_prefix"
+        # @param removed_in [String] version in which the option was deprecated
+        # @param replacement [String, nil] dot-notation path to the replacement option
+        # @param severity [:warning, :error] :warning logs + forwards, :error raises
+        # @param message [String, nil] additional migration guidance
+        def register(path, removed_in:, replacement: nil, severity: :warning, message: nil)
+          segments = path.split(".")
+          source_prefix = nil
+          if segments.length == 1
+            target_class = Configuration
+            option_name = segments.first
+          else
+            source_prefix = segments.first
+            option_name = segments.last
+            class_name = SETTINGS_CLASSES[source_prefix]
+            raise ArgumentError, "Unknown settings accessor: #{source_prefix}" unless class_name
+
+            target_class = Configuration.const_get(class_name)
+          end
+
+          deprecation_message = build_message(path, removed_in, replacement, message)
+
+          if target_class.method_defined?(:"#{option_name}=") || target_class.method_defined?(option_name.to_sym)
+            warn "[SourceMonitor] DeprecationRegistry: '#{path}' already exists on #{target_class.name}. " \
+                 "Skipping trap definition -- the option is not yet removed/renamed."
+            entries[path] = { path: path, removed_in: removed_in, replacement: replacement,
+                              severity: severity, message: deprecation_message, skipped: true }
+            return
+          end
+
+          define_trap_methods(target_class, option_name, deprecation_message, severity, replacement,
+                              source_prefix: source_prefix)
+
+          entries[path] = { path: path, removed_in: removed_in, replacement: replacement,
+                            severity: severity, message: deprecation_message, skipped: false }
+        end
+
+        # Remove all registered deprecation traps and clear state.
+        # Essential for test isolation.
+        def clear!
+          defined_methods.each do |target_class, method_name|
+            target_class.remove_method(method_name) if target_class.method_defined?(method_name)
+          rescue NameError
+            # Method was already removed or never defined; ignore.
+          end
+
+          @entries = {}
+          @defined_methods = []
+        end
+
+        # Returns a duplicate of the entries hash for inspection.
+        def entries
+          @entries ||= {}
+        end
+
+        # Check if a path is registered.
+        def registered?(path)
+          entries.key?(path)
+        end
+
+        # No-op hook for future "default changed" checks.
+        # Called by Configuration#check_deprecations! after the configure block.
+        def check_defaults!(_config)
+          # Reserved for future use. Phases may add checks like:
+          # "option X changed its default from A to B in version Y"
+        end
+
+        private
+
+        def defined_methods
+          @defined_methods ||= []
+        end
+
+        def build_message(path, removed_in, replacement, extra_message)
+          parts = +"[SourceMonitor] DEPRECATION: '#{path}' was deprecated in v#{removed_in}"
+          parts << " and replaced by '#{replacement}'" if replacement
+          parts << ". #{extra_message}" if extra_message
+          parts << "." unless parts.end_with?(".")
+          parts.freeze
+        end
+
+        def define_trap_methods(target_class, option_name, deprecation_message, severity, replacement, source_prefix: nil)
+          writer_name = :"#{option_name}="
+          reader_name = option_name.to_sym
+
+          case severity
+          when :warning
+            define_warning_writer(target_class, writer_name, deprecation_message, replacement, source_prefix)
+            define_warning_reader(target_class, reader_name, deprecation_message, replacement, source_prefix)
+          when :error
+            define_error_method(target_class, writer_name, deprecation_message)
+            define_error_method(target_class, reader_name, deprecation_message)
+          else
+            raise ArgumentError, "Unknown severity: #{severity}. Must be :warning or :error."
+          end
+
+          defined_methods.push([ target_class, writer_name ], [ target_class, reader_name ])
+        end
+
+        def define_warning_writer(target_class, writer_name, deprecation_message, replacement, source_prefix)
+          replacement_writer = replacement_setter_for(replacement, source_prefix)
+
+          target_class.define_method(writer_name) do |value|
+            Rails.logger.warn(deprecation_message)
+            if replacement_writer
+              resolve_replacement_target(replacement_writer[:target]).public_send(
+                replacement_writer[:setter], value
+              )
+            end
+          end
+        end
+
+        def define_warning_reader(target_class, reader_name, deprecation_message, replacement, source_prefix)
+          replacement_reader = replacement_getter_for(replacement, source_prefix)
+
+          target_class.define_method(reader_name) do
+            Rails.logger.warn(deprecation_message)
+            if replacement_reader
+              resolve_replacement_target(replacement_reader[:target]).public_send(
+                replacement_reader[:getter]
+              )
+            end
+          end
+        end
+
+        def define_error_method(target_class, method_name, deprecation_message)
+          target_class.define_method(method_name) do |*|
+            raise SourceMonitor::DeprecatedOptionError, deprecation_message
+          end
+        end
+
+        # Parse replacement path into target accessor chain and setter name.
+        # When source_prefix matches the replacement prefix, the target is nil
+        # (replacement is on the same settings class).
+        #
+        # "http.proxy" with source_prefix "http" => { target: nil, setter: "proxy=" }
+        # "queue_namespace" => { target: nil, setter: "queue_namespace=" }
+        # "http.proxy" with source_prefix nil => { target: :http, setter: "proxy=" }
+        def replacement_setter_for(replacement, source_prefix = nil)
+          return nil unless replacement
+
+          segments = replacement.split(".")
+          if segments.length == 1
+            { target: nil, setter: :"#{segments.first}=" }
+          elsif source_prefix && segments.first == source_prefix
+            { target: nil, setter: :"#{segments.last}=" }
+          else
+            { target: segments.first.to_sym, setter: :"#{segments.last}=" }
+          end
+        end
+
+        # Parse replacement path into target accessor chain and getter name.
+        def replacement_getter_for(replacement, source_prefix = nil)
+          return nil unless replacement
+
+          segments = replacement.split(".")
+          if segments.length == 1
+            { target: nil, getter: segments.first.to_sym }
+          elsif source_prefix && segments.first == source_prefix
+            { target: nil, getter: segments.last.to_sym }
+          else
+            { target: segments.first.to_sym, getter: segments.last.to_sym }
+          end
+        end
+      end
+    end
+  end
+end
+
+# Add a helper method to settings classes and Configuration for resolving
+# replacement targets. This allows "http.proxy" to resolve as self.http.proxy
+# from within a Configuration instance, or as self.proxy from within an
+# HTTPSettings instance.
+module SourceMonitor
+  class Configuration
+    private
+
+    def resolve_replacement_target(accessor)
+      accessor ? public_send(accessor) : self
+    end
+  end
+end
+
+# Add the same helper to all settings classes so forwarding works
+# when the deprecated method is defined on a nested settings class
+# and the replacement is on the same class (e.g. "http.old_proxy" -> "http.proxy").
+SourceMonitor::Configuration::DeprecationRegistry::SETTINGS_CLASSES.each_value do |class_name|
+  klass = SourceMonitor::Configuration.const_get(class_name)
+  unless klass.method_defined?(:resolve_replacement_target, false)
+    klass.define_method(:resolve_replacement_target) do |accessor|
+      accessor ? public_send(accessor) : self
+    end
+    klass.send(:private, :resolve_replacement_target)
+  end
+end

data/lib/source_monitor/configuration.rb

@@ -14,6 +14,7 @@ require "source_monitor/configuration/events"
 require "source_monitor/configuration/validation_definition"
 require "source_monitor/configuration/model_definition"
 require "source_monitor/configuration/models"
+require "source_monitor/configuration/deprecation_registry"
 
 module SourceMonitor
   class Configuration
@@ -85,5 +86,12 @@ module SourceMonitor
         raise ArgumentError, "unknown queue role #{role.inspect}"
       end
     end
+
+    # Post-configure hook for deprecation validation.
+    # Delegates to DeprecationRegistry.check_defaults! for future
+    # "default changed" checks. Currently a no-op.
+    def check_deprecations!
+      DeprecationRegistry.check_defaults!(self)
+    end
   end
 end

data/lib/source_monitor/setup/cli.rb

@@ -23,6 +23,13 @@ module SourceMonitor
         handle_summary(summary)
       end
 
+      desc "upgrade", "Upgrade SourceMonitor after a gem version change"
+      def upgrade
+        command = UpgradeCommand.new
+        summary = command.call
+        handle_summary(summary)
+      end
+
       private
 
       def handle_summary(summary)

data/lib/source_monitor/setup/skills_installer.rb

@@ -11,6 +11,7 @@ module SourceMonitor
       CONSUMER_SKILLS = %w[
         sm-host-setup sm-configure sm-scraper-adapter
         sm-event-handler sm-model-extension sm-dashboard-widget
+        sm-upgrade
       ].freeze
 
       CONTRIBUTOR_SKILLS = %w[

data/lib/source_monitor/setup/upgrade_command.rb

@@ -0,0 +1,59 @@
+# frozen_string_literal: true
+
+module SourceMonitor
+  module Setup
+    class UpgradeCommand
+      def initialize(
+        migration_installer: MigrationInstaller.new,
+        install_generator: InstallGenerator.new,
+        verifier: Verification::Runner.new,
+        version_file: File.join(Dir.pwd, ".source_monitor_version"),
+        current_version: SourceMonitor::VERSION
+      )
+        @migration_installer = migration_installer
+        @install_generator = install_generator
+        @verifier = verifier
+        @version_file = version_file
+        @current_version = current_version
+      end
+
+      def call
+        stored = read_stored_version
+
+        if stored == current_version
+          return up_to_date_summary
+        end
+
+        migration_installer.install
+        install_generator.run
+        summary = verifier.call
+        write_version_marker
+        summary
+      end
+
+      private
+
+      attr_reader :migration_installer, :install_generator, :verifier, :version_file, :current_version
+
+      def read_stored_version
+        return nil unless File.exist?(version_file)
+
+        File.read(version_file).strip
+      end
+
+      def write_version_marker
+        File.write(version_file, current_version)
+      end
+
+      def up_to_date_summary
+        result = Verification::Result.new(
+          key: :upgrade,
+          name: "Upgrade",
+          status: :ok,
+          details: "Already up to date (v#{current_version})"
+        )
+        Verification::Summary.new([ result ])
+      end
+    end
+  end
+end

data/lib/source_monitor/setup/verification/pending_migrations_verifier.rb

@@ -0,0 +1,92 @@
+# frozen_string_literal: true
+
+module SourceMonitor
+  module Setup
+    module Verification
+      class PendingMigrationsVerifier
+        MIGRATION_TIMESTAMP_PATTERN = /\A\d+_/
+
+        def initialize(
+          engine_migrations_path: default_engine_migrations_path,
+          host_migrations_path: default_host_migrations_path,
+          connection: default_connection
+        )
+          @engine_migrations_path = engine_migrations_path
+          @host_migrations_path = host_migrations_path
+          @connection = connection
+        end
+
+        def call
+          engine_names = source_monitor_migration_names(engine_migrations_path)
+          return ok_result("No SourceMonitor engine migrations found") if engine_names.empty?
+
+          host_names = migration_names(host_migrations_path)
+          missing = engine_names - host_names
+
+          if missing.any?
+            warning_result(
+              "#{missing.size} SourceMonitor migration(s) not copied to host: #{missing.join(', ')}",
+              "Run `bin/source_monitor upgrade` or `bin/rails railties:install:migrations FROM=source_monitor`"
+            )
+          elsif connection.migration_context.needs_migration?
+            warning_result(
+              "All SourceMonitor migrations are copied but some migrations are pending",
+              "Run `bin/rails db:migrate` to apply pending migrations"
+            )
+          else
+            ok_result("All SourceMonitor migrations are present and up to date")
+          end
+        rescue StandardError => e
+          error_result(
+            "Migration verification failed: #{e.message}",
+            "Check database connectivity and migration file permissions"
+          )
+        end
+
+        private
+
+        attr_reader :engine_migrations_path, :host_migrations_path, :connection
+
+        def default_engine_migrations_path
+          SourceMonitor::Engine.root.join("db/migrate")
+        end
+
+        def default_host_migrations_path
+          Rails.root.join("db/migrate")
+        end
+
+        def default_connection
+          ActiveRecord::Base.connection
+        end
+
+        def source_monitor_migration_names(path)
+          migration_names(path).select { |name| name.include?("source_monitor") }
+        end
+
+        def migration_names(path)
+          return [] unless File.directory?(path.to_s)
+
+          Dir.children(path.to_s)
+            .select { |f| f.end_with?(".rb") }
+            .map { |f| strip_timestamp(f) }
+        end
+
+        def strip_timestamp(filename)
+          filename.sub(MIGRATION_TIMESTAMP_PATTERN, "").delete_suffix(".rb")
+        end
+
+        def ok_result(details)
+          Result.new(key: :pending_migrations, name: "Pending Migrations", status: :ok, details: details)
+        end
+
+        def warning_result(details, remediation)
+          Result.new(key: :pending_migrations, name: "Pending Migrations", status: :warning, details: details, remediation: remediation)
+        end
+
+        def error_result(details, remediation)
+          Result.new(key: :pending_migrations, name: "Pending Migrations", status: :error, details: details, remediation: remediation)
+        end
+      end
+    end
+  end
+end

data/lib/source_monitor/setup/verification/runner.rb

@@ -18,7 +18,7 @@ module SourceMonitor
         attr_reader :verifiers
 
         def default_verifiers
-          [ SolidQueueVerifier.new, RecurringScheduleVerifier.new, ActionCableVerifier.new ]
+          [ PendingMigrationsVerifier.new, SolidQueueVerifier.new, RecurringScheduleVerifier.new, ActionCableVerifier.new ]
         end
       end
     end

data/lib/source_monitor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SourceMonitor
-  VERSION = "0.4.0"
+  VERSION = "0.5.1"
 end