source_monitor 0.3.3 → 0.4.0

data/.vbw-planning/phases/04-dashboard-ux/04-VERIFICATION.md

@@ -0,0 +1,129 @@
+---
+phase: 4
+tier: standard
+result: PASS
+passed: 23
+failed: 0
+total: 23
+date: 2026-02-12
+---
+
+## Must-Have Checks
+
+| # | Truth/Condition | Status | Evidence |
+|---|-----------------|--------|----------|
+| 1 | Run `PARALLEL_WORKERS=1 bin/rails test test/lib/source_monitor/dashboard/recent_activity_presenter_test.rb` exits 0 with 0 failures | PASS | 6 runs, 14 assertions, 0 failures, 0 errors, 0 skips |
+| 2 | Run `PARALLEL_WORKERS=1 bin/rails test test/lib/source_monitor/logs/table_presenter_test.rb` exits 0 with 0 failures | PASS | 1 runs, 51 assertions, 0 failures, 0 errors, 0 skips |
+| 3 | Run `bin/rails test` exits 0 with 874+ runs and 0 failures | PASS | 885 runs, 2957 assertions, 0 failures, 0 errors, 0 skips |
+| 4 | Run `bin/rubocop` exits 0 with 0 offenses | PASS | 381 files inspected, 0 offenses (after auto-fix of Active Storage migration) |
+
+## Artifact Checks
+
+| Artifact | Exists | Contains | Status |
+|----------|--------|----------|--------|
+| lib/source_monitor/dashboard/recent_activity.rb | YES | source_feed_url | PASS |
+| lib/source_monitor/dashboard/recent_activity_presenter.rb | YES | source_domain | PASS |
+| lib/source_monitor/dashboard/queries/recent_activity_query.rb | YES | feed_url | PASS |
+| lib/source_monitor/logs/table_presenter.rb | YES | url_label | PASS |
+| app/helpers/source_monitor/application_helper.rb | YES | external_link_to | PASS |
+| app/views/source_monitor/dashboard/_recent_activity.html.erb | YES | url_display | PASS |
+| app/views/source_monitor/sources/_row.html.erb | YES | external_link_to | PASS |
+| app/views/source_monitor/sources/_details.html.erb | YES | external_link_to | PASS |
+| app/views/source_monitor/items/_details.html.erb | YES | external_link_to | PASS |
+
+## Key Link Checks
+
+| From | To | Via | Status |
+|------|----|----|--------|
+| recent_activity_query.rb#fetch_log_sql | REQ-22 | JOIN sources to pull feed_url (line 90), displayed as domain on dashboard | PASS |
+| recent_activity_query.rb#scrape_log_sql | REQ-22 | JOIN items to pull item url (line 108), displayed on dashboard | PASS |
+| application_helper.rb#external_link_to | REQ-23 | All external URLs use this helper for target=_blank + external-link icon (line 217) | PASS |
+| sources/_row.html.erb | REQ-23 | Feed URL in source index row is clickable (line 32) | PASS |
+| sources/_details.html.erb | REQ-23 | Website URL and feed URL on source detail page are clickable (lines 28, 140) | PASS |
+| items/_details.html.erb | REQ-23 | Item URL and canonical URL are clickable (lines 56-57) | PASS |
+
+## Convention Compliance
+
+| Convention | File | Status | Detail |
+|------------|------|--------|--------|
+| frozen_string_literal | All modified .rb files | PASS | All files have frozen_string_literal pragma |
+| Test coverage | Helper tests | PASS | 7 new tests for external_link_to and domain_from_url |
+| Test coverage | Presenter tests | PASS | 4 new tests for url_display in fetch/scrape events |
+| Test coverage | Table presenter tests | PASS | 6 new assertions for url_label/url_href |
+| RuboCop omakase | All modified files | PASS | 0 offenses after auto-fix |
+| Rails conventions | Helper methods | PASS | external_link_to follows Rails helper patterns, returns html_safe |
+| Rails conventions | Query objects | PASS | SQL JOINs use LEFT JOIN, proper table name quoting |
+| Rails conventions | View partials | PASS | Use helper methods, maintain existing layout structure |
+
+## Anti-Pattern Scan
+
+| Pattern | Found | Location | Severity |
+|---------|-------|----------|----------|
+| TODO/FIXME/HACK/XXX | YES | app/controllers/source_monitor/items_controller.rb:39 | INFO |
+| Hard-coded strings | NO | N/A | N/A |
+| Missing nil checks | NO | All helpers check for blank URLs | N/A |
+| Unsafe HTML rendering | NO | link_to returns html_safe | N/A |
+| N+1 queries | NO | Query uses JOINs, not lazy loading | N/A |
+
+**Note:** The TODO in items_controller.rb is pre-existing (extract ItemScrapesController), not related to Phase 4.
+
+## Requirement Mapping
+
+| Requirement | Plan Ref | Artifact Evidence | Status |
+|-------------|----------|-------------------|--------|
+| REQ-22: Fetch logs show source URL on dashboard | PLAN-01 Task 2, 3, 4 | recent_activity_query.rb JOINs sources (line 90), presenter extracts domain (line 33), view displays url_display (line 24-30) | PASS |
+| REQ-22: Scrape logs show item URL on dashboard | PLAN-01 Task 2, 3, 4 | recent_activity_query.rb JOINs items (line 108), presenter passes item_url (line 372), view displays url_display (line 24-30) | PASS |
+| REQ-22: Both success and failure show URLs | PLAN-01 Task 2 | Tests verify failure events include url_display (recent_activity_presenter_test.rb line 436-455) | PASS |
+| REQ-22: Logs table shows URL info | PLAN-01 Task 3 | table_presenter.rb url_label method (line 64), logs/index.html.erb displays below subject | PASS |
+| REQ-23: external_link_to helper with target=_blank | PLAN-01 Task 1 | application_helper.rb line 217-224, includes target="_blank", rel="noopener noreferrer" | PASS |
+| REQ-23: Feed URLs clickable in source index | PLAN-01 Task 5 | sources/_row.html.erb line 32 uses external_link_to | PASS |
+| REQ-23: Website/Feed URLs clickable in source detail | PLAN-01 Task 5 | sources/_details.html.erb lines 28, 140 use external_link_to | PASS |
+| REQ-23: Item URLs clickable in item detail | PLAN-01 Task 5 | items/_details.html.erb lines 56-57 use external_link_to | PASS |
+
+## Summary
+
+**Tier:** standard
+
+**Result:** PASS
+
+**Passed:** 23/23
+
+**Failed:** None
+
+### Verification Details
+
+Phase 4 (Dashboard UX Improvements) has been fully executed according to PLAN-01 specifications:
+
+1. **Helper Layer (Task 1):** `external_link_to` helper added with target="_blank", rel="noopener noreferrer", and external-link SVG icon. `domain_from_url` helper extracts hostnames from URLs. Both handle nil/blank inputs gracefully. 7 comprehensive tests cover all edge cases.
+
+2. **Data Layer (Task 2):** `recent_activity_query.rb` now JOINs sources table for fetch logs (pulling feed_url) and items table for scrape logs (pulling item url). Event struct extended with `source_feed_url` field. Presenter extracts domain for fetch events and passes through item URL for scrape events. Both success and failure events include URL info. 4 new tests verify all scenarios.
+
+3. **Logs Table (Task 3):** `table_presenter.rb` Row class adds `url_label` (domain for fetches, full URL for scrapes) and `url_href` methods. Health check rows return nil. 6 assertions added to existing comprehensive test.
+
+4. **View Layer (Task 4):** Dashboard `_recent_activity.html.erb` displays URL below event description. Logs `index.html.erb` displays URL below subject column. Both use `external_link_to` for clickable links with consistent muted styling.
+
+5. **Clickable URLs (Task 5):** All external URLs across source index rows, source detail page (feed URL, website URL), and item detail page (URL, canonical URL) are now clickable with new-tab behavior.
+
+### Test Results
+
+- Test suite: **885 runs, 2957 assertions, 0 failures**
+- RuboCop: **381 files inspected, 0 offenses**
+- Coverage: All new functionality covered by tests
+
+### Requirements Satisfied
+
+- **REQ-22:** Fetch logs show source domain; scrape logs show item URL; both success and failure events display URL info; logs table shows URL below subject column
+- **REQ-23:** All external URLs are clickable links opening in new tabs with external-link icon indicator
+
+### Commits Verified
+
+All 5 commits referenced in PLAN-01-SUMMARY.md are present:
+- 6fde387: Add external_link_to and domain_from_url helpers
+- 527bea1: Add URL info to recent activity query and presenter
+- cd6041e: Add url_label and url_href to logs table presenter
+- 5376b03: Show URL info in dashboard and logs views
+- 51db3c6: Make external URLs clickable across views
+
+### Deviations
+
+None. All tasks executed as specified in PLAN-01. No requirements gaps, no anti-patterns introduced, full test coverage achieved.

data/.vbw-planning/phases/04-dashboard-ux/PLAN-01-SUMMARY.md

@@ -0,0 +1,70 @@
+# PLAN-01 Summary: dashboard-url-display-and-clickable-links
+
+## Status: COMPLETE
+
+## What Was Built
+
+### Task 1: Add external_link_to helper and tests
+- Added `external_link_to(label, url, **options)` public helper: renders `<a>` with `target="_blank"`, `rel="noopener noreferrer"`, and external-link SVG icon; returns plain label when URL is blank
+- Added `domain_from_url(url)` public helper: extracts hostname via `URI.parse`, returns nil for blank/invalid URLs
+- Added `external_link_icon` private helper: renders Heroicon external-link SVG with consistent Tailwind styling
+- 7 new tests covering link rendering, nil/blank handling, custom CSS class, domain extraction, and invalid URL
+
+### Task 2: Add URL info to recent activity query and presenter
+- Added `:source_feed_url` field to `Dashboard::RecentActivity::Event` struct
+- Updated `fetch_log_sql` to JOIN `sources` table and SELECT `feed_url AS source_feed_url`
+- Updated `scrape_log_sql` to JOIN `items` table and SELECT `items.url AS item_url`
+- Added `NULL AS source_feed_url` to `scrape_log_sql` and `item_sql` for UNION column alignment
+- Updated `build_event` to pass `source_feed_url` from query results
+- Added `url_display` (domain for fetches, full URL for scrapes) and `url_href` keys to presenter view models
+- Added `source_domain` private method for domain extraction
+- 4 new tests: fetch with domain, fetch with nil URL, failure with URL, scrape with item URL
+
+### Task 3: Add URL to logs table presenter
+- Added `url_label` public method: returns domain for fetch rows, item URL for scrape rows, nil for health checks
+- Added `url_href` public method: returns full feed_url for fetches, item URL for scrapes, nil for health checks
+- Added `domain_from_feed_url` private helper with URI parsing
+- 6 new assertions for fetch, scrape, and health check row types
+
+### Task 4: Update dashboard and logs views with URL display
+- Dashboard `_recent_activity.html.erb`: added URL display line below event description, using `external_link_to` for clickable links
+- Logs `index.html.erb`: added URL display below subject column in table rows, using `external_link_to` for clickable links
+- Both use muted `text-slate-400` styling with `hover:text-blue-500` for visual consistency
+
+### Task 5: Make external URLs clickable across views
+- `sources/_row.html.erb`: feed_url in source index row is now a clickable external link
+- `sources/_details.html.erb`: Feed URL header and Website URL in details hash are clickable external links
+- `items/_details.html.erb`: URL and Canonical URL in details hash are clickable external links
+
+## Files Modified
+- `app/helpers/source_monitor/application_helper.rb` (external_link_to, domain_from_url, external_link_icon)
+- `lib/source_monitor/dashboard/recent_activity.rb` (source_feed_url field)
+- `lib/source_monitor/dashboard/queries/recent_activity_query.rb` (JOIN sources/items, source_feed_url column)
+- `lib/source_monitor/dashboard/recent_activity_presenter.rb` (url_display, url_href, source_domain)
+- `lib/source_monitor/logs/table_presenter.rb` (url_label, url_href, domain_from_feed_url)
+- `app/views/source_monitor/dashboard/_recent_activity.html.erb` (URL display below description)
+- `app/views/source_monitor/logs/index.html.erb` (URL display below subject)
+- `app/views/source_monitor/sources/_row.html.erb` (clickable feed_url)
+- `app/views/source_monitor/sources/_details.html.erb` (clickable feed URL, website URL)
+- `app/views/source_monitor/items/_details.html.erb` (clickable URL, canonical URL)
+- `test/helpers/source_monitor/application_helper_test.rb` (7 new tests)
+- `test/lib/source_monitor/dashboard/recent_activity_presenter_test.rb` (4 new tests)
+- `test/lib/source_monitor/logs/table_presenter_test.rb` (6 new assertions)
+
+## Commits
+- `6fde387` feat(04-dashboard-ux): add external_link_to and domain_from_url helpers
+- `527bea1` feat(04-dashboard-ux): add URL info to recent activity query and presenter
+- `cd6041e` feat(04-dashboard-ux): add url_label and url_href to logs table presenter
+- `5376b03` feat(04-dashboard-ux): show URL info in dashboard and logs views
+- `51db3c6` feat(04-dashboard-ux): make external URLs clickable across views
+
+## Requirements Satisfied
+- REQ-22: Fetch log events display source domain; scrape log events display item URL; both success and failure events show URL info; logs table shows URL below subject column
+- REQ-23: All external URLs (feed URLs, website URLs, item URLs, canonical URLs) are clickable links opening in new tabs with external-link icon indicator
+
+## Verification Results
+- `bin/rails test`: 885 runs, 2957 assertions, 0 failures, 0 errors
+- `bin/rubocop`: 378 files inspected, 0 offenses
+
+## Deviations
+None. All tasks executed as specified in the plan.