soundx 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 06e4808727b131b50f1d37e805eb4660e3d0291437588ed2f77bc221691ba57b
-  data.tar.gz: e030973ecc248204ac6f7b6c4f09c73bd38fe69cf9b2bd4c8a94e34aa00ecd47
+  metadata.gz: 70da174fdeb5829dc7ad150b4d3f55ffdc10234e2f3b766fbe0a5b958855fa9f
+  data.tar.gz: 69fd9ec26626d65efd54ef0ced2112bf1818ea8ce9557c68253e1299abc5b5da
 SHA512:
-  metadata.gz: c61cc1f4bfcf617bc34fc2562c703a6e2475756a5b53767ca8b8c3878f67d4c6a89e3c41819444345fe16e853ce398ae4dae0eadbbdef1817bad5999dea844f8
-  data.tar.gz: 7a04204d898953dd287b54331bce9d13862d5930519526857344b2fe6eda345842d084feac90a9a02d32441a1a95c257f8cf311e81fb498081939b0cebdc1a47
+  metadata.gz: 4045704be2c535c5cf56324e156300217a820e9aa52518c96ff8865906d2c9bb191bb7cb98044842382d96752d871b2acd46cea9c4a91d8b207222d423e3bf78
+  data.tar.gz: 616866e481e640814594105e59407d200e782ffeabfbde84fd4895189cac7dd3c270f691914bd436d6adf5828674c7747ba2b491dd13c960f52df387ddf35331

data/ext/soundx/soundx.c

@@ -20,7 +20,7 @@ r                      => 6
  Pre-computed mapping of a-z to the above
  table.
 */
-static const char mapping[128] = {
+static const unsigned char mapping[128] = {
 0xFE, 0xFE, 0xFE, 0xFE, 0xFE, 0xFE, 0xFE,
 0xFE, 0xFE, 0xFE, 0xFE, 0xFE, 0xFE, 0xFE,
 0xFE, 0xFE, 0xFE, 0xFE, 0xFE, 0xFE, 0xFE,
@@ -46,14 +46,15 @@ static VALUE
 rb_soundx(int argc, VALUE* argv, VALUE self)
 {
   VALUE input;
-  const unsigned char* src;
+  unsigned char* src;
   int written = 0;
   size_t srclen;
-  char *dest = malloc(5);
 
-  if (!dest) {
-    rb_raise(rb_eNoMemError, "malloc failed");
-  }
+  /*
+   Destination is padded with up to 3 trailing zeros
+   for short names.
+  */
+  char dest[5] = {'0', '0', '0', '0', '\0'};
 
   rb_scan_args(argc, argv, "1", &input);
 
@@ -62,7 +63,7 @@ rb_soundx(int argc, VALUE* argv, VALUE self)
   }
 
   srclen = RSTRING_LEN(input);
-  src = (const unsigned char*) StringValueCStr(input);
+  src = (unsigned char *) StringValueCStr(input);
 
   dest[0] = toupper(src[0]);
 
@@ -76,15 +77,14 @@ rb_soundx(int argc, VALUE* argv, VALUE self)
     }
 
     if (src[i] > 128) {
-      free(dest);
       rb_raise(rb_eArgError, "non-ASCII character found");
       break;
     }
 
     unsigned char current = tolower(src[i]);
 
-    char match = mapping[ current ];
-    if (0xFE == (int) match) {
+    unsigned char match = mapping[ current ];
+    if (0xFE == match) {
       continue;
     }
 
@@ -104,18 +104,7 @@ rb_soundx(int argc, VALUE* argv, VALUE self)
     written++;
   }
 
-  // Pad at most three '0' characters
-  // to handle really short names
-  if (written < 3) {
-    for( int i = (3-written); i > 0; i--) {
-      dest[written+i] = '0';
-    }
-  }
-
-  dest[4] = '\0';
-
   VALUE rbString = rb_str_new_cstr(dest);
-  free(dest);
 
   return rbString;
 }

data/lib/soundx/version.rb

@@ -1,3 +1,3 @@
 module SoundX
-  VERSION = '1.0.2'
+  VERSION = '1.0.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soundx
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - James Cook
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-07 00:00:00.000000000 Z
+date: 2019-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake-compiler