sorted 1.1.1 → 2.0.0

data/spec/sorted/orms/active_record_spec.rb

@@ -1,33 +0,0 @@
-require 'spec_helper'
-
-if defined? ActiveRecord
-  describe Sorted::Orms::ActiveRecord do
-    ActiveRecord::Base.send(:include, Sorted::Orms::ActiveRecord)
-
-    class SortedActiveRecordTest < ActiveRecord::Base
-      establish_connection adapter: 'sqlite3', database: ':memory:'
-
-      connection.create_table table_name, force: true do |t|
-        t.string :name
-      end
-
-      scope :page, -> { limit(50) }
-    end
-
-    it 'should integrate with ActiveRecord::Base' do
-      SortedActiveRecordTest.should respond_to(:sorted)
-      SortedActiveRecordTest.should respond_to(:resorted)
-    end
-
-    it 'should play nice with other scopes' do
-      sql = "SELECT  \"sorted_active_record_tests\".* FROM \"sorted_active_record_tests\"  WHERE \"sorted_active_record_tests\".\"name\" = 'bob'  ORDER BY \"name\" ASC LIMIT 50"
-      SortedActiveRecordTest.where(name: 'bob').page.sorted(nil, 'name ASC').to_sql.should == sql
-      SortedActiveRecordTest.page.sorted(nil, 'name ASC').where(name: 'bob').to_sql.should == sql
-    end
-
-    it 'should override the provided order' do
-      sql = "SELECT  \"sorted_active_record_tests\".* FROM \"sorted_active_record_tests\"  WHERE \"sorted_active_record_tests\".\"name\" = 'bob'  ORDER BY \"name\" ASC LIMIT 50"
-      SortedActiveRecordTest.page.where(name: 'bob').order(:id).sorted(nil, 'name DESC').resorted(nil, 'name ASC').to_sql.should == sql
-    end
-  end
-end

data/spec/sorted/orms/mongoid_spec.rb

@@ -1,32 +0,0 @@
-require 'spec_helper'
-
-if defined? Mongoid
-  describe Sorted::Orms::Mongoid do
-    ::Mongoid::Criteria.send :include, Sorted::Orms::Mongoid
-    ::Mongoid::Document.send :include, Sorted::Orms::Mongoid
-
-    class SortedMongoidTest
-      include ::Mongoid::Document
-
-      field :name, type: String
-
-      def self.page
-        limit(50)
-      end
-    end
-
-    it 'should integrate with Mongoid::Document' do
-      SortedMongoidTest.should respond_to(:sorted)
-    end
-
-    it 'should integrate with Mongoid::Criteria' do
-      SortedMongoidTest.page.should respond_to(:sorted)
-    end
-
-    it 'should play nice with other scopes' do
-      query_options = { limit: 50, sort: { 'name' => 1 } }
-      SortedMongoidTest.page.sorted(nil, 'name ASC').options.should == query_options
-      SortedMongoidTest.page.sorted(nil, 'name ASC').options.should == query_options
-    end
-  end
-end

data/spec/sorted/parser_spec.rb

@@ -1,117 +0,0 @@
-require 'spec_helper'
-
-describe Sorted::Parser, 'params parsing' do
-  it 'should not raise if pased nil arguments' do
-    -> { Sorted::Parser.new(nil, nil).toggle }.should_not raise_error
-  end
-
-  it 'should return a nice array from the order sql' do
-    sort   = nil
-    order  = 'email ASC, phone ASC, name DESC'
-    result = [['email', 'asc'], ['phone', 'asc'], ['name', 'desc']]
-
-    sorter = Sorted::Parser.new(sort, order)
-    sorter.orders.should eq result
-  end
-
-  it 'should return a nice array from the sort params' do
-    sort   = 'email_desc!name_desc'
-    order  = nil
-    result = [['email', 'desc'], ['name', 'desc']]
-
-    sorter = Sorted::Parser.new(sort, order)
-    sorter.sorts.should eq result
-  end
-
-  it 'should combine sort and order params with sort params being of higer importance' do
-    sort   = 'email_desc!name_desc'
-    order  = 'email ASC, phone ASC, name DESC'
-    result = [['email', 'desc'], ['name', 'desc'], ['phone', 'asc']]
-
-    sorter = Sorted::Parser.new(sort, order)
-    sorter.to_a.should eq result
-  end
-
-  it 'should allow numbers, underscores and full stops in sort params' do
-    sort   = 'assessmentsTable.name_desc!users_300.name_5_desc'
-    order  = nil
-    result = [['assessmentsTable.name', 'desc'], ['users_300.name_5', 'desc']]
-
-    sorter = Sorted::Parser.new(sort, order)
-    sorter.sorts.should eq result
-  end
-
-  it 'should allow numbers, underscores and full stops in order params' do
-    sort   = nil
-    order  = 'assessmentsTable.name ASC, users_300.name_5 ASC'
-    result = [['assessmentsTable.name', 'asc'], ['users_300.name_5', 'asc']]
-
-    sorter = Sorted::Parser.new(sort, order)
-    sorter.orders.should eq result
-  end
-
-  it 'should default to asc if sort params order is ommited' do
-    sort   = nil
-    order  = :email
-    result = [['email', 'asc']]
-
-    sorter = Sorted::Parser.new(sort, order)
-    sorter.orders.should eq result
-  end
-end
-
-describe Sorted::Parser, 'return types' do
-  module FakeConnection
-    def self.quote_column_name(column_name)
-      "`#{column_name}`"
-    end
-  end
-
-  let(:quoter) {
-    ->(frag) { FakeConnection.quote_column_name(frag) }
-  }
-
-  it 'should properly escape sql column names' do
-    order = 'users.name DESC'
-    result = '`users`.`name` DESC'
-
-    sorter = Sorted::Parser.new(nil, order)
-    sorter.to_sql(quoter).should eq result
-  end
-
-  it 'should return an sql sort string' do
-    sort   = 'email_desc!name_desc'
-    order  = 'email ASC, phone ASC, name DESC'
-    result = '`email` DESC, `name` DESC, `phone` ASC'
-
-    sorter = Sorted::Parser.new(sort, order)
-    sorter.to_sql(quoter).should eq result
-  end
-
-  it 'should return an hash' do
-    sort   = 'email_desc!name_desc'
-    order  = 'email ASC, phone ASC, name DESC'
-    result = { 'email' => 'desc', 'name' => 'desc', 'phone' => 'asc' }
-
-    sorter = Sorted::Parser.new(sort, order)
-    sorter.to_hash.should eq result
-  end
-
-  it 'should return an the encoded sort string' do
-    sort   = 'email_desc!name_desc'
-    order  = 'email ASC, phone ASC, name DESC'
-    result = 'email_desc!name_desc!phone_asc'
-
-    sorter = Sorted::Parser.new(sort, order)
-    sorter.to_s.should eq result
-  end
-
-  it 'sql injection using order by clause should not work' do
-    sort   = '(case+when+((ASCII(SUBSTR((select+table_name+from+all_tables+where+rownum%3d1),1))>%3D128))+then+id+else+something+end)'
-    order  = 'email ASC, phone ASC, name DESC'
-    result = '`email` ASC, `phone` ASC, `name` DESC'
-
-    sorter = Sorted::Parser.new(sort, order)
-    sorter.to_sql(quoter).should eq result
-  end
-end

data/spec/sorted/toggler_spec.rb

@@ -1,75 +0,0 @@
-require 'spec_helper'
-
-describe Sorted::Toggler do
-  it 'should bring phone to first order importance but not toggle ascendance' do
-    orders = [['email', 'asc'], ['phone', 'asc']]
-    sorts  = [['phone', 'asc']]
-    result = [['phone', 'asc'], ['email', 'asc']]
-
-    toggler = Sorted::Toggler.new(sorts, orders)
-    toggler.to_a.should eq result
-  end
-
-  it 'should toggle ascendance of email' do
-    orders = [['email', 'desc']]
-    sorts  = [['email', 'asc']]
-    result = [['email', 'desc']]
-
-    toggler = Sorted::Toggler.new(sorts, orders)
-    toggler.to_a.should eq result
-  end
-
-  it 'should return both order params un-toggled with no sort param' do
-    orders = [['email', 'asc'], ['phone', 'asc']]
-    sorts  = []
-    result = [['email', 'asc'], ['phone', 'asc']]
-
-    toggler = Sorted::Toggler.new(sorts, orders)
-    toggler.to_a.should eq result
-  end
-
-  it 'should toggle the email ascendance' do
-    orders = [['email', 'asc']]
-    sorts  = [['email', 'asc'], ['phone', 'asc']]
-    result = [['email', 'desc'], ['phone', 'asc']]
-
-    toggler = Sorted::Toggler.new(sorts, orders)
-    toggler.to_a.should eq result
-  end
-
-  it 'should toggle the email ascendance' do
-    orders = [['email', 'desc']]
-    sorts  = [['email', 'asc'], ['phone', 'asc']]
-    result = [['email', 'desc'], ['phone', 'asc']]
-
-    toggler = Sorted::Toggler.new(sorts, orders)
-    toggler.to_a.should eq result
-  end
-
-  it 'should toggle two 1..n sort values' do
-    orders = [['email', 'asc'], ['phone', 'asc']]
-    sorts  = [['email', 'asc'], ['phone', 'asc']]
-    result = [['email', 'desc'], ['phone', 'desc']]
-
-    toggler = Sorted::Toggler.new(sorts, orders)
-    toggler.to_a.should eq result
-  end
-
-  it 'should toggle based on sorts and not orders' do
-    orders = [['email', 'desc'], ['phone', 'desc']]
-    sorts  = [['email', 'asc'], ['phone', 'asc']]
-    result = [['email', 'desc'], ['phone', 'desc']]
-
-    toggler = Sorted::Toggler.new(sorts, orders)
-    toggler.to_a.should eq result
-  end
-
-  it 'should toggle based on sorts and not orders' do
-    orders = [['email', 'asc']]
-    sorts  = [['name', 'asc']]
-    result = [['email', 'asc'], ['name', 'asc']]
-
-    toggler = Sorted::Toggler.new(sorts, orders)
-    toggler.to_a.should eq result
-  end
-end

data/spec/sorted/view_helpers/action_view_spec.rb

@@ -1,63 +0,0 @@
-require 'spec_helper'
-
-describe Sorted::ViewHelpers::ActionView do
-  it 'should integrate with ActiveRecord::Base' do
-    ActionView::Base.send(:include, Sorted::ViewHelpers::ActionView)
-    ActionView::Base.new.should respond_to(:link_to_sorted)
-  end
-end
-
-describe Sorted::ViewHelpers::ActionView::SortedViewHelper do
-  it 'should return the default sort order and preserve the existing params' do
-    order  = :email
-    params = { page: 10 }
-    result = { page: 10, sort: 'email_asc' }
-
-    sorter = Sorted::ViewHelpers::ActionView::SortedViewHelper.new order, params
-    sorter.params.should eq result
-  end
-
-  it 'should only return the sorted css class if email has not yet been sorted' do
-    order  = :email
-    params = {}
-    result = 'sorted'
-
-    sorter = Sorted::ViewHelpers::ActionView::SortedViewHelper.new order, params
-    sorter.css.should eq result
-  end
-
-  it 'should only return the sorted css class if email has not yet been sorted' do
-    order  = :email
-    params = { sort: 'email_asc' }
-    result = 'sorted asc'
-
-    sorter = Sorted::ViewHelpers::ActionView::SortedViewHelper.new order, params
-    sorter.css.should eq result
-  end
-
-  it 'should return the default order when params are empty' do
-    order  = :email
-    result = { sort: 'email_asc' }
-
-    sorter = Sorted::ViewHelpers::ActionView::SortedViewHelper.new order, {}
-    sorter.params.should eq result
-  end
-
-  it 'should correctly toggle multiple params' do
-    order  = 'email DESC, name DESC'
-    params = { sort: 'email_asc!name_asc' }
-    result = { sort: 'email_desc!name_desc' }
-
-    sorter = Sorted::ViewHelpers::ActionView::SortedViewHelper.new order, params
-    sorter.params.should eq result
-  end
-
-  it 'should have sort order over existing params' do
-    order  = :email
-    params = { sort: 'name_asc' }
-    result = { sort: 'email_asc!name_asc' }
-
-    sorter = Sorted::ViewHelpers::ActionView::SortedViewHelper.new order, params
-    sorter.params.should eq result
-  end
-end