sortah 0.6.0 → 0.7.0

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+##11/14/11
+
+### IMPROVEMENTS
+
+- added "dynamic" destinations. If you do:
+
+    send_to dynamic: "path/to/your/dynamic/dest"
+
+  sortah will append it to the given maildir with all the usual treatment
+  (maildir support, mostly), useful for dynamically handling things like
+  mailinglists (which is the impetus for creating this).
+
+
 ##11/04/11
 
 ### IMPROVEMENTS

data/KNOWN_BUGS.md

@@ -12,3 +12,12 @@ if you do
 --------
 
 if you try to metaprogram routers or w/e, it doesn't actually define them.
+
+--------
+
+I think :abs destinations are handled poorly, and there is some problems of
+logic location wrt destination handling
+
+--------
+
+The sorting logic should get centralized in cleanroom

data/lib/sortah/cleanroom.rb

@@ -32,7 +32,11 @@ module Sortah
     end
 
     def send_to(dest)
-      @pointer = @__context__.routers[dest] || @__context__.destinations[dest]
+      @pointer = if dest.is_a? Hash
+        Destination.dynamic(dest[:dynamic])
+      else
+        @__context__.routers[dest] || @__context__.destinations[dest]
+      end
       throw :finished_execution 
     end
 

data/lib/sortah/components/destination.rb

@@ -15,6 +15,10 @@ module Sortah
   class Destination
     attr_reader :name, :path
 
+    def self.dynamic(path)
+      Destination.new(nil, path)
+    end
+
     def initialize(name, path)
       @name = name
       @path = if path.class == Hash then path[:abs] else path end

data/lib/sortah/components/lens.rb

@@ -21,8 +21,10 @@ module Sortah
 
     def run!(email, context)
       @email = email
-      run_dependencies!(email, context)
       return if already_ran?
+      #XXX: this can be moved to the cleanroom, then the mark_as_run! can be put
+      #after the appropriate 
+      run_dependencies!(email, context)
       result = run_block!
       email.metadata(name, result) if provides_value?
     end

data/lib/sortah/version.rb

@@ -1,3 +1,3 @@
 module Sortah
-  VERSION = "0.6.0"
+  VERSION = "0.7.0"
 end

data/spec/fixtures/rc

@@ -6,6 +6,7 @@ sortah do
 
   router do
     raise RuntimeException if email.from && email.from.any? { |e| e =~ /fail/ }
+    send_to :dynamic => "bar" if email.from && email.from.any? { |e| e =~ /dynamic/ }
     send_to :foo
   end
 end

data/spec/fixtures/semantic_acceptance/rc

@@ -35,6 +35,7 @@ sortah do
   end
 
   router do
+    send_to :dynamic => "bar" if email.from && email.from.any? { |e| e =~ /dynamic/ }
     send_to :personal if email.to.any? { |r| r =~ /jfredett@place.com/ }
     send_to :work if email.to.any? { |r| r =~ /joe@work.com/ } 
     send_to :unknown

data/spec/semantic_spec.rb

@@ -74,20 +74,16 @@ describe Sortah do
     end
 
     describe "#sort" do
-      it "should return an object which responds to #destination" do
-        basic_sortah_definition
-        sortah.sort(@email).should respond_to :destination
-      end
-
-      it "should return an object which responds to #metadata" do
-        basic_sortah_definition
-        sortah.sort(@email).should respond_to :metadata
-      end
-      
-      it "should sort emails based on the sortah definitions" do
-        basic_sortah_definition
-        sortah.sort(@email).destination.should == "foo/"
-        sortah.sort(@reply_email).destination.should == "bar/"
+      context "when using sortah#sort, " do
+        subject { basic_sortah_definition; sortah.sort(@email) }
+        it { should respond_to :destination }
+        it { should respond_to :metadata } 
+
+        subject { basic_sortah_definition; sortah }
+        it "should sort emails based on the sortah definitions" do
+          subject.sort(@email).destination.should == "foo/"
+          subject.sort(@reply_email).destination.should == "bar/"
+        end
       end
 
       it "should defer to a second router if it is sent to one" do
@@ -341,7 +337,16 @@ describe Sortah do
             end
           end
           sortah.sort(@email).full_destination.should == "/tmp/foo/"
-          
+        end
+
+        it "should return the correct path when using a dynamic destination" do
+          sortah do
+            maildir '/tmp/'
+            router do
+              send_to :dynamic => "foo.bar.baz"
+            end
+          end
+          sortah.sort(@email).full_destination.should == "/tmp/foo.bar.baz"
         end
       end
 
@@ -368,9 +373,17 @@ describe Sortah do
         #shuttup, I can dream.
       end
 
+      dynamic_email = Mail.new do
+        to 'joe@work.com'
+        from 'dynamic@work.com'
+        subject 'this is a dynamic email'
+        #shuttup, I can dream.
+      end
+
       sortah.sort(@email).destination.should == 'new/'
       sortah.sort(personal_email).destination.should == 'personal/sarah/new/'
       sortah.sort(work_email).destination.should == 'work/brian/new/'
+      sortah.sort(dynamic_email).destination.should == 'bar'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sortah
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-07 00:00:00.000000000Z
+date: 2011-11-14 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mail
-  requirement: &2161248620 !ruby/object:Gem::Requirement
+  requirement: &2164370860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2161248620
+  version_requirements: *2164370860
 - !ruby/object:Gem::Dependency
   name: trollop
-  requirement: &2161247740 !ruby/object:Gem::Requirement
+  requirement: &2164369620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +32,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2161247740
+  version_requirements: *2164369620
 description: ! "\n    Sortah provides a simple, declarative internal DSL for sorting
   \n    your email. It provides an executable which may serve as an external\n    mail
   delivery agent for such programs as `getmail`. Finally, since\n    your sorting