sort_n_params 1.2.2 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cea1f96ef8bba32a0577ca8e86bf1325aae552427f5403a2c03d00d536a5f2b0
-  data.tar.gz: ea209f082dc417900a8e873d6a4bddc0901e25f6958b811743f168d0ff46a779
+  metadata.gz: 5546d17da19b3cfb15a26cb4cd14fc684545af3f743ea175d28947b0511f9758
+  data.tar.gz: 449f77325f1afb0e71ba03276bb07d095e9d00348882d50c69788e4c4902685d
 SHA512:
-  metadata.gz: 998f053ac4c19a0e14fe46064568a9260d1c3f5ac1f0dbcb2ad8db67b76284379ab709313bf85411515803a5b8d97bdff25d24dbd596bb07069a68fc3decfb2f
-  data.tar.gz: f5c313061ea1c2c365092ba5a91239aa38d7e5ee9616104cbc6bfd9fcbbfe8d0516f74f60cc22d6a749f36b3e450910f7cbd0ab3d399c4e5d7e19942d9972ab0
+  metadata.gz: 350e519cb57c72ba5b7541f8802bba8436a57905b8adb2c293c09d1892c50e23c646a5280f1469a0c5b56e34929bc9c745d5c08a348224c95ff588d526691afc
+  data.tar.gz: 0a314e2fcdc8998dfe14fa42ceead8114474f5dccf101112bc7243d265ba56d3f22dd2f8b6e6f00d0111fa90b8d3281e3eeb8e6dd7d653abec71f9976d596ea3

data/Gemfile

@@ -1,6 +1,8 @@
-source "https://rubygems.org"
+# frozen_string_literal: true
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+source 'https://rubygems.org'
+
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in invoice_client.gemspec
 gemspec

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/lib/sort_n_params/concerns/scopes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/concern'
 
 module SortNParams

data/lib/sort_n_params/sort_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SortNParams
   module SortHelpers
     def sortable(column, title = nil)
@@ -6,17 +8,29 @@ module SortNParams
         concat(
           link_to(data.title, data.sort_params, class: data.css)
         )
-        concat(
-          link_to(data.sort_params, class: SortNParams.badge_main_class) do
-            "<b>#{data.position}</b><i class='#{data.icon}'></i>".html_safe
-          end
-        ) if data.position.present?
-        concat(
-          link_to(data.clear_params, class: SortNParams.badge_secondary_class) do
-            "<i class='#{SortNParams.sort_clear_class}'></i>".html_safe
-          end
-        ) if data.clear_params.present?
+
+        concat_position(data) if data.position.present?
+
+        concat_clear_params(data) if data.clear_params.present?
       end
     end
+
+    private
+
+    def concat_position(data)
+      concat(
+        link_to(data.sort_params, class: SortNParams.badge_main_class) do
+          "<b>#{data.position}</b><i class='#{data.icon}'></i>".html_safe
+        end
+      )
+    end
+
+    def concat_clear_params(data)
+      concat(
+        link_to(data.clear_params, class: SortNParams.badge_secondary_class) do
+          "<i class='#{SortNParams.sort_clear_class}'></i>".html_safe
+        end
+      )
+    end
   end
 end

data/lib/sort_n_params/sortable.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'ostruct'
 require 'sort_n_params'
 
 class Sortable
-  DEFAULT_ORDER = 'asc'.freeze
+  DEFAULT_ORDER = 'asc'
 
   def initialize(column, title, params)
     @column = column
@@ -34,13 +36,18 @@ class Sortable
   end
 
   def build_data
-    OpenStruct.new(css: set_css, icon: set_icon, title: @title, position: @column_position, sort_params: @sort_params, clear_params: @clear_params)
+    OpenStruct.new(css: set_css, icon: set_icon, title: @title, position: @column_position, sort_params: @sort_params,
+                   clear_params: @clear_params)
   end
 
   def revert_order
     column_index = @sort_params[:order].find_index(@column)
-    direction = @column == @sort_params[:order].detect { |e| e == @column } &&
-      @sort_params[:order][column_index + 1] == 'asc' ? 'desc' : 'asc'
+    direction = if @column == @sort_params[:order].detect { |e| e == @column } &&
+                   @sort_params[:order][column_index + 1] == 'asc'
+                  'desc'
+                else
+                  'asc'
+                end
     @sort_params[:order][column_index + 1] = direction
   end
 
@@ -51,7 +58,7 @@ class Sortable
 
   def set_clear_params
     column_index = @clear_params[:order].find_index(@column)
-    2.times{|x| @clear_params[:order].delete_at(column_index) }
+    2.times { |_x| @clear_params[:order].delete_at(column_index) }
   end
 
   def reset_clear_params
@@ -69,8 +76,20 @@ class Sortable
   end
 
   def set_icon
-    if @params[:order] && @params[:order].detect { |e| e == @column } == @column && @params[:order][ @params[:order].find_index(@column) + 1 ]
-      @column == @params[:order].detect { |e| e == @column } && @params[:order][ @params[:order].find_index(@column) + 1 ] == 'asc' ? SortNParams.sort_asc_class : SortNParams.sort_desc_class
+    return unless order_param_exists?
+
+    if @column == order_column && @params[:order][ @params[:order].find_index(@column) + 1 ] == 'asc'
+      SortNParams.sort_asc_class
+    else
+      SortNParams.sort_desc_class
     end
   end
+
+  def order_param_exists?
+    @params[:order] && @column == order_column && @params[:order][ @params[:order].find_index(@column) + 1 ]
+  end
+
+  def order_column
+    @params[:order].detect { |e| e == @column }
+  end
 end

data/lib/sort_n_params.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'sort_n_params/sort_helpers'
 require 'sort_n_params/sortable'
 require 'rails/engine'
@@ -16,7 +18,7 @@ module SortNParams
 
     initializer 'sort_n_params.initialize' do |_app|
       ActiveSupport.on_load :action_view do
-        ActionView::Base.send :include, SortNParams::SortHelpers
+        ActionView::Base.include SortNParams::SortHelpers
       end
     end
   end

data/sort_n_params.gemspec

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 Gem::Specification.new do |s|
   s.name        = 'sort_n_params'
-  s.version     = '1.2.2'
-  s.date        = '2022-06-17'
+  s.version     = '1.2.3'
+  s.date        = '2022-06-22'
   s.summary     = 'Sort N Params'
   s.description = 'Make your html <tables> sortables with N <th> parameters this gem.'
   s.authors     = ['Juan Francisco Ferrari']
@@ -23,15 +25,18 @@ Gem::Specification.new do |s|
   s.homepage =
     'https://github.com/JuannFerrari/sort_n_params'
   s.license = 'MIT'
-  s.required_ruby_version = Gem::Requirement.new(">= 2.6.0")
+  s.required_ruby_version = Gem::Requirement.new('>= 2.6.0')
 
   s.add_development_dependency 'bundler'
   s.add_development_dependency 'factory_bot', '~> 4.0'
+  s.add_development_dependency 'pry', '~> 0.13.1'
   s.add_development_dependency 'pry-byebug'
   s.add_development_dependency 'rake', '>= 12.3.3'
   s.add_development_dependency 'rspec', '~> 3.0'
+  s.add_development_dependency 'rubocop', '~> 1.30'
+  s.add_development_dependency 'rubocop-rails'
 
-  s.add_dependency('rails'.freeze, ['>= 7.0'])
-  s.add_dependency('nokogiri'.freeze, ['>= 0'])
-  s.add_dependency('rake'.freeze, ['>= 12.3.3'])
+  s.add_dependency('nokogiri', ['>= 0'])
+  s.add_dependency('rails', ['>= 7.0'])
+  s.add_dependency('rake', ['>= 12.3.3'])
 end

data/spec/concerns/scopes_spec.rb

@@ -1,25 +1,31 @@
+# frozen_string_literal: true
+
 require 'sort_n_params/concerns/scopes'
 
+CustomTable = Struct.new(:custom_field) do
+  include SortNParams::Scopes
+end
+
 RSpec.describe SortNParams::Scopes do
   let(:test_class) do
-    CustomTable = Struct.new(:custom_field) do
-      include SortNParams::Scopes
-    end
+    CustomTable
   end
 
-  context 'when you pass only an ordering array' do
-    subject { test_class.parse_array(["test_field","asc"]) }
+  describe '#parse_array' do
+    context 'when you pass only an ordering array' do
+      subject { test_class.parse_array(%w[test_field asc]) }
 
-    it "builds the array correctly without the table_name param passed" do
-      expect(subject).to eq("custom_tables.test_field asc")
+      it 'builds the array correctly without the table_name param passed' do
+        expect(subject).to eq('custom_tables.test_field asc')
+      end
     end
-  end
 
-  context 'when you pass both ordering array and table name' do
-    subject { test_class.parse_array(["test_field","asc"], "another_table_name" ) }
+    context 'when you pass both ordering array and table name' do
+      subject { test_class.parse_array(%w[test_field asc], 'another_table_name') }
 
-    it "builds the array correctly with the table_name param passed" do
-      expect(subject).to eq("another_table_name.test_field asc")
+      it 'builds the array correctly with the table_name param passed' do
+        expect(subject).to eq('another_table_name.test_field asc')
+      end
     end
   end
-end
+end

data/spec/sortable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'sort_n_params'
 
 RSpec.describe Sortable do

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'factory_bot'
 require 'sort_n_params/sortable'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sort_n_params
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.2.3
 platform: ruby
 authors:
 - Juan Francisco Ferrari
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-17 00:00:00.000000000 Z
+date: 2022-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.13.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.13.1
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -81,19 +95,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.30'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.30'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.0'
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -108,6 +136,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '7.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement