sorcery 0.1.3 → 0.2.0

data/spec/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../../../
   specs:
-    sorcery (0.1.3)
+    sorcery (0.1.4)
 
 GEM
   remote: http://rubygems.org/
@@ -33,6 +33,7 @@ GEM
       activemodel (= 3.0.3)
       activesupport (= 3.0.3)
     activesupport (3.0.3)
+    addressable (2.2.4)
     archive-tar-minitar (0.5.2)
     arel (2.0.6)
     bcrypt-ruby (2.1.3)
@@ -41,6 +42,10 @@ GEM
     diff-lcs (1.1.2)
     erubis (2.6.6)
       abstract (>= 1.0.0)
+    faraday (0.5.5)
+      addressable (~> 2.2.4)
+      multipart-post (~> 1.1.0)
+      rack (< 2, >= 1.1.0)
     i18n (0.5.0)
     linecache19 (0.5.11)
       ruby_core_source (>= 0.1.4)
@@ -50,6 +55,12 @@ GEM
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
     mime-types (1.16)
+    multi_json (0.0.5)
+    multipart-post (1.1.0)
+    oauth (0.4.4)
+    oauth2 (0.1.1)
+      faraday (~> 0.5.0)
+      multi_json (~> 0.0.4)
     polyglot (0.3.1)
     rack (1.2.1)
     rack-mount (0.6.13)
@@ -101,8 +112,10 @@ PLATFORMS
 
 DEPENDENCIES
   bcrypt-ruby
+  oauth (>= 0.4.4)
+  oauth2 (>= 0.1.1)
   rails (= 3.0.3)
   rspec
   ruby-debug19
   simplecov (>= 0.3.8)
-  sorcery (= 0.1.3)!
+  sorcery (= 0.1.4)!

data/spec/rails3/app_root/.rspec

@@ -0,0 +1 @@
+--colour

data/spec/rails3/{Gemfile → app_root/Gemfile}

@@ -2,12 +2,14 @@ source 'http://rubygems.org'
 
 gem 'rails', '3.0.3'
 gem 'sqlite3-ruby', :require => 'sqlite3'
-gem "sorcery", '0.1.3', :path => '../../../'
+gem "sorcery", '0.1.4', :path => '../../../'
 gem 'bcrypt-ruby', '~> 2.1.4', :require => 'bcrypt'
-  
-group :development do
+gem 'oauth', ">= 0.4.4"
+gem 'oauth2', ">= 0.1.1"
+group :development, :test do
   gem 'rspec'
   gem 'rspec-rails'
   gem 'ruby-debug19'
   gem 'simplecov', '>= 0.3.8', :require => false # Will install simplecov-html as a dependency
+  gem 'spork', '~> 0.9.0.rc'
 end

data/spec/rails3/{Gemfile.lock → app_root/Gemfile.lock}

@@ -1,7 +1,14 @@
 PATH
   remote: ../../../
   specs:
-    sorcery (0.1.3)
+    sorcery (0.1.4)
+      bcrypt-ruby (~> 2.1.4)
+      json (>= 1.5.1)
+      oauth (>= 0.4.4)
+      oauth (>= 0.4.4)
+      oauth2 (>= 0.1.1)
+      oauth2 (>= 0.1.1)
+      rails (>= 3.0.0)
 
 GEM
   remote: http://rubygems.org/
@@ -33,6 +40,7 @@ GEM
       activemodel (= 3.0.3)
       activesupport (= 3.0.3)
     activesupport (3.0.3)
+    addressable (2.2.4)
     archive-tar-minitar (0.5.2)
     arel (2.0.6)
     bcrypt-ruby (2.1.4)
@@ -41,7 +49,12 @@ GEM
     diff-lcs (1.1.2)
     erubis (2.6.6)
       abstract (>= 1.0.0)
+    faraday (0.5.5)
+      addressable (~> 2.2.4)
+      multipart-post (~> 1.1.0)
+      rack (< 2, >= 1.1.0)
     i18n (0.5.0)
+    json (1.5.1)
     linecache19 (0.5.11)
       ruby_core_source (>= 0.1.4)
     mail (2.2.13)
@@ -50,6 +63,12 @@ GEM
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
     mime-types (1.16)
+    multi_json (0.0.5)
+    multipart-post (1.1.0)
+    oauth (0.4.4)
+    oauth2 (0.1.1)
+      faraday (~> 0.5.0)
+      multi_json (~> 0.0.4)
     polyglot (0.3.1)
     rack (1.2.1)
     rack-mount (0.6.13)
@@ -96,6 +115,7 @@ GEM
     simplecov (0.3.9)
       simplecov-html (>= 0.3.7)
     simplecov-html (0.3.9)
+    spork (0.9.0.rc3)
     sqlite3-ruby (1.3.2)
     thor (0.14.6)
     treetop (1.4.9)
@@ -107,10 +127,13 @@ PLATFORMS
 
 DEPENDENCIES
   bcrypt-ruby (~> 2.1.4)
+  oauth (>= 0.4.4)
+  oauth2 (>= 0.1.1)
   rails (= 3.0.3)
   rspec
   rspec-rails
   ruby-debug19
   simplecov (>= 0.3.8)
-  sorcery (= 0.1.3)!
+  sorcery (= 0.1.4)!
+  spork (~> 0.9.0.rc)
   sqlite3-ruby

data/spec/rails3/app_root/app/controllers/application_controller.rb

@@ -1,9 +1,11 @@
+require 'oauth'
+
 class ApplicationController < ActionController::Base
   protect_from_forgery
   
   #before_filter :validate_session, :only => [:test_should_be_logged_in] if defined?(:validate_session)
-  before_filter :require_user_login_from_http, :only => [:test_http_basic_auth]
-  before_filter :require_user_login, :only => [:test_logout, :test_should_be_logged_in, :some_action]
+  before_filter :require_login_from_http_basic, :only => [:test_http_basic_auth]
+  before_filter :require_login, :only => [:test_logout, :test_should_be_logged_in, :some_action]
   
   def index
     render :text => ""
@@ -18,6 +20,11 @@ class ApplicationController < ActionController::Base
     render :text => ""
   end
   
+  def test_return_to
+    @user = login(params[:username], params[:password])
+    return_or_redirect_to(:index, :notice => 'haha!')
+  end
+  
   def test_logout
     logout
     render :text => ""
@@ -43,7 +50,7 @@ class ApplicationController < ActionController::Base
   end
   
   def test_login_from_cookie
-    @user = logged_in_user
+    @user = current_user
     render :text => ""
   end
   
@@ -59,6 +66,40 @@ class ApplicationController < ActionController::Base
     render :text => "HTTP Basic Auth"
   end
   
+  def auth_at_provider_test
+    auth_at_provider(:twitter)
+  end
+  
+  def auth_at_provider_test2
+    auth_at_provider(:facebook)
+  end
+  
+  def test_login_from_access_token
+    if @user = login_from_access_token(:twitter)
+      redirect_to "bla", :notice => "Success!"
+    else
+      redirect_to "blu", :alert => "Failed!"
+    end
+  end
+  
+  def test_login_from_access_token2
+    if @user = login_from_access_token(:facebook)
+      redirect_to "bla", :notice => "Success!"
+    else
+      redirect_to "blu", :alert => "Failed!"
+    end
+  end
+  
+  def test_create_from_provider
+    provider = params[:provider]
+    login_from_access_token(provider)
+    if @user = create_from_provider!(provider)
+      redirect_to "bla", :notice => "Success!"
+    else
+      redirect_to "blu", :alert => "Failed!"
+    end
+  end
+  
   protected
   
   

data/spec/rails3/app_root/app/models/authentication.rb

@@ -0,0 +1,3 @@
+class Authentication < ActiveRecord::Base
+  belongs_to :user
+end

data/spec/rails3/app_root/app/models/user.rb

@@ -1,3 +1,6 @@
 class User < ActiveRecord::Base
-  #activate_sorcery!
+  attr_accessible :email, :password, :password_confirmation, :authentications_attributes
+  
+  has_many :authentications, :dependent => :destroy
+  accepts_nested_attributes_for :authentications
 end

data/spec/rails3/app_root/config/application.rb

@@ -38,9 +38,7 @@ module AppRoot
 
     # Configure sensitive parameters which will be filtered from the log file.
     config.filter_parameters += [:password]
-    
-    config.root = File.expand_path('../..', __FILE__)
-    
+        
     config.action_mailer.delivery_method = :test
     
     config.active_support.deprecation = :stderr

data/spec/rails3/app_root/config/routes.rb

@@ -1,14 +1,5 @@
 AppRoot::Application.routes.draw do
   root :to => "application#index" 
-  match '/test_login', :to => "application#test_login"
-  match '/test_logout', :to => "application#test_logout"
-  match '/some_action', :to => "application#some_action"
-  match '/test_logout_with_remember', :to => "application#test_logout_with_remember"
-  match '/test_login_with_remember', :to => 'application#test_login_with_remember'
-  match '/test_login_with_remember_in_login', :to => 'application#test_login_with_remember_in_login'
-  match '/test_login_from_cookie', :to => 'application#test_login_from_cookie'
-  match '/test_should_be_logged_in', :to => 'application#test_should_be_logged_in'
-  match '/test_http_basic_auth', :to => 'application#test_http_basic_auth'
   # The priority is based upon order of creation:
   # first created -> highest priority.
 
@@ -64,5 +55,5 @@ AppRoot::Application.routes.draw do
 
   # This is a legacy wild controller route that's not recommended for RESTful applications.
   # Note: This route will make all actions in every controller accessible via GET requests.
-  # match ':controller(/:action(/:id(.:format)))'
+  match ':controller(/:action(/:id(.:format)))'
 end

data/spec/rails3/app_root/db/migrate/activation/20101224223622_add_activation_to_users.rb

@@ -1,15 +1,17 @@
 class AddActivationToUsers < ActiveRecord::Migration
   def self.up
     add_column :users, :activation_state, :string, :default => nil
-    add_column :users, :activation_code, :string, :default => nil
+    add_column :users, :activation_token, :string, :default => nil
+    add_column :users, :activation_token_expires_at, :datetime, :default => nil
     
-    add_index :users, :activation_code
+    add_index :users, :activation_token
   end
 
   def self.down
-    remove_index :users, :activation_code
+    remove_index :users, :activation_token
     
-    remove_column :users, :activation_code
+    remove_column :users, :activation_token_expires_at
+    remove_column :users, :activation_token
     remove_column :users, :activation_state
   end
 end

data/spec/rails3/app_root/db/migrate/activity_logging/20101224223624_add_activity_logging_to_users.rb

@@ -0,0 +1,17 @@
+class AddActivityLoggingToUsers < ActiveRecord::Migration
+  def self.up
+    add_column :users, :last_login_at,     :datetime, :default => nil
+    add_column :users, :last_logout_at,    :datetime, :default => nil
+    add_column :users, :last_activity_at,  :datetime, :default => nil
+    
+    add_index :users, [:last_logout_at, :last_activity_at]
+  end
+
+  def self.down
+    remove_index :users, [:last_logout_at, :last_activity_at]
+    
+    remove_column :users, :last_activity_at
+    remove_column :users, :last_logout_at
+    remove_column :users, :last_login_at
+  end
+end

data/spec/rails3/app_root/db/migrate/brute_force_protection/20101224223626_add_brute_force_protection_to_users.rb

@@ -0,0 +1,11 @@
+class AddBruteForceProtectionToUsers < ActiveRecord::Migration
+  def self.up
+    add_column :users, :failed_logins_count, :integer, :default => 0
+    add_column :users, :lock_expires_at, :datetime, :default => nil
+  end
+
+  def self.down
+    remove_column :users, :lock_expires_at
+    remove_column :users, :failed_logins_count
+  end
+end

data/spec/rails3/app_root/db/migrate/core/20101224223620_create_users.rb

@@ -1,10 +1,10 @@
 class CreateUsers < ActiveRecord::Migration
   def self.up
     create_table :users do |t|
-      t.string :username
-      t.string :email, :null => false
-      t.string :crypted_password
-      t.string :salt
+      t.string :username,         :null => false
+      t.string :email,            :default => nil
+      t.string :crypted_password, :default => nil
+      t.string :salt,             :default => nil
 
       t.timestamps
     end

data/spec/rails3/app_root/db/migrate/oauth/20101224223628_create_authentications.rb

@@ -0,0 +1,14 @@
+class CreateAuthentications < ActiveRecord::Migration
+  def self.up
+    create_table :authentications do |t|
+      t.integer :user_id, :null => false
+      t.string :provider, :uid, :null => false
+
+      t.timestamps
+    end
+  end
+
+  def self.down
+    drop_table :authentications
+  end
+end

data/spec/rails3/app_root/db/migrate/reset_password/20101224223622_add_reset_password_to_users.rb

@@ -0,0 +1,13 @@
+class AddResetPasswordToUsers < ActiveRecord::Migration
+  def self.up
+    add_column :users, :reset_password_token, :string, :default => nil
+    add_column :users, :reset_password_token_expires_at, :datetime, :default => nil
+    add_column :users, :reset_password_email_sent_at, :datetime, :default => nil
+  end
+
+  def self.down
+    remove_column :users, :reset_password_email_sent_at
+    remove_column :users, :reset_password_token_expires_at
+    remove_column :users, :reset_password_token
+  end
+end

data/spec/rails3/app_root/spec/controller_activity_logging_spec.rb

@@ -0,0 +1,84 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+
+describe ApplicationController do
+  before(:all) do
+    ActiveRecord::Migrator.migrate("#{Rails.root}/db/migrate/activity_logging")
+  end
+  
+  after(:all) do
+    ActiveRecord::Migrator.rollback("#{Rails.root}/db/migrate/activity_logging")
+  end
+  
+  # ----------------- ACTIVITY LOGGING -----------------------
+  describe ApplicationController, "with activity logging features" do
+    before(:all) do
+      sorcery_reload!([:activity_logging])
+    end
+
+    before(:each) do
+      create_new_user
+    end
+
+    after(:each) do
+      User.delete_all
+    end
+
+    it "should respond to 'current_users'" do
+      subject.should respond_to(:current_users)
+    end
+
+    it "'current_users' should be empty when no users are logged in" do
+      subject.current_users.size.should == 0
+    end
+
+    it "should log login time on login" do
+      now = Time.now.utc
+      login_user
+      @user.last_login_at.should_not be_nil
+      @user.last_login_at.to_s(:db).should >= now.to_s(:db)
+      @user.last_login_at.to_s(:db).should <= (now+2).to_s(:db)
+    end
+
+    it "should log logout time on logout" do
+      login_user
+      now = Time.now.utc
+      logout_user
+      User.first.last_logout_at.should_not be_nil
+      User.first.last_logout_at.to_s(:db).should >= now.to_s(:db)
+      User.first.last_logout_at.to_s(:db).should <= (now+2).to_s(:db)
+    end
+
+    it "should log last activity time when logged in" do
+      login_user
+      now = Time.now.utc
+      get :some_action
+      User.first.last_activity_at.to_s(:db).should >= now.to_s(:db)
+      User.first.last_activity_at.to_s(:db).should <= (now+2).to_s(:db)
+    end
+
+    it "'current_users' should hold the user object when 1 user is logged in" do
+      login_user
+      get :some_action
+      subject.current_users.size.should == 1
+      subject.current_users[0].should == @user
+    end
+
+    it "'current_users' should show all current_users, whether they have logged out before or not." do
+      user1 = create_new_user({:username => 'gizmo1', :email => "bla1@bla.com", :password => 'secret1'})
+      login_user(user1)
+      get :some_action
+      clear_user_without_logout
+      user2 = create_new_user({:username => 'gizmo2', :email => "bla2@bla.com", :password => 'secret2'})
+      login_user(user2)
+      get :some_action
+      clear_user_without_logout
+      user3 = create_new_user({:username => 'gizmo3', :email => "bla3@bla.com", :password => 'secret3'})
+      login_user(user3)
+      get :some_action
+      subject.current_users.size.should == 3
+      subject.current_users[0].should == user1
+      subject.current_users[1].should == user2
+      subject.current_users[2].should == user3
+    end
+  end
+end

data/spec/rails3/app_root/spec/controller_brute_force_protection_spec.rb

@@ -0,0 +1,65 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+
+describe ApplicationController do
+  before(:all) do
+    ActiveRecord::Migrator.migrate("#{Rails.root}/db/migrate/brute_force_protection")
+  end
+  
+  after(:all) do
+    ActiveRecord::Migrator.rollback("#{Rails.root}/db/migrate/brute_force_protection")
+  end
+  
+  # ----------------- SESSION TIMEOUT -----------------------
+  describe ApplicationController, "with brute force protection features" do
+    before(:all) do
+      sorcery_reload!([:brute_force_protection])
+      create_new_user
+    end
+    
+    after(:each) do
+      Sorcery::Controller::Config.reset!
+      sorcery_controller_property_set(:user_class, User)
+    end
+    
+    it "should count login retries" do
+      3.times {get :test_login, :username => 'gizmo', :password => 'blabla'}
+      User.find_by_username('gizmo').failed_logins_count.should == 3
+    end
+    
+    it "should reset the counter on a good login" do
+      sorcery_model_property_set(:consecutive_login_retries_amount_limit, 5)
+      3.times {get :test_login, :username => 'gizmo', :password => 'blabla'}
+      get :test_login, :username => 'gizmo', :password => 'secret'
+      User.find_by_username('gizmo').failed_logins_count.should == 0
+    end
+    
+    it "should lock user when number of retries reached the limit" do
+      User.find_by_username('gizmo').lock_expires_at.should be_nil
+      sorcery_model_property_set(:consecutive_login_retries_amount_limit, 1)
+      get :test_login, :username => 'gizmo', :password => 'blabla'
+      User.find_by_username('gizmo').lock_expires_at.should_not be_nil
+    end
+
+    it "should unlock after lock time period passes" do
+      sorcery_model_property_set(:consecutive_login_retries_amount_limit, 2)
+      sorcery_model_property_set(:login_lock_time_period, 0.2)
+      get :test_login, :username => 'gizmo', :password => 'blabla'
+      get :test_login, :username => 'gizmo', :password => 'blabla'
+      User.find_by_username('gizmo').lock_expires_at.should_not be_nil
+      sleep 0.3
+      get :test_login, :username => 'gizmo', :password => 'blabla'
+      User.find_by_username('gizmo').lock_expires_at.should be_nil
+    end
+
+    it "should not unlock if time period is 0 (permanent lock)" do
+      sorcery_model_property_set(:consecutive_login_retries_amount_limit, 2)
+      sorcery_model_property_set(:login_lock_time_period, 0)
+      get :test_login, :username => 'gizmo', :password => 'blabla'
+      get :test_login, :username => 'gizmo', :password => 'blabla'
+      unlock_date = User.find_by_username('gizmo').lock_expires_at
+      sleep 1
+      get :test_login, :username => 'gizmo', :password => 'blabla'
+      User.find_by_username('gizmo').lock_expires_at.to_s.should == unlock_date.to_s
+    end
+  end
+end

data/spec/rails3/{controller_http_basic_auth_spec.rb → app_root/spec/controller_http_basic_auth_spec.rb}

@@ -5,10 +5,14 @@ describe ApplicationController do
   # ----------------- HTTP BASIC AUTH -----------------------
   describe ApplicationController, "with http basic auth features" do
     before(:all) do
-      plugin_model_configure([:http_basic_auth])
+      sorcery_reload!([:http_basic_auth])
       create_new_user
     end
     
+    after(:each) do
+      logout_user
+    end
+    
     it "requests basic authentication when before_filter is used" do
       get :test_http_basic_auth
       response.code.should == "401"
@@ -27,14 +31,20 @@ describe ApplicationController do
     end
     
     it "should allow configuration option 'controller_to_realm_map'" do
-      plugin_set_controller_config_property(:controller_to_realm_map, {"1" => "2"})
+      sorcery_controller_property_set(:controller_to_realm_map, {"1" => "2"})
       Sorcery::Controller::Config.controller_to_realm_map.should == {"1" => "2"}
     end
     
     it "should display the correct realm name configured for the controller" do
-      plugin_set_controller_config_property(:controller_to_realm_map, {"application" => "Salad"})
+      sorcery_controller_property_set(:controller_to_realm_map, {"application" => "Salad"})
       get :test_http_basic_auth
       response.headers["WWW-Authenticate"].should == "Basic realm=\"Salad\""
     end
+    
+    it "should sign in the user's session on successful login" do
+      @request.env["HTTP_AUTHORIZATION"] = "Basic " + Base64::encode64("#{@user.username}:secret")
+      get :test_http_basic_auth, nil, :http_authentication_used => true
+      session[:user_id].should == User.find_by_username(@user.username).id
+    end
   end
 end

data/spec/rails3/app_root/spec/controller_oauth2_spec.rb

@@ -0,0 +1,117 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+
+def stub_all_oauth2_requests!
+  @client = OAuth2::Client.new("key","secret", :site => "http://myapi.com")
+  OAuth2::Client.stub!(:new).and_return(@client)
+  @acc_token = OAuth2::AccessToken.new(@client, "", "asd", nil, {})
+  @webby = @client.web_server
+  OAuth2::Strategy::WebServer.stub!(:new).and_return(@webby)
+  @webby.stub!(:get_access_token).and_return(@acc_token)
+  @acc_token.stub!(:get).and_return({"id"=>"123", "name"=>"Noam Ben Ari", "first_name"=>"Noam", "last_name"=>"Ben Ari", "link"=>"http://www.facebook.com/nbenari1", "hometown"=>{"id"=>"110619208966868", "name"=>"Haifa, Israel"}, "location"=>{"id"=>"106906559341067", "name"=>"Pardes Hanah, Hefa, Israel"}, "bio"=>"I'm a new daddy, and enjoying it!", "gender"=>"male", "email"=>"nbenari@gmail.com", "timezone"=>2, "locale"=>"en_US", "languages"=>[{"id"=>"108405449189952", "name"=>"Hebrew"}, {"id"=>"106059522759137", "name"=>"English"}, {"id"=>"112624162082677", "name"=>"Russian"}], "verified"=>true, "updated_time"=>"2011-02-16T20:59:38+0000"}.to_json)
+end
+
+describe ApplicationController do
+  before(:all) do
+    ActiveRecord::Migrator.migrate("#{Rails.root}/db/migrate/oauth")
+    sorcery_reload!([:oauth])
+    sorcery_controller_property_set(:oauth_providers, [:facebook])
+    sorcery_controller_oauth_property_set(:facebook, :key, "eYVNBjBDi33aa9GkA3w")
+    sorcery_controller_oauth_property_set(:facebook, :secret, "XpbeSdCoaKSmQGSeokz5qcUATClRW5u08QWNfv71N8")
+    sorcery_controller_oauth_property_set(:facebook, :callback_url, "http://blabla.com")
+  end
+  
+  after(:all) do
+    ActiveRecord::Migrator.rollback("#{Rails.root}/db/migrate/oauth")
+  end
+  # ----------------- OAuth -----------------------
+  describe ApplicationController, "with OAuth features" do
+  
+    before(:each) do
+      stub_all_oauth2_requests!
+    end
+      
+    after(:each) do
+      User.delete_all
+    end
+    
+    it "auth_at_provider redirects correctly" do
+      create_new_user
+      get :auth_at_provider_test2
+      response.should be_a_redirect
+      response.should redirect_to("http://myapi.com/oauth/authorize?client_id=key&redirect_uri=http%3A%2F%2Fblabla.com&scope=email%2Coffline_access&type=web_server")
+    end
+    
+    it "'login_from_access_token' logins if user exists" do
+      sorcery_model_property_set(:authentications_class, Authentication)
+      create_new_external_user(:facebook)
+      get :test_login_from_access_token2
+      flash[:notice].should == "Success!"
+    end
+    
+    it "'login_from_access_token' fails if user doesn't exist" do
+      sorcery_model_property_set(:authentications_class, Authentication)
+      create_new_user
+      get :test_login_from_access_token2
+      flash[:alert].should == "Failed!"
+    end
+  end
+  
+  describe ApplicationController, "'create_from_provider!'" do
+    before(:each) do
+      stub_all_oauth2_requests!
+      User.delete_all
+    end
+      
+    it "should create a new user" do
+      sorcery_controller_property_set(:authentications_class, Authentication)
+      sorcery_controller_oauth_property_set(:facebook, :user_info_mapping, {:username => "name"})
+      lambda do
+        get :test_create_from_provider, :provider => "facebook"
+      end.should change(User, :count).by(1)
+      User.first.username.should == "Noam Ben Ari"
+    end
+    
+    it "should support nested attributes" do
+      sorcery_controller_property_set(:authentications_class, Authentication)
+      sorcery_controller_oauth_property_set(:facebook, :user_info_mapping, {:username => "hometown/name"})
+      lambda do
+        get :test_create_from_provider, :provider => "facebook"
+      end.should change(User, :count).by(1)
+      User.first.username.should == "Haifa, Israel"
+    end
+  end
+  
+  describe ApplicationController, "OAuth with User Activation features" do
+    before(:all) do
+      ActiveRecord::Migrator.migrate("#{Rails.root}/db/migrate/activation")
+      sorcery_reload!([:user_activation,:oauth], :user_activation_mailer => ::SorceryMailer)
+      sorcery_controller_property_set(:oauth_providers, [:facebook])
+      sorcery_controller_oauth_property_set(:facebook, :key, "eYVNBjBDi33aa9GkA3w")
+      sorcery_controller_oauth_property_set(:facebook, :secret, "XpbeSdCoaKSmQGSeokz5qcUATClRW5u08QWNfv71N8")
+      sorcery_controller_oauth_property_set(:facebook, :callback_url, "http://blabla.com")
+    end
+    
+    after(:all) do
+      ActiveRecord::Migrator.rollback("#{Rails.root}/db/migrate/activation")
+    end
+    
+    after(:each) do
+      User.delete_all
+    end
+    
+    it "should not send activation email to external users" do
+      old_size = ActionMailer::Base.deliveries.size
+      create_new_external_user(:facebook)
+      ActionMailer::Base.deliveries.size.should == old_size
+    end
+    
+    it "should not send external users an activation success email" do
+      sorcery_model_property_set(:activation_success_email_method_name, nil)
+      create_new_external_user(:facebook)
+      old_size = ActionMailer::Base.deliveries.size
+      @user.activate!
+      ActionMailer::Base.deliveries.size.should == old_size
+    end
+  end
+  
+end