sorbet-runtime 0.6.13615 → 0.6.13616

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 83afd87671f904e0e627730dbefaa1f70173159106c48dc129e684627236bb6d
-  data.tar.gz: 3b0f25dc28f65cd39e560ebdc0b625eda8651030693f9a185fd86557b2363628
+  metadata.gz: 53d7992bc3b757a09cec54c0adaf659670b8e2f13d1429a42c9af6289575a75b
+  data.tar.gz: 59f61eb250810f11570be0509ca0c06a1642d1898b0f260891735ce435e97d2f
 SHA512:
-  metadata.gz: 8bc6a890b37dda640b8c830f3385319a1bb4ef01239e0bec56138240117e0e5f4f14aa64806027f4918c2ee60d31521c876ce072d7f853d1ff77892f2336ecc3
-  data.tar.gz: 1befcd02c403f3d20652f7637d365085e296e00ff178a496a72e700b943aa5ff8a744d80597fc02d6a6528a25114f86cf2ab289edd80987ef3d9a4ce7abe901a
+  metadata.gz: 9236e351b585061fd58490a603d75d19ca1f43a6e742a3abd57a648214a5b050d4d4408409004c150bbbfb87e8af9afbba11633067aa253c739acc39d718f727
+  data.tar.gz: f69a44eda94a3646b1d0422bf15d9bc2cf92da478c3f0a1615ac986a16a10371470621813d65c6d3222ce7382e7b55c7b6aead62916ee99f1c11dc422536ddad

data/lib/types/private/methods/signature.rb

@@ -1,9 +1,12 @@
 # frozen_string_literal: true
 # typed: true
 
+# Every sig keeps one of these for the life of the process. At 18 or fewer instance variables an
+# instance fits in a 160-byte GC slot; a 19th moves every instance to the 320-byte slot, so prefer
+# deriving new state over storing it.
 class T::Private::Methods::Signature
-  attr_reader :method, :method_name, :arg_types, :kwarg_types, :block_type, :block_name,
-              :rest_type, :rest_name, :keyrest_type, :keyrest_name, :bind, :effective_return_type,
+  attr_reader :method, :method_name, :arg_types, :kwarg_types, :block_type,
+              :rest_type, :keyrest_type, :bind, :effective_return_type,
               :return_type, :mode, :req_arg_count, :req_kwarg_names,
               :check_level, :parameters, :on_failure, :override_allow_incompatible,
               :defined_raw
@@ -47,11 +50,8 @@ class T::Private::Methods::Signature
     @method = method
     @method_name = method_name
     @block_type = nil
-    @block_name = nil
     @rest_type = nil
-    @rest_name = nil
     @keyrest_type = nil
-    @keyrest_name = nil
     @return_type = T::Utils.coerce(raw_return_type)
     @effective_return_type = if check_level == :tests && @return_type.is_a?(T::Private::Types::Void)
       T::Types::Anything::Private::INSTANCE
@@ -147,13 +147,10 @@ class T::Private::Methods::Signature
           (req_kwarg_names ||= []) << param_name
         end
       when :block
-        @block_name = param_name
         @block_type = type
       when :rest
-        @rest_name = param_name
         @rest_type = type
       when :keyrest
-        @keyrest_name = param_name
         @keyrest_type = type
       else
         raise "Unexpected param_kind: `#{param_kind}`. Method: #{method_desc}"
@@ -177,6 +174,19 @@ class T::Private::Methods::Signature
     new_sig
   end
 
+  # Names are derived rather than stored so that Signature fits in a smaller GC slot.
+  def block_name
+    parameter_name(:block)
+  end
+
+  def rest_name
+    parameter_name(:rest)
+  end
+
+  def keyrest_name
+    parameter_name(:keyrest)
+  end
+
   def arg_count
     @arg_types.length
   end
@@ -227,11 +237,14 @@ class T::Private::Methods::Signature
 
       if !@rest_type.nil?
         rest_count = args_length - @arg_types.length
-        rest_count = 0 if rest_count.negative?
 
-        rest_count.times do
-          yield @rest_name, args[it], @rest_type
-          it += 1
+        if rest_count > 0
+          rest_name = fast_rest_name
+
+          rest_count.times do
+            yield rest_name, args[it], @rest_type
+            it += 1
+          end
         end
       end
     end
@@ -268,6 +281,16 @@ class T::Private::Methods::Signature
     @return_type.build_type
   end
 
+  # The rest param directly follows the positional params unless required params come after it.
+  private def fast_rest_name
+    param_kind, param_name = @parameters[@arg_types.length]
+    param_kind == :rest ? param_name : parameter_name(:rest)
+  end
+
+  private def parameter_name(kind)
+    @parameters.assoc(kind)&.[](1)
+  end
+
   EMPTY_LIST = [].freeze
   EMPTY_HASH = {}.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.6.13615
+  version: 0.6.13616
 platform: ruby
 authors:
 - Stripe