sorbet-runtime 0.6.13612 → 0.6.13616

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a55754bbdc43cfcf4bf7fee9c48115331cc0f1382cdb8419b7892751d2ca1b6
-  data.tar.gz: 7be4e804bb6055583e367662baacff6217a5f0806b0d069e4dfef05d0837431f
+  metadata.gz: 53d7992bc3b757a09cec54c0adaf659670b8e2f13d1429a42c9af6289575a75b
+  data.tar.gz: 59f61eb250810f11570be0509ca0c06a1642d1898b0f260891735ce435e97d2f
 SHA512:
-  metadata.gz: 559bedbd9597db5b2502796002d6911ee4fc2dba33d8a2f0d4c890bf2156db1079f191e7b6768dd4963fb378691d69a0b1c2200f6eb9ca3a3c97cfc473fcc471
-  data.tar.gz: e30c5fc33877556d12997f7b2484a4abdeb4fcb4224792c6ba8e3c8310850a41e913c6f761cbc538ad568a792f8c51eae28a4e50f7457ce6464487ba7d23b140
+  metadata.gz: 9236e351b585061fd58490a603d75d19ca1f43a6e742a3abd57a648214a5b050d4d4408409004c150bbbfb87e8af9afbba11633067aa253c739acc39d718f727
+  data.tar.gz: f69a44eda94a3646b1d0422bf15d9bc2cf92da478c3f0a1615ac986a16a10371470621813d65c6d3222ce7382e7b55c7b6aead62916ee99f1c11dc422536ddad

data/lib/types/private/methods/_methods.rb

@@ -616,6 +616,17 @@ module T::Private::Methods
     @signatures_by_method[method_to_key(maybe_wrapped_method)] = signature
   end
 
+  # This method tells whether `drop_unchecked_sigs!` can free `signature`.
+  # It returns true for a signature whose runtime checks never run.
+  # It returns false for an `abstract` signature, because `T::AbstractUtils`
+  # reads that signature after load time.
+  private_class_method def self.drop_sig?(signature)
+    return false if signature.mode == Modes.abstract
+
+    signature.check_level == :never ||
+      (signature.check_level == :tests && !T::Private::RuntimeLevels.check_tests?)
+  end
+
   # Only public because it needs to get called inside the first-call wrapper closure.
   def self._sig_block_is_current?(key, sig_block)
     @sig_wrappers[key].equal?(sig_block)
@@ -699,6 +710,10 @@ module T::Private::Methods
     @signatures_by_method.values.select { |sig| sig.check_level == :tests }
   end
 
+  def self.drop_unchecked_sigs!
+    @signatures_by_method.delete_if { |_key, sig| drop_sig?(sig) }
+  end
+
   # the module target is adding the methods from the module source to itself. we need to check that for all instance
   # methods M on source, M is not defined on any of target's ancestors.
   def self._hook_impl(target, source)

data/lib/types/private/methods/signature.rb

@@ -1,9 +1,12 @@
 # frozen_string_literal: true
 # typed: true
 
+# Every sig keeps one of these for the life of the process. At 18 or fewer instance variables an
+# instance fits in a 160-byte GC slot; a 19th moves every instance to the 320-byte slot, so prefer
+# deriving new state over storing it.
 class T::Private::Methods::Signature
-  attr_reader :method, :method_name, :arg_types, :kwarg_types, :block_type, :block_name,
-              :rest_type, :rest_name, :keyrest_type, :keyrest_name, :bind, :effective_return_type,
+  attr_reader :method, :method_name, :arg_types, :kwarg_types, :block_type,
+              :rest_type, :keyrest_type, :bind, :effective_return_type,
               :return_type, :mode, :req_arg_count, :req_kwarg_names,
               :check_level, :parameters, :on_failure, :override_allow_incompatible,
               :defined_raw
@@ -47,11 +50,8 @@ class T::Private::Methods::Signature
     @method = method
     @method_name = method_name
     @block_type = nil
-    @block_name = nil
     @rest_type = nil
-    @rest_name = nil
     @keyrest_type = nil
-    @keyrest_name = nil
     @return_type = T::Utils.coerce(raw_return_type)
     @effective_return_type = if check_level == :tests && @return_type.is_a?(T::Private::Types::Void)
       T::Types::Anything::Private::INSTANCE
@@ -147,13 +147,10 @@ class T::Private::Methods::Signature
           (req_kwarg_names ||= []) << param_name
         end
       when :block
-        @block_name = param_name
         @block_type = type
       when :rest
-        @rest_name = param_name
         @rest_type = type
       when :keyrest
-        @keyrest_name = param_name
         @keyrest_type = type
       else
         raise "Unexpected param_kind: `#{param_kind}`. Method: #{method_desc}"
@@ -177,6 +174,19 @@ class T::Private::Methods::Signature
     new_sig
   end
 
+  # Names are derived rather than stored so that Signature fits in a smaller GC slot.
+  def block_name
+    parameter_name(:block)
+  end
+
+  def rest_name
+    parameter_name(:rest)
+  end
+
+  def keyrest_name
+    parameter_name(:keyrest)
+  end
+
   def arg_count
     @arg_types.length
   end
@@ -227,11 +237,14 @@ class T::Private::Methods::Signature
 
       if !@rest_type.nil?
         rest_count = args_length - @arg_types.length
-        rest_count = 0 if rest_count.negative?
 
-        rest_count.times do
-          yield @rest_name, args[it], @rest_type
-          it += 1
+        if rest_count > 0
+          rest_name = fast_rest_name
+
+          rest_count.times do
+            yield rest_name, args[it], @rest_type
+            it += 1
+          end
         end
       end
     end
@@ -268,6 +281,16 @@ class T::Private::Methods::Signature
     @return_type.build_type
   end
 
+  # The rest param directly follows the positional params unless required params come after it.
+  private def fast_rest_name
+    param_kind, param_name = @parameters[@arg_types.length]
+    param_kind == :rest ? param_name : parameter_name(:rest)
+  end
+
+  private def parameter_name(kind)
+    @parameters.assoc(kind)&.[](1)
+  end
+
   EMPTY_LIST = [].freeze
   EMPTY_HASH = {}.freeze
 end

data/lib/types/utils.rb

@@ -191,6 +191,18 @@ module T::Utils
     nil
   end
 
+  # Free the signatures whose runtime checks never run: the `.checked(:never)`
+  # sigs, plus the `.checked(:tests)` sigs outside of a test environment. After
+  # this call, `T::Utils.signature_for_method` returns `nil` for those methods,
+  # and nothing can rebuild them.
+  #
+  # Call this once after eagerly preloading a codebase (e.g. at service startup)
+  # and after `run_all_sig_blocks`, to trade that introspection for memory.
+  def self.drop_unchecked_sigs!
+    T::Private::Methods.drop_unchecked_sigs!
+    nil
+  end
+
   def self.lift_enum(enum)
     unless enum.is_a?(T::Types::Enum)
       raise ArgumentError.new("#{enum.inspect} is not a T.deprecated_enum")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.6.13612
+  version: 0.6.13616
 platform: ruby
 authors:
 - Stripe