sorbet-runtime 0.6.13455 → 0.6.13558

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 52d62633bf90952fb1e60ed348020d669e5e06dfe5d80fb1431d94d11ba1c3d9
-  data.tar.gz: d710f2e9d232a1eb737631807cee5fa7421a9d0d370b8f173127adb9d12fefcb
+  metadata.gz: 28fdc76a685d7fe5085b89732a4aec05fa803bd38313c1ad26359dfaf93deb09
+  data.tar.gz: 5df93e5b8be311fb7cfd52d7587439d6d52ee00704b5819d566e93af88385396
 SHA512:
-  metadata.gz: cc43769140a87189ac849af8aba74bea844e2197661ec6a973dae12a15ae6d4a7f390d8c7f9727e5a3788b9a8cf72ffcc6eb5b65d7954336313aaa5d68c977f9
-  data.tar.gz: 94fa009f872bb1d75a51b251a534f04955ea734e19c19e18f456ebe0af1a8bc5dd081bc08eddc39a9f6b237e946751a8ce75745d4b896bb0ddaebd6e5d75fa3e
+  metadata.gz: 47b078b793fd134133fffe4765c7623d02a1fa2f312f59fd75b795c791922a75fbba3df1ac4a5bdec9873cf3067b8c904d77ec0113c1d12e926cecbf019893af
+  data.tar.gz: 97079b47fdc95608f7f81edc16bf090513b1da88503ab1663074303b2c8bbe050241bbad9a04412e90472e72fcdebc820be4e5ed825105b1baa18beb924fa8dd

data/lib/types/configuration.rb

@@ -270,38 +270,6 @@ module T::Configuration
     nil
   end
 
-  @log_info_handler = nil
-  # Set a handler for logging
-  #
-  # @param [Lambda, Proc, Object, nil] value Proc that handles the error
-  #   report (pass nil to reset to default behavior)
-  #
-  # Parameters passed to value.call:
-  #
-  #  @param [String] str Message to be logged
-  #  @param [Hash] extra A hash containing additional parameters to be passed along to the logger.
-  #
-  # @example
-  #   T::Configuration.log_info_handler = lambda do |str, extra|
-  #     puts "#{str}, context: #{extra}"
-  #   end
-  def self.log_info_handler=(value)
-    validate_lambda_given!(value)
-    @log_info_handler = value
-  end
-
-  private_class_method def self.log_info_handler_default(str, extra)
-    puts "#{str}, extra: #{extra}"
-  end
-
-  def self.log_info_handler(str, extra)
-    if @log_info_handler
-      @log_info_handler.call(str, extra)
-    else
-      log_info_handler_default(str, extra)
-    end
-  end
-
   @soft_assert_handler = nil
   # Set a handler for soft assertions
   #

data/lib/types/private/methods/call_validation.rb

@@ -7,7 +7,8 @@ module T::Private::Methods::CallValidation
 
   KERNEL_TO_S = Kernel.instance_method(:to_s)
   MODULE_TO_S = Module.instance_method(:to_s)
-  private_constant(:KERNEL_TO_S, :MODULE_TO_S)
+  METHOD_NAME_FOR_EVAL = /\A[A-Za-z_][A-Za-z0-9_]*[!?]?\z/
+  private_constant(:KERNEL_TO_S, :MODULE_TO_S, :METHOD_NAME_FOR_EVAL)
 
   # Wraps a method with a layer of validation for the given type signature.
   # This wrapper is meant to be fast, and is applied by a previous wrapper,
@@ -52,21 +53,35 @@ module T::Private::Methods::CallValidation
   def self.create_abstract_wrapper(mod, method_name, original_visibility)
     T::Configuration.without_ruby_warnings do
       T::Private::DeclState.current.without_on_method_added do
-        mod.module_eval(<<~METHOD, __FILE__, __LINE__ + 1)
-          #{original_visibility}
-
-          def #{method_name}(...)
+        if METHOD_NAME_FOR_EVAL.match?(method_name)
+          mod.module_eval(<<~METHOD, __FILE__, __LINE__ + 1)
+            #{original_visibility}
+
+            def #{method_name}(...)
+              # We allow abstract methods to be implemented by things further down the ancestor chain.
+              # So, if a super method exists, call it.
+              if defined?(super)
+                super
+              else
+                raise NotImplementedError.new(
+                  "The method `#{method_name}` on #{mod} is declared as `abstract`. It does not have an implementation."
+                )
+              end
+            end
+          METHOD
+        else
+          T::Private::ClassUtils.def_with_visibility(mod, method_name, original_visibility) do |*args, &blk|
             # We allow abstract methods to be implemented by things further down the ancestor chain.
             # So, if a super method exists, call it.
             if defined?(super)
-              super
+              super(*args, &blk)
             else
               raise NotImplementedError.new(
                 "The method `#{method_name}` on #{mod} is declared as `abstract`. It does not have an implementation."
               )
             end
           end
-        METHOD
+        end
       end
     end
   end

data/lib/types/private/types/not_typed.rb

@@ -10,6 +10,11 @@ class T::Private::Types::NotTyped < T::Types::Base
     nil
   end
 
+  # overrides Base
+  def build_lazy_fields
+    nil
+  end
+
   # overrides Base
   def name
     "<NOT-TYPED>"

data/lib/types/private/types/string_holder.rb

@@ -13,6 +13,11 @@ class T::Private::Types::StringHolder < T::Types::Base
     nil
   end
 
+  # overrides Base
+  def build_lazy_fields
+    nil
+  end
+
   # overrides Base
   def name
     string

data/lib/types/private/types/type_alias.rb

@@ -25,6 +25,13 @@ module T::Private::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      # Not the aliased type too: an alias can refer to itself.
+      effective_aliased_type
+      nil
+    end
+
     def aliased_type
       @aliased_type ||= T::Utils.coerce(@callable.call)
     end

data/lib/types/private/types/void.rb

@@ -22,6 +22,11 @@ module T::Private::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      nil
+    end
+
     # overrides Base
     def name
       "<VOID>"

data/lib/types/props/serializable.rb

@@ -141,10 +141,7 @@ module T::Props::Serializable
       # If the prop was already missing during deserialization, that means the application
       # code already had to deal with a nil value, which means we wouldn't be accomplishing
       # much by raising here (other than causing an unnecessary breakage).
-      T::Configuration.log_info_handler(
-        "chalk-odm: missing required property in serialize",
-        prop: prop, class: self.class.name, id: self.class.decorator.get_id(self)
-      )
+      Kernel.warn("chalk-odm: missing required property in serialize prop=#{prop.inspect} class=#{self.class.name} id=#{self.class.decorator.get_id(self).inspect}")
     else
       raise TypeError.new("#{self.class.name}.#{prop} not set for non-optional prop")
     end
@@ -289,6 +286,18 @@ module T::Props::Serializable::DecoratorMethods
       raise ArgumentError.new("The value of `raise_on_nil_write` if specified must be `true` (given: #{rules[:raise_on_nil_write]}).")
     end
 
+    if rules[:raise_on_nil_write] && !rules[:_tnilable]
+      is_nilclass_parent = type.is_a?(T::Types::Simple) &&
+                           (type.raw_type.equal?(Object) || type.raw_type.equal?(BasicObject))
+      # Use `instance_of?` because modules can be mixed into NilClass, but classes cannot.
+      is_module = type.is_a?(T::Types::Simple) && type.raw_type.instance_of?(Module)
+      underspecified_type = type.equal?(T.untyped) || is_nilclass_parent || is_module
+
+      unless underspecified_type
+        raise ArgumentError.new("`raise_on_nil_write` requires that the type of `#{name}` be `T.nilable(...)` (given: #{type})")
+      end
+    end
+
     result
   end
 

data/lib/types/types/anything.rb

@@ -10,6 +10,11 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      nil
+    end
+
     # overrides Base
     def name
       "T.anything"

data/lib/types/types/attached_class.rb

@@ -14,6 +14,11 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      nil
+    end
+
     # overrides Base
     def name
       "T.attached_class"

data/lib/types/types/base.rb

@@ -39,6 +39,17 @@ module T::Types
       raise NotImplementedError
     end
 
+    # Force every lazily-initialized field of this type and its inner types to be built.
+    # It's unusual to call this directly; you probably want to call it indirectly via `T::Utils.build_all_types`.
+    define_method(:build_lazy_fields) do
+      raise NotImplementedError
+    end
+
+    # A frozen type can't take the write, so skip it.
+    private def build_inner_lazy_fields(inner)
+      inner.build_lazy_fields unless inner.frozen?
+    end
+
     # Equality is based on name, so be sure the name reflects all relevant state when implementing.
     define_method(:name) do
       raise NotImplementedError

data/lib/types/types/class_of.rb

@@ -14,6 +14,11 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      nil
+    end
+
     # overrides Base
     def name
       "T.class_of(#{@type})"

data/lib/types/types/enum.rb

@@ -22,6 +22,12 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      name
+      nil
+    end
+
     # overrides Base
     def valid?(obj)
       @values.member?(obj)

data/lib/types/types/fixed_array.rb

@@ -19,6 +19,12 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      types.each { |type| build_inner_lazy_fields(type) }
+      nil
+    end
+
     # overrides Base
     def name
       "[#{types.join(', ')}]"

data/lib/types/types/fixed_hash.rb

@@ -18,6 +18,12 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      types.each_value { |type| build_inner_lazy_fields(type) }
+      nil
+    end
+
     # overrides Base
     def name
       serialize_hash(types)

data/lib/types/types/intersection.rb

@@ -25,6 +25,12 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      types.each { |type| build_inner_lazy_fields(type) }
+      nil
+    end
+
     # overrides Base
     def name
       "T.all(#{types.map(&:name).compact.sort.join(', ')})"

data/lib/types/types/noreturn.rb

@@ -10,6 +10,11 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      nil
+    end
+
     # overrides Base
     def name
       "T.noreturn"

data/lib/types/types/proc.rb

@@ -29,6 +29,13 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      arg_types.each_value { |type| build_inner_lazy_fields(type) }
+      build_inner_lazy_fields(returns)
+      nil
+    end
+
     # overrides Base
     def name
       args = []

data/lib/types/types/self_type.rb

@@ -12,6 +12,11 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      nil
+    end
+
     # overrides Base
     def name
       "T.self_type"

data/lib/types/types/simple.rb

@@ -17,6 +17,14 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      name
+      # NilClass can't be paired with itself in a SimplePairUnion.
+      to_nilable.types unless @raw_type.equal?(NilClass)
+      nil
+    end
+
     # overrides Base
     def name
       # Memoize to mitigate pathological performance with anonymous modules (https://bugs.ruby-lang.org/issues/11119)

data/lib/types/types/t_enum.rb

@@ -14,6 +14,11 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      nil
+    end
+
     # overrides Base
     def name
       # Strips the #<...> off, just leaving the ...

data/lib/types/types/type_parameter.rb

@@ -24,6 +24,11 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      nil
+    end
+
     def self.make(name)
       cached = Private.cached_entry(name)
       return cached if cached

data/lib/types/types/type_variable.rb

@@ -23,6 +23,11 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      nil
+    end
+
     def valid?(obj)
       true
     end

data/lib/types/types/typed_class.rb

@@ -16,6 +16,12 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      build_inner_lazy_fields(type)
+      nil
+    end
+
     # overrides Base
     def name
       "T::Class[#{type.name}]"

data/lib/types/types/typed_enumerable.rb

@@ -19,6 +19,12 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      build_inner_lazy_fields(type)
+      nil
+    end
+
     def underlying_class
       Enumerable
     end

data/lib/types/types/typed_module.rb

@@ -16,6 +16,12 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      build_inner_lazy_fields(type)
+      nil
+    end
+
     # overrides Base
     def name
       "T::Module[#{type.name}]"

data/lib/types/types/union.rb

@@ -42,6 +42,12 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      types.each { |type| build_inner_lazy_fields(type) }
+      nil
+    end
+
     # overrides Base
     def name
       # Use the attr_reader here so we can override it in SimplePairUnion

data/lib/types/types/untyped.rb

@@ -11,6 +11,11 @@ module T::Types
       nil
     end
 
+    # overrides Base
+    def build_lazy_fields
+      nil
+    end
+
     # overrides Base
     def name
       "T.untyped"

data/lib/types/utils.rb

@@ -178,6 +178,19 @@ module T::Utils
     nil
   end
 
+  # Force every type object in the process to build its lazily-initialized
+  # fields (see `T::Types::Base#build_lazy_fields`).
+  #
+  # Call this before forking workers so that first use of a type in a worker
+  # doesn't write onto a type object shared with the parent via copy-on-write.
+  def self.build_all_types
+    require 'objspace'
+    ObjectSpace.each_object(T::Types::Base) do |type|
+      type.build_lazy_fields unless type.frozen?
+    end
+    nil
+  end
+
   def self.lift_enum(enum)
     unless enum.is_a?(T::Types::Enum)
       raise ArgumentError.new("#{enum.inspect} is not a T.deprecated_enum")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.6.13455
+  version: 0.6.13558
 platform: ruby
 authors:
 - Stripe