sorbet-runtime 0.5.9266 → 0.5.9287

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e3b59f0bc1a270f595e0bd7d199c528af1fc3ed0dd81120185509533877b585b
-  data.tar.gz: 926079130346393f975d6ccfa78cec361e4d4331ad58444fdc48e39a8d17a0c3
+  metadata.gz: 53cf2740a5d62c687f1c05148c6e59546c1a0250b706a960e0e1ca998dd9c917
+  data.tar.gz: c607bcf2b4cf9382f15c4274f963bc1033a8dad286b278551a7fb52a84f4b22c
 SHA512:
-  metadata.gz: d21a28864aad2f3cda6e1d0bb1a5dfc08e9cd48df4d8539c3129ef5fb6e7add1611e373fa4564369362c400eb742fb325978fd792e1a4dfee8e846711fb889e4
-  data.tar.gz: 5092f6320ada939fec4869e1f36530ac269bf7bee265733cfb0c85bf421e07b839618c9f5848b770537a2308bff8d9275c4eba3aae6ab3da0cfd3e7d90fa6a03
+  metadata.gz: 7bc3a0dc930e6f8689e041cdc129532607bc295395d190e35d15b6aff494ec9efb98a2d993042eaca6c2d1a6445ba2d5c51c1e44599837dfd39ed7cf2ba3cc98
+  data.tar.gz: 29982ffa0238b6aa91dd653d54d4bead28fb2f99ede5bac9826e758b99e6ce50e0f0f78777ab88235e8209c01c4d8ad71aae2e1a48eef514f0aa33b035e32616

data/lib/types/private/sealed.rb

@@ -3,11 +3,11 @@
 
 module T::Private::Sealed
   module NoInherit
-    def inherited(other)
+    def inherited(child)
       super
       this_line = Kernel.caller.find {|line| !line.match(/in `inherited'$/)}
-      T::Private::Sealed.validate_inheritance(this_line, self, 'inherited')
-      @sorbet_sealed_module_all_subclasses << other
+      T::Private::Sealed.validate_inheritance(this_line, self, child, 'inherited')
+      @sorbet_sealed_module_all_subclasses << child
     end
 
     def sealed_subclasses
@@ -20,18 +20,18 @@ module T::Private::Sealed
   end
 
   module NoIncludeExtend
-    def included(other)
+    def included(child)
       super
       this_line = Kernel.caller.find {|line| !line.match(/in `included'$/)}
-      T::Private::Sealed.validate_inheritance(this_line, self, 'included')
-      @sorbet_sealed_module_all_subclasses << other
+      T::Private::Sealed.validate_inheritance(this_line, self, child, 'included')
+      @sorbet_sealed_module_all_subclasses << child
     end
 
-    def extended(other)
+    def extended(child)
       super
       this_line = Kernel.caller.find {|line| !line.match(/in `extended'$/)}
-      T::Private::Sealed.validate_inheritance(this_line, self, 'extended')
-      @sorbet_sealed_module_all_subclasses << other
+      T::Private::Sealed.validate_inheritance(this_line, self, child, 'extended')
+      @sorbet_sealed_module_all_subclasses << child
     end
 
     def sealed_subclasses
@@ -68,12 +68,15 @@ module T::Private::Sealed
     mod.instance_variable_defined?(:@sorbet_sealed_module_decl_file)
   end
 
-  def self.validate_inheritance(this_line, parent, verb)
+  def self.validate_inheritance(this_line, parent, child, verb)
     this_file = this_line&.split(':')&.first
     decl_file = parent.instance_variable_get(:@sorbet_sealed_module_decl_file)
 
-    if !this_file || !decl_file
-      raise "Couldn't determine enough file information for checking sealed modules"
+    if !this_file
+      raise "Could not use backtrace to determine file for #{verb} child #{child}"
+    end
+    if !decl_file
+      raise "#{parent} does not seem to be a sealed module (#{verb} by #{child})"
     end
 
     if !this_file.start_with?(decl_file)

data/lib/types/props/decorator.rb

@@ -61,7 +61,6 @@ class T::Props::Decorator
   VALID_RULE_KEYS = T.let(%i[
     enum
     foreign
-    foreign_hint_only
     ifunset
     immutable
     override
@@ -359,12 +358,7 @@ class T::Props::Decorator
     # get at the property (e.g., Chalk::ODM::Document exposes `get` and `set`).
     define_getter_and_setter(name, rules) unless rules[:without_accessors]
 
-    if rules[:foreign] && rules[:foreign_hint_only]
-      raise ArgumentError.new(":foreign and :foreign_hint_only are mutually exclusive.")
-    end
-
     handle_foreign_option(name, cls, rules, rules[:foreign]) if rules[:foreign]
-    handle_foreign_hint_only_option(name, cls, rules[:foreign_hint_only]) if rules[:foreign_hint_only]
     handle_redaction_option(name, rules[:redaction]) if rules[:redaction]
   end
 
@@ -484,42 +478,6 @@ class T::Props::Decorator
     end
   end
 
-  sig do
-    params(
-      prop_name: Symbol,
-      prop_cls: Module,
-      foreign_hint_only: T.untyped,
-    )
-    .void
-  end
-  private def handle_foreign_hint_only_option(prop_name, prop_cls, foreign_hint_only)
-    if ![String, Array].include?(prop_cls) && !prop_cls.is_a?(T::Props::CustomType)
-      raise ArgumentError.new(
-        "`foreign_hint_only` can only be used with String or Array prop types"
-      )
-    end
-
-    validate_foreign_option(
-      :foreign_hint_only, foreign_hint_only,
-      valid_type_msg: "an individual or array of a model class, or a Proc returning such."
-    )
-
-    unless foreign_hint_only.is_a?(Proc)
-      T::Configuration.soft_assert_handler(<<~MESSAGE, storytime: {prop: prop_name, value: foreign_hint_only}, notify: 'jerry')
-        Please use a Proc that returns a model class instead of the model class itself as the argument to `foreign_hint_only`. In other words:
-
-          instead of `prop :foo, String, foreign_hint_only: FooModel`
-          use `prop :foo, String, foreign_hint_only: -> {FooModel}`
-
-          OR
-
-          instead of `prop :foo, String, foreign_hint_only: [FooModel, BarModel]`
-          use `prop :foo, String, foreign_hint_only: -> {[FooModel, BarModel]}`
-
-      MESSAGE
-    end
-  end
-
   # checked(:never) - Rules hash is expensive to check
   sig do
     params(
@@ -598,8 +556,8 @@ class T::Props::Decorator
       # keep them from being lurky performance hits by issuing a bunch of un-batched DB queries.
       # We could potentially address that by porting over something like AmbiguousIDLoader.
       raise ArgumentError.new(
-        "Using an array for `foreign` is no longer supported. Instead, use `foreign_hint_only` " \
-        "with an array or a Proc that returns an array, e.g., foreign_hint_only: -> {[Foo, Bar]}"
+        "Using an array for `foreign` is no longer supported. Instead, please use a union type of " \
+        "token types for the prop type, e.g., T.any(Opus::Autogen::Tokens::FooModelToken, Opus::Autogen::Tokens::BarModelToken)"
       )
     end
 

data/lib/types/types/base.rb

@@ -133,7 +133,7 @@ module T::Types
       if valid?(obj)
         nil
       else
-        "Expected type #{self.name}, got #{describe_obj(obj)}"
+        error_message(obj)
       end
     end
 
@@ -141,10 +141,14 @@ module T::Types
       if recursively_valid?(obj)
         nil
       else
-        "Expected type #{self.name}, got #{describe_obj(obj)}"
+        error_message(obj)
       end
     end
 
+    private def error_message(obj)
+      "Expected type #{self.name}, got #{describe_obj(obj)}"
+    end
+
     def validate!(obj)
       err = error_message_for_obj(obj)
       raise TypeError.new(err) if err

data/lib/types/types/simple.rb

@@ -34,6 +34,23 @@ module T::Types
       end
     end
 
+    # overrides Base
+    private def error_message(obj)
+      error_message = super(obj)
+      actual_name = obj.class.name
+
+      return error_message unless name == actual_name
+
+      <<~MSG.strip
+        #{error_message}
+
+        The expected type and received object type have the same name but refer to different constants.
+        Expected type is #{name} with object id #{@raw_type.__id__}, but received type is #{actual_name} with object id #{obj.class.__id__}.
+
+        There might be a constant reloading problem in your application.
+      MSG
+    end
+
     def to_nilable
       @nilable ||= T::Types::Union.new([self, T::Utils::Nilable::NIL_TYPE])
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.5.9266
+  version: 0.5.9287
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-24 00:00:00.000000000 Z
+date: 2021-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest