sorbet-runtime 0.5.9103 → 0.5.9258

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dd50aa97fa3835f75f05ddad407ced4062053e791cb9c246a4ac617cb6e4eeb5
-  data.tar.gz: dd7a5031c72ae5ce3a09324d2b110c343e1409e350c12b1a8bf8a1bf21763c90
+  metadata.gz: 95b9cb872fe8ae6316b306945eb32d69cae31f87d7542d96ef0e3cd92c6955fc
+  data.tar.gz: 59cb77a96ef8a838c49fa506495d94b4c548d5ed7ed5d41b000d000b23670a6d
 SHA512:
-  metadata.gz: fa6efdc3b42d1b42322af825df44bf33c625cc24b2d93f5474887218f686604e8603db6c19afae00c29c6e32e1e1ecceb52a07de68471ec9cf18aea01ab98ef4
-  data.tar.gz: a16780c9665e17e0666d2e2b04a5b60a04a7b02863f111d3a068e2b5c7b32b72334b246b00e76ddfa98d1a64fd78c79fa1467e03d19d80203c0bc5ccacf28b6c
+  metadata.gz: 9f2d84052ba670e52e5c245dbb0998fe72d8e83fa8730d9a399a3951845b286f20ff7b75f89688e1e6ff66fe32c4c4dd0fe4fbb5708e24e8790ab57ddb7d52b4
+  data.tar.gz: 168869f66b93a304bb74af73d89cd6167fa8d9d289beaea0b6472e84153a90b00372ddc6093115d5c8af94fd9f8d68c6d1ab54d9f6904dc94b7939d51fba7860

data/lib/sorbet-runtime.rb

@@ -12,8 +12,6 @@ module T::Private; end
 module T::Private::Abstract; end
 module T::Private::Types; end
 
-require 'set'
-
 # Each section is a group that I believe need a fixed ordering. There is also
 # an ordering between groups.
 

data/lib/types/_types.rb

@@ -53,7 +53,8 @@ module T
   end
 
   # Matches any of the listed values
-  def self.enum(values)
+  # @deprecated Use T::Enum instead.
+  def self.deprecated_enum(values)
     T::Types::Enum.new(values)
   end
 
@@ -82,8 +83,9 @@ module T
 
   # Constructs a type alias. Used to create a short name for a larger type. In Ruby this returns a
   # wrapper that contains a proc that is evaluated to get the underlying type. This syntax however
-  # is needed for support by the static checker. Example usage:
+  # is needed for support by the static checker.
   #
+  # @example
   #  NilableString = T.type_alias {T.nilable(String)}
   #
   #  sig {params(arg: NilableString, default: String).returns(String)}
@@ -106,8 +108,9 @@ module T
   # References a type parameter which was previously defined with
   # `type_parameters`.
   #
-  # This is used for generic methods. Example usage:
+  # This is used for generic methods.
   #
+  # @example
   #  sig
   #  .type_parameters(:U)
   #  .params(
@@ -185,7 +188,7 @@ module T
   # cycle. However, we also don't actually need to do so; An untyped
   # identity method works just as well here.
   #
-  # sig {params(value: T.untyped).returns(T.untyped)}
+  # `sig {params(value: T.untyped).returns(T.untyped)}`
   def self.unsafe(value)
     value
   end
@@ -206,7 +209,7 @@ module T
   # Intended to be used to promise sorbet that a given nilable value happens
   # to contain a non-nil value at this point.
   #
-  # sig {params(arg: T.nilable(A)).returns(A)}
+  # `sig {params(arg: T.nilable(A)).returns(A)}`
   def self.must(arg)
     return arg if arg
     return arg if arg == false
@@ -214,7 +217,7 @@ module T
     begin
       raise TypeError.new("Passed `nil` into T.must")
     rescue TypeError => e # raise into rescue to ensure e.backtrace is populated
-      T::Configuration.inline_type_error_handler(e)
+      T::Configuration.inline_type_error_handler(e, {kind: 'T.must', value: arg, type: nil})
     end
   end
 
@@ -239,7 +242,7 @@ module T
     begin
       raise TypeError.new(msg)
     rescue TypeError => e # raise into rescue to ensure e.backtrace is populated
-      T::Configuration.inline_type_error_handler(e)
+      T::Configuration.inline_type_error_handler(e, {kind: 'T.absurd', value: value, type: nil})
     end
   end
 

data/lib/types/configuration.rb

@@ -130,10 +130,15 @@ module T::Configuration
   #
   # Parameters passed to value.call:
   #
-  # @param [TypeError] error TypeError that was raised
+  #  @param [TypeError] error TypeError that was raised
+  #  @param [Hash] opts A hash containing contextual information on the error:
+  #  @option opts [String] :kind One of:
+  #    ['T.cast', 'T.let', 'T.bind', 'T.assert_type!', 'T.must', 'T.absurd']
+  #  @option opts [Object, nil] :type Expected param/return value type
+  #  @option opts [Object] :value Actual param/return value
   #
   # @example
-  #   T::Configuration.inline_type_error_handler = lambda do |error|
+  #   T::Configuration.inline_type_error_handler = lambda do |error, opts|
   #     puts error.message
   #   end
   def self.inline_type_error_handler=(value)
@@ -141,15 +146,20 @@ module T::Configuration
     @inline_type_error_handler = value
   end
 
-  private_class_method def self.inline_type_error_handler_default(error)
+  private_class_method def self.inline_type_error_handler_default(error, opts)
     raise error
   end
 
-  def self.inline_type_error_handler(error)
+  def self.inline_type_error_handler(error, opts={})
     if @inline_type_error_handler
-      @inline_type_error_handler.call(error)
+      # Backwards compatibility before `inline_type_error_handler` took a second arg
+      if @inline_type_error_handler.arity == 1
+        @inline_type_error_handler.call(error)
+      else
+        @inline_type_error_handler.call(error, opts)
+      end
     else
-      inline_type_error_handler_default(error)
+      inline_type_error_handler_default(error, opts)
     end
     nil
   end
@@ -169,8 +179,8 @@ module T::Configuration
   #
   # Parameters passed to value.call:
   #
-  # @param [StandardError] error The error that was raised
-  # @param [Thread::Backtrace::Location] location Location of the error
+  #  @param [StandardError] error The error that was raised
+  #  @param [Thread::Backtrace::Location] location Location of the error
   #
   # @example
   #   T::Configuration.sig_builder_error_handler = lambda do |error, location|
@@ -211,16 +221,16 @@ module T::Configuration
   #
   # Parameters passed to value.call:
   #
-  # @param [StandardError] error The error that was raised
-  # @param [Hash] opts A hash containing contextual information on the error:
-  # @option opts [Method, UnboundMethod] :method Method on which the signature build failed
-  # @option opts [T::Private::Methods::Declaration] :declaration Method
-  #   signature declaration struct
-  # @option opts [T::Private::Methods::Signature, nil] :signature Signature
-  #   that failed (nil if sig build failed before Signature initialization)
-  # @option opts [T::Private::Methods::Signature, nil] :super_signature Super
-  #   method's signature (nil if method is not an override or super method
-  #   does not have a method signature)
+  #  @param [StandardError] error The error that was raised
+  #  @param [Hash] opts A hash containing contextual information on the error:
+  #  @option opts [Method, UnboundMethod] :method Method on which the signature build failed
+  #  @option opts [T::Private::Methods::Declaration] :declaration Method
+  #    signature declaration struct
+  #  @option opts [T::Private::Methods::Signature, nil] :signature Signature
+  #    that failed (nil if sig build failed before Signature initialization)
+  #  @option opts [T::Private::Methods::Signature, nil] :super_signature Super
+  #    method's signature (nil if method is not an override or super method
+  #    does not have a method signature)
   #
   # @example
   #   T::Configuration.sig_validation_error_handler = lambda do |error, opts|
@@ -256,17 +266,17 @@ module T::Configuration
   #
   # Parameters passed to value.call:
   #
-  # @param [T::Private::Methods::Signature] signature Signature that failed
-  # @param [Hash] opts A hash containing contextual information on the error:
-  # @option opts [String] :message Error message
-  # @option opts [String] :kind One of:
-  #   ['Parameter', 'Block parameter', 'Return value']
-  # @option opts [Symbol] :name Param or block param name (nil for return
-  #   value)
-  # @option opts [Object] :type Expected param/return value type
-  # @option opts [Object] :value Actual param/return value
-  # @option opts [Thread::Backtrace::Location] :location Location of the
-  #   caller
+  #  @param [T::Private::Methods::Signature] signature Signature that failed
+  #  @param [Hash] opts A hash containing contextual information on the error:
+  #  @option opts [String] :message Error message
+  #  @option opts [String] :kind One of:
+  #    ['Parameter', 'Block parameter', 'Return value']
+  #  @option opts [Symbol] :name Param or block param name (nil for return
+  #    value)
+  #  @option opts [Object] :type Expected param/return value type
+  #  @option opts [Object] :value Actual param/return value
+  #  @option opts [Thread::Backtrace::Location] :location Location of the
+  #    caller
   #
   # @example
   #   T::Configuration.call_validation_error_handler = lambda do |signature, opts|
@@ -297,8 +307,8 @@ module T::Configuration
   #
   # Parameters passed to value.call:
   #
-  # @param [String] str Message to be logged
-  # @param [Hash] extra A hash containing additional parameters to be passed along to the logger.
+  #  @param [String] str Message to be logged
+  #  @param [Hash] extra A hash containing additional parameters to be passed along to the logger.
   #
   # @example
   #   T::Configuration.log_info_handler = lambda do |str, extra|
@@ -331,8 +341,8 @@ module T::Configuration
   #
   # Parameters passed to value.call:
   #
-  # @param [String] str Assertion message
-  # @param [Hash] extra A hash containing additional parameters to be passed along to the handler.
+  #  @param [String] str Assertion message
+  #  @param [Hash] extra A hash containing additional parameters to be passed along to the handler.
   #
   # @example
   #   T::Configuration.soft_assert_handler = lambda do |str, extra|
@@ -365,8 +375,8 @@ module T::Configuration
   #
   # Parameters passed to value.call:
   #
-  # @param [String] str Assertion message
-  # @param [Hash] extra A hash containing additional parameters to be passed along to the handler.
+  #  @param [String] str Assertion message
+  #  @param [Hash] extra A hash containing additional parameters to be passed along to the handler.
   #
   # @example
   #   T::Configuration.hard_assert_handler = lambda do |str, extra|
@@ -392,7 +402,7 @@ module T::Configuration
   # Set a list of class strings that are to be considered scalar.
   #   (pass nil to reset to default behavior)
   #
-  # @param [String] value Class name.
+  # @param [String] values Class name.
   #
   # @example
   #   T::Configuration.scalar_types = ["NilClass", "TrueClass", "FalseClass", ...]
@@ -405,21 +415,21 @@ module T::Configuration
         raise ArgumentError.new("Provided values must all be class name strings.")
       end
 
-      @scalar_types = Set.new(values).freeze
+      @scalar_types = values.each_with_object({}) {|x, acc| acc[x] = true}.freeze
     end
   end
 
-  @default_scalar_types = Set.new(%w[
-    NilClass
-    TrueClass
-    FalseClass
-    Integer
-    Float
-    String
-    Symbol
-    Time
-    T::Enum
-  ]).freeze
+  @default_scalar_types = {
+    "NilClass" => true,
+    "TrueClass" => true,
+    "FalseClass" => true,
+    "Integer" => true,
+    "Float" => true,
+    "String" => true,
+    "Symbol" => true,
+    "Time" => true,
+    "T::Enum" => true,
+  }.freeze
 
   def self.scalar_types
     @scalar_types || @default_scalar_types
@@ -445,7 +455,7 @@ module T::Configuration
   #   to names in generated code. Used by the runtime implementation
   #   associated with `--stripe-packages` mode.
   #
-  # @param [Lambda, Proc, nil] value Proc that converts a type (Class/Module)
+  # @param [Lambda, Proc, nil] handler Proc that converts a type (Class/Module)
   #   to a String (pass nil to reset to default behavior)
   def self.module_name_mangler=(handler)
     @module_name_mangler = handler
@@ -454,7 +464,7 @@ module T::Configuration
   # Set to a PII handler function. This will be called with the `sensitivity:`
   # annotations on things that use `T::Props` and can modify them ahead-of-time.
   #
-  # @param [Lambda, Proc, nil] value Proc that takes a hash mapping symbols to the
+  # @param [Lambda, Proc, nil] handler Proc that takes a hash mapping symbols to the
   # prop values. Pass nil to avoid changing `sensitivity:` annotations.
   def self.normalize_sensitivity_and_pii_handler=(handler)
     @sensitivity_and_pii_handler = handler
@@ -470,7 +480,7 @@ module T::Configuration
   # `nil` and will raise an exception when the redacted version of a prop is
   # accessed.
   #
-  # @param [Lambda, Proc, nil] value Proc that converts a value into its
+  # @param [Lambda, Proc, nil] handler Proc that converts a value into its
   # redacted version according to the spec passed as the second argument.
   def self.redaction_handler=(handler)
     @redaction_handler = handler
@@ -483,7 +493,7 @@ module T::Configuration
   # Set to a function which can get the 'owner' of a class. This is
   # used in reporting deserialization errors
   #
-  # @param [Lambda, Proc, nil] value Proc that takes a class and
+  # @param [Lambda, Proc, nil] handler Proc that takes a class and
   # produces its owner, or `nil` if it does not have one.
   def self.class_owner_finder=(handler)
     @class_owner_finder = handler

data/lib/types/enum.rb

@@ -47,7 +47,7 @@ class T::Enum
   SerializedVal = T.type_alias {T.untyped}
   private_constant :SerializedVal
 
-  ## Enum class methods ##
+  ### Enum class methods ###
   sig {returns(T::Array[T.attached_class])}
   def self.values
     if @values.nil?
@@ -134,7 +134,7 @@ class T::Enum
     self.from_serialized(mongo_value)
   end
 
-  ## Enum instance methods ##
+  ### Enum instance methods ###
 
   sig {returns(T.self_type)}
   def dup
@@ -243,7 +243,7 @@ class T::Enum
     )
   end
 
-  ## Private implementation ##
+  ### Private implementation ###
 
   sig {params(serialized_val: SerializedVal).void}
   def initialize(serialized_val=nil)

data/lib/types/helpers.rb

@@ -4,6 +4,8 @@
 # Use as a mixin with extend (`extend T::Helpers`).
 # Docs at https://confluence.corp.stripe.com/display/PRODINFRA/Ruby+Types
 module T::Helpers
+  extend T::Sig
+
   Private = T::Private
 
   ### Class/Module Helpers ###
@@ -44,7 +46,7 @@ module T::Helpers
   #   module MyHelper
   #     extend T::Helpers
   #
-  #     requires_ancestor Kernel
+  #     requires_ancestor { Kernel }
   #   end
   #
   #   class MyClass < BasicObject # error: `MyClass` must include `Kernel` (required by `MyHelper`)
@@ -52,5 +54,5 @@ module T::Helpers
   #   end
   #
   # TODO: implement the checks in sorbet-runtime.
-  def requires_ancestor(mod, *mods); end
+  def requires_ancestor(*mods, &block); end
 end

data/lib/types/non_forcing_constants.rb

@@ -2,11 +2,6 @@
 # typed: strict
 
 module T::NonForcingConstants
-  T::Sig::WithoutRuntime.sig {returns(T::Boolean)}
-  private_class_method def self.stripe_packages_enabled?
-    const_defined?('StripePackages') && const_get('StripePackages').enabled?
-  end
-
   # NOTE: This method is documented on the RBI in Sorbet's payload, so that it
   # shows up in the hover/completion documentation via LSP.
   T::Sig::WithoutRuntime.sig {params(val: BasicObject, klass: String, package: T.nilable(String)).returns(T::Boolean)}
@@ -16,10 +11,11 @@ module T::NonForcingConstants
       raise ArgumentError.new("The string given to `#{method_name}` must not be empty")
     end
 
-    # TODO(gdritter): this might not be want we want in a multipackage
-    # world; revisit this implementation we move on from the monopackage
-    if stripe_packages_enabled?
-      klass = "PkgRegistry::#{package}::#{klass}"
+    # We don't treat packages differently at runtime, but the static
+    # type-checker still needs to have the package and constant
+    # separated out. This just re-assembles the string as needed
+    if !package.nil?
+      klass = "::#{package}::#{klass}"
     end
 
     current_klass = T.let(nil, T.nilable(Module))

data/lib/types/private/abstract/declare.rb

@@ -40,6 +40,11 @@ module T::Private::Abstract::Declare
         end
         super(*args, &blk)
       end
+
+      # Ruby doesn not emit "method redefined" warnings for aliased methods
+      # (more robust than undef_method that would create a small window in which the method doesn't exist)
+      mod.send(:alias_method, :initialize, :initialize)
+
       if mod.respond_to?(:ruby2_keywords, true)
         mod.send(:ruby2_keywords, :initialize)
       end

data/lib/types/private/casts.rb

@@ -14,7 +14,7 @@ module T::Private
 
         raise TypeError.new("#{cast_method}: #{error}\n#{suffix}")
       rescue TypeError => e # raise into rescue to ensure e.backtrace is populated
-        T::Configuration.inline_type_error_handler(e)
+        T::Configuration.inline_type_error_handler(e, {kind: cast_method, value: value, type: type})
         value
       end
     end
@@ -33,7 +33,7 @@ module T::Private
 
         raise TypeError.new("#{cast_method}: #{error}\n#{suffix}")
       rescue TypeError => e # raise into rescue to ensure e.backtrace is populated
-        T::Configuration.inline_type_error_handler(e)
+        T::Configuration.inline_type_error_handler(e, {kind: cast_method, value: value, type: type})
         value
       end
     end

data/lib/types/private/methods/_methods.rb

@@ -2,13 +2,13 @@
 # typed: false
 
 module T::Private::Methods
-  @installed_hooks = Set.new
+  @installed_hooks = {}
   @signatures_by_method = {}
   @sig_wrappers = {}
   @sigs_that_raised = {}
   # stores method names that were declared final without regard for where.
   # enables early rejection of names that we know can't induce final method violations.
-  @was_ever_final_names = Set.new
+  @was_ever_final_names = {}
   # maps from modules to the set of final methods declared in that module.
   # we also overload entries slightly: if the value is nil, that means that the
   # module has final methods somewhere along its ancestor chain, but does not itself
@@ -190,10 +190,11 @@ module T::Private::Methods
     m = is_singleton_method ? mod.singleton_class : mod
     methods = @modules_with_final[m]
     if methods.nil?
-      methods = Set.new
+      methods = {}
       @modules_with_final[m] = methods
     end
-    methods.add(method_name)
+    methods[method_name] = true
+    nil
   end
 
   def self.note_module_deals_with_final(mod)
@@ -276,7 +277,7 @@ module T::Private::Methods
 
     @sig_wrappers[key] = sig_block
     if current_declaration.final
-      @was_ever_final_names.add(method_name)
+      @was_ever_final_names[method_name] = true
       # use hook_mod, not mod, because for example, we want class C to be marked as having final if we def C.foo as
       # final. change this to mod to see some final_method tests fail.
       note_module_deals_with_final(hook_mod)
@@ -527,7 +528,7 @@ module T::Private::Methods
 
   def self.install_hooks(mod)
     return if @installed_hooks.include?(mod)
-    @installed_hooks << mod
+    @installed_hooks[mod] = true
 
     if mod == TOP_SELF
       # self at the top-level of a file is weirdly special in Ruby

data/lib/types/private/methods/signature.rb

@@ -156,7 +156,7 @@ class T::Private::Methods::Signature
     "#{@mode}_method"
   end
 
-  # @return [Hash] a mapping like {arg_name: [val, type], ...}, for only those args actually present.
+  # @return [Hash] a mapping like `{arg_name: [val, type], ...}`, for only those args actually present.
   def each_args_value_type(args)
     # Manually split out args and kwargs based on ruby's behavior. Do not try to implement this by
     # getting ruby to determine the kwargs for you (e.g., by defining this method to take *args and

data/lib/types/private/sealed.rb

@@ -11,7 +11,11 @@ module T::Private::Sealed
     end
 
     def sealed_subclasses
-      @sorbet_sealed_module_all_subclasses
+      @sorbet_sealed_module_all_subclasses_set ||= # rubocop:disable Naming/MemoizedInstanceVariableName
+        begin
+          require 'set'
+          Set.new(@sorbet_sealed_module_all_subclasses).freeze
+        end
     end
   end
 
@@ -34,7 +38,11 @@ module T::Private::Sealed
       # this will freeze the set so that you can never get into a
       # state where you use the subclasses list and then something
       # else will add to it
-      @sorbet_sealed_module_all_subclasses.freeze
+      @sorbet_sealed_module_all_subclasses_set ||= # rubocop:disable Naming/MemoizedInstanceVariableName
+        begin
+          require 'set'
+          Set.new(@sorbet_sealed_module_all_subclasses).freeze
+        end
     end
   end
 
@@ -53,7 +61,7 @@ module T::Private::Sealed
       raise "Couldn't determine declaration file for sealed class."
     end
     mod.instance_variable_set(:@sorbet_sealed_module_decl_file, decl_file)
-    mod.instance_variable_set(:@sorbet_sealed_module_all_subclasses, Set.new)
+    mod.instance_variable_set(:@sorbet_sealed_module_all_subclasses, [])
   end
 
   def self.sealed_module?(mod)

data/lib/types/private/types/not_typed.rb

@@ -6,17 +6,17 @@
 class T::Private::Types::NotTyped < T::Types::Base
   ERROR_MESSAGE = "Validation is being done on a `NotTyped`. Please report to #dev-productivity."
 
-  # @override Base
+  # overrides Base
   def name
     "<NOT-TYPED>"
   end
 
-  # @override Base
+  # overrides Base
   def valid?(obj)
     raise ERROR_MESSAGE
   end
 
-  # @override Base
+  # overrides Base
   private def subtype_of_single?(other)
     raise ERROR_MESSAGE
   end

data/lib/types/private/types/string_holder.rb

@@ -9,17 +9,17 @@ class T::Private::Types::StringHolder < T::Types::Base
     @string = string
   end
 
-  # @override Base
+  # overrides Base
   def name
     string
   end
 
-  # @override Base
+  # overrides Base
   def valid?(obj)
     false
   end
 
-  # @override Base
+  # overrides Base
   private def subtype_of_single?(other)
     false
   end

data/lib/types/private/types/type_alias.rb

@@ -13,17 +13,17 @@ module T::Private::Types
       @aliased_type ||= T::Utils.coerce(@callable.call)
     end
 
-    # @override Base
+    # overrides Base
     def name
       aliased_type.name
     end
 
-    # @override Base
+    # overrides Base
     def recursively_valid?(obj)
       aliased_type.recursively_valid?(obj)
     end
 
-    # @override Base
+    # overrides Base
     def valid?(obj)
       aliased_type.valid?(obj)
     end

data/lib/types/private/types/void.rb

@@ -17,17 +17,17 @@ class T::Private::Types::Void < T::Types::Base
     freeze
   end
 
-  # @override Base
+  # overrides Base
   def name
     "<VOID>"
   end
 
-  # @override Base
+  # overrides Base
   def valid?(obj)
     raise ERROR_MESSAGE
   end
 
-  # @override Base
+  # overrides Base
   private def subtype_of_single?(other)
     raise ERROR_MESSAGE
   end

data/lib/types/props/_props.rb

@@ -38,8 +38,6 @@ module T::Props
       @decorator = decorator_class.new(self)
     end
 
-    # @!method self.prop(name, type, opts={})
-    #
     # Define a new property. See {file:README.md} for some concrete
     #  examples.
     #
@@ -50,7 +48,7 @@ module T::Props
     #
     # @param name [Symbol] The name of this property
     # @param cls [Class,T::Types::Base] The type of this
-    #   property. If the type is itself a {Document} subclass, this
+    #   property. If the type is itself a `Document` subclass, this
     #   property will be recursively serialized/deserialized.
     # @param rules [Hash] Options to control this property's behavior.
     # @option rules [T::Boolean,Symbol] :optional If `true`, this property
@@ -61,7 +59,7 @@ module T::Props
     #   If `false`, when the property is missing/nil after deserialization, it
     #   will be set to the default value (as defined by the `default` or
     #   `factory` option) or will raise if they are not present.
-    #   Deprecated: For {Model}s, if `:optional` is set to the special value
+    #   Deprecated: For `Model`s, if `:optional` is set to the special value
     #   `:existing`, the property can be saved as nil even if it was
     #   deserialized with a non-nil value. (Deprecated because there should
     #   never be a need for this behavior; the new behavior of non-optional
@@ -69,7 +67,8 @@ module T::Props
     # @option rules [Array] :enum An array of legal values; The
     #  property is required to take on one of those values.
     # @option rules [T::Boolean] :dont_store If true, this property will
-    #   not be saved on the hash resulting from {#serialize}
+    #   not be saved on the hash resulting from
+    #   {T::Props::Serializable#serialize}
     # @option rules [Object] :ifunset A value to be returned if this
     #   property is requested but has never been set (is set to
     #   `nil`). It is applied at property-access time, and never saved
@@ -93,10 +92,10 @@ module T::Props
     #  class directly.
     #
     # @option rules [Object] :default A default value that will be set
-    #   by {#initialize} if none is provided in the initialization
+    #   by `#initialize` if none is provided in the initialization
     #   hash. This will not affect objects loaded by {.from_hash}.
     # @option rules [Proc] :factory A `Proc` that will be called to
-    #   generate an initial value for this prop on {#initialize}, if
+    #   generate an initial value for this prop on `#initialize`, if
     #   none is provided.
     # @option rules [T::Boolean] :immutable If true, this prop cannot be
     #   modified after an instance is created or loaded from a hash.
@@ -116,8 +115,6 @@ module T::Props
       decorator.prop_defined(name, cls, rules)
     end
 
-    # @!method validate_prop_value(propname, value)
-    #
     # Validates the value of the specified prop. This method allows the caller to
     #  validate a value for a prop without having to set the data on the instance.
     #  Throws if invalid.

data/lib/types/props/custom_type.rb

@@ -37,7 +37,7 @@ module T::Props
     # Given an instance of this type, serialize that into a scalar type
     # supported by T::Props.
     #
-    # @param [Object] _instance
+    # @param [Object] instance
     # @return An instance of one of T::Configuration.scalar_types
     sig {abstract.params(instance: T.untyped).returns(T.untyped).checked(:never)}
     def serialize(instance); end