sorbet-runtime 0.5.6382 → 0.5.6391

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bf2148f2c8b83fe261d42135aebb10b7e4bd6ed53981cf3cca3aef02dc973edb
-  data.tar.gz: b353a661bcc6f804f657c340af961ecdf076e773283d9e8b5d9ab925544846dd
+  metadata.gz: 5a81243179b6a7b33dc911b45394c4d509a3ca58f5400e9fef69745629504b94
+  data.tar.gz: 4106d81a66aeed8dc5bf06ab6266140dd3f7dc5cd00803b4b2532acb8da1114e
 SHA512:
-  metadata.gz: 3eea8c3e5cf69f0282dd20bc012a9fee55b33e8457c5c3b83c5b4a40d6f9e00eb11c5f446e01d7beda09153d7243305c66d3bf2ef7a5cecad3691a503ea453ed
-  data.tar.gz: 19cf13cd5b49c076f187fff4863ad5d1d09e7bcd2b8941a01cc2d4c5a85a0dcb8bc996e839c0c73660324a2c6cad0b08e9d666a7aec74833a5c10caa48cdac3b
+  metadata.gz: d7ce14e14087c651d5de7ebb98cb0752e0a5f42c65fedef67c0088be0bf097f33126985c9eb0ebf52b9b24f3f8db73b88fd18a9c6ad6a4ebc4df338ff3eff7bb
+  data.tar.gz: 4ef0b7e7f4f5fab289e8f40ac9c91e91c2e856ecc6bb9352bc6864fcb3e4a81c6b1a01b2c7f917eb9e43916e0fc27ff836bd40a9af813310777e9a359633f44f

data/lib/types/configuration.rb

@@ -73,6 +73,27 @@ module T::Configuration
     @include_value_in_type_errors = true
   end
 
+  # Whether to use VM-defined prop serialization/deserialization routines.
+  #
+  # The default is to use runtime codegen inside sorbet-runtime itself.
+  #
+  # @return [T::Boolean]
+  def self.use_vm_prop_serde?
+    @use_vm_prop_serde || false
+  end
+
+  # Enable using VM-defined prop serialization/deserialization routines.
+  #
+  # This method is likely to break things outside of Stripe's systems.
+  def self.enable_vm_prop_serde
+    @use_vm_prop_serde = true
+  end
+
+  # Disable using VM-defined prop serialization/deserialization routines.
+  def self.disable_vm_prop_serde
+    @use_vm_prop_serde = false
+  end
+
   # Configure the default checked level for a sig with no explicit `.checked`
   # builder. When unset, the default checked level is `:always`.
   #

data/lib/types/props/generated_code_validation.rb

@@ -162,7 +162,16 @@ module T::Props
         exceptions.children.each {|c| assert_equal(:const, c.type)}
         assert_equal(:lvasgn, assignment.type)
         assert_equal([:e], assignment.children)
-        validate_lack_of_side_effects(handler, whitelisted_methods_for_deserialize)
+
+        deserialization_error, val_return = handler.children
+
+        assert_equal(:send, deserialization_error.type)
+        receiver, method, *args = deserialization_error.children
+        assert_equal(nil, receiver)
+        assert_equal(:raise_deserialization_error, method)
+        args.each {|a| validate_lack_of_side_effects(a, whitelisted_methods_for_deserialize)}
+
+        validate_lack_of_side_effects(val_return, whitelisted_methods_for_deserialize)
       else
         validate_lack_of_side_effects(else_body, whitelisted_methods_for_deserialize)
       end
@@ -261,7 +270,7 @@ module T::Props
     private_class_method def self.whitelisted_methods_for_deserialize
       @whitelisted_methods_for_deserialize ||= {
         lvar: %i{dup map transform_values transform_keys each_with_object nil? []= to_f},
-        const: %i[deserialize from_hash deep_clone_object soft_assert_handler],
+        const: %i[deserialize from_hash deep_clone_object],
       }
     end
   end

data/lib/types/props/has_lazily_specialized_methods.rb

@@ -48,6 +48,11 @@ module T::Props
         @lazily_defined_methods ||= {}
       end
 
+      sig {returns(T::Hash[Symbol, T.untyped]).checked(:never)}
+      private def lazily_defined_vm_methods
+        @lazily_defined_vm_methods ||= {}
+      end
+
       sig {params(name: Symbol).void}
       private def eval_lazily_defined_method!(name)
         if !HasLazilySpecializedMethods.lazy_evaluation_enabled?
@@ -61,6 +66,18 @@ module T::Props
         cls.send(:private, name)
       end
 
+      sig {params(name: Symbol).void}
+      private def eval_lazily_defined_vm_method!(name)
+        if !HasLazilySpecializedMethods.lazy_evaluation_enabled?
+          raise SourceEvaluationDisabled.new
+        end
+
+        lazily_defined_vm_methods.fetch(name).call
+
+        cls = decorated_class
+        cls.send(:private, name)
+      end
+
       sig {params(name: Symbol, blk: T.proc.returns(String)).void}
       private def enqueue_lazy_method_definition!(name, &blk)
         lazily_defined_methods[name] = blk
@@ -76,6 +93,21 @@ module T::Props
         cls.send(:private, name)
       end
 
+      sig {params(name: Symbol, blk: T.untyped).void}
+      private def enqueue_lazy_vm_method_definition!(name, &blk)
+        lazily_defined_vm_methods[name] = blk
+
+        cls = decorated_class
+        cls.send(:define_method, name) do |*args|
+          self.class.decorator.send(:eval_lazily_defined_vm_method!, name)
+          send(name, *args)
+        end
+        if cls.respond_to?(:ruby2_keywords, true)
+          cls.send(:ruby2_keywords, name)
+        end
+        cls.send(:private, name)
+      end
+
       sig {void}
       def eagerly_define_lazy_methods!
         return if lazily_defined_methods.empty?
@@ -87,6 +119,17 @@ module T::Props
         lazily_defined_methods.each_key {|name| cls.send(:private, name)}
         lazily_defined_methods.clear
       end
+
+      sig {void}
+      def eagerly_define_lazy_vm_methods!
+        return if lazily_defined_vm_methods.empty?
+
+        lazily_defined_vm_methods.values.map(&:call)
+
+        cls = decorated_class
+        lazily_defined_vm_methods.each_key {|name| cls.send(:private, name)}
+        lazily_defined_vm_methods.clear
+      end
     end
   end
 end

data/lib/types/props/private/deserializer_generator.rb

@@ -57,15 +57,10 @@ module T::Props
               begin
                 #{transformation}
               rescue NoMethodError => e
-                T::Configuration.soft_assert_handler(
-                  'Deserialization error (probably unexpected stored type)',
-                  storytime: {
-                    klass: self.class,
-                    prop: #{prop.inspect},
-                    value: val,
-                    error: e.message,
-                    notify: 'djudd'
-                  }
+                raise_deserialization_error(
+                  #{prop.inspect},
+                  val,
+                  e,
                 )
                 val
               end

data/lib/types/props/serializable.rb

@@ -156,6 +156,19 @@ module T::Props::Serializable
     @_required_props_missing_from_deserialize << prop
     nil
   end
+
+  private def raise_deserialization_error(prop_name, value, orig_error)
+    T::Configuration.soft_assert_handler(
+      'Deserialization error (probably unexpected stored type)',
+      storytime: {
+        klass: self.class,
+        prop: prop_name,
+        value: value,
+        error: orig_error.message,
+        notify: 'djudd'
+      }
+    )
+  end
 end
 
 
@@ -201,8 +214,13 @@ module T::Props::Serializable::DecoratorMethods
     rules[:serialized_form] = rules.fetch(:name, prop.to_s)
     res = super
     prop_by_serialized_forms[rules[:serialized_form]] = prop
-    enqueue_lazy_method_definition!(:__t_props_generated_serialize) {generate_serialize_source}
-    enqueue_lazy_method_definition!(:__t_props_generated_deserialize) {generate_deserialize_source}
+    if T::Configuration.use_vm_prop_serde?
+      enqueue_lazy_vm_method_definition!(:__t_props_generated_serialize) {generate_serialize2}
+      enqueue_lazy_vm_method_definition!(:__t_props_generated_deserialize) {generate_deserialize2}
+    else
+      enqueue_lazy_method_definition!(:__t_props_generated_serialize) {generate_serialize_source}
+      enqueue_lazy_method_definition!(:__t_props_generated_deserialize) {generate_deserialize_source}
+    end
     res
   end
 
@@ -217,6 +235,18 @@ module T::Props::Serializable::DecoratorMethods
     )
   end
 
+  private def generate_serialize2
+    T::Props::Private::SerializerGenerator.generate2(decorated_class, props)
+  end
+
+  private def generate_deserialize2
+    T::Props::Private::DeserializerGenerator.generate2(
+      decorated_class,
+      props,
+      props_with_defaults || {},
+    )
+  end
+
   def message_with_generated_source_context(error, generated_method, generate_source_method)
     line_label = error.backtrace.find {|l| l.end_with?("in `#{generated_method}'")}
     return unless line_label

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.5.6382
+  version: 0.5.6391
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-20 00:00:00.000000000 Z
+date: 2021-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest