sorbet-runtime 0.5.6380 → 0.5.6389

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 49556be08ab286022f707803457534261073bd93a74f01d1426f834e960c9f7f
-  data.tar.gz: 324c158d85d372d73b785b0ca4c1058c1a74bd655ac5aa2ec5128f2b29012f76
+  metadata.gz: 0e3d0d5bfc5dcb1ca384ecbf66158041b7c083efd63b35de6bc2e17c0eeae517
+  data.tar.gz: 47dd020b8985f5cd5338d4287a3e26f89542428a85bd9bef6f818310dc308c46
 SHA512:
-  metadata.gz: 0bc3267d9e763d348f0fd131f853395b3a5890e0f5ee4bf42d3d1832433a1242c83421556d152b4b5c93600ff66cdf497522bd5d83f01e0bf6702cfa3d305cc9
-  data.tar.gz: 04d00ee175bff8c5b17bc59a6f0889b52457118694fe1e752ebd2333cf2a4412e6565db6a287a9a82e68590d22666705ea0dc2f180265ada2fa502b4260bdd54
+  metadata.gz: e8d88ddb272c2823fdd9d9f3e90d9cad2d488cd7a782a919097be4e9fdf2debf0d267c20db241bb67eb074425d9195afc87f8d130913a3addccd6877c881d242
+  data.tar.gz: cafe196e1d9d6097392c2b0d9dc19514b59e572a388ff51b0982f965018a400bce734e777b929193c3f3ff2ea9cdf038ef63b30c8fbfc3a8796e54b1ba8ad828

data/lib/types/configuration.rb

@@ -290,51 +290,6 @@ module T::Configuration
     end
   end
 
-  # Set a handler for deserialization errors
-  #
-  # These generally shouldn't stop execution of the program, but rather inform
-  # some party of the error to action on later.
-  #
-  # @param [Lambda, Proc, Object, nil] value Proc that handles the error
-  #   report (pass nil to reset to default behavior)
-  #
-  # Parameters passed to value.call:
-  #
-  # @param [Class] klass The class of the top-level object being deserialized
-  # @param [String] prop_name The name of the prop being deserialized
-  # @param [Object] value The prop value being deserialized
-  # @param [Error] orig_error The original error raised during deserialization
-  #
-  # @example
-  #   T::Configuration.deserialization_error_handler = lambda do |klass, prop_name, value, orig_error}
-  #     puts "Error deserializing #{prop_name} on #{klass}: #{orig_error.message}
-  #   end
-  def self.deserialization_error_handler=(value)
-    validate_lambda_given!(value)
-    @deserialization_error_handler = value
-  end
-
-  private_class_method def self.deserialization_error_handler_default(klass, prop_name, value, orig_error)
-    soft_assert_handler(
-      'Deserialization error (probably unexpected stored type)',
-      storytime: {
-        klass: klass,
-        prop: prop_name,
-        value: value,
-        error: orig_error.message,
-        notify: 'djudd'
-      }
-    )
-  end
-
-  def self.deserialization_error_handler(klass, prop_name, value, orig_error)
-    if @deserialization_error_handler
-      @deserialization_error_handler.call(klass, prop_name, value, orig_error)
-    else
-      deserialization_error_handler_default(klass, prop_name, value, orig_error)
-    end
-  end
-
   # Set a handler for soft assertions
   #
   # These generally shouldn't stop execution of the program, but rather inform

data/lib/types/props/generated_code_validation.rb

@@ -162,7 +162,16 @@ module T::Props
         exceptions.children.each {|c| assert_equal(:const, c.type)}
         assert_equal(:lvasgn, assignment.type)
         assert_equal([:e], assignment.children)
-        validate_lack_of_side_effects(handler, whitelisted_methods_for_deserialize)
+
+        deserialization_error, val_return = handler.children
+
+        assert_equal(:send, deserialization_error.type)
+        receiver, method, *args = deserialization_error.children
+        assert_equal(nil, receiver)
+        assert_equal(:raise_deserialization_error, method)
+        args.each {|a| validate_lack_of_side_effects(a, whitelisted_methods_for_deserialize)}
+
+        validate_lack_of_side_effects(val_return, whitelisted_methods_for_deserialize)
       else
         validate_lack_of_side_effects(else_body, whitelisted_methods_for_deserialize)
       end
@@ -261,8 +270,7 @@ module T::Props
     private_class_method def self.whitelisted_methods_for_deserialize
       @whitelisted_methods_for_deserialize ||= {
         lvar: %i{dup map transform_values transform_keys each_with_object nil? []= to_f},
-        self: %i{class},
-        const: %i[deserialize from_hash deep_clone_object deserialization_error_handler],
+        const: %i[deserialize from_hash deep_clone_object],
       }
     end
   end

data/lib/types/props/private/deserializer_generator.rb

@@ -57,8 +57,7 @@ module T::Props
               begin
                 #{transformation}
               rescue NoMethodError => e
-                T::Configuration.deserialization_error_handler(
-                  self.class,
+                raise_deserialization_error(
                   #{prop.inspect},
                   val,
                   e,

data/lib/types/props/serializable.rb

@@ -156,6 +156,19 @@ module T::Props::Serializable
     @_required_props_missing_from_deserialize << prop
     nil
   end
+
+  private def raise_deserialization_error(prop_name, value, orig_error)
+    T::Configuration.soft_assert_handler(
+      'Deserialization error (probably unexpected stored type)',
+      storytime: {
+        klass: self.class,
+        prop: prop_name,
+        value: value,
+        error: orig_error.message,
+        notify: 'djudd'
+      }
+    )
+  end
 end
 
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.5.6380
+  version: 0.5.6389
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-17 00:00:00.000000000 Z
+date: 2021-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest