sorbet-runtime 0.5.6324 → 0.5.6341

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d32edb62f9d95ef7cda78766959c2855150ad4b4b921ff7161c02a9b8ac104a2
-  data.tar.gz: fa7529bc57b5c025452a888f53722945c74e3e38e566e8ce22a665046a3ef199
+  metadata.gz: ac27b172d55e3a40caded5e635c88edeeb1620bd1ef925b9e9fa741c33e630a9
+  data.tar.gz: e36feac21c69b5cb622128fe1b33ca75a55a2f08af5daa26beb3376b632a31d7
 SHA512:
-  metadata.gz: f0f93246a969b6a474113d5f2133d39a5c1c8bfa5239cf83a931b9ce5f312b1c48f44613f0a79f144f34bdf8b5803587c6f7f86fdcd7942265f696b57a2797e2
-  data.tar.gz: bc2a8464f8fdbc79672cbe473c75da40e311a3c150181632999dbb49850e0fe4b49719ea90efc2b06f4d32536ae3db0bc6eaf984232542fc80db3ef1a64771e3
+  metadata.gz: 7c3dbac967ee74b48c6daf8287b493c6e19785f876b09a865de66e3d3f94a35361dd6b42206f4524e3c9a8b9448563fc341e2b3968ede856fc5436f97dd3c076
+  data.tar.gz: e079e875e6cd268f83721fc4283463a0330ef96e36c359280203623309861c3abfd6f3f242d130828287790e566bdfb0ff97e456c5d403bcc6ffc2b6da4507ea

data/lib/types/private/methods/_methods.rb

@@ -11,6 +11,9 @@ module T::Private::Methods
   # - they are done possibly before any sig block has run.
   # - they are done even if the method being defined doesn't have a sig.
   @final_methods = Set.new
+  # stores method names that were declared final without regard for where.
+  # enables early rejection of names that we know can't induce final method violations.
+  @was_ever_final_names = Set.new
   # a non-singleton is a module for which at least one of the following is true:
   # - is declared final
   # - defines a method that is declared final
@@ -96,13 +99,14 @@ module T::Private::Methods
   # when target includes a module with instance methods source_method_names, ensure there is zero intersection between
   # the final instance methods of target and source_method_names. so, for every m in source_method_names, check if there
   # is already a method defined on one of target_ancestors with the same name that is final.
+  #
+  # we assume that source_method_names has already been filtered to only include method
+  # names that were declared final at one point.
   def self._check_final_ancestors(target, target_ancestors, source_method_names)
-    if !module_with_final?(target)
-      return
-    end
     # use reverse_each to check farther-up ancestors first, for better error messages. we could avoid this if we were on
     # the version of ruby that adds the optional argument to method_defined? that allows you to exclude ancestors.
     target_ancestors.reverse_each do |ancestor|
+      next if !module_with_final?(ancestor)
       source_method_names.each do |method_name|
         # the usage of method_owner_and_name_to_key(ancestor, method_name) instead of
         # method_to_key(ancestor.instance_method(method_name)) is not (just) an optimization, but also required for
@@ -148,6 +152,14 @@ module T::Private::Methods
     @final_methods.include?(method_key)
   end
 
+  private_class_method def self.add_was_ever_final(method_name)
+    @was_ever_final_names.add(method_name)
+  end
+
+  private_class_method def self.was_ever_final?(method_name)
+    @was_ever_final_names.include?(method_name)
+  end
+
   def self.add_module_with_final(mod)
     @modules_with_final.add(mod)
     @modules_with_final.add(mod.singleton_class)
@@ -169,7 +181,10 @@ module T::Private::Methods
     if T::Private::Final.final_module?(mod) && (current_declaration.nil? || !current_declaration.final)
       raise "#{mod} was declared as final but its method `#{method_name}` was not declared as final"
     end
-    _check_final_ancestors(mod, mod.ancestors, [method_name])
+    # Don't compute mod.ancestors if we don't need to bother checking final-ness.
+    if was_ever_final?(method_name) && module_with_final?(mod)
+      _check_final_ancestors(mod, mod.ancestors, [method_name])
+    end
 
     # We need to fetch the active declaration again, as _check_final_ancestors
     # may have reset it (see the comment in that method for details).
@@ -229,6 +244,7 @@ module T::Private::Methods
     @sig_wrappers[key] = sig_block
     if current_declaration.final
       add_final_method(key)
+      add_was_ever_final(method_name)
       # use hook_mod, not mod, because for example, we want class C to be marked as having final if we def C.foo as
       # final. change this to mod to see some final_method tests fail.
       add_module_with_final(hook_mod)
@@ -407,13 +423,30 @@ module T::Private::Methods
 
   # the module target is adding the methods from the module source to itself. we need to check that for all instance
   # methods M on source, M is not defined on any of target's ancestors.
-  def self._hook_impl(target, target_ancestors, source)
-    if !module_with_final?(target) && !module_with_final?(source)
+  def self._hook_impl(target, singleton_class, source)
+    target_was_final = module_with_final?(target)
+    if !target_was_final && !module_with_final?(source)
       return
     end
+    # we do not need to call add_was_ever_final here, because we have already marked
+    # any such methods when source was originally defined.
     add_module_with_final(target)
     install_hooks(target)
-    _check_final_ancestors(target, target_ancestors - source.ancestors, source.instance_methods)
+
+    if !target_was_final
+      return
+    end
+
+    methods = source.instance_methods
+    methods.select! do |method_name|
+      was_ever_final?(method_name)
+    end
+    if methods.empty?
+      return
+    end
+
+    target_ancestors = singleton_class ? target.singleton_class.ancestors : target.ancestors
+    _check_final_ancestors(target, target_ancestors - source.ancestors, methods)
   end
 
   def self.set_final_checks_on_hooks(enable)
@@ -427,15 +460,15 @@ module T::Private::Methods
     else
       old_included = T::Private::ClassUtils.replace_method(Module, :included) do |arg|
         old_included.bind(self).call(arg)
-        ::T::Private::Methods._hook_impl(arg, arg.ancestors, self)
+        ::T::Private::Methods._hook_impl(arg, false, self)
       end
       old_extended = T::Private::ClassUtils.replace_method(Module, :extended) do |arg|
         old_extended.bind(self).call(arg)
-        ::T::Private::Methods._hook_impl(arg, arg.singleton_class.ancestors, self)
+        ::T::Private::Methods._hook_impl(arg, true, self)
       end
       old_inherited = T::Private::ClassUtils.replace_method(Class, :inherited) do |arg|
         old_inherited.bind(self).call(arg)
-        ::T::Private::Methods._hook_impl(arg, arg.ancestors, self)
+        ::T::Private::Methods._hook_impl(arg, false, self)
       end
       @old_hooks = [old_included, old_extended, old_inherited]
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.5.6324
+  version: 0.5.6341
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-06 00:00:00.000000000 Z
+date: 2021-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest