sorbet-runtime 0.5.6294 → 0.5.6305

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a256ee0dabdde01c3340aaa37de9f6087b07796fa1d4750e9d29e3de32984a86
-  data.tar.gz: b492eff42df0d3a3f551783d45e39273acee9336327f36e6b30f798180fae958
+  metadata.gz: b991b6d3b1e4a952f6f1b321c3a0d740dfd81ef5bd919ff0b5132cfaed853edd
+  data.tar.gz: fbbfc89a63e874c2266171e802200275da17791edc37444f1aa056071534ea50
 SHA512:
-  metadata.gz: 92c340a4a1f7497b7c4be890058eda75ecbf3b54949ab3f30412d8f8a4289b3547b9cb5db1c7285817abd3e0cb4e142c6e390309c41a25016ff45f062bcc1dc6
-  data.tar.gz: 6211f37dd7142f87ba110421240c1c02c0ac9634e9a2c43f6b0618ebb68490f94639c5cf828aaaa75a8bec5d9215f051acfce01165c4f830957843c7daad16b9
+  metadata.gz: 7c775efd5d498bcf6c0c99e833533d1091aaa1144428340cd350b74f83a336a1c1787f29d452ea9f681e12e51a62c9be37d95996200786efd9560acf79b3d806
+  data.tar.gz: fcb0323f9c22cda96c4cb2f27d1e2be305704fb74cbcbab0bdb0c03230dea2d91c3e94b78165ee8e9074b250ad0954d6c34937226d14584ae72cd2360f17ed97

data/lib/types/non_forcing_constants.rb

@@ -2,18 +2,26 @@
 # typed: strict
 
 module T::NonForcingConstants
+  T::Sig::WithoutRuntime.sig {returns(T::Boolean)}
+  private_class_method def self.stripe_packages_enabled?
+    const_defined?('StripePackages') && const_get('StripePackages').enabled?
+  end
+
   # NOTE: This method is documented on the RBI in Sorbet's payload, so that it
   # shows up in the hover/completion documentation via LSP.
   T::Sig::WithoutRuntime.sig {params(val: BasicObject, klass: String, package: T.nilable(String)).returns(T::Boolean)}
   def self.non_forcing_is_a?(val, klass, package: nil)
-    # TODO(gdritter): once we have a runtime implementation of
-    # packages, we'll need to actually handle the `package` argument
-    # here.
     method_name = "T::NonForcingConstants.non_forcing_is_a?"
     if klass.empty?
       raise ArgumentError.new("The string given to `#{method_name}` must not be empty")
     end
 
+    # TODO(gdritter): this might not be want we want in a multipackage
+    # world; revisit this implementation we move on from the monopackage
+    if stripe_packages_enabled?
+      klass = "PkgRegistry::#{package}::#{klass}"
+    end
+
     current_klass = T.let(nil, T.nilable(Module))
     current_prefix = T.let(nil, T.nilable(String))
 

data/lib/types/private/methods/call_validation.rb

@@ -47,110 +47,6 @@ module T::Private::Methods::CallValidation
     mod.instance_method(method_sig.method_name)
   end
 
-  def self.validate_call(instance, original_method, method_sig, args, blk)
-    # This method is called for every `sig`. It's critical to keep it fast and
-    # reduce number of allocations that happen here.
-
-    T::Profile.typecheck_sample_attempts -= 1
-    should_sample = T::Profile.typecheck_sample_attempts == 0
-    if should_sample
-      T::Profile.typecheck_sample_attempts = T::Profile::SAMPLE_RATE
-      T::Profile.typecheck_samples += 1
-      t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
-    end
-
-    if method_sig.bind
-      message = method_sig.bind.error_message_for_obj(instance)
-      if message
-        CallValidation.report_error(
-          method_sig,
-          message,
-          'Bind',
-          nil,
-          method_sig.bind,
-          instance
-        )
-      end
-    end
-
-    # NOTE: We don't bother validating for missing or extra kwargs;
-    # the method call itself will take care of that.
-    method_sig.each_args_value_type(args) do |name, arg, type|
-      message = type.error_message_for_obj(arg)
-      if message
-        CallValidation.report_error(
-          method_sig,
-          message,
-          'Parameter',
-          name,
-          type,
-          arg,
-          caller_offset: 2
-        )
-      end
-    end
-
-    if method_sig.block_type
-      message = method_sig.block_type.error_message_for_obj(blk)
-      if message
-        CallValidation.report_error(
-          method_sig,
-          message,
-          'Block parameter',
-          method_sig.block_name,
-          method_sig.block_type,
-          blk
-        )
-      end
-    end
-
-    if should_sample
-      T::Profile.typecheck_duration += (Process.clock_gettime(Process::CLOCK_MONOTONIC) - t1)
-    end
-
-    # The following line breaks are intentional to show nice pry message
-
-
-
-
-
-
-
-
-
-
-    # PRY note:
-    # this code is sig validation code.
-    # Please issue `finish` to step out of it
-
-    return_value = original_method.bind(instance).call(*args, &blk)
-    if should_sample
-      t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
-    end
-
-    # The only type that is allowed to change the return value is `.void`.
-    # It ignores what you returned and changes it to be a private singleton.
-    if method_sig.return_type.is_a?(T::Private::Types::Void)
-      T::Private::Types::Void::VOID
-    else
-      message = method_sig.return_type.error_message_for_obj(return_value)
-      if message
-        CallValidation.report_error(
-          method_sig,
-          message,
-          'Return value',
-          nil,
-          method_sig.return_type,
-          return_value,
-        )
-      end
-      if should_sample
-        T::Profile.typecheck_duration += (Process.clock_gettime(Process::CLOCK_MONOTONIC) - t1)
-      end
-      return_value
-    end
-  end
-
   @is_allowed_to_have_fast_path = true
   def self.is_allowed_to_have_fast_path
     @is_allowed_to_have_fast_path
@@ -169,9 +65,9 @@ module T::Private::Methods::CallValidation
 
     T::Configuration.without_ruby_warnings do
       T::Private::DeclState.current.without_on_method_added do
-        if has_fixed_arity && has_simple_method_types && method_sig.arg_types.length < 5 && is_allowed_to_have_fast_path
+        if has_fixed_arity && has_simple_method_types && !method_sig.bind && method_sig.arg_types.length < 5 && is_allowed_to_have_fast_path
           create_validator_method_fast(mod, original_method, method_sig)
-        elsif has_fixed_arity && has_simple_procedure_types && method_sig.arg_types.length < 5 && is_allowed_to_have_fast_path
+        elsif has_fixed_arity && has_simple_procedure_types && !method_sig.bind && method_sig.arg_types.length < 5 && is_allowed_to_have_fast_path
           create_validator_procedure_fast(mod, original_method, method_sig)
         else
           create_validator_slow(mod, original_method, method_sig)
@@ -181,15 +77,6 @@ module T::Private::Methods::CallValidation
     mod.send(original_visibility, method_sig.method_name)
   end
 
-  def self.create_validator_slow(mod, original_method, method_sig)
-    mod.send(:define_method, method_sig.method_name) do |*args, &blk|
-      CallValidation.validate_call(self, original_method, method_sig, args, blk)
-    end
-    if mod.respond_to?(:ruby2_keywords, true)
-      mod.send(:ruby2_keywords, method_sig.method_name)
-    end
-  end
-
   def self.create_validator_method_fast(mod, original_method, method_sig)
     if method_sig.return_type.is_a?(T::Private::Types::Void)
       raise "Should have used create_validator_procedure_fast"
@@ -233,20 +120,6 @@ module T::Private::Methods::CallValidation
         t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       end
 
-      if method_sig.bind
-        message = method_sig.bind.error_message_for_obj(self)
-        if message
-          CallValidation.report_error(
-            method_sig,
-            message,
-            'Bind',
-            nil,
-            method_sig.bind,
-            self
-          )
-        end
-      end
-
       if should_sample
         T::Profile.typecheck_duration += (Process.clock_gettime(Process::CLOCK_MONOTONIC) - t1)
       end
@@ -306,20 +179,6 @@ module T::Private::Methods::CallValidation
         t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       end
 
-      if method_sig.bind
-        message = method_sig.bind.error_message_for_obj(self)
-        if message
-          CallValidation.report_error(
-            method_sig,
-            message,
-            'Bind',
-            nil,
-            method_sig.bind,
-            self
-          )
-        end
-      end
-
       unless arg0.is_a?(arg0_type)
         CallValidation.report_error(
           method_sig,
@@ -391,20 +250,6 @@ module T::Private::Methods::CallValidation
         t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       end
 
-      if method_sig.bind
-        message = method_sig.bind.error_message_for_obj(self)
-        if message
-          CallValidation.report_error(
-            method_sig,
-            message,
-            'Bind',
-            nil,
-            method_sig.bind,
-            self
-          )
-        end
-      end
-
       unless arg0.is_a?(arg0_type)
         CallValidation.report_error(
           method_sig,
@@ -488,20 +333,6 @@ module T::Private::Methods::CallValidation
         t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       end
 
-      if method_sig.bind
-        message = method_sig.bind.error_message_for_obj(self)
-        if message
-          CallValidation.report_error(
-            method_sig,
-            message,
-            'Bind',
-            nil,
-            method_sig.bind,
-            self
-          )
-        end
-      end
-
       unless arg0.is_a?(arg0_type)
         CallValidation.report_error(
           method_sig,
@@ -598,20 +429,6 @@ module T::Private::Methods::CallValidation
         t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       end
 
-      if method_sig.bind
-        message = method_sig.bind.error_message_for_obj(self)
-        if message
-          CallValidation.report_error(
-            method_sig,
-            message,
-            'Bind',
-            nil,
-            method_sig.bind,
-            self
-          )
-        end
-      end
-
       unless arg0.is_a?(arg0_type)
         CallValidation.report_error(
           method_sig,
@@ -747,20 +564,6 @@ module T::Private::Methods::CallValidation
         t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       end
 
-      if method_sig.bind
-        message = method_sig.bind.error_message_for_obj(self)
-        if message
-          CallValidation.report_error(
-            method_sig,
-            message,
-            'Bind',
-            nil,
-            method_sig.bind,
-            self
-          )
-        end
-      end
-
       if should_sample
         T::Profile.typecheck_duration += (Process.clock_gettime(Process::CLOCK_MONOTONIC) - t1)
       end
@@ -800,20 +603,6 @@ module T::Private::Methods::CallValidation
         t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       end
 
-      if method_sig.bind
-        message = method_sig.bind.error_message_for_obj(self)
-        if message
-          CallValidation.report_error(
-            method_sig,
-            message,
-            'Bind',
-            nil,
-            method_sig.bind,
-            self
-          )
-        end
-      end
-
       unless arg0.is_a?(arg0_type)
         CallValidation.report_error(
           method_sig,
@@ -863,20 +652,6 @@ module T::Private::Methods::CallValidation
         t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       end
 
-      if method_sig.bind
-        message = method_sig.bind.error_message_for_obj(self)
-        if message
-          CallValidation.report_error(
-            method_sig,
-            message,
-            'Bind',
-            nil,
-            method_sig.bind,
-            self
-          )
-        end
-      end
-
       unless arg0.is_a?(arg0_type)
         CallValidation.report_error(
           method_sig,
@@ -939,20 +714,6 @@ module T::Private::Methods::CallValidation
         t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       end
 
-      if method_sig.bind
-        message = method_sig.bind.error_message_for_obj(self)
-        if message
-          CallValidation.report_error(
-            method_sig,
-            message,
-            'Bind',
-            nil,
-            method_sig.bind,
-            self
-          )
-        end
-      end
-
       unless arg0.is_a?(arg0_type)
         CallValidation.report_error(
           method_sig,
@@ -1028,20 +789,6 @@ module T::Private::Methods::CallValidation
         t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       end
 
-      if method_sig.bind
-        message = method_sig.bind.error_message_for_obj(self)
-        if message
-          CallValidation.report_error(
-            method_sig,
-            message,
-            'Bind',
-            nil,
-            method_sig.bind,
-            self
-          )
-        end
-      end
-
       unless arg0.is_a?(arg0_type)
         CallValidation.report_error(
           method_sig,
@@ -1114,6 +861,119 @@ module T::Private::Methods::CallValidation
     end
   end
 
+  def self.create_validator_slow(mod, original_method, method_sig)
+    mod.send(:define_method, method_sig.method_name) do |*args, &blk|
+      CallValidation.validate_call(self, original_method, method_sig, args, blk)
+    end
+    if mod.respond_to?(:ruby2_keywords, true)
+      mod.send(:ruby2_keywords, method_sig.method_name)
+    end
+  end
+
+  def self.validate_call(instance, original_method, method_sig, args, blk)
+    # This method is called for every `sig`. It's critical to keep it fast and
+    # reduce number of allocations that happen here.
+
+    T::Profile.typecheck_sample_attempts -= 1
+    should_sample = T::Profile.typecheck_sample_attempts == 0
+    if should_sample
+      T::Profile.typecheck_sample_attempts = T::Profile::SAMPLE_RATE
+      T::Profile.typecheck_samples += 1
+      t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+    end
+
+    if method_sig.bind
+      message = method_sig.bind.error_message_for_obj(instance)
+      if message
+        CallValidation.report_error(
+          method_sig,
+          message,
+          'Bind',
+          nil,
+          method_sig.bind,
+          instance
+        )
+      end
+    end
+
+    # NOTE: We don't bother validating for missing or extra kwargs;
+    # the method call itself will take care of that.
+    method_sig.each_args_value_type(args) do |name, arg, type|
+      message = type.error_message_for_obj(arg)
+      if message
+        CallValidation.report_error(
+          method_sig,
+          message,
+          'Parameter',
+          name,
+          type,
+          arg,
+          caller_offset: 2
+        )
+      end
+    end
+
+    if method_sig.block_type
+      message = method_sig.block_type.error_message_for_obj(blk)
+      if message
+        CallValidation.report_error(
+          method_sig,
+          message,
+          'Block parameter',
+          method_sig.block_name,
+          method_sig.block_type,
+          blk
+        )
+      end
+    end
+
+    if should_sample
+      T::Profile.typecheck_duration += (Process.clock_gettime(Process::CLOCK_MONOTONIC) - t1)
+    end
+
+    # The following line breaks are intentional to show nice pry message
+
+
+
+
+
+
+
+
+
+
+    # PRY note:
+    # this code is sig validation code.
+    # Please issue `finish` to step out of it
+
+    return_value = original_method.bind(instance).call(*args, &blk)
+    if should_sample
+      t1 = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+    end
+
+    # The only type that is allowed to change the return value is `.void`.
+    # It ignores what you returned and changes it to be a private singleton.
+    if method_sig.return_type.is_a?(T::Private::Types::Void)
+      T::Private::Types::Void::VOID
+    else
+      message = method_sig.return_type.error_message_for_obj(return_value)
+      if message
+        CallValidation.report_error(
+          method_sig,
+          message,
+          'Return value',
+          nil,
+          method_sig.return_type,
+          return_value,
+        )
+      end
+      if should_sample
+        T::Profile.typecheck_duration += (Process.clock_gettime(Process::CLOCK_MONOTONIC) - t1)
+      end
+      return_value
+    end
+  end
+
   def self.report_error(method_sig, error_message, kind, name, type, value, caller_offset: 0)
     caller_loc = T.must(caller_locations(3 + caller_offset, 1))[0]
     definition_file, definition_line = method_sig.method.source_location

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.5.6294
+  version: 0.5.6305
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-20 00:00:00.000000000 Z
+date: 2021-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest