sorbet-runtime 0.5.5403 → 0.5.5406

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f473428349c55b787d0d32060bf8a78448adf9a1133f0c8e20f817b83e7d4c58
-  data.tar.gz: 434b145981f510ef0148a270ec5227fcfb8d1c741e4e9eb26ebf0ebc1e665c96
+  metadata.gz: eae0cc4b7fdb52047e84a290e7b7cd213cdc65e695367520f0b6f20812ae2a11
+  data.tar.gz: 760c82af2b52574b6de71ac9871e34b6086cd0938d285e84840ded2deabf370b
 SHA512:
-  metadata.gz: 9de7bf33a67fb9f5dbdb430138eae9ebbcfe2ecda211419728948f7f8095cc26ca97927886fc23378a24da62e0324480101e4ea9a153e4b0e45e3b97fda3cd44
-  data.tar.gz: 15b30b2ea60102d219e53d774aea7bfc56277bee5616a5a24f3bb47a774a6ec8e9cf02c6addadc390e8a40cec86619e69aa319f0b8086ad2236209e895405b62
+  metadata.gz: fe8068bf43f3a19b01697898272ac24fe375a908f72aeeaffc57be2863bfde26ed19f5ce2d9b7da7d2de8d1d4b3f9805685507ef1020035e1f3339a7406407f9
+  data.tar.gz: 1fe68bcff353ed2ba795b315382fbb3262664c87134f6a68bb34ff6e375c9334efbb4fb20df31677135fd1fc92e8ae2b7210be0bd1f99f2c5eeb70b8fb5d6578

data/lib/types/props/decorator.rb

@@ -429,7 +429,7 @@ class T::Props::Decorator
     end
 
     handle_foreign_option(name, cls, rules, rules[:foreign]) if rules[:foreign]
-    handle_foreign_hint_only_option(cls, rules[:foreign_hint_only]) if rules[:foreign_hint_only]
+    handle_foreign_hint_only_option(name, cls, rules[:foreign_hint_only]) if rules[:foreign_hint_only]
     handle_redaction_option(name, rules[:redaction]) if rules[:redaction]
   end
 
@@ -636,12 +636,13 @@ class T::Props::Decorator
 
   sig do
     params(
+      prop_name: Symbol,
       prop_cls: Module,
       foreign_hint_only: T.untyped,
     )
     .void
   end
-  private def handle_foreign_hint_only_option(prop_cls, foreign_hint_only)
+  private def handle_foreign_hint_only_option(prop_name, prop_cls, foreign_hint_only)
     if ![String, Array].include?(prop_cls) && !(prop_cls.is_a?(T::Props::CustomType))
       raise ArgumentError.new(
         "`foreign_hint_only` can only be used with String or Array prop types"
@@ -652,6 +653,21 @@ class T::Props::Decorator
       :foreign_hint_only, foreign_hint_only,
       valid_type_msg: "an individual or array of a model class, or a Proc returning such."
     )
+
+    unless foreign_hint_only.is_a?(Proc)
+      T::Configuration.soft_assert_handler(<<~MESSAGE, storytime: {prop: prop_name, value: foreign_hint_only}, notify: 'jerry')
+        Please use a Proc that returns a model class instead of the model class itself as the argument to `foreign_hint_only`. In other words:
+
+          instead of `prop :foo, String, foreign_hint_only: FooModel`
+          use `prop :foo, String, foreign_hint_only: -> {FooModel}`
+
+          OR
+
+          instead of `prop :foo, String, foreign_hint_only: [FooModel, BarModel]`
+          use `prop :foo, String, foreign_hint_only: -> {[FooModel, BarModel]}`
+
+      MESSAGE
+    end
   end
 
   # checked(:never) - Rules hash is expensive to check
@@ -745,6 +761,16 @@ class T::Props::Decorator
       )
     end
 
+    unless foreign.is_a?(Proc)
+      T::Configuration.soft_assert_handler(<<~MESSAGE, storytime: {prop: prop_name, value: foreign}, notify: 'jerry')
+        Please use a Proc that returns a model class instead of the model class itself as the argument to `foreign`. In other words:
+
+          instead of `prop :foo, String, foreign: FooModel`
+          use `prop :foo, String, foreign: -> {FooModel}`
+
+      MESSAGE
+    end
+
     define_foreign_method(prop_name, rules, foreign)
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.5.5403
+  version: 0.5.5406
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-28 00:00:00.000000000 Z
+date: 2020-02-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest