sorbet-runtime 0.5.5284 → 0.5.5316

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6570883296df2b8c2f0f18bd126c932daeac62effd65b35544f04c5b467a66a2
-  data.tar.gz: 43f95a4fdd8d83076f72d3094438995b05440d222d487a67c20b328745eecc13
+  metadata.gz: 96ac3f40e289c8880e546f48cc793e4e12461e713ac5a6d5daf9777d91af2774
+  data.tar.gz: 425ccca3f410868f357385eba3bbf0e8cc9cdd4b2cdc252137b0da96b36d5002
 SHA512:
-  metadata.gz: 26308242fd0d09ba1585594cf116150ed3a3112c503e4f11ee96a3301450a9cf7742729200c8a4652d28a6b166eca32dd1c6e766c6a16099b6c403d67006c45b
-  data.tar.gz: c5e8e54c724a32857f50642cd18400a0886e66a33cc5a84ddc68d75919ebc576e5d7bd52365919f69b5a653591dced8c5566223fa375071af8ae3cd75f02297f
+  metadata.gz: 28df096a88491a837b89157f6b3fb2a779d0e61729e0c9363740a9fa8ddef7d23156f0c910fcc0b9569daba0826dfef9e22441bb82718872923a444c09b9536c
+  data.tar.gz: cae44a94689f106188a491200eccf8b0da90e61ce2b089f79dbf8bcbb0ac4c486c9a10934f3647762aa3c179df677bfeee571665e1154b5929ebb8275ed3d7cf

data/lib/types/private/sealed.rb

@@ -55,7 +55,7 @@ module T::Private::Sealed
 
     if !this_file.start_with?(decl_file)
       whitelist = T::Configuration.sealed_violation_whitelist
-      if whitelist != nil && whitelist.any? {|pattern| decl_file =~ pattern}
+      if whitelist != nil && whitelist.any? {|pattern| this_file =~ pattern}
         return
       end
 

data/lib/types/props/decorator.rb

@@ -33,15 +33,6 @@ class T::Props::Decorator
   sig {returns(T::Hash[Symbol, Rules]).checked(:never)}
   attr_reader :props
 
-  # Try to avoid using this; post-definition mutation of prop rules is
-  # surprising and hard to reason about.
-  sig {params(prop: Symbol, key: Symbol, value: T.untyped).void}
-  def mutate_prop_backdoor!(prop, key, value)
-    @props = props.merge(
-      prop => props.fetch(prop).merge(key => value).freeze
-    ).freeze
-  end
-
   sig {returns(T::Array[Symbol])}
   def all_props; props.keys; end
 
@@ -91,25 +82,6 @@ class T::Props::Decorator
 
   # Accessors
 
-  # For performance, don't use named params here.
-  # Passing in rules here is purely a performance optimization.
-  #
-  # checked(:never) - O(prop accesses)
-  sig do
-    params(
-      instance: DecoratedInstance,
-      prop: T.any(String, Symbol),
-      rules: T.nilable(Rules)
-    )
-    .returns(T.untyped)
-    .checked(:never)
-  end
-  def get(instance, prop, rules=props[prop.to_sym])
-    # For backwards compatibility, fall back to reconstructing the accessor key
-    # (though it would probably make more sense to raise in that case).
-    instance.instance_variable_get(rules ? rules[:accessor_key] : '@' + prop.to_s) # rubocop:disable PrisonGuard/NoLurkyInstanceVariableAccess
-  end
-
   # Use this to validate that a value will validate for a given prop. Useful for knowing whether a value can be set on a model without setting it.
   #
   # checked(:never) - potentially O(prop accesses) depending on usage pattern
@@ -157,20 +129,17 @@ class T::Props::Decorator
     params(
       instance: DecoratedInstance,
       prop: T.any(String, Symbol),
-      rules: T.nilable(Rules)
+      rules: Rules
     )
     .returns(T.untyped)
     .checked(:never)
   end
-  def prop_get(instance, prop, rules=props[prop.to_sym])
-    val = get(instance, prop, rules)
-
+  def prop_get(instance, prop, rules=prop_rules(prop))
+    val = instance.instance_variable_get(rules[:accessor_key])
     if !val.nil?
       val
     else
-      raise NoRulesError.new if !rules
-      d = rules[:ifunset]
-      if d
+      if (d = rules[:ifunset])
         T::Props::Utils.deep_clone_object(d)
       else
         nil
@@ -178,6 +147,20 @@ class T::Props::Decorator
     end
   end
 
+  sig do
+    params(
+      instance: DecoratedInstance,
+      prop: T.any(String, Symbol),
+      rules: Rules
+    )
+    .returns(T.untyped)
+    .checked(:never)
+  end
+  def prop_get_if_set(instance, prop, rules=prop_rules(prop))
+    instance.instance_variable_get(rules[:accessor_key])
+  end
+  alias_method :get, :prop_get_if_set # Alias for backwards compatibility
+
   # checked(:never) - O(prop accesses)
   sig do
     params(
@@ -246,9 +229,10 @@ class T::Props::Decorator
     nil
   end
 
-  sig {params(name: Symbol).void}
+  # Used to validate both prop names and serialized forms
+  sig {params(name: T.any(Symbol, String)).void}
   private def validate_prop_name(name)
-    if name !~ /\A[A-Za-z_][A-Za-z0-9_-]*\z/
+    if !name.match?(/\A[A-Za-z_][A-Za-z0-9_-]*\z/)
       raise ArgumentError.new("Invalid prop name in #{@class.name}: #{name}")
     end
   end

data/lib/types/props/optional.rb

@@ -34,13 +34,6 @@ module T::Props::Optional::DecoratorMethods
 
   def prop_optional?(prop); prop_rules(prop)[:fully_optional]; end
 
-  def mutate_prop_backdoor!(prop, key, value)
-    rules = props.fetch(prop)
-    rules = rules.merge(key => value)
-    compute_derived_rules(rules)
-    @props = props.merge(prop => rules.freeze).freeze
-  end
-
   def compute_derived_rules(rules)
     rules[:fully_optional] = !T::Props::Utils.need_nil_write_check?(rules)
     rules[:need_nil_read_check] = T::Props::Utils.need_nil_read_check?(rules)

data/lib/types/props/serializable.rb

@@ -344,7 +344,7 @@ module T::Props::Serializable::DecoratorMethods
   private_constant :EMPTY_EXTRA_PROPS
 
   def extra_props(instance)
-    get(instance, '_extra_props') || EMPTY_EXTRA_PROPS
+    instance.instance_variable_get(:@_extra_props) || EMPTY_EXTRA_PROPS
   end
 
   # @override T::Props::PrettyPrintable

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.5.5284
+  version: 0.5.5316
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-25 00:00:00.000000000 Z
+date: 2020-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest