sorbet-runtime 0.5.5207 → 0.5.5213

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d08a775098ed6f7c1b9f0f9e55646a42cbe887ff207a5f6611ecbe4b50cc0f4
-  data.tar.gz: 22747dc67dfe8060b4d8539b628599236bcc88f94f47852316fd35510f4d37a5
+  metadata.gz: bd7c2c5d45d883ad4e220fc3203d9ef80dc3e8107f9871335db7aaa4c9a9a40f
+  data.tar.gz: 4966f2a48e6c729c45030c5f375ad5f835709349dcc1c8ea7e69a5c242d06293
 SHA512:
-  metadata.gz: c0a09c3e6522b1d41d8d721eb7926ba3e59d27519ffd9507c4d4d0320f5f6d8b2c7f6612e1a487a881362be4e81c16f28af648c1e1dc267fb72ba4c4b0e1c341
-  data.tar.gz: 7eb1be39c4d7363c601fcd69cdc40e01aa800df6330dd39dad7ad960d9dc9bcea73d029e23574dfb4fb7d620c1a4746bb5a7e9ac56cd7877df7bb0693f82387a
+  metadata.gz: d73323f743b97181769e7973f3ad3942dec32822ea7e5e04870a5a3639f800cf3a21dd0a34f88ded31a1d22acae114b0e24987110a6cf781c56676cd63a9ee48
+  data.tar.gz: f0a09a571797e982ee13316799c1886824a97a47efc1c795d843740ab1c8990c4af3fe746e22918e24beb7675eab0f09c62f358e0f199cbbc6884e8a5975c238

data/lib/types/props/decorator.rb

@@ -201,6 +201,9 @@ class T::Props::Decorator
 
   # For performance, don't use named params here.
   # Passing in rules here is purely a performance optimization.
+  #
+  # Note this path is NOT used by generated getters on instances,
+  # unless `ifunset` is used on the prop, or `prop_get` is overridden.
   sig do
     params(
       instance: DecoratedInstance,
@@ -213,15 +216,7 @@ class T::Props::Decorator
   def prop_get(instance, prop, rules=props[prop.to_sym])
     val = get(instance, prop, rules)
 
-    # NB: Do NOT change this to check `val.nil?` instead. BSON::ByteBuffer overrides `==` such
-    # that `== nil` can return true while `.nil?` returns false. Tests will break in mysterious
-    # ways. A special thanks to Ruby for enabling this type of bug.
-    #
-    # One side effect here is that _if_ a class (like BSON::ByteBuffer) defines ==
-    # in such a way that instances which are not `nil`, ie are not NilClass, nevertheless
-    # are `== nil`, then we will transparently convert such instances to `nil` on read.
-    # Yes, our code relies on this behavior (as of writing). :thisisfine:
-    if val != nil # rubocop:disable Style/NonNilCheck
+    if !val.nil?
       val
     else
       raise NoRulesError.new if !rules
@@ -510,8 +505,13 @@ class T::Props::Decorator
         end
       end
 
-      @class.send(:define_method, name) do
-        self.class.decorator.prop_get(self, name, rules)
+      if method(:prop_get).owner != T::Props::Decorator || rules.key?(:ifunset)
+        @class.send(:define_method, name) do
+          self.class.decorator.prop_get(self, name, rules)
+        end
+      else
+        # Fast path (~30x faster as of Ruby 2.6)
+        @class.attr_reader(name)
       end
     end
   end
@@ -811,6 +811,23 @@ class T::Props::Decorator
       # time. Any class that defines props and also overrides the `decorator_class` method is going
       # to reach this line before its override take effect, turning it into a no-op.
       child.decorator.add_prop_definition(name, copied_rules)
+
+      # It's a bit tricky to support `prop_get` hooks added by plugins without
+      # sacrificing the `attr_reader` fast path or clobbering customized getters
+      # defined manually on a child.
+      #
+      # To make this work, we _do_ clobber getters defined on the child, but only if:
+      # (a) it's needed in order to support a `prop_get` hook, and
+      # (b) it's safe because the getter was defined by this file.
+      #
+      unless rules[:without_accessors]
+        if child.decorator.method(:prop_get).owner != method(:prop_get).owner &&
+            child.instance_method(name).source_location.first == __FILE__
+          child.send(:define_method, name) do
+            self.class.decorator.prop_get(self, name, rules)
+          end
+        end
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.5.5207
+  version: 0.5.5213
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-07 00:00:00.000000000 Z
+date: 2020-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest