sorbet-runtime 0.4.4331 → 0.4.4355

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23fe6d1adf71c97852b2e1bd12133d79212b7855
-  data.tar.gz: f4ba79a25eb179f3aeba3a0c758876c363a3dc3c
+  metadata.gz: c20d0628aa85a684b88e4737a8e717fe91a7f15d
+  data.tar.gz: a5af90068a95344d3beeac78c6ad8d3ba334ad88
 SHA512:
-  metadata.gz: cec9cff7dcb4ef500914a038bf009180436bdecb607d6eedbf2c6692a6267360f8b0c48e90b5cd70c0b667761d6ad2db4e8e583bdd40bdb16043bc1122d45e23
-  data.tar.gz: b9dda89def4e0ea5e5dd33e4393b93999a8226f788a9080a5ffbd689df880990ec290e01c843fcf7eee336c6ec466984811cb0d32abc21cad03fe2a635bd6880
+  metadata.gz: 85dd318b56ab855f315742cbd5e3ea380990aa6a377be7d6fee40f0ac7fa5ac8f388abfb51fa0b2aea8af0c89c7df15857983bd3c799f281ccf7b20557832c4b
+  data.tar.gz: 3f8f068484b137a255cf122a5e94c36799410d4207f352e6ba881d7cd1d58b9f11d2f7b52a6f32cee52fa41cd69c40d2fa60f0cec75c538582c01e39e5a476d0

data/lib/types/_types.rb

@@ -178,6 +178,9 @@ module T
   #
   # sig {params(arg: T.nilable(A), msg: T.nilable(String)).returns(A)}
   def self.must(arg, msg=nil)
+    return arg if arg
+    return arg if arg == false
+
     begin
       if msg
         if !T.unsafe(msg).is_a?(String)
@@ -186,11 +189,9 @@ module T
       else
         msg = "Passed `nil` into T.must"
       end
-      raise TypeError.new(msg) if arg.nil?
-      arg
+      raise TypeError.new(msg)
     rescue TypeError => e # raise into rescue to ensure e.backtrace is populated
       T::Private::ErrorHandler.handle_inline_type_error(e)
-      arg
     end
   end
 

data/lib/types/configuration.rb

@@ -175,14 +175,7 @@ module T::Configuration
   end
 
   private_class_method def self.call_validation_error_handler_default(signature, opts)
-    method_file, method_line = signature.method.source_location
-    location = opts[:location]
-
-    error_message = "#{opts[:kind]}#{opts[:name] ? " '#{opts[:name]}'" : ''}: #{opts[:message]}\n" \
-      "Caller: #{location.path}:#{location.lineno}\n" \
-      "Definition: #{method_file}:#{method_line}"
-
-    raise TypeError.new(error_message)
+    raise TypeError.new(opts[:pretty_message])
   end
 
   def self.call_validation_error_handler(signature, opts)

data/lib/types/private/methods/call_validation.rb

@@ -1150,10 +1150,16 @@ module T::Private::Methods::CallValidation
   def self.report_error(method_sig, error_message, kind, name, type, value, caller_offset: 0)
     method_sig.mark_failed
     caller_loc = T.must(caller_locations(3 + caller_offset, 1))[0]
+    definition_file, definition_line = method_sig.method.source_location
+
+    pretty_message = "#{kind}#{name ? " '#{name}'" : ''}: #{error_message}\n" \
+      "Caller: #{caller_loc.path}:#{caller_loc.lineno}\n" \
+      "Definition: #{definition_file}:#{definition_line}"
 
     T::Private::ErrorHandler.handle_call_validation_error(
       method_sig,
       message: error_message,
+      pretty_message: pretty_message,
       kind: kind,
       name: name,
       type: type,

data/lib/types/private/methods/decl_builder.rb

@@ -131,9 +131,6 @@ module T::Private::Methods
     end
 
     def generated
-      if T.unsafe(true)
-        raise "The .generated API is unstable, so we don't want it used until we redesign it. To change Sorbet's runtime behavior, see https://sorbet.org/docs/tconfiguration"
-      end
       check_live!
 
       if !decl.generated.equal?(ARG_NOT_PROVIDED)

data/lib/types/runtime_profiled.rb

@@ -2,35 +2,23 @@
 # frozen_string_literal: true
 
 #
-# Hey there!
+# From the static system, T::Utils::RuntimeProfiled is T.untyped.
 #
-# T::Utils::Runtime is just a random class. Chances are[^1] it's not a class
-# that your variables are instances of, which means that using it in a type
-# signature will always create a type error.
+# But from the runtime system, it's a random class (specifically, a class that
+# normal programs currently don't have any instances of).
 #
-# At first, it doesn't seem like a good thing to have a type that's sole
-# purpose is to cause type errors. The trick is that within the ruby-types
-# team, we only use T::Utils::RuntimeProfiled within 'generated' sigs.
+# Thus, T::Utils::RuntimeProfiled can be used to introduce runtime-only type
+# errors. This seems like a bad idea, but it's not. It can be used to gather
+# runtime type information from running code via a custom T::Configuration
+# handler.
 #
-# Unlike normal sigs, generated sigs never raise at runtime. They also log the
-# actual, observed type on type error to a central location. We're using these
-# observed types to refine and expand our type coverage in pay-server.
+# This process has only ever been used at Stripe, and is likely to have rough
+# edges. If you've managed to find your way here and you're curious to try it,
+# please chat with us on Slack. There are no docs.
 #
-# What does this all mean for you?
-#
-# - If you were just curious, that's it! Leave the sig as is, and carry on.
-# - If you wanted to replace this sig with a better, hand-authored one:
-#
-#   1. Remove 'generated' from the sig.
-#   2. Update the sig to your liking
-#
-# Questions? :portal-to: => #ruby-types
-#
-# [^1]: Unless you happen to be calling T::Utils::RuntimeProfiled.new directly...
+# See also: the --suggest-runtime-profiled flag to sorbet.
 #
 
 module T; end
 module T::Utils; end
-# Sorbet guesses this type instead of T.untyped when passed --suggest-runtime-profiled
-
 class T::Utils::RuntimeProfiled; end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.4.4331
+  version: 0.4.4355
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-27 00:00:00.000000000 Z
+date: 2019-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest