sorbet-rails 0.7.27 → 0.7.31

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e80eb4263d607a23eec096f9751339d944226b2feb2c1bc52ece8d2b7531128
-  data.tar.gz: df11889efd6ebcddc194293ba868e80d9a2b1e88d4783d10aeb954a99a1e1422
+  metadata.gz: 8c8486bf0c5537443c859e1f51c4aebd3e62bd16370f78526a4f2e879b148c81
+  data.tar.gz: ffd9da9622e74e186ae94eb9547da174df0e86e294373b06bbdf4caf4d71736f
 SHA512:
-  metadata.gz: 04f2af9fb19e21bf584686158e874a33553551226e5c926d497f8c981199226a63d80f46e8b6badba42e6198508bb593a89d8a619849c4d71319c858dfea01ed
-  data.tar.gz: 0e14167c972be954efa22d1955dbb36938a73199f094c698a69759727eb95961b0a46e31a1a2b6d3bd3d9bb07cc60f3f16a755ae4c08e80f25f08fa2f4d713b8
+  metadata.gz: e9b9d08940d9c0c82984326439fd8c310955e6c3c59a1b6ed01c46c5ab05ca71680e9627f0bef456942ad2c08430d216ad969a0506c2478c0fec5863a3bb3d32
+  data.tar.gz: 82f9e89b908de82b1a63f02f60cef7aea5ded0108c2717b3e3aa1ee0ac2ee534476327fb5483a155d98d95f9f35640534ce133a2b017daf31797844725a91138

data/.github/workflows/ci-master.yml

@@ -4,6 +4,8 @@ on:
   push:
     branches: # Trigger only on the main branch to avoid duplicate runs on PR branches
       - master
+  schedule: # trigger once a week to ensure that CI works even after dependent gem updates
+    - cron: 0 0 * * 1
 
 jobs:
   rspec:

data/README.md

@@ -365,6 +365,7 @@ Following are the list of attribute dynamic methods and their static counterpart
 - `<attribute>_was` -> `attribute_was(<attribute>)`
 - `saved_change_to_<attribute>?` -> `saved_change_to_attribute?(<attribute>)`
 - `<attribute>_before_type_cast` -> `read_attribute_before_type_cast(<attribute>)`
+- `will_save_change_to_<attribute>?` -> `will_save_change_to_attribute?(<attribute>)`
 
 ### `after_commit` and other callbacks
 

data/lib/sorbet-rails/gem_plugins/aasm_plugin.rb

@@ -38,13 +38,18 @@ class AasmPlugin < SorbetRails::ModelPlugins::Base
       )
     end
 
-    # - If you have a state like :baz, you get these methods:
-    # - `baz?`
+    # - If you have a state like :baz, you get:
+    # - a method `baz?`
+    # - a constant `STATE_BAZ`
     aasm_states.each do |state|
       model_rbi.create_method(
         "#{state}?",
         return_type: 'T::Boolean'
       )
+
+      root.create_module(
+        "#{model_class_name}::STATE_#{state.to_s.upcase}"
+      )
     end
   end
 end

data/lib/sorbet-rails/model_column_utils.rb

@@ -17,7 +17,7 @@ module SorbetRails::ModelColumnUtils
       type = base_type.to_s
       # A nullable array column should be T.nilable(T::Array[column_type]) not T::Array[T.nilable(column_type)]
       type = "T::Array[#{type}]" if array_type
-      type = "T.nilable(#{type})" if nilable
+      type = "T.nilable(#{type})" if nilable && type != "T.untyped"
       type
     end
   end

data/lib/sorbet-rails/model_plugins/active_record_assoc.rb

@@ -34,7 +34,7 @@ class SorbetRails::ModelPlugins::ActiveRecordAssoc < SorbetRails::ModelPlugins::
   def populate_single_assoc_getter_setter(assoc_module_rbi, assoc_name, reflection)
     # TODO allow people to specify the possible values of polymorphic associations
     assoc_class = assoc_should_be_untyped?(reflection) ? "T.untyped" : "::#{reflection.klass.name}"
-    assoc_type = (belongs_to_and_required?(reflection) || has_one_and_required?(reflection)) ? assoc_class : "T.nilable(#{assoc_class})"
+    assoc_type = (belongs_to_and_required?(reflection) || has_one_and_required?(reflection) || assoc_class == "T.untyped") ? assoc_class : "T.nilable(#{assoc_class})"
 
     params = [
       Parameter.new("*args", type: "T.untyped"),

data/spec/sorbet_spec.rb

@@ -63,6 +63,9 @@ RSpec.describe 'sorbet' do
     # run sorbet-rails rake tasks
     Rake::Task['rails_rbi:all'].invoke
 
+    # ensure we remove sorbet-rails.rbi as there are conflicts which cause srb tc to fail
+    FileUtils.rm_f(Rails.root.join('sorbet/rbi/gems/sorbet-rails.rbi'))
+
     # Regenerate hidden-definitions because there might be conflicts between signature
     # generated by sorbet-rails & by hidden-definitions
     # They should be resolved when re-running this script

data/spec/test_data/v5.2/expected_wizard_wo_spellbook.rbi

@@ -287,7 +287,7 @@ module Wizard::GeneratedAssociationMethods
   sig { params(value: T::Enumerable[::ActiveStorage::Blob]).void }
   def hats_blobs=(value); end
 
-  sig { returns(T.nilable(T.untyped)) }
+  sig { returns(T.untyped) }
   def school; end
 
   sig { params(args: T.untyped, block: T.nilable(T.proc.params(object: T.untyped).void)).returns(T.untyped) }
@@ -299,10 +299,10 @@ module Wizard::GeneratedAssociationMethods
   sig { params(args: T.untyped, block: T.nilable(T.proc.params(object: T.untyped).void)).returns(T.untyped) }
   def create_school!(*args, &block); end
 
-  sig { params(value: T.nilable(T.untyped)).void }
+  sig { params(value: T.untyped).void }
   def school=(value); end
 
-  sig { returns(T.nilable(T.untyped)) }
+  sig { returns(T.untyped) }
   def reload_school; end
 
   sig { returns(T.nilable(::ActiveStorage::Attachment)) }

data/spec/test_data/v6.0/expected_wizard_wo_spellbook.rbi

@@ -1134,7 +1134,7 @@ module Wizard::GeneratedAssociationMethods
   sig { params(value: T::Enumerable[::ActiveStorage::Blob]).void }
   def hats_blobs=(value); end
 
-  sig { returns(T.nilable(T.untyped)) }
+  sig { returns(T.untyped) }
   def school; end
 
   sig { params(args: T.untyped, block: T.nilable(T.proc.params(object: T.untyped).void)).returns(T.untyped) }
@@ -1146,10 +1146,10 @@ module Wizard::GeneratedAssociationMethods
   sig { params(args: T.untyped, block: T.nilable(T.proc.params(object: T.untyped).void)).returns(T.untyped) }
   def create_school!(*args, &block); end
 
-  sig { params(value: T.nilable(T.untyped)).void }
+  sig { params(value: T.untyped).void }
   def school=(value); end
 
-  sig { returns(T.nilable(T.untyped)) }
+  sig { returns(T.untyped) }
   def reload_school; end
 
   sig { returns(T.nilable(::ActiveStorage::Attachment)) }

data/spec/test_data/v6.1/expected_wizard_wo_spellbook.rbi

@@ -1254,7 +1254,7 @@ module Wizard::GeneratedAssociationMethods
   sig { params(value: T::Enumerable[::ActiveStorage::Blob]).void }
   def hats_blobs=(value); end
 
-  sig { returns(T.nilable(T.untyped)) }
+  sig { returns(T.untyped) }
   def school; end
 
   sig { params(args: T.untyped, block: T.nilable(T.proc.params(object: T.untyped).void)).returns(T.untyped) }
@@ -1266,10 +1266,10 @@ module Wizard::GeneratedAssociationMethods
   sig { params(args: T.untyped, block: T.nilable(T.proc.params(object: T.untyped).void)).returns(T.untyped) }
   def create_school!(*args, &block); end
 
-  sig { params(value: T.nilable(T.untyped)).void }
+  sig { params(value: T.untyped).void }
   def school=(value); end
 
-  sig { returns(T.nilable(T.untyped)) }
+  sig { returns(T.untyped) }
   def reload_school; end
 
   sig { returns(T.nilable(::ActiveStorage::Attachment)) }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-rails
 version: !ruby/object:Gem::Version
-  version: 0.7.27
+  version: 0.7.31
 platform: ruby
 authors:
 - Chan Zuckerberg Initiative