RubyGems - sorbet-rails - Versions diffs - 0.7.2 → 0.7.3 - Mend

sorbet-rails 0.7.2 → 0.7.3

Files changed (130) hide show

@@ -1,7 +1,7 @@
 require 'rails_helper'
 require 'open3'
-RSpec.xdescribe 'sorbet' do
+RSpec.describe 'sorbet' do
   let!(:harry) do
     Wizard.create!(
       name: 'Harry Potter',

data/spec/support/v5.0/Gemfile.lock CHANGED

@@ -1,7 +1,7 @@
 PATH
   remote: ../../..
   specs:
-    sorbet-rails (0.7.2)
+    sorbet-rails (0.7.3)
       method_source (>= 0.9.2)
       parlour (>= 4.0.1)
       parser (>= 2.7)
@@ -76,12 +76,12 @@ GEM
     nio4r (2.5.2)
     nokogiri (1.10.9)
       mini_portile2 (~> 2.4.0)
-    parlour (4.0.1)
+    parlour (5.0.0)
       commander (~> 4.5)
       parser
       rainbow (~> 3.0)
       sorbet-runtime (>= 0.5)
-    parser (2.7.2.0)
+    parser (3.0.0.0)
       ast (~> 2.4.1)
     polyfill (1.9.0)
     puma (3.12.6)
@@ -116,7 +116,7 @@ GEM
     safe_type (1.1.1)
     sorbet (0.5.5480)
       sorbet-static (= 0.5.5480)
-    sorbet-coerce (0.2.7)
+    sorbet-coerce (0.3.0)
       polyfill (~> 1.8)
       safe_type (~> 1.1, >= 1.1.1)
       sorbet (>= 0.4.4704)

data/spec/support/v5.0/app/controllers/application_controller.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strong
+# typed: strict
 class ApplicationController < ActionController::Base
   protect_from_forgery with: :exception
 end

data/spec/support/v5.0/app/models/headmaster.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strong
+# typed: strict
 class Headmaster < ApplicationRecord
   belongs_to :school, required: false
   belongs_to :wizard, optional: true

data/spec/support/v5.0/app/models/potion.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strong
+# typed: strict
 # an abstract class that has no table
 class Potion < ApplicationRecord
   self.abstract_class = true

data/spec/support/v5.0/app/models/robe.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strong
+# typed: strict
 class Robe < ApplicationRecord
   belongs_to :wizard, required: false
 end

data/spec/support/v5.0/app/models/school.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strong
+# typed: strict
 class School < ApplicationRecord
   has_one :headmaster
   validates :headmaster, presence: true

data/spec/support/v5.0/app/models/spell.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strong
+# typed: strict
 class Spell < ApplicationRecord
   # habtm enforced at the DB level
   has_and_belongs_to_many :spell_books

data/spec/support/v5.0/app/models/subject.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strong
+# typed: strict
 class Subject < ApplicationRecord
   # habtm which is optional at the db level
   has_and_belongs_to_many :wizards

data/spec/support/v5.0/app/models/wizard.rb CHANGED

@@ -47,6 +47,11 @@ class Wizard < ApplicationRecord
     blue: 2,
   }, _prefix: :color, _suffix: :eyes
+  serialize :owl_results, Hash
+  serialize :newt_subjects # no specific data type, uses the default YAML Object coder
+  serialize :pets, Array
+  serialize :patronus_characteristics, JSON
   has_one :wand
   has_many :spell_books
   # habtm which is optional at the db level

data/spec/support/v5.0/config/environments/development.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.

data/spec/support/v5.0/config/environments/production.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.

data/spec/support/v5.0/config/environments/test.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.

data/spec/support/v5.0/config/initializers/wrap_parameters.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 # Be sure to restart your server when you modify this file.
 # This file contains settings for ActionController::ParamsWrapper which

data/spec/support/v5.0/config/routes.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 Rails.application.routes.draw do
   get 'test/index' => 'test#index'
   # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html

data/spec/support/v5.0/db/migrate/20190620000015_add_serialized_to_wizards.rb ADDED

@@ -0,0 +1,9 @@
+# typed: false
+class AddSerializedToWizards < ActiveRecord::Migration[5.0]
+  def change
+    add_column :wizards, :owl_results, :text # Hash
+    add_column :wizards, :newt_subjects, :text # generic
+    add_column :wizards, :pets, :text # Array
+    add_column :wizards, :patronus_characteristics, :text # serialized as JSON, but not a JSON column type
+  end
+end

data/spec/support/v5.0/db/schema.rb CHANGED

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
-ActiveRecord::Schema.define(version: 20190620000014) do
+ActiveRecord::Schema.define(version: 20190620000015) do
   create_table "headmasters", force: :cascade do |t|
     t.integer "school_id"
@@ -78,15 +78,19 @@ ActiveRecord::Schema.define(version: 20190620000014) do
     t.integer  "professor"
     t.string   "parent_email"
     t.text     "notes"
-    t.datetime "created_at",                            null: false
-    t.datetime "updated_at",                            null: false
+    t.datetime "created_at",                                  null: false
+    t.datetime "updated_at",                                  null: false
     t.string   "broom"
     t.integer  "quidditch_position"
     t.integer  "hair_color"
     t.integer  "eye_color"
     t.integer  "hair_length"
-    t.string   "type",               default: "Wizard", null: false
+    t.string   "type",                     default: "Wizard", null: false
     t.integer  "school_id"
+    t.text     "owl_results"
+    t.text     "newt_subjects"
+    t.text     "pets"
+    t.text     "patronus_characteristics"
   end
 end

data/spec/support/v5.0/sorbet_test_cases.rb CHANGED

@@ -305,6 +305,21 @@ T.assert_type!(Wizard::House::Hufflepuff, Wizard::House)
 T.assert_type!(Wizard::House::Ravenclaw, Wizard::House)
 T.assert_type!(Wizard::House::Slytherin, Wizard::House)
+# Serialization
+T.assert_type!(
+  wizard.owl_results,
+  T.nilable(T::Hash[T.untyped, T.untyped])
+)
+T.assert_type!(
+  wizard.newt_subjects,
+  T.nilable(T.any(T::Array[T.untyped], T::Boolean, Float, T::Hash[T.untyped, T.untyped], Integer, String))
+)
+T.assert_type!(
+  wizard.patronus_characteristics,
+  T.nilable(T.any(T::Array[T.untyped], T::Boolean, Float, T::Hash[String, T.untyped], Integer, String))
+)
+T.assert_type!(wizard.pets, T.nilable(T::Array[T.untyped]))
 # Mythical plugin
 T.assert_type!(Wand.mythicals, T::Array[Wand])

data/spec/support/v5.1/Gemfile.lock CHANGED

@@ -1,7 +1,7 @@
 PATH
   remote: ../../..
   specs:
-    sorbet-rails (0.7.2)
+    sorbet-rails (0.7.3)
       method_source (>= 0.9.2)
       parlour (>= 4.0.1)
       parser (>= 2.7)
@@ -77,12 +77,12 @@ GEM
     nio4r (2.5.2)
     nokogiri (1.10.9)
       mini_portile2 (~> 2.4.0)
-    parlour (4.0.1)
+    parlour (5.0.0)
       commander (~> 4.5)
       parser
       rainbow (~> 3.0)
       sorbet-runtime (>= 0.5)
-    parser (2.7.2.0)
+    parser (3.0.0.0)
       ast (~> 2.4.1)
     polyfill (1.9.0)
     puma (3.12.4)
@@ -117,7 +117,7 @@ GEM
     safe_type (1.1.1)
     sorbet (0.5.5480)
       sorbet-static (= 0.5.5480)
-    sorbet-coerce (0.2.7)
+    sorbet-coerce (0.3.0)
       polyfill (~> 1.8)
       safe_type (~> 1.1, >= 1.1.1)
       sorbet (>= 0.4.4704)

data/spec/support/v5.1/app/controllers/application_controller.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strong
+# typed: strict
 class ApplicationController < ActionController::Base
   protect_from_forgery with: :exception
 end

data/spec/support/v5.1/app/models/headmaster.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strong
+# typed: strict
 class Headmaster < ApplicationRecord
   belongs_to :school, required: false
   belongs_to :wizard, optional: true

data/spec/support/v5.1/app/models/school.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strong
+# typed: strict
 class School < ApplicationRecord
   has_one :headmaster
   validates :headmaster, presence: true

data/spec/support/v5.1/app/models/wizard.rb CHANGED

@@ -47,6 +47,11 @@ class Wizard < ApplicationRecord
     blue: 2,
   }, _prefix: :color, _suffix: :eyes
+  serialize :owl_results, Hash
+  serialize :newt_subjects # no specific data type, uses the default YAML Object coder
+  serialize :pets, Array
+  serialize :patronus_characteristics, JSON
   has_one :wand
   has_many :spell_books
   # habtm which is optional at the db level

data/spec/support/v5.1/config/environments/production.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.

data/spec/support/v5.1/config/initializers/wrap_parameters.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 # Be sure to restart your server when you modify this file.
 # This file contains settings for ActionController::ParamsWrapper which

data/spec/support/v5.1/config/routes.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 Rails.application.routes.draw do
   get 'test/index' => 'test#index'
   # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html

data/spec/support/v5.1/db/migrate/20190620000015_add_serialized_to_wizards.rb ADDED

@@ -0,0 +1,9 @@
+# typed: false
+class AddSerializedToWizards < ActiveRecord::Migration[5.1]
+  def change
+    add_column :wizards, :owl_results, :text # Hash
+    add_column :wizards, :newt_subjects, :text # generic
+    add_column :wizards, :pets, :text # Array
+    add_column :wizards, :patronus_characteristics, :text # serialized as JSON, but not a JSON column type
+  end
+end

data/spec/support/v5.1/db/schema.rb CHANGED

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
-ActiveRecord::Schema.define(version: 20190620000014) do
+ActiveRecord::Schema.define(version: 20190620000015) do
   create_table "headmasters", force: :cascade do |t|
     t.integer "school_id"
@@ -87,6 +87,10 @@ ActiveRecord::Schema.define(version: 20190620000014) do
     t.integer "hair_length"
     t.string "type", default: "Wizard", null: false
     t.integer "school_id"
+    t.text "owl_results"
+    t.text "newt_subjects"
+    t.text "pets"
+    t.text "patronus_characteristics"
   end
 end

data/spec/support/v5.1/sorbet_test_cases.rb CHANGED

@@ -305,6 +305,21 @@ T.assert_type!(Wizard::House::Hufflepuff, Wizard::House)
 T.assert_type!(Wizard::House::Ravenclaw, Wizard::House)
 T.assert_type!(Wizard::House::Slytherin, Wizard::House)
+# Serialization
+T.assert_type!(
+  wizard.owl_results,
+  T.nilable(T::Hash[T.untyped, T.untyped])
+)
+T.assert_type!(
+  wizard.newt_subjects,
+  T.nilable(T.any(T::Array[T.untyped], T::Boolean, Float, T::Hash[T.untyped, T.untyped], Integer, String))
+)
+T.assert_type!(
+  wizard.patronus_characteristics,
+  T.nilable(T.any(T::Array[T.untyped], T::Boolean, Float, T::Hash[String, T.untyped], Integer, String))
+)
+T.assert_type!(wizard.pets, T.nilable(T::Array[T.untyped]))
 # Mythical plugin
 T.assert_type!(Wand.mythicals, T::Array[Wand])

data/spec/support/v5.2/Gemfile.lock CHANGED

@@ -1,7 +1,7 @@
 PATH
   remote: ../../..
   specs:
-    sorbet-rails (0.7.2)
+    sorbet-rails (0.7.3)
       method_source (>= 0.9.2)
       parlour (>= 4.0.1)
       parser (>= 2.7)
@@ -84,12 +84,12 @@ GEM
     nio4r (2.5.2)
     nokogiri (1.10.9)
       mini_portile2 (~> 2.4.0)
-    parlour (4.0.1)
+    parlour (5.0.0)
       commander (~> 4.5)
       parser
       rainbow (~> 3.0)
       sorbet-runtime (>= 0.5)
-    parser (2.7.2.0)
+    parser (3.0.0.0)
       ast (~> 2.4.1)
     polyfill (1.9.0)
     puma (3.12.6)
@@ -125,7 +125,7 @@ GEM
     safe_type (1.1.1)
     sorbet (0.5.5480)
       sorbet-static (= 0.5.5480)
-    sorbet-coerce (0.2.7)
+    sorbet-coerce (0.3.0)
       polyfill (~> 1.8)
       safe_type (~> 1.1, >= 1.1.1)
       sorbet (>= 0.4.4704)

data/spec/support/v5.2/app/models/headmaster.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strong
+# typed: strict
 class Headmaster < ApplicationRecord
   belongs_to :school, required: false
   belongs_to :wizard, optional: true

data/spec/support/v5.2/app/models/school.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strong
+# typed: strict
 class School < ApplicationRecord
   has_one :headmaster
   validates :headmaster, presence: true

data/spec/support/v5.2/app/models/wizard.rb CHANGED

@@ -47,6 +47,11 @@ class Wizard < ApplicationRecord
     blue: 2,
   }, _prefix: :color, _suffix: :eyes
+  serialize :owl_results, Hash
+  serialize :newt_subjects # no specific data type, uses the default YAML Object coder
+  serialize :pets, Array
+  serialize :patronus_characteristics, JSON
   has_one :wand
   has_many :spell_books
   # habtm which is optional at the db level

data/spec/support/v5.2/config/environments/development.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.

data/spec/support/v5.2/config/environments/production.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.

data/spec/support/v5.2/config/environments/test.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.

data/spec/support/v5.2/config/initializers/wrap_parameters.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 # Be sure to restart your server when you modify this file.
 # This file contains settings for ActionController::ParamsWrapper which

data/spec/support/v5.2/config/routes.rb CHANGED

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 Rails.application.routes.draw do
   get 'test/index' => 'test#index'
   # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html

data/spec/support/v5.2/db/migrate/20190620000015_add_serialized_to_wizards.rb ADDED

@@ -0,0 +1,9 @@
+# typed: true
+class AddSerializedToWizards < ActiveRecord::Migration[5.2]
+  def change
+    add_column :wizards, :owl_results, :text # Hash
+    add_column :wizards, :newt_subjects, :text # generic
+    add_column :wizards, :pets, :text # Array
+    add_column :wizards, :patronus_characteristics, :text # serialized as JSON, but not a JSON column type
+  end
+end