sorbet-rails 0.6.5 → 0.7.3

data/spec/tstruct_comparable.rb

@@ -0,0 +1,13 @@
+module TStructComparable
+  def ==(other)
+    return false unless other.is_a?(self.class)
+
+    self.class.props.keys.all? do |prop|
+      self.send(prop) == other.send(prop)
+    end
+  end
+
+  def eql?(other)
+    self == other
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-rails
 version: !ruby/object:Gem::Version
-  version: 0.6.5
+  version: 0.7.3
 platform: ruby
 authors:
 - Chan Zuckerberg Initiative
@@ -14,16 +14,16 @@ dependencies:
   name: parlour
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: 4.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: 4.0.1
 - !ruby/object:Gem::Dependency
   name: sorbet-runtime
   requirement: !ruby/object:Gem::Requirement
@@ -200,15 +200,14 @@ files:
 - Rakefile
 - SECURITY.md
 - bin/sorbet
-- lib/bundled_rbi/parameters.rbi
+- lib/bundled_rbi/customizabel_rbi_formatter.rbi
 - lib/bundled_rbi/pluck_to_tstruct.rbi
 - lib/bundled_rbi/type_assert.rbi
+- lib/bundled_rbi/typed_enum.rbi
 - lib/bundled_rbi/typed_params.rbi
 - lib/sorbet-rails.rb
 - lib/sorbet-rails/active_record_rbi_formatter.rb
 - lib/sorbet-rails/config.rb
-- lib/sorbet-rails/custom_types/boolean_string.rb
-- lib/sorbet-rails/custom_types/integer_string.rb
 - lib/sorbet-rails/dependent_gem_rbis/README.md
 - lib/sorbet-rails/dependent_gem_rbis/actionmailer.rbi
 - lib/sorbet-rails/dependent_gem_rbis/activejob.rbi
@@ -224,11 +223,13 @@ files:
 - lib/sorbet-rails/helper_rbi_formatter.rb
 - lib/sorbet-rails/job_rbi_formatter.rb
 - lib/sorbet-rails/mailer_rbi_formatter.rb
+- lib/sorbet-rails/model_column_utils.rb
 - lib/sorbet-rails/model_plugins/active_record_assoc.rb
 - lib/sorbet-rails/model_plugins/active_record_attribute.rb
 - lib/sorbet-rails/model_plugins/active_record_enum.rb
 - lib/sorbet-rails/model_plugins/active_record_named_scope.rb
 - lib/sorbet-rails/model_plugins/active_record_querying.rb
+- lib/sorbet-rails/model_plugins/active_record_serialized_attribute.rb
 - lib/sorbet-rails/model_plugins/active_relation_where_not.rb
 - lib/sorbet-rails/model_plugins/active_storage_methods.rb
 - lib/sorbet-rails/model_plugins/base.rb
@@ -239,7 +240,6 @@ files:
 - lib/sorbet-rails/model_utils.rb
 - lib/sorbet-rails/rails_mixins/active_record_overrides.rb
 - lib/sorbet-rails/rails_mixins/custom_finder_methods.rb
-- lib/sorbet-rails/rails_mixins/custom_params_methods.rb
 - lib/sorbet-rails/rails_mixins/generated_url_helpers.rb
 - lib/sorbet-rails/rails_mixins/pluck_to_tstruct.rb
 - lib/sorbet-rails/railtie.rb
@@ -257,13 +257,10 @@ files:
 - spec/bin/run_all_specs.sh
 - spec/bin/run_spec.sh
 - spec/bin/update_test_data.sh
-- spec/boolean_string_spec.rb
 - spec/custom_finder_methods_spec.rb
-- spec/custom_params_methods_spec.rb
 - spec/generators/rails-template.rb
 - spec/generators/sorbet_test_cases.rb
 - spec/helper_rbi_formatter_spec.rb
-- spec/integer_string_spec.rb
 - spec/job_rbi_formatter_spec.rb
 - spec/mailer_rbi_formatter_spec.rb
 - spec/model_plugins_spec.rb
@@ -356,6 +353,7 @@ files:
 - spec/support/v5.0/db/migrate/20190620000012_add_spell.rb
 - spec/support/v5.0/db/migrate/20190620000013_add_spells_spell_books.rb
 - spec/support/v5.0/db/migrate/20190620000014_create_headmasters.rb
+- spec/support/v5.0/db/migrate/20190620000015_add_serialized_to_wizards.rb
 - spec/support/v5.0/db/schema.rb
 - spec/support/v5.0/db/seeds.rb
 - spec/support/v5.0/lib/assets/.keep
@@ -440,6 +438,7 @@ files:
 - spec/support/v5.1/db/migrate/20190620000012_add_spell.rb
 - spec/support/v5.1/db/migrate/20190620000013_add_spells_spell_books.rb
 - spec/support/v5.1/db/migrate/20190620000014_create_headmasters.rb
+- spec/support/v5.1/db/migrate/20190620000015_add_serialized_to_wizards.rb
 - spec/support/v5.1/db/schema.rb
 - spec/support/v5.1/db/seeds.rb
 - spec/support/v5.1/lib/assets/.keep
@@ -527,6 +526,7 @@ files:
 - spec/support/v5.2/db/migrate/20190620000012_add_spell.rb
 - spec/support/v5.2/db/migrate/20190620000013_add_spells_spell_books.rb
 - spec/support/v5.2/db/migrate/20190620000014_create_headmasters.rb
+- spec/support/v5.2/db/migrate/20190620000015_add_serialized_to_wizards.rb
 - spec/support/v5.2/db/schema.rb
 - spec/support/v5.2/db/seeds.rb
 - spec/support/v5.2/lib/assets/.keep
@@ -613,6 +613,7 @@ files:
 - spec/support/v6.0/db/migrate/20190620000012_add_spell.rb
 - spec/support/v6.0/db/migrate/20190620000013_add_spells_spell_books.rb
 - spec/support/v6.0/db/migrate/20190620000014_create_headmasters.rb
+- spec/support/v6.0/db/migrate/20190620000015_add_serialized_to_wizards.rb
 - spec/support/v6.0/db/schema.rb
 - spec/support/v6.0/db/seeds.rb
 - spec/support/v6.0/lib/assets/.keep
@@ -623,12 +624,18 @@ files:
 - spec/support/v6.0/sorbet_test_cases.rb
 - spec/support/v6.0/storage/.keep
 - spec/support/v6.0/tmp/.keep
+- spec/support/v6.0/tmp/pids/.keep
 - spec/support/v6.0/vendor/.keep
 - spec/test_data/v5.0/expected_active_record_base.rbi
 - spec/test_data/v5.0/expected_active_record_relation.rbi
 - spec/test_data/v5.0/expected_application_job.rbi
 - spec/test_data/v5.0/expected_application_mailer.rbi
 - spec/test_data/v5.0/expected_award_house_point_hourglasses.rbi
+- spec/test_data/v5.0/expected_custom_application_job.rbi
+- spec/test_data/v5.0/expected_custom_application_mailer.rbi
+- spec/test_data/v5.0/expected_custom_award_house_point_hourglasses.rbi
+- spec/test_data/v5.0/expected_custom_daily_prophet_mailer.rbi
+- spec/test_data/v5.0/expected_custom_hogwarts_acceptance_mailer.rbi
 - spec/test_data/v5.0/expected_daily_prophet_mailer.rbi
 - spec/test_data/v5.0/expected_habtm_subjects.rbi
 - spec/test_data/v5.0/expected_habtm_wizards.rbi
@@ -661,6 +668,11 @@ files:
 - spec/test_data/v5.1/expected_application_job.rbi
 - spec/test_data/v5.1/expected_application_mailer.rbi
 - spec/test_data/v5.1/expected_award_house_point_hourglasses.rbi
+- spec/test_data/v5.1/expected_custom_application_job.rbi
+- spec/test_data/v5.1/expected_custom_application_mailer.rbi
+- spec/test_data/v5.1/expected_custom_award_house_point_hourglasses.rbi
+- spec/test_data/v5.1/expected_custom_daily_prophet_mailer.rbi
+- spec/test_data/v5.1/expected_custom_hogwarts_acceptance_mailer.rbi
 - spec/test_data/v5.1/expected_daily_prophet_mailer.rbi
 - spec/test_data/v5.1/expected_habtm_subjects.rbi
 - spec/test_data/v5.1/expected_habtm_wizards.rbi
@@ -695,6 +707,11 @@ files:
 - spec/test_data/v5.2/expected_attachment.rbi
 - spec/test_data/v5.2/expected_award_house_point_hourglasses.rbi
 - spec/test_data/v5.2/expected_blob.rbi
+- spec/test_data/v5.2/expected_custom_application_job.rbi
+- spec/test_data/v5.2/expected_custom_application_mailer.rbi
+- spec/test_data/v5.2/expected_custom_award_house_point_hourglasses.rbi
+- spec/test_data/v5.2/expected_custom_daily_prophet_mailer.rbi
+- spec/test_data/v5.2/expected_custom_hogwarts_acceptance_mailer.rbi
 - spec/test_data/v5.2/expected_daily_prophet_mailer.rbi
 - spec/test_data/v5.2/expected_habtm_subjects.rbi
 - spec/test_data/v5.2/expected_habtm_wizards.rbi
@@ -729,6 +746,11 @@ files:
 - spec/test_data/v6.0/expected_attachment.rbi
 - spec/test_data/v6.0/expected_award_house_point_hourglasses.rbi
 - spec/test_data/v6.0/expected_blob.rbi
+- spec/test_data/v6.0/expected_custom_application_job.rbi
+- spec/test_data/v6.0/expected_custom_application_mailer.rbi
+- spec/test_data/v6.0/expected_custom_award_house_point_hourglasses.rbi
+- spec/test_data/v6.0/expected_custom_daily_prophet_mailer.rbi
+- spec/test_data/v6.0/expected_custom_hogwarts_acceptance_mailer.rbi
 - spec/test_data/v6.0/expected_daily_prophet_mailer.rbi
 - spec/test_data/v6.0/expected_habtm_subjects.rbi
 - spec/test_data/v6.0/expected_habtm_wizards.rbi
@@ -756,6 +778,7 @@ files:
 - spec/test_data/v6.0/expected_wizard.rbi
 - spec/test_data/v6.0/expected_wizard/habtm_subjects.rbi
 - spec/test_data/v6.0/expected_wizard_wo_spellbook.rbi
+- spec/tstruct_comparable.rb
 - spec/typed_enum_spec.rb
 - spec/typed_params_spec.rb
 - spec/utils_spec.rb
@@ -788,13 +811,10 @@ test_files:
 - spec/bin/run_all_specs.sh
 - spec/bin/run_spec.sh
 - spec/bin/update_test_data.sh
-- spec/boolean_string_spec.rb
 - spec/custom_finder_methods_spec.rb
-- spec/custom_params_methods_spec.rb
 - spec/generators/rails-template.rb
 - spec/generators/sorbet_test_cases.rb
 - spec/helper_rbi_formatter_spec.rb
-- spec/integer_string_spec.rb
 - spec/job_rbi_formatter_spec.rb
 - spec/mailer_rbi_formatter_spec.rb
 - spec/model_plugins_spec.rb
@@ -887,6 +907,7 @@ test_files:
 - spec/support/v5.0/db/migrate/20190620000012_add_spell.rb
 - spec/support/v5.0/db/migrate/20190620000013_add_spells_spell_books.rb
 - spec/support/v5.0/db/migrate/20190620000014_create_headmasters.rb
+- spec/support/v5.0/db/migrate/20190620000015_add_serialized_to_wizards.rb
 - spec/support/v5.0/db/schema.rb
 - spec/support/v5.0/db/seeds.rb
 - spec/support/v5.0/lib/assets/.keep
@@ -971,6 +992,7 @@ test_files:
 - spec/support/v5.1/db/migrate/20190620000012_add_spell.rb
 - spec/support/v5.1/db/migrate/20190620000013_add_spells_spell_books.rb
 - spec/support/v5.1/db/migrate/20190620000014_create_headmasters.rb
+- spec/support/v5.1/db/migrate/20190620000015_add_serialized_to_wizards.rb
 - spec/support/v5.1/db/schema.rb
 - spec/support/v5.1/db/seeds.rb
 - spec/support/v5.1/lib/assets/.keep
@@ -1058,6 +1080,7 @@ test_files:
 - spec/support/v5.2/db/migrate/20190620000012_add_spell.rb
 - spec/support/v5.2/db/migrate/20190620000013_add_spells_spell_books.rb
 - spec/support/v5.2/db/migrate/20190620000014_create_headmasters.rb
+- spec/support/v5.2/db/migrate/20190620000015_add_serialized_to_wizards.rb
 - spec/support/v5.2/db/schema.rb
 - spec/support/v5.2/db/seeds.rb
 - spec/support/v5.2/lib/assets/.keep
@@ -1144,6 +1167,7 @@ test_files:
 - spec/support/v6.0/db/migrate/20190620000012_add_spell.rb
 - spec/support/v6.0/db/migrate/20190620000013_add_spells_spell_books.rb
 - spec/support/v6.0/db/migrate/20190620000014_create_headmasters.rb
+- spec/support/v6.0/db/migrate/20190620000015_add_serialized_to_wizards.rb
 - spec/support/v6.0/db/schema.rb
 - spec/support/v6.0/db/seeds.rb
 - spec/support/v6.0/lib/assets/.keep
@@ -1154,12 +1178,18 @@ test_files:
 - spec/support/v6.0/sorbet_test_cases.rb
 - spec/support/v6.0/storage/.keep
 - spec/support/v6.0/tmp/.keep
+- spec/support/v6.0/tmp/pids/.keep
 - spec/support/v6.0/vendor/.keep
 - spec/test_data/v5.0/expected_active_record_base.rbi
 - spec/test_data/v5.0/expected_active_record_relation.rbi
 - spec/test_data/v5.0/expected_application_job.rbi
 - spec/test_data/v5.0/expected_application_mailer.rbi
 - spec/test_data/v5.0/expected_award_house_point_hourglasses.rbi
+- spec/test_data/v5.0/expected_custom_application_job.rbi
+- spec/test_data/v5.0/expected_custom_application_mailer.rbi
+- spec/test_data/v5.0/expected_custom_award_house_point_hourglasses.rbi
+- spec/test_data/v5.0/expected_custom_daily_prophet_mailer.rbi
+- spec/test_data/v5.0/expected_custom_hogwarts_acceptance_mailer.rbi
 - spec/test_data/v5.0/expected_daily_prophet_mailer.rbi
 - spec/test_data/v5.0/expected_habtm_subjects.rbi
 - spec/test_data/v5.0/expected_habtm_wizards.rbi
@@ -1192,6 +1222,11 @@ test_files:
 - spec/test_data/v5.1/expected_application_job.rbi
 - spec/test_data/v5.1/expected_application_mailer.rbi
 - spec/test_data/v5.1/expected_award_house_point_hourglasses.rbi
+- spec/test_data/v5.1/expected_custom_application_job.rbi
+- spec/test_data/v5.1/expected_custom_application_mailer.rbi
+- spec/test_data/v5.1/expected_custom_award_house_point_hourglasses.rbi
+- spec/test_data/v5.1/expected_custom_daily_prophet_mailer.rbi
+- spec/test_data/v5.1/expected_custom_hogwarts_acceptance_mailer.rbi
 - spec/test_data/v5.1/expected_daily_prophet_mailer.rbi
 - spec/test_data/v5.1/expected_habtm_subjects.rbi
 - spec/test_data/v5.1/expected_habtm_wizards.rbi
@@ -1226,6 +1261,11 @@ test_files:
 - spec/test_data/v5.2/expected_attachment.rbi
 - spec/test_data/v5.2/expected_award_house_point_hourglasses.rbi
 - spec/test_data/v5.2/expected_blob.rbi
+- spec/test_data/v5.2/expected_custom_application_job.rbi
+- spec/test_data/v5.2/expected_custom_application_mailer.rbi
+- spec/test_data/v5.2/expected_custom_award_house_point_hourglasses.rbi
+- spec/test_data/v5.2/expected_custom_daily_prophet_mailer.rbi
+- spec/test_data/v5.2/expected_custom_hogwarts_acceptance_mailer.rbi
 - spec/test_data/v5.2/expected_daily_prophet_mailer.rbi
 - spec/test_data/v5.2/expected_habtm_subjects.rbi
 - spec/test_data/v5.2/expected_habtm_wizards.rbi
@@ -1260,6 +1300,11 @@ test_files:
 - spec/test_data/v6.0/expected_attachment.rbi
 - spec/test_data/v6.0/expected_award_house_point_hourglasses.rbi
 - spec/test_data/v6.0/expected_blob.rbi
+- spec/test_data/v6.0/expected_custom_application_job.rbi
+- spec/test_data/v6.0/expected_custom_application_mailer.rbi
+- spec/test_data/v6.0/expected_custom_award_house_point_hourglasses.rbi
+- spec/test_data/v6.0/expected_custom_daily_prophet_mailer.rbi
+- spec/test_data/v6.0/expected_custom_hogwarts_acceptance_mailer.rbi
 - spec/test_data/v6.0/expected_daily_prophet_mailer.rbi
 - spec/test_data/v6.0/expected_habtm_subjects.rbi
 - spec/test_data/v6.0/expected_habtm_wizards.rbi
@@ -1287,6 +1332,7 @@ test_files:
 - spec/test_data/v6.0/expected_wizard.rbi
 - spec/test_data/v6.0/expected_wizard/habtm_subjects.rbi
 - spec/test_data/v6.0/expected_wizard_wo_spellbook.rbi
+- spec/tstruct_comparable.rb
 - spec/typed_enum_spec.rb
 - spec/typed_params_spec.rb
 - spec/utils_spec.rb

data/lib/bundled_rbi/parameters.rbi

@@ -1,28 +0,0 @@
-# typed: strong
-
-module SorbetRails::CustomParamsMethods
-  extend T::Sig
-
-  sig {
-    type_parameters(:U).
-    params(key: Symbol, ta: ITypeAssert[T.type_parameter(:U)]).
-    returns(T.type_parameter(:U))
-  }
-  def require_typed(key, ta); end
-
-  # Note: when default value is a hash, it'll be converted into an ActionController::Parameters
-  sig {
-    type_parameters(:U).
-    params(
-      key: Symbol,
-      ta: ITypeAssert[T.type_parameter(:U)],
-      args: T.untyped,
-    ).
-    returns(T.type_parameter(:U))
-  }
-  def fetch_typed(key, ta, *args); end
-end
-
-class ActionController::Parameters
-  include SorbetRails::CustomParamsMethods
-end

data/lib/sorbet-rails/custom_types/boolean_string.rb

@@ -1,42 +0,0 @@
-# typed: false
-require('sorbet-rails/deprecation.rb')
-
-module BooleanStringImpl
-  def is_a?(type)
-    return super unless type == BooleanString
-    _is_a_boolean_string?
-  end
-
-  def kind_of?(type)
-    return super unless type == BooleanString
-    _is_a_boolean_string?
-  end
-
-  def instance_of?(type)
-    return super unless type == BooleanString
-    _is_a_boolean_string?
-  end
-
-  def _is_a_boolean_string?
-    return @cached_is_a unless @cached_is_a.nil?
-    SorbetRails::TypeAssertDeprecation.deprecation_warning(
-      :BooleanString,
-      'Use TypedParam with T::Boolean type instead.'
-    )
-    @cached_is_a = (self =~ /^(true|false)$/i) == 0
-  end
-end
-
-class String
-  include BooleanStringImpl
-end
-
-class BooleanString < String
-  def self.===(other)
-    SorbetRails::TypeAssertDeprecation.deprecation_warning(
-      :BooleanString,
-      'Use TypedParam with T::Boolean type instead.'
-    )
-    other.is_a?(BooleanString)
-  end
-end

data/lib/sorbet-rails/custom_types/integer_string.rb

@@ -1,45 +0,0 @@
-# typed: false
-require('sorbet-rails/deprecation.rb')
-
-module IntegerStringImpl
-  def is_a?(type)
-    return super unless type == IntegerString
-    _is_a_integer_string?
-  end
-
-  def kind_of?(type)
-    return super unless type == IntegerString
-    _is_a_integer_string?
-  end
-
-  def instance_of?(type)
-    return super unless type == IntegerString
-    _is_a_integer_string?
-  end
-
-  def _is_a_integer_string?
-    return @cached_is_a unless @cached_is_a.nil?
-    SorbetRails::TypeAssertDeprecation.deprecation_warning(
-      :IntegerString,
-      'Use TypedParams with Integer type instead.'
-    )
-    Integer(self, 10)
-    @cached_is_a = true
-  rescue ArgumentError => err
-    @cached_is_a = false
-  end
-end
-
-class String
-  include IntegerStringImpl
-end
-
-class IntegerString < String
-  def self.===(other)
-    SorbetRails::TypeAssertDeprecation.deprecation_warning(
-      :IntegerString,
-      'Use TypedParams with Integer type instead.'
-    )
-    other.is_a?(IntegerString)
-  end
-end

data/lib/sorbet-rails/rails_mixins/custom_params_methods.rb

@@ -1,57 +0,0 @@
-# typed: false
-require 'sorbet-runtime'
-require('sorbet-rails/deprecation.rb')
-
-module SorbetRails::CustomParamsMethods
-  include Kernel
-  extend T::Sig
-  extend T::Helpers
-
-  # methods exists on ActionController::Parameter
-  # def require(key); super; end
-  # def fetch(key, *args); super; end
-
-  sig {
-    type_parameters(:U).
-    params(key: Symbol, ta: ITypeAssert[T.type_parameter(:U)]).
-    returns(T.type_parameter(:U))
-  }
-  def require_typed(key, ta)
-    SorbetRails::TypeAssertDeprecation.deprecation_warning(
-      :require_typed,
-      'Use TypedParams with a T::Struct represents the type of each parameters.'
-    )
-
-    val = require(key)
-    ta.assert(val)
-  rescue TypeError
-    raise ActionController::BadRequest.new(
-      "Expected parameter #{key} to be an instance of type #{ta.get_type}, got `#{val}`"
-    )
-  end
-
-  # Note: when default value is a hash, it'll be converted into an ActionController::Parameters
-  sig {
-    type_parameters(:U).
-    params(
-      key: Symbol,
-      ta: ITypeAssert[T.type_parameter(:U)],
-      args: T.untyped,
-    ).
-    returns(T.type_parameter(:U))
-  }
-  def fetch_typed(key, ta, *args)
-    SorbetRails::TypeAssertDeprecation.deprecation_warning(
-      :fetch_typed,
-      'Use TypedParams with a T::Struct represents the type of each parameters.'
-    )
-
-    val = fetch(key, *args)
-    ta.assert(val)
-  rescue TypeError
-    raise ActionController::BadRequest.new(
-      "Expected parameter #{key} to be an instance of type T.nilable(#{ta.get_type}),
-      got `#{val}`".squish!
-    )
-  end
-end