sorbet-rails 0.5.0 → 0.5.1

data/spec/support/v5.2-no-sorbet/db/schema.rb

@@ -1,4 +1,3 @@
-# typed: strict
 # This file is auto-generated from the current state of the database. Instead
 # of editing this file, please use the migrations feature of Active Record to
 # incrementally modify your database, and then regenerate this schema definition.
@@ -11,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2019_06_22_000000) do
+ActiveRecord::Schema.define(version: 2019_06_20_000004) do
 
   create_table "spell_books", force: :cascade do |t|
     t.string "name"

data/spec/support/v5.2-no-sorbet/db/seeds.rb

@@ -1,4 +1,3 @@
-# typed: strong
 # This file should contain all the record creation needed to seed the database with its default values.
 # The data can then be loaded with the rails db:seed command (or created alongside the database with db:setup).
 #

data/spec/support/v5.2-no-sorbet/lib/mythical_rbi_plugin.rb

@@ -0,0 +1,16 @@
+# typed: true
+class MythicalRbiPlugin < SorbetRails::ModelPlugins::Base
+  def generate(root)
+    return unless @model_class.include?(Mythical)
+
+    model_class_rbi = root.create_class(self.model_class_name)
+
+    # ActiveSupport::Concern class method will be inserted to the class
+    # directly. We need to also put the sig in the model class rbi directly
+    model_class_rbi.create_method(
+      'mythicals',
+      class_method: true,
+      return_type: "T::Array[#{@model_class.name}]",
+    )
+  end
+end

data/spec/support/v5.2-no-sorbet/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "v5_2-no-sorbet",
+  "private": true,
+  "dependencies": {}
+}

data/spec/support/v5.2-no-sorbet/sorbet_test_cases.rb

@@ -0,0 +1,123 @@
+# typed: false
+require 'sorbet-runtime'
+
+wizard = Wizard.first!
+T.assert_type!(wizard, Wizard)
+
+# -- model columns
+T.assert_type!(wizard.name, T.nilable(String))
+
+# -- model associations
+T.assert_type!(wizard.wand, T.nilable(Wand))
+T.assert_type!(T.must(wizard.wand).wizard, Wizard)
+
+T.assert_type!(wizard.spell_books, ActiveRecord::Associations::CollectionProxy)
+T.reveal_type(wizard.spell_books) # SpellBook::CollectionProxy
+
+# -- model relation
+# default
+T.assert_type!(Wizard.all, ActiveRecord::Relation)
+T.reveal_type(Wizard.all) # Wizard::ActiveRecord_Relation
+
+# custom scope
+T.assert_type!(Wizard.recent, ActiveRecord::Relation)
+T.reveal_type(Wizard.recent)
+
+# enum scope
+T.assert_type!(Wizard.Gryffindor, ActiveRecord::Relation)
+T.reveal_type(Wizard.Gryffindor)
+
+# chained scopes
+T.assert_type!(Wizard.Gryffindor.recent, ActiveRecord::Relation)
+T.reveal_type(Wizard.Gryffindor.recent)
+T.assert_type!(Wizard.Gryffindor.recent.unscoped, ActiveRecord::Relation)
+T.reveal_type(Wizard.Gryffindor.recent.unscoped)
+
+# ActiveRecord Querying
+T.assert_type!(Wizard.where(id: 1), ActiveRecord::Relation)
+T.reveal_type(Wizard.where(id: 1)) # Wizard::Relation
+T.assert_type!(Wizard.preload(:spell_books), ActiveRecord::Relation)
+T.reveal_type(Wizard.preload(:spell_books)) # Wizard::Relation
+T.assert_type!(Wizard.eager_load(:spell_books), ActiveRecord::Relation)
+T.reveal_type(Wizard.eager_load(:spell_books)) # Wizard::Relation
+T.assert_type!(Wizard.order(:id), ActiveRecord::Relation)
+T.reveal_type(Wizard.order(:id)) # Wizard::Relation
+
+# Finder methods -- Model
+T.assert_type!(Wizard.exists?(name: 'Test'), T::Boolean)
+T.assert_type!(Wizard.find(wizard.id), Wizard)
+T.assert_type!(Wizard.first!, Wizard)
+T.assert_type!(Wizard.first, T.nilable(Wizard))
+T.assert_type!(Wizard.last!, Wizard)
+T.assert_type!(Wizard.last, T.nilable(Wizard))
+T.assert_type!(Wizard.first_n(5), T::Array[Wizard])
+T.assert_type!(Wizard.last_n(5), T::Array[Wizard])
+T.assert_type!(Wizard.find_by(name: 'Harry Potter'), T.nilable(Wizard))
+T.assert_type!(Wizard.find_by!(name: 'Harry Potter'), Wizard)
+T.assert_type!(Wizard.find_by_id(wizard.id), T.nilable(Wizard))
+T.assert_type!(Wizard.find_by_id!(wizard.id), Wizard)
+
+# Finder methods -- ActiveRecord::Relation
+T.assert_type!(Wizard.all.exists?(name: 'Harry Potter'), T::Boolean)
+T.assert_type!(Wizard.all.find(wizard.id), Wizard)
+T.assert_type!(Wizard.all.first!, Wizard)
+T.assert_type!(Wizard.all.first, T.nilable(Wizard))
+T.assert_type!(Wizard.all.last!, Wizard)
+T.assert_type!(Wizard.all.last, T.nilable(Wizard))
+T.assert_type!(Wizard.all.first_n(5), T::Array[Wizard])
+T.assert_type!(Wizard.all.last_n(5), T::Array[Wizard])
+T.assert_type!(Wizard.all.find_by(name: 'Harry Potter'), T.nilable(Wizard))
+T.assert_type!(Wizard.all.find_by!(name: 'Harry Potter'), Wizard)
+T.assert_type!(Wizard.all.find_by_id(wizard.id), T.nilable(Wizard))
+T.assert_type!(Wizard.all.find_by_id!(wizard.id), Wizard)
+
+# Finder methods -- CollectionProxy
+spell_book = wizard.spell_books.first!
+T.assert_type!(wizard.spell_books.exists?(name: 'Fantastic Beasts'), T::Boolean)
+T.assert_type!(wizard.spell_books.find(spell_book.id), SpellBook)
+T.assert_type!(wizard.spell_books.first!, SpellBook)
+# T.assert_type!(wizard.spell_books.first, T.nilable(SpellBook)) # TODO fix sig for 4.2 and 5.0
+T.assert_type!(wizard.spell_books.last!, SpellBook)
+# T.assert_type!(wizard.spell_books.last, T.nilable(SpellBook)) # TODO fix sig for 4.2 and 5.0
+T.assert_type!(wizard.spell_books.first_n(5), T::Array[SpellBook])
+T.assert_type!(wizard.spell_books.last_n(5), T::Array[SpellBook])
+T.assert_type!(wizard.spell_books.find_by(name: 'Fantastic Beasts'), T.nilable(SpellBook))
+T.assert_type!(wizard.spell_books.find_by!(name: 'Fantastic Beasts'), SpellBook)
+T.assert_type!(wizard.spell_books.find_by_id(spell_book.id), T.nilable(SpellBook))
+T.assert_type!(wizard.spell_books.find_by_id!(spell_book.id), SpellBook)
+
+# Enumerable
+T.assert_type!(Wizard.all.to_a, T::Array[Wizard])
+Wizard.all.each do |w|
+  T.assert_type!(w, Wizard)
+end
+Wizard.all.map do |w|
+  T.assert_type!(w, Wizard) # TODO this doesn't work on Rails 4.2 or 5.0
+end
+Wizard.all.to_a.map do |w|
+  T.assert_type!(w, Wizard)
+end
+
+T.assert_type!(wizard.spell_books.to_a, T::Array[SpellBook])
+wizard.spell_books.each do |sp|
+  T.assert_type!(sp, SpellBook)
+end
+wizard.spell_books.map do |sp|
+  T.assert_type!(sp, SpellBook) # TODO this doesn't work on Rails 4.2 or 5.0
+end
+wizard.spell_books.to_a.map do |sp|
+  T.assert_type!(sp, SpellBook) # This works on Rails 4.2
+end
+
+# Model columns
+T.assert_type!(wizard.id, Integer)
+T.assert_type!(wizard.id?, T::Boolean)
+T.assert_type!(wizard.notes, T.nilable(String))
+T.assert_type!(wizard.house, T.nilable(String))
+
+# Model enum
+T.assert_type!(wizard.Gryffindor?, T::Boolean)
+T.assert_type!(Wizard.houses, T::Hash[T.any(String, Symbol), Integer])
+
+# Mythical plugin
+T.assert_type!(Wand.mythicals, T::Array[Wand])

data/spec/support/v5.2-no-sorbet/typed-override.yaml

@@ -0,0 +1,2 @@
+true:
+- ./sorbet_test_cases.rb

data/spec/support/v5.2/.gitignore

@@ -0,0 +1,31 @@
+# See https://help.github.com/articles/ignoring-files for more about ignoring files.
+#
+# If you find yourself ignoring temporary files generated by your text editor
+# or operating system, you probably want to add a global ignore instead:
+#   git config --global core.excludesfile '~/.gitignore_global'
+
+# Ignore bundler config.
+/.bundle
+
+# Ignore the default SQLite database.
+/db/*.sqlite3
+/db/*.sqlite3-journal
+
+# Ignore all logfiles and tempfiles.
+/log/*
+/tmp/*
+!/log/.keep
+!/tmp/.keep
+
+# Ignore uploaded files in development
+/storage/*
+!/storage/.keep
+
+/node_modules
+/yarn-error.log
+
+/public/assets
+.byebug_history
+
+# Ignore master key for decrypting credentials and more.
+/config/master.key

data/spec/support/v5.2/Gemfile

@@ -1,16 +1,16 @@
 source 'https://rubygems.org'
 git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
-gem 'rails', '~> 5.2.3'
+ruby '2.6.3'
 
+# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
+gem 'rails', '~> 5.2.3'
 # Use sqlite3 as the database for Active Record
-gem 'sqlite3', '~> 1.4.1'
+gem 'sqlite3'
 # Use Puma as the app server
 gem 'puma', '~> 3.11'
 # Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
-# gem 'jbuilder', '~> 2.5'
-# Use Redis adapter to run Action Cable in production
-# gem 'redis', '~> 4.0'
+gem 'jbuilder', '~> 2.5'
 # Use ActiveModel has_secure_password
 # gem 'bcrypt', '~> 3.1.7'
 
@@ -20,36 +20,20 @@ gem 'puma', '~> 3.11'
 # Use Capistrano for deployment
 # gem 'capistrano-rails', group: :development
 
-# Reduces boot times through caching; required in config/boot.rb
-# gem 'bootsnap', '>= 1.1.0', require: false
-
-# Use Rack CORS for handling Cross-Origin Resource Sharing (CORS), making cross-origin AJAX possible
-# gem 'rack-cors'
-
 group :development, :test do
   # Call 'byebug' anywhere in the code to stop execution and get a debugger console
   gem 'byebug', platforms: [:mri, :mingw, :x64_mingw]
 end
 
 group :development do
-  # gem 'listen', '>= 3.0.5', '< 3.2'
-  # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
-  # gem 'spring'
-  # gem 'spring-watcher-listen', '~> 2.0.0'
+  # Access an interactive console on exception pages or by calling 'console' anywhere in the code.
+  gem 'web-console', '>= 3.3.0'
 end
 
-gem 'sorbet-rails', path: '../../../.'
 
 # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
-# gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
-
-sorbet_version = ENV["SORBET_VERSION"]
-if sorbet_version
-  # mostly used to test against a stable version of Sorbet in Travis.
-  gem 'sorbet', sorbet_version
-  gem 'sorbet-runtime', sorbet_version
-else
-  # prefer to test against latest version because sorbet is updated frequently
-  gem 'sorbet'
-  gem 'sorbet-runtime'
-end
+gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
+
+gem 'sorbet-rails', path: '../../../.'
+gem 'sorbet'
+gem 'sorbet-runtime'

data/spec/support/v5.2/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../../..
   specs:
-    sorbet-rails (0.4.0)
+    sorbet-rails (0.5.0)
       parlour (~> 0.6.0)
 
 GEM
@@ -49,6 +49,7 @@ GEM
       minitest (~> 5.1)
       tzinfo (~> 1.1)
     arel (9.0.0)
+    bindex (0.8.1)
     builder (3.2.3)
     byebug (11.0.1)
     concurrent-ruby (1.1.5)
@@ -58,6 +59,8 @@ GEM
       activesupport (>= 4.2.0)
     i18n (1.6.0)
       concurrent-ruby (~> 1.0)
+    jbuilder (2.9.1)
+      activesupport (>= 4.2.0)
     loofah (2.2.3)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
@@ -67,10 +70,10 @@ GEM
       mimemagic (~> 0.3.2)
     method_source (0.9.2)
     mimemagic (0.3.3)
-    mini_mime (1.0.1)
+    mini_mime (1.0.2)
     mini_portile2 (2.4.0)
     minitest (5.11.3)
-    nio4r (2.3.1)
+    nio4r (2.4.0)
     nokogiri (1.10.3)
       mini_portile2 (~> 2.4.0)
     parlour (0.6.1)
@@ -96,7 +99,7 @@ GEM
     rails-dom-testing (2.0.3)
       activesupport (>= 4.2.0)
       nokogiri (>= 1.6)
-    rails-html-sanitizer (1.0.4)
+    rails-html-sanitizer (1.2.0)
       loofah (~> 2.2, >= 2.2.2)
     railties (5.2.3)
       actionpack (= 5.2.3)
@@ -105,11 +108,11 @@ GEM
       rake (>= 0.8.7)
       thor (>= 0.19.0, < 2.0)
     rainbow (3.0.0)
-    rake (12.3.2)
-    sorbet (0.4.4386)
-      sorbet-static (= 0.4.4386)
-    sorbet-runtime (0.4.4386)
-    sorbet-static (0.4.4386-universal-darwin-14)
+    rake (12.3.3)
+    sorbet (0.4.4602)
+      sorbet-static (= 0.4.4602)
+    sorbet-runtime (0.4.4602)
+    sorbet-static (0.4.4602-universal-darwin-14)
     sprockets (3.7.2)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
@@ -122,6 +125,11 @@ GEM
     thread_safe (0.3.6)
     tzinfo (1.2.5)
       thread_safe (~> 0.1)
+    web-console (3.7.0)
+      actionview (>= 5.0)
+      activemodel (>= 5.0)
+      bindex (>= 0.4.0)
+      railties (>= 5.0)
     websocket-driver (0.7.1)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.4)
@@ -131,12 +139,18 @@ PLATFORMS
 
 DEPENDENCIES
   byebug
+  jbuilder (~> 2.5)
   puma (~> 3.11)
   rails (~> 5.2.3)
   sorbet
   sorbet-rails!
   sorbet-runtime
-  sqlite3 (~> 1.4.1)
+  sqlite3
+  tzinfo-data
+  web-console (>= 3.3.0)
+
+RUBY VERSION
+   ruby 2.6.3p62
 
 BUNDLED WITH
    2.0.2

data/spec/support/v5.2/app/assets/config/manifest.js

@@ -0,0 +1,2 @@
+//= link_tree ../images
+//= link_directory ../stylesheets .css

data/spec/support/v5.2/app/assets/stylesheets/application.css

@@ -0,0 +1,15 @@
+/*
+ * This is a manifest file that'll be compiled into application.css, which will include all the files
+ * listed below.
+ *
+ * Any CSS and SCSS file within this directory, lib/assets/stylesheets, or any plugin's
+ * vendor/assets/stylesheets directory can be referenced here using a relative path.
+ *
+ * You're free to add application-wide styles to this file and they'll appear at the bottom of the
+ * compiled file so the styles you add here take precedence over styles defined in any other CSS/SCSS
+ * files in this directory. Styles in this file should be added after the last require_* statement.
+ * It is generally better to create a new file per style scope.
+ *
+ *= require_tree .
+ *= require_self
+ */

data/spec/support/v5.2/app/controllers/application_controller.rb

@@ -0,0 +1,3 @@
+# typed: strong
+class ApplicationController < ActionController::Base
+end

data/spec/support/v5.2/app/helpers/application_helper.rb

@@ -0,0 +1,3 @@
+# typed: strong
+module ApplicationHelper
+end

data/spec/support/v5.2/app/helpers/bar_helper.rb

@@ -0,0 +1,3 @@
+# typed: strong
+module BarHelper
+end

data/spec/support/v5.2/app/helpers/baz_helper.rb

@@ -0,0 +1,3 @@
+# typed: strong
+module BazHelper
+end

data/spec/support/v5.2/app/helpers/foo_helper.rb

@@ -0,0 +1,3 @@
+# typed: strong
+module FooHelper
+end

data/spec/support/v5.2/app/models/application_record.rb

@@ -0,0 +1,5 @@
+# typed: strict
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+  scope :recent, -> { where('created_at > ?', 1.month.ago) }
+end

data/spec/support/v5.2/app/models/concerns/mythical.rb

@@ -0,0 +1,11 @@
+# typed: false
+require 'active_support/concern'
+module Mythical
+  extend ActiveSupport::Concern
+
+  class_methods do
+    def mythicals
+      all.to_a # yeah!
+    end
+  end
+end

data/spec/support/v5.2/app/models/potion.rb

@@ -0,0 +1,5 @@
+# typed: strong
+# an abstract class that has no table
+class Potion < ApplicationRecord
+  self.abstract_class = true
+end

data/spec/support/v5.2/app/models/spell_book.rb

@@ -0,0 +1,5 @@
+# typed: strong
+class SpellBook < ApplicationRecord
+  validates :name, length: { minimum: 5 }, presence: true
+  belongs_to :wizard
+end