sorare-rewards 1.3.0 → 1.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 01fd7615db59531b3ff62b6cb1c41ff0df013b21faa6f2cd606dc8c3bfa8ecbb
-  data.tar.gz: efd268efe1bc3ce02dc7a02c49b0e5caa777152aef6bdb5ada31a38b51f62ca9
+  metadata.gz: 8641fffa2c82df83b2e775393fbc68ae16d99857695061d1a8b8af33017c4971
+  data.tar.gz: dc828084b6b07733bb8725e3d62d302ab3601c260c5ed7fbaf81039167df4a07
 SHA512:
-  metadata.gz: 29d31f438e4962fa3381f783cd263307f1dfb5562eaf0e8eb06b36dc9aca4848efb03ed4d07e4d12fa5eba77a309873a9add2184f214262ac425287f5767b52d
-  data.tar.gz: b3eabfe23636dbdb50b18abfc4fbad687ca42c80d5d82e1cb88c5017b754bdf555614e7c3090793adc3493432de76bf53ce3e0194e8d85c7d972fd4eda79f25a
+  metadata.gz: ce2bd4d025e0d1efcf6bf8bbefa6e9ff992d751cedaed1a582e07ebe380a6eae2cc4148ebc49be595a5345e8bda235096e287f0cb549a5f9b01f237c86b3d496
+  data.tar.gz: 6a9d835f7cd4c8237676c5b47e7ee6e122162ae1606062a9521754cca70d392941ff0a94413ba69c8e5bbd5dff29fe703dcc009290c766a3422b757e2d81319f

data/.rubocop.yml

@@ -14,6 +14,7 @@ Metrics/BlockLength:
     - "Rakefile"
     - "**/*.rake"
     - "spec/**/*.rb"
+    - "sorare-rewards.gemspec"
 
 Metrics/ClassLength:
   Max: 120

data/CHANGELOG.md

@@ -1,11 +1,29 @@
+## [1.4.1] - 2021-12-14
+
+### Fixes
+
+- Fix an issue where the `config` was null when accessed on a `GameWeek` with no loaded data
+
+## [1.4.0] - 2021-12-14
+
+### Added
+
+- Added support for rarity based `rewards_ratio_per_cards_in_circulation`
+
 ## [1.3.0] - 2021-11-02
+
 ### Breaking
+
 - Removed rewards method from `GameWeek` (`card_rewards`, `cards_picked`, `reward_allocations`, `prize_pools`, `card_allocations`)
 - `Picker` has been renamed to `CardPicker`
+
 ### Added
+
 - Added a `GameWeekRewards` class that provides all rewards related methods
 - Added a way to pick cards with a custom `card_allocations`
 
 ## [1.2.0] - 2021-11-02
+
 ### Added
+
 - Enable cross leagues cooldown using `per_league` configuration flag

data/Gemfile.lock

@@ -1,41 +1,39 @@
 PATH
   remote: .
   specs:
-    sorare-rewards (1.3.0)
+    sorare-rewards (1.4.3)
       activesupport (~> 6.1.4)
       interactor (~> 3.1.2)
       json (~> 2)
-      net-http (~> 0.1.1)
       yaml (~> 0.2.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.4.1)
+    activesupport (6.1.4.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
       zeitwerk (~> 2.3)
+    addressable (2.8.0)
+      public_suffix (>= 2.0.2, < 5.0)
     ast (2.4.2)
     concurrent-ruby (1.1.9)
+    crack (0.4.5)
+      rexml
     diff-lcs (1.4.4)
-    i18n (1.8.10)
+    hashdiff (1.0.1)
+    i18n (1.8.11)
       concurrent-ruby (~> 1.0)
     interactor (3.1.2)
-    io-wait (0.1.0)
     json (2.6.0)
-    minitest (5.14.4)
-    net-http (0.1.1)
-      net-protocol
-      uri
-    net-protocol (0.1.2)
-      io-wait
-      timeout
+    minitest (5.15.0)
     ostruct (0.4.0)
     parallel (1.21.0)
     parser (3.0.2.0)
       ast (~> 2.4.1)
+    public_suffix (4.0.6)
     rainbow (3.0.0)
     rake (12.3.3)
     regexp_parser (2.1.1)
@@ -69,13 +67,15 @@ GEM
     rubocop-rspec (2.5.0)
       rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
-    timeout (0.2.0)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.1.0)
-    uri (0.11.0)
+    webmock (3.14.0)
+      addressable (>= 2.8.0)
+      crack (>= 0.3.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
     yaml (0.2.0)
-    zeitwerk (2.5.0)
+    zeitwerk (2.5.1)
 
 PLATFORMS
   ruby
@@ -88,6 +88,7 @@ DEPENDENCIES
   rubocop-rake (~> 0.6.0)
   rubocop-rspec (~> 2.5.0)
   sorare-rewards!
+  webmock (~> 3.14.0)
 
 BUNDLED WITH
-   2.2.22
+   2.2.30

data/README.md

@@ -10,15 +10,14 @@ gem 'sorare-rewards'
 
 And then execute:
 
-  $ bundle install
+$ bundle install
 
 Or install it yourself as:
 
-  $ gem install sorare-rewards
+$ gem install sorare-rewards
 
 ## Usage
 
-
 First you need to load a game week
 
 ```ruby
@@ -27,7 +26,6 @@ game_week = Sorare::Rewards::GameWeek.new(hash: 'QmbwCo1fuhRN1T2DyEQtETefsBH6yCj
 
 Game Week's `hash` and `salt` can be retrieved using the GQL API, the salt is made public after the rewards have been distributed.
 
-
 To compute rewards for a game week :
 
 ```ruby
@@ -67,7 +65,6 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
-
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/lib/sorare/rewards/game_week.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
 require 'json'
-require 'net/http'
 require 'active_support/core_ext/module/delegation'
+require 'open-uri'
 
 module Sorare
   module Rewards
@@ -11,7 +11,7 @@ module Sorare
       attr_reader :salt
 
       def initialize(data: nil, hash: nil, salt: nil)
-        @uri = URI("#{Sorare::Rewards.configuration.gateway}#{hash}")
+        @uri = URI.parse("#{Sorare::Rewards.configuration.gateway}#{hash}")
         @data = data
         @salt = salt
       end
@@ -23,11 +23,11 @@ module Sorare
       end
 
       def data
-        @data ||= JSON.parse(::Net::HTTP.get(@uri))
+        @data ||= JSON.parse(@uri.open.read)
       end
 
       def config
-        @config ||= GameWeekConfig.new(@data['config'])
+        @config ||= GameWeekConfig.new(data['config'])
       end
 
       def supply_for(league, rarity: nil, player: nil)

data/lib/sorare/rewards/league.rb

@@ -24,9 +24,17 @@ module Sorare
       end
 
       def cards_in_circulation_limit(rarity)
-        return unless cards_in_circulation&.dig(rarity) && game_week.config.rewards_ratio_per_cards_in_circulation
+        return unless cards_in_circulation&.dig(rarity) && rewards_ratio_per_cards_in_circulation_for_rarity(rarity)
 
-        (cards_in_circulation[rarity] * game_week.config.rewards_ratio_per_cards_in_circulation).floor
+        (cards_in_circulation[rarity] * rewards_ratio_per_cards_in_circulation_for_rarity(rarity)).floor
+      end
+
+      def rewards_ratio_per_cards_in_circulation_for_rarity(rarity)
+        if game_week.config.rewards_ratio_per_cards_in_circulation.is_a?(Hash)
+          return game_week.config.rewards_ratio_per_cards_in_circulation[rarity]
+        end
+
+        game_week.config.rewards_ratio_per_cards_in_circulation
       end
 
       def each_division_prize_pools

data/lib/sorare/rewards/version.rb

@@ -2,6 +2,6 @@
 
 module Sorare
   module Rewards
-    VERSION = '1.3.0'
+    VERSION = '1.4.3'
   end
 end

data/lib/sorare/rewards.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'json'
-require 'net/http'
 require 'digest'
 
 Dir["#{File.dirname(__FILE__)}/rewards/**/*.rb"].sort.each do |file|

data/sorare-rewards.gemspec

@@ -2,12 +2,11 @@
 
 require_relative 'lib/sorare/rewards/version'
 
-# rubocop:disable Metrics/BlockLength
 Gem::Specification.new do |spec|
   spec.name          = 'sorare-rewards'
   spec.version       = Sorare::Rewards::VERSION
-  spec.authors       = ['pierre']
-  spec.email         = ['pierre@sorare.com']
+  spec.authors       = ['Sorare team']
+  spec.email         = ['hello@sorare.com']
 
   spec.summary       = %w[Sorare reward allocation algorithm]
   # spec.description   = %q{TODO: Write a longer description or delete this line.}
@@ -33,12 +32,11 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'activesupport', '~> 6.1.4'
   spec.add_dependency 'interactor', '~> 3.1.2'
   spec.add_dependency 'json', '~> 2'
-  spec.add_dependency 'net-http', '~> 0.1.1'
   spec.add_dependency 'yaml', '~> 0.2.0'
   spec.add_development_dependency 'ostruct', '~> 0.4.0'
   spec.add_development_dependency 'rspec', '~> 3.10'
   spec.add_development_dependency 'rubocop', '~> 1.22.1'
   spec.add_development_dependency 'rubocop-rake', '~> 0.6.0'
   spec.add_development_dependency 'rubocop-rspec', '~> 2.5.0'
+  spec.add_development_dependency 'webmock', '~> 3.14.0'
 end
-# rubocop:enable Metrics/BlockLength

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sorare-rewards
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.3
 platform: ruby
 authors:
-- pierre
-autorequire: 
+- Sorare team
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-11-19 00:00:00.000000000 Z
+date: 2022-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -52,20 +52,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2'
-- !ruby/object:Gem::Dependency
-  name: net-http
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.1.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.1.1
 - !ruby/object:Gem::Dependency
   name: yaml
   requirement: !ruby/object:Gem::Requirement
@@ -150,9 +136,23 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.5.0
-description: 
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.14.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.14.0
+description:
 email:
-- pierre@sorare.com
+- hello@sorare.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -211,7 +211,7 @@ licenses:
 metadata:
   homepage_uri: https://gitlab.com/sorare/sorare-rewards
   source_code_uri: https://gitlab.com/sorare/sorare-rewards
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -227,7 +227,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.2.22
-signing_key: 
+signing_key:
 specification_version: 4
 summary: '["Sorare", "reward", "allocation", "algorithm"]'
 test_files: []