sorare-rewards 1.2.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4f64ea163ad5ed02120737f8a540b3c1a86cbfc4e2d472ff4906cf2ca836f060
-  data.tar.gz: d9021d4ce7717b197408ee1e9e1da025e3af46f4f744862c987ea58654e9f191
+  metadata.gz: e8b73fbf4bff9af80575de83f2d3d726fa91a4d587892fb9d06eb88bf28e006f
+  data.tar.gz: e8d9949c62b554da58ba80ba1cb7c849bc5ba8cc6e5a565fac89fa316f961c48
 SHA512:
-  metadata.gz: eafcc27cb84b5974e901b8246fd49a9f351b7e88b784274eb2a3dc0b1086f6b11a6d96611b20790b42c92e83ac97e4abb6dadfa3b2f928f2c66db161451c86c4
-  data.tar.gz: db9da4a9da91484dd38a71afa544cc324d7c1e724a85cebe154453fa381c376c8c028ad3f4494e533cd6480657c6d6b9a6a2c2b6cef6e1be6f96fa2f57516222
+  metadata.gz: ce1fc376f8102f8df7ded7337f235f64393ed954e122b978051a9efbf6b9d70f2548f5ada427af8a070152495ba4206277f680c3a2cbcf6097a3cba2db4af48f
+  data.tar.gz: a338114ad5c95083d4e674880fae0a5b9285ccae2ae73d3358c908fb5a4551271590976a92fdbe79dc58b830b88e164eca3bc7384673dbde51a4db537add85e0

data/CHANGELOG.md

@@ -1,3 +1,29 @@
+## [1.4.1] - 2021-12-14
+
+### Fixes
+
+- Fix an issue where the `config` was null when accessed on a `GameWeek` with no loaded data
+
+## [1.4.0] - 2021-12-14
+
+### Added
+
+- Added support for rarity based `rewards_ratio_per_cards_in_circulation`
+
+## [1.3.0] - 2021-11-02
+
+### Breaking
+
+- Removed rewards method from `GameWeek` (`card_rewards`, `cards_picked`, `reward_allocations`, `prize_pools`, `card_allocations`)
+- `Picker` has been renamed to `CardPicker`
+
+### Added
+
+- Added a `GameWeekRewards` class that provides all rewards related methods
+- Added a way to pick cards with a custom `card_allocations`
+
 ## [1.2.0] - 2021-11-02
+
 ### Added
+
 - Enable cross leagues cooldown using `per_league` configuration flag

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sorare-rewards (1.2.0)
+    sorare-rewards (1.4.1)
       activesupport (~> 6.1.4)
       interactor (~> 3.1.2)
       json (~> 2)
@@ -20,7 +20,7 @@ GEM
     ast (2.4.2)
     concurrent-ruby (1.1.9)
     diff-lcs (1.4.4)
-    i18n (1.8.10)
+    i18n (1.8.11)
       concurrent-ruby (~> 1.0)
     interactor (3.1.2)
     io-wait (0.1.0)
@@ -29,7 +29,7 @@ GEM
     net-http (0.1.1)
       net-protocol
       uri
-    net-protocol (0.1.1)
+    net-protocol (0.1.2)
       io-wait
       timeout
     ostruct (0.4.0)
@@ -73,9 +73,9 @@ GEM
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.1.0)
-    uri (0.10.1)
+    uri (0.11.0)
     yaml (0.2.0)
-    zeitwerk (2.5.0)
+    zeitwerk (2.5.1)
 
 PLATFORMS
   ruby
@@ -90,4 +90,4 @@ DEPENDENCIES
   sorare-rewards!
 
 BUNDLED WITH
-   2.2.22
+   2.2.30

data/README.md

@@ -10,15 +10,14 @@ gem 'sorare-rewards'
 
 And then execute:
 
-    $ bundle install
+$ bundle install
 
 Or install it yourself as:
 
-    $ gem install sorare-rewards
+$ gem install sorare-rewards
 
 ## Usage
 
-
 First you need to load a game week
 
 ```ruby
@@ -27,21 +26,37 @@ game_week = Sorare::Rewards::GameWeek.new(hash: 'QmbwCo1fuhRN1T2DyEQtETefsBH6yCj
 
 Game Week's `hash` and `salt` can be retrieved using the GQL API, the salt is made public after the rewards have been distributed.
 
-
-To compute the number of rewards for the game week :
+To compute rewards for a game week :
 
 ```ruby
-# Card rewards :
-game_week.card_allocations
+rewards = Sorare::Rewards::GameWeekRewards.new(game_week: game_week)
+
+# Cards allocations :
+rewards.card_allocations
 
-# Eth rewards :
-game_week.prize_pools
+# Cards :
+rewards.cards
+
+# Prize pools :
+rewards.prize_pools
 ```
 
-To get the cards rewarded for a GameWeek :
+By default it uses the computed card allocations to pick the rewards. To override it :
 
 ```ruby
-game_week.cards_picked
+card_allocations = {
+  'global_all-star' => {
+    'D1' => {
+      'rare' => {
+        'tier_0' => 1,
+        ...
+      }
+    }
+  }
+}
+
+rewards = Sorare::Rewards::GameWeekRewards.new(game_week: game_week, card_allocations: card_allocations)
+
 ```
 
 ## Development
@@ -50,7 +65,6 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
-
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/lib/sorare/rewards/{picker.rb → card_picker.rb}

@@ -4,8 +4,8 @@ require 'active_support/core_ext/module/delegation'
 
 module Sorare
   module Rewards
-    # Picker allows to randomly pick a card
-    class Picker
+    # CardPicker allows to randomly pick a card
+    class CardPicker
       attr_accessor :cards, :player_counter
 
       delegate :length, to: :cards

data/lib/sorare/rewards/game_week.rb

@@ -6,13 +6,10 @@ require 'active_support/core_ext/module/delegation'
 
 module Sorare
   module Rewards
-    # GameWeek stores the reward data of a game week
+    # GameWeek stores the data of a game week
     class GameWeek
       attr_reader :salt
 
-      delegate :card_allocations, :prize_pools, to: :reward_allocations
-      delegate :cards_picked, to: :card_rewards
-
       def initialize(data: nil, hash: nil, salt: nil)
         @uri = URI("#{Sorare::Rewards.configuration.gateway}#{hash}")
         @data = data
@@ -30,7 +27,7 @@ module Sorare
       end
 
       def config
-        @config ||= GameWeekConfig.new(@data['config'])
+        @config ||= GameWeekConfig.new(data['config'])
       end
 
       def supply_for(league, rarity: nil, player: nil)
@@ -48,16 +45,6 @@ module Sorare
         end
       end
 
-      def reward_allocations
-        raise 'Salt required' unless salt
-
-        @reward_allocations ||= Sorare::Rewards::Build.call!(game_week: self, salt: salt)
-      end
-
-      def card_rewards
-        @card_rewards ||= Sorare::Rewards::Pick.call!(reward_allocations.to_h)
-      end
-
       def league(name)
         raise 'Unknown league' unless (leagues || {})[name]
 

data/lib/sorare/rewards/game_week_rewards.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+module Sorare
+  module Rewards
+    # GameWeekRewards stores rewards related data for a specified GameWeek, salt,
+    # And a card allocations hash
+    #    {
+    #      'global-all_star' => {
+    #        'D1' => {
+    #          'rare' => { 'tier_0' => 0, 'tier_1' => 1 }
+    #        }
+    #      }
+    #    }
+    class GameWeekRewards
+      attr_reader :game_week, :salt, :card_allocations
+
+      MISSING_PARAMETER = '%s parameter required'
+
+      def initialize(game_week:, salt: nil, card_allocations: nil)
+        @game_week = game_week
+        @salt = salt || game_week.salt
+        @card_allocations = card_allocations || computed_card_allocations
+      end
+
+      def cards
+        @cards ||= Sorare::Rewards::Pick.call!(
+          salt: salt,
+          game_week: game_week,
+          card_allocations: card_allocations
+        ).cards_picked
+      end
+
+      def prize_pools
+        @prize_pools ||= reward_allocations.prize_pools
+      end
+
+      def reward_allocations
+        validate!(:salt)
+
+        @reward_allocations ||= Sorare::Rewards::Build.call!(game_week: game_week, salt: salt)
+      end
+
+      def computed_card_allocations
+        Transposer.transpose_allocations(reward_allocations.card_allocations)
+      end
+
+      private
+
+      def validate!(field)
+        raise format(MISSING_PARAMETER, field) unless send(field)
+      end
+    end
+  end
+end

data/lib/sorare/rewards/interactors/build.rb

@@ -8,27 +8,26 @@ module Sorare
     class Build
       include Interactor
 
-      delegate :game_week, :salt, to: :context
+      delegate :game_week, to: :context
 
       def call
         context.card_allocations = allocate!
         context.prize_pools = prize_pools!
-        context.prize_pool_currency = game_week.config.prize_pool_currency
       end
 
       def game_week_supply
-        @game_week_supply ||= Supply::ComputeForGameWeek.call!(game_week: game_week, salt: salt)
+        @game_week_supply ||= Supply::ComputeForGameWeek.call!(game_week: game_week)
                                                         .game_week_supply
       end
 
       def allocate!
         Allocations::ComputeForGameWeek.call!(
-          game_week: game_week, supply: game_week_supply, salt: salt
+          supply: game_week_supply, public_seed: game_week.public_seed, salt: game_week.salt
         ).game_week_allocations
       end
 
       def prize_pools!
-        PrizePools::ComputeForGameWeek.call!(game_week: game_week, salt: salt).prize_pools
+        PrizePools::ComputeForGameWeek.call!(game_week: game_week).prize_pools
       end
     end
   end

data/lib/sorare/rewards/interactors/cards/pick_for_division.rb

@@ -10,8 +10,8 @@ module Sorare
       # PickForDivision picks the rewards for a given division
       # Receive a list of pickers for each tiers and quality
       #   {
-      #     'rare' => { 'tier_0' => Picker, 'tier_1' => Picker },
-      #     'super_rare' => { 'tier_0' => Picker, 'tier_1' => Picker }
+      #     'rare' => { 'tier_0' => CardPicker, 'tier_1' => CardPicker },
+      #     'super_rare' => { 'tier_0' => CardPicker, 'tier_1' => CardPicker }
       #   }
       # And a reward allocations
       #   {

data/lib/sorare/rewards/interactors/cards/pick_for_division_and_rarity.rb

@@ -9,7 +9,7 @@ module Sorare
       # PickForDivisionAndRarity picks the rewards for a given division and rarity
       # Receive a list of pickers for each tiers
       #   {
-      #     'tier_0' => Picker, 'tier_1' => Picker
+      #     'tier_0' => CardPicker, 'tier_1' => CardPicker
       #   }
       # A game week data
       # And a reward allocations

data/lib/sorare/rewards/interactors/cards/pick_for_game_week.rb

@@ -19,7 +19,7 @@ module Sorare
       class PickForGameWeek
         include Interactor
 
-        delegate :game_week, :allocations, :salt, :picks, to: :context
+        delegate :game_week, :allocations, :picks, to: :context
 
         def call
           context.cards_picked = pick!

data/lib/sorare/rewards/interactors/cards/pick_for_league.rb

@@ -17,8 +17,9 @@ module Sorare
       class PickForLeague
         include Interactor
 
-        delegate :salt, :league, :allocations, :pickers, to: :context
+        delegate :league, :allocations, :pickers, to: :context
         delegate :game_week, to: :league
+        delegate :public_seed, :salt, to: :game_week
 
         def call
           context.pickers = {}
@@ -48,7 +49,7 @@ module Sorare
         end
 
         def initialize_tier_picker(players, rarity, tier)
-          pickers[rarity][tier] = Picker.new(game_week.public_seed, salt)
+          pickers[rarity][tier] = CardPicker.new(public_seed, salt)
 
           players.each do |slug, _|
             pickers[rarity][tier].add_player(slug, player_supply(rarity, slug))

data/lib/sorare/rewards/interactors/pick.rb

@@ -11,8 +11,8 @@ module Sorare
     # And a reward allocations
     #    {
     #      'global-all_star' => {
-    #        'rare' => {
-    #          'D1' => { 'tier_0' => 0, 'tier_1' => 1 }
+    #        'D1' => {
+    #          'rare' => { 'tier_0' => 0, 'tier_1' => 1 }
     #        }
     #      }
     #    }
@@ -27,13 +27,9 @@ module Sorare
         context.cards_picked = Sorare::Rewards::Cards::PickForGameWeek.call!(
           **context.to_h,
           salt: salt,
-          allocations: transposed_allocations
+          allocations: Sorare::Rewards::GameWeekAllocations.new(card_allocations)
         ).cards_picked
       end
-
-      def transposed_allocations
-        Sorare::Rewards::GameWeekAllocations.new(Transposer.transpose_allocations(card_allocations))
-      end
     end
   end
 end

data/lib/sorare/rewards/interactors/supply/compute_for_game_week.rb

@@ -10,7 +10,7 @@ module Sorare
       class ComputeForGameWeek
         include Interactor
 
-        delegate :salt, :game_week, :game_week_supply, to: :context
+        delegate :game_week, :game_week_supply, to: :context
 
         def call
           context.game_week_supply = game_week_supply!
@@ -31,7 +31,7 @@ module Sorare
         end
 
         def randomizer
-          @randomizer ||= Sorare::Rewards::Random.new(game_week.public_seed, salt)
+          @randomizer ||= Sorare::Rewards::Random.new(game_week.public_seed, game_week.salt)
         end
       end
     end

data/lib/sorare/rewards/league.rb

@@ -24,9 +24,17 @@ module Sorare
       end
 
       def cards_in_circulation_limit(rarity)
-        return unless cards_in_circulation&.dig(rarity) && game_week.config.rewards_ratio_per_cards_in_circulation
+        return unless cards_in_circulation&.dig(rarity) && rewards_ratio_per_cards_in_circulation_for_rarity(rarity)
 
-        (cards_in_circulation[rarity] * game_week.config.rewards_ratio_per_cards_in_circulation).floor
+        (cards_in_circulation[rarity] * rewards_ratio_per_cards_in_circulation_for_rarity(rarity)).floor
+      end
+
+      def rewards_ratio_per_cards_in_circulation_for_rarity(rarity)
+        if game_week.config.rewards_ratio_per_cards_in_circulation.is_a?(Hash)
+          return game_week.config.rewards_ratio_per_cards_in_circulation[rarity]
+        end
+
+        game_week.config.rewards_ratio_per_cards_in_circulation
       end
 
       def each_division_prize_pools

data/lib/sorare/rewards/version.rb

@@ -2,6 +2,6 @@
 
 module Sorare
   module Rewards
-    VERSION = '1.2.0'
+    VERSION = '1.4.1'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sorare-rewards
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.4.1
 platform: ruby
 authors:
 - pierre
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-11-02 00:00:00.000000000 Z
+date: 2021-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -150,7 +150,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.5.0
-description: 
+description:
 email:
 - pierre@sorare.com
 executables: []
@@ -172,10 +172,12 @@ files:
 - data.patch
 - lib/sorare/rewards.rb
 - lib/sorare/rewards/allocation_configuration.yml
+- lib/sorare/rewards/card_picker.rb
 - lib/sorare/rewards/configuration.rb
 - lib/sorare/rewards/game_week.rb
 - lib/sorare/rewards/game_week_allocations.rb
 - lib/sorare/rewards/game_week_config.rb
+- lib/sorare/rewards/game_week_rewards.rb
 - lib/sorare/rewards/interactor.rb
 - lib/sorare/rewards/interactors/allocations/compute_for_game_week.rb
 - lib/sorare/rewards/interactors/allocations/compute_for_league.rb
@@ -197,7 +199,6 @@ files:
 - lib/sorare/rewards/interactors/tiers/qualify_players.rb
 - lib/sorare/rewards/interactors/tiers/qualify_supply.rb
 - lib/sorare/rewards/league.rb
-- lib/sorare/rewards/picker.rb
 - lib/sorare/rewards/player.rb
 - lib/sorare/rewards/prize_pool_configuration.yml
 - lib/sorare/rewards/random.rb
@@ -210,7 +211,7 @@ licenses:
 metadata:
   homepage_uri: https://gitlab.com/sorare/sorare-rewards
   source_code_uri: https://gitlab.com/sorare/sorare-rewards
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -225,8 +226,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
-signing_key: 
+rubygems_version: 3.2.3
+signing_key:
 specification_version: 4
 summary: '["Sorare", "reward", "allocation", "algorithm"]'
 test_files: []