RubyGems - sonicop - Versions diffs - 26.8.112 → 26.8.113 - Mend

sonicop 26.8.112 → 26.8.113

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (343) hide show

checksums.yaml +4 -4
data/Cargo.lock +11 -11
data/Cargo.toml +4 -4
data/README.ja.md +36 -23
data/README.md +38 -26
data/lib/sonicop/version.rb +1 -1
data/src/config/inheritance.rs +45 -3
data/src/engine.rs +11 -7
data/src/lib.rs +1 -0
data/src/nul_bytes.rs +2 -6
data/src/parser.rs +37 -0
data/src/profile.rs +13 -1
data/src/rules/bundler/duplicated_group.rs +3 -2
data/src/rules/bundler/gem_comment.rs +5 -4
data/src/rules/gemspec/attribute_assignment.rs +4 -3
data/src/rules/gemspec/deprecated_attribute_assignment.rs +7 -6
data/src/rules/gemspec/duplicated_assignment.rs +4 -3
data/src/rules/gemspec/require_mfa.rs +10 -9
data/src/rules/gemspec/required_ruby_version.rs +3 -2
data/src/rules/gemspec/support.rs +3 -2
data/src/rules/layout/array_alignment.rs +1 -2
data/src/rules/layout/block_end_newline.rs +5 -5
data/src/rules/layout/class_structure.rs +5 -3
data/src/rules/layout/closing_heredoc_indentation.rs +4 -3
data/src/rules/layout/closing_parenthesis_indentation.rs +1 -2
data/src/rules/layout/condition_position.rs +3 -2
data/src/rules/layout/def_end_alignment.rs +2 -2
data/src/rules/layout/dot_position.rs +1 -2
data/src/rules/layout/empty_line_after_guard_clause.rs +3 -6
data/src/rules/layout/empty_line_after_multiline_condition.rs +5 -5
data/src/rules/layout/empty_lines_around_access_modifier.rs +2 -3
data/src/rules/layout/empty_lines_around_arguments.rs +4 -4
data/src/rules/layout/empty_lines_around_exception_handling_keywords.rs +1 -2
data/src/rules/layout/empty_lines_around_method_body.rs +3 -2
data/src/rules/layout/end_alignment.rs +2 -2
data/src/rules/layout/extra_spacing.rs +7 -6
data/src/rules/layout/first_array_element_indentation.rs +1 -2
data/src/rules/layout/first_hash_element_indentation.rs +8 -6
data/src/rules/layout/hash_alignment.rs +4 -4
data/src/rules/layout/heredoc_argument_closing_parenthesis.rs +6 -5
data/src/rules/layout/heredoc_indentation.rs +4 -3
data/src/rules/layout/indentation_style.rs +4 -3
data/src/rules/layout/indentation_width.rs +14 -13
data/src/rules/layout/line_continuation_leading_space.rs +4 -3
data/src/rules/layout/line_continuation_spacing.rs +2 -2
data/src/rules/layout/line_length.rs +101 -57
data/src/rules/layout/multiline_assignment_layout.rs +4 -3
data/src/rules/layout/multiline_block_layout.rs +1 -2
data/src/rules/layout/multiline_expression.rs +60 -31
data/src/rules/layout/multiline_hash_brace_layout.rs +4 -3
data/src/rules/layout/multiline_method_call_indentation.rs +1 -1
data/src/rules/layout/multiline_operation_indentation.rs +3 -3
data/src/rules/layout/redundant_line_break.rs +3 -2
data/src/rules/layout/single_line_block_chain.rs +4 -3
data/src/rules/layout/space_around_block_parameters.rs +1 -2
data/src/rules/layout/space_around_equals_in_parameter_default.rs +1 -2
data/src/rules/layout/space_around_operators.rs +1 -2
data/src/rules/layout/space_before_brackets.rs +6 -5
data/src/rules/layout/space_before_comma.rs +3 -2
data/src/rules/layout/space_inside_range_literal.rs +8 -6
data/src/rules/layout/support.rs +9 -7
data/src/rules/layout/tokens.rs +15 -6
data/src/rules/lint/access_modifier.rs +19 -10
data/src/rules/lint/ambiguity.rs +2 -2
data/src/rules/lint/ambiguous_block_association.rs +7 -10
data/src/rules/lint/ambiguous_regexp_literal.rs +7 -5
data/src/rules/lint/array_literal_in_regexp.rs +4 -3
data/src/rules/lint/assignment_in_condition.rs +3 -2
data/src/rules/lint/blocks.rs +2 -1
data/src/rules/lint/boolean_symbol.rs +4 -4
data/src/rules/lint/constant_definition_in_block.rs +1 -2
data/src/rules/lint/constant_reassignment.rs +2 -1
data/src/rules/lint/deprecated_open_ssl_constant.rs +1 -2
data/src/rules/lint/disjunctive_assignment_in_constructor.rs +2 -2
data/src/rules/lint/duplicate_branch.rs +6 -5
data/src/rules/lint/duplicate_case_condition.rs +5 -5
data/src/rules/lint/duplicate_hash_key.rs +4 -3
data/src/rules/lint/duplicate_match_pattern.rs +7 -5
data/src/rules/lint/duplicate_methods.rs +4 -3
data/src/rules/lint/duplicate_require.rs +1 -2
data/src/rules/lint/duplicate_set_element.rs +3 -2
data/src/rules/lint/empty_conditional_body.rs +4 -3
data/src/rules/lint/empty_in_pattern.rs +3 -2
data/src/rules/lint/empty_when.rs +4 -4
data/src/rules/lint/ensure_return.rs +3 -2
data/src/rules/lint/float_comparison.rs +8 -6
data/src/rules/lint/format_parameter_mismatch.rs +4 -3
data/src/rules/lint/hash_compare_by_identity.rs +5 -4
data/src/rules/lint/heredoc_method_call_position.rs +3 -2
data/src/rules/lint/implicit_string_concatenation.rs +7 -5
data/src/rules/lint/ineffective_access_modifier.rs +5 -4
data/src/rules/lint/inherit_exception.rs +4 -3
data/src/rules/lint/literal_as_condition.rs +5 -3
data/src/rules/lint/literal_assignment_in_condition.rs +4 -3
data/src/rules/lint/literal_in_interpolation.rs +5 -5
data/src/rules/lint/literals.rs +10 -8
data/src/rules/lint/no_return_in_begin_end_blocks.rs +2 -2
data/src/rules/lint/node_equality.rs +8 -5
data/src/rules/lint/non_atomic_file_operation.rs +1 -1
data/src/rules/lint/non_deterministic_require_order.rs +5 -3
data/src/rules/lint/non_local_exit_from_iterator.rs +3 -2
data/src/rules/lint/number_conversion.rs +1 -1
data/src/rules/lint/out_of_range_regexp_ref.rs +6 -4
data/src/rules/lint/redundant_dir_glob_sort.rs +1 -2
data/src/rules/lint/redundant_safe_navigation.rs +4 -3
data/src/rules/lint/redundant_splat_expansion.rs +4 -2
data/src/rules/lint/redundant_string_coercion.rs +3 -2
data/src/rules/lint/regexp_source.rs +2 -2
data/src/rules/lint/require_range_parentheses.rs +5 -5
data/src/rules/lint/rescue_exception.rs +4 -3
data/src/rules/lint/rescue_type.rs +3 -2
data/src/rules/lint/return_in_void_context.rs +2 -2
data/src/rules/lint/safe_navigation_chain.rs +3 -2
data/src/rules/lint/self_assignment.rs +3 -2
data/src/rules/lint/shadowed_argument.rs +2 -2
data/src/rules/lint/shadowed_exception.rs +2 -2
data/src/rules/lint/suppressed_exception_in_number_conversion.rs +4 -3
data/src/rules/lint/symbol_conversion.rs +6 -5
data/src/rules/lint/syntax.rs +4 -3
data/src/rules/lint/triple_quotes.rs +3 -2
data/src/rules/lint/unescaped_bracket_in_regexp.rs +1 -1
data/src/rules/lint/unexpected_block_arity.rs +3 -2
data/src/rules/lint/unmodified_reduce_accumulator.rs +7 -6
data/src/rules/lint/unreachable_pattern_branch.rs +4 -4
data/src/rules/lint/unused_block_argument.rs +2 -2
data/src/rules/lint/unused_method_argument.rs +1 -2
data/src/rules/lint/useless_assignment.rs +3 -2
data/src/rules/lint/useless_constant_scoping.rs +3 -2
data/src/rules/lint/useless_else_without_rescue.rs +4 -3
data/src/rules/lint/useless_rescue.rs +5 -4
data/src/rules/lint/useless_ruby2_keywords.rs +2 -1
data/src/rules/lint/useless_setter_call.rs +5 -4
data/src/rules/lint/useless_times.rs +4 -3
data/src/rules/lint/variable_force.rs +146 -100
data/src/rules/lint/void.rs +5 -4
data/src/rules/metrics/block_nesting.rs +1 -2
data/src/rules/metrics/collection_literal_length.rs +2 -1
data/src/rules/metrics/complexity.rs +18 -13
data/src/rules/metrics/fragments.rs +10 -14
data/src/rules/metrics/locals.rs +23 -12
data/src/rules/metrics/parameter_lists.rs +7 -6
data/src/rules/metrics/support.rs +1 -1
data/src/rules/mod.rs +464 -62
data/src/rules/naming/ascii_identifiers.rs +3 -3
data/src/rules/naming/block_forwarding.rs +9 -8
data/src/rules/naming/constant_name.rs +1 -1
data/src/rules/naming/predicate_method.rs +6 -5
data/src/rules/naming/predicate_prefix.rs +10 -8
data/src/rules/naming/rescued_exceptions_variable_name.rs +8 -6
data/src/rules/naming/support.rs +7 -5
data/src/rules/naming/variable_number.rs +4 -4
data/src/rules/node_ext.rs +1 -1
data/src/rules/ruby_literal.rs +3 -2
data/src/rules/security/compound_hash.rs +3 -2
data/src/rules/security/open.rs +5 -4
data/src/rules/send_node.rs +134 -0
data/src/rules/single_line.rs +4 -4
data/src/rules/style/access_modifier_declarations.rs +1 -1
data/src/rules/style/alias.rs +1 -2
data/src/rules/style/and_or.rs +2 -2
data/src/rules/style/arguments_forwarding.rs +5 -5
data/src/rules/style/array_coercion.rs +5 -5
data/src/rules/style/array_first_last.rs +3 -3
data/src/rules/style/array_intersect.rs +2 -2
data/src/rules/style/array_intersect_with_single_element.rs +1 -1
data/src/rules/style/attr.rs +1 -1
data/src/rules/style/auto_resource_cleanup.rs +1 -1
data/src/rules/style/bitwise_predicate.rs +2 -2
data/src/rules/style/block_args.rs +1 -1
data/src/rules/style/block_delimiters.rs +7 -6
data/src/rules/style/case_equality.rs +3 -2
data/src/rules/style/case_like_if.rs +1 -1
data/src/rules/style/class_and_module_children.rs +7 -5
data/src/rules/style/class_methods.rs +1 -1
data/src/rules/style/collection_compact.rs +4 -4
data/src/rules/style/combinable_defined.rs +2 -2
data/src/rules/style/combinable_loops.rs +1 -1
data/src/rules/style/comparable_clamp.rs +2 -2
data/src/rules/style/concat_array_literals.rs +3 -3
data/src/rules/style/conditional.rs +8 -1
data/src/rules/style/constant_visibility.rs +3 -3
data/src/rules/style/copyright.rs +1 -1
data/src/rules/style/data_inheritance.rs +1 -1
data/src/rules/style/def_with_parentheses.rs +1 -1
data/src/rules/style/document_dynamic_eval_definition.rs +1 -1
data/src/rules/style/documentation.rs +1 -1
data/src/rules/style/each_for_simple_loop.rs +1 -1
data/src/rules/style/each_with_object.rs +4 -4
data/src/rules/style/empty_block_parameter.rs +1 -1
data/src/rules/style/empty_case_condition.rs +6 -6
data/src/rules/style/empty_class_definition.rs +1 -1
data/src/rules/style/empty_else.rs +1 -1
data/src/rules/style/empty_heredoc.rs +1 -1
data/src/rules/style/empty_lambda_parameter.rs +1 -1
data/src/rules/style/empty_literal.rs +2 -2
data/src/rules/style/empty_method.rs +1 -1
data/src/rules/style/empty_string_inside_interpolation.rs +1 -1
data/src/rules/style/endless.rs +1 -1
data/src/rules/style/env_home.rs +1 -1
data/src/rules/style/even_odd.rs +1 -1
data/src/rules/style/exact_regexp_match.rs +1 -1
data/src/rules/style/expand_path_arguments.rs +3 -3
data/src/rules/style/explicit_block_argument.rs +3 -3
data/src/rules/style/file_open_call.rs +3 -3
data/src/rules/style/file_write.rs +1 -1
data/src/rules/style/for.rs +1 -1
data/src/rules/style/format_string.rs +2 -2
data/src/rules/style/format_string_token.rs +6 -6
data/src/rules/style/guard_clause.rs +8 -7
data/src/rules/style/hash_as_last_array_item.rs +4 -4
data/src/rules/style/hash_each_methods.rs +1 -1
data/src/rules/style/hash_like_case.rs +8 -8
data/src/rules/style/hash_lookup_method.rs +3 -3
data/src/rules/style/hash_subset.rs +16 -10
data/src/rules/style/hash_syntax.rs +4 -4
data/src/rules/style/hash_transform.rs +20 -18
data/src/rules/style/identical_conditional_branches.rs +4 -5
data/src/rules/style/if_inside_else.rs +3 -3
data/src/rules/style/if_unless_modifier.rs +13 -14
data/src/rules/style/if_with_boolean_literal_branches.rs +1 -1
data/src/rules/style/if_with_semicolon.rs +1 -1
data/src/rules/style/in_pattern_then.rs +2 -2
data/src/rules/style/inverse_methods.rs +2 -2
data/src/rules/style/invertible_unless_condition.rs +3 -3
data/src/rules/style/it_block_parameter.rs +1 -1
data/src/rules/style/keyword_arguments_merging.rs +2 -2
data/src/rules/style/keyword_parameters_order.rs +1 -1
data/src/rules/style/magic_comment_format.rs +3 -2
data/src/rules/style/map_chain.rs +1 -1
data/src/rules/style/map_compact_with_conditional_block.rs +3 -3
data/src/rules/style/map_into_array.rs +7 -7
data/src/rules/style/map_join.rs +3 -3
data/src/rules/style/method_call_with_args_parentheses.rs +7 -7
data/src/rules/style/method_call_without_args_parentheses.rs +2 -2
data/src/rules/style/method_def_parentheses.rs +2 -3
data/src/rules/style/min_max.rs +3 -3
data/src/rules/style/min_max_comparison.rs +2 -2
data/src/rules/style/missing_else.rs +1 -1
data/src/rules/style/missing_respond_to_missing.rs +1 -1
data/src/rules/style/mixin_grouping.rs +1 -1
data/src/rules/style/multiline_block_chain.rs +2 -2
data/src/rules/style/multiline_if_then.rs +1 -1
data/src/rules/style/multiline_in_pattern_then.rs +1 -1
data/src/rules/style/multiline_method_signature.rs +1 -1
data/src/rules/style/multiline_when_then.rs +2 -2
data/src/rules/style/mutable_constant.rs +3 -3
data/src/rules/style/negated_if.rs +2 -2
data/src/rules/style/negated_if_else_condition.rs +2 -2
data/src/rules/style/negated_while.rs +1 -1
data/src/rules/style/negative_array_index.rs +2 -2
data/src/rules/style/nested_modifier.rs +1 -1
data/src/rules/style/nested_parenthesized_calls.rs +2 -2
data/src/rules/style/nested_ternary_operator.rs +2 -2
data/src/rules/style/next.rs +1 -1
data/src/rules/style/nil_lambda.rs +2 -2
data/src/rules/style/nodes.rs +21 -0
data/src/rules/style/non_nil_check.rs +2 -2
data/src/rules/style/numbered_parameters_limit.rs +2 -2
data/src/rules/style/one_line_conditional.rs +4 -4
data/src/rules/style/optional_arguments.rs +1 -1
data/src/rules/style/or_assignment.rs +1 -1
data/src/rules/style/parallel_assignment.rs +9 -10
data/src/rules/style/parens.rs +1 -1
data/src/rules/style/parentheses_around_condition.rs +3 -3
data/src/rules/style/partition_instead_of_double_select.rs +3 -3
data/src/rules/style/percent.rs +9 -7
data/src/rules/style/percent_q_literals.rs +4 -3
data/src/rules/style/preferred_hash_methods.rs +1 -1
data/src/rules/style/random_with_offset.rs +1 -1
data/src/rules/style/reduce_to_hash.rs +6 -6
data/src/rules/style/redundant_argument.rs +1 -1
data/src/rules/style/redundant_assignment.rs +5 -5
data/src/rules/style/redundant_begin.rs +2 -2
data/src/rules/style/redundant_capital_w.rs +3 -2
data/src/rules/style/redundant_condition.rs +9 -7
data/src/rules/style/redundant_current_directory_in_path.rs +2 -2
data/src/rules/style/redundant_double_splat_hash_braces.rs +4 -4
data/src/rules/style/redundant_file_extension_in_require.rs +2 -2
data/src/rules/style/redundant_format.rs +16 -14
data/src/rules/style/redundant_freeze.rs +1 -1
data/src/rules/style/redundant_heredoc_delimiter_quotes.rs +1 -1
data/src/rules/style/redundant_initialize.rs +2 -2
data/src/rules/style/redundant_interpolation.rs +2 -2
data/src/rules/style/redundant_interpolation_unfreeze.rs +2 -2
data/src/rules/style/redundant_line_continuation.rs +5 -4
data/src/rules/style/redundant_parentheses.rs +16 -15
data/src/rules/style/redundant_regexp_argument.rs +1 -1
data/src/rules/style/redundant_regexp_character_class.rs +4 -3
data/src/rules/style/redundant_regexp_escape.rs +3 -2
data/src/rules/style/redundant_return.rs +1 -2
data/src/rules/style/redundant_self.rs +11 -11
data/src/rules/style/redundant_sort.rs +1 -1
data/src/rules/style/redundant_sort_by.rs +1 -1
data/src/rules/style/redundant_string_escape.rs +6 -5
data/src/rules/style/regexp_literal.rs +3 -2
data/src/rules/style/require_order.rs +2 -2
data/src/rules/style/rescue_modifier.rs +1 -1
data/src/rules/style/rescue_standard_error.rs +1 -1
data/src/rules/style/return_nil.rs +2 -2
data/src/rules/style/return_nil_in_predicate_method_definition.rs +2 -2
data/src/rules/style/safe_navigation.rs +2 -2
data/src/rules/style/sample.rs +3 -3
data/src/rules/style/select_by.rs +2 -2
data/src/rules/style/select_by_range.rs +1 -1
data/src/rules/style/semicolon.rs +5 -4
data/src/rules/style/single_argument_dig.rs +1 -1
data/src/rules/style/single_line_block_params.rs +7 -6
data/src/rules/style/single_line_do_end_block.rs +13 -12
data/src/rules/style/single_line_methods.rs +2 -2
data/src/rules/style/slicing_with_range.rs +2 -2
data/src/rules/style/sole_nested_conditional.rs +4 -4
data/src/rules/style/special_global_vars.rs +2 -2
data/src/rules/style/stabby_lambda_parentheses.rs +1 -1
data/src/rules/style/statement_modifier.rs +3 -2
data/src/rules/style/static_class.rs +1 -1
data/src/rules/style/string_concatenation.rs +9 -7
data/src/rules/style/string_hash_keys.rs +3 -2
data/src/rules/style/string_literals.rs +3 -3
data/src/rules/style/string_literals_in_interpolation.rs +1 -1
data/src/rules/style/struct_inheritance.rs +3 -3
data/src/rules/style/super_arguments.rs +2 -2
data/src/rules/style/super_with_args_parentheses.rs +1 -1
data/src/rules/style/swap_values.rs +1 -1
data/src/rules/style/symbol_array.rs +1 -1
data/src/rules/style/symbol_proc.rs +3 -3
data/src/rules/style/tally_method.rs +4 -4
data/src/rules/style/ternary_parentheses.rs +4 -4
data/src/rules/style/top_level_method_definition.rs +1 -1
data/src/rules/style/trailing_body.rs +1 -1
data/src/rules/style/trailing_comma_in_array_literal.rs +1 -1
data/src/rules/style/trailing_comma_in_hash_literal.rs +1 -1
data/src/rules/style/trailing_method_end_statement.rs +1 -1
data/src/rules/style/trailing_underscore_variable.rs +4 -5
data/src/rules/style/trivial_accessors.rs +2 -2
data/src/rules/style/unless_logical_operators.rs +1 -1
data/src/rules/style/unpack_first.rs +1 -1
data/src/rules/style/when_then.rs +4 -4
data/src/rules/style/while_until_do.rs +1 -1
data/src/rules/style/while_until_modifier.rs +3 -3
data/src/rules/style/word_array.rs +3 -3
data/src/rules/style/yoda_condition.rs +2 -2
data/src/rules/support.rs +33 -8
metadata +2 -1

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd4ccd5169f98c0ac8c5aedbe9dd4662344c27da16b2a4ea009a5f95b77a0cff
-  data.tar.gz: d516055ea9785026bda48a405d49ad97fc0e0851469bafa7d71cb341b663bda3
+  metadata.gz: 60de249d7f58e674b388a3514790bbaf79f4fc4ce59338d281b1684fbe124bd2
+  data.tar.gz: afe8bb37e97f4c4043825877ca906d79e7511dc98e1ac6270a8b2d84a3824f30
 SHA512:
-  metadata.gz: a28ead40c6fd72e5e79ea4c69e3d6dabeeb1a5af3004110548ae02cbad6310bbdaf6fe7f5765afc3014d77dd640dcad02821465be4d6d866808f080bc697f822
-  data.tar.gz: f422f7e53c4e4a7535ac1910ca2bbf50a0e7fae1851fcb94621a0dcec388bf4bdd0164962b140187085e15eabb5e31351f0e4c0a04ae6cb050fa8b1f7834e009
+  metadata.gz: 856f0aab5b6a28b07ddc026d2513b9415f7b50b3697b1e256667796683b929dade0950e22b71dc90259d98ab6ef5ffb43f5db7ab059e2d3948deacdafc080251
+  data.tar.gz: ebfba527d38101fec7b231c916dfb5ee3c47f602da107a555a8a7df56c1393c4c2ed968f1f113881a73a723cd8136593e7c1e304ffd81fe52b2e1795ff216d7e

data/Cargo.lock CHANGED Viewed

@@ -128,9 +128,9 @@ dependencies = [
 [[package]]
 name = "bstr"
-version = "1.13.0"
+version = "1.13.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1f7dc094d718f2e1c1559ad110e27eeaae14a5465d3d56dd6dbd793079fbd530"
+checksum = "6bb31b46c14244e20ee9984b11bf5c992b91fb6939fea616e3512c8baecdbe5f"
 dependencies = [
  "memchr",
  "regex-automata",
@@ -145,9 +145,9 @@ checksum = "fc652a48c352aef3ea3aed32080501cf3ef6ed5da78602a020c991775b0aff04"
 [[package]]
 name = "cc"
-version = "1.4.0"
+version = "1.4.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5add81bb678e6cb321aff7fa0dc7689ad82b112dbc032cea19f91d6b8e3582b9"
+checksum = "509591b7bcd67f4ef775afad7662703b4935daaa6ec0e5605cfb1090b32a2b6d"
 dependencies = [
  "find-msvc-tools",
  "shlex",
@@ -317,9 +317,9 @@ checksum = "da7c62ceae207dd37ea5b845da6a0696c799f85e97da1ab5b7910be3c1c80223"
 [[package]]
 name = "find-msvc-tools"
-version = "0.1.9"
+version = "0.1.11"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5baebc0774151f905a1a2cc41989300b1e6fbb29aff0ceffa1064fdd3088d582"
+checksum = "d45db016d36b838f563236e9193d0ee6ce38f3f68b6c94e914b4929c96bbb890"
 [[package]]
 name = "foreign-types"
@@ -549,9 +549,9 @@ checksum = "9b4f627cb1b25917193a259e49bdad08f671f8d9708acfd5fe0a8c1455d87220"
 [[package]]
 name = "pkg-config"
-version = "0.3.33"
+version = "0.3.34"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "19f132c84eca552bf34cab8ec81f1c1dcc229b811638f9d283dceabe58c5569e"
+checksum = "f6b464fbc74e149a392436b17d523f769e057cb6877f6a5c4618bc6f11800548"
 [[package]]
 name = "predicates"
@@ -793,7 +793,7 @@ checksum = "f8fadd59c855ef2080decdef8ff161eb6661b86933c9d82e5ba29dc602a55aba"
 [[package]]
 name = "sonicop"
-version = "26.8.112"
+version = "26.8.113"
 dependencies = [
  "anyhow",
  "assert_cmd",
@@ -880,9 +880,9 @@ checksum = "8f50febec83f5ee1df3015341d8bd429f2d1cc62bcba7ea2076759d315084683"
 [[package]]
 name = "tree-sitter"
-version = "0.26.11"
+version = "0.26.12"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "af1c71c1c4cc0920b20d6b0f6572e7682cd07a6a2faec71067a31fa394c586df"
+checksum = "83c567a8e18ae93f20982c90370b16fd24023aeaf52f6052b96957ab253a0fec"
 dependencies = [
  "cc",
  "regex",

data/Cargo.toml CHANGED Viewed

@@ -1,6 +1,6 @@
 [package]
 name = "sonicop"
-version = "26.8.112"
+version = "26.8.113"
 edition = "2024"
 rust-version = "1.85"
 description = "A fast, native RuboCop-compatible Ruby linter and formatter"
@@ -29,7 +29,7 @@ serde_json = "1.0.151"
 serde_yaml_ng = "0.10"
 shell-words = "1.1.1"
 tempfile = "3.27.0"
-tree-sitter = "0.26.11"
+tree-sitter = "0.26.12"
 tree-sitter-ruby = { git = "https://github.com/owayo/tree-sitter-ruby.git", tag = "v26.8.103" }
 ureq = { version = "3.4", default-features = false, features = ["native-tls"] }
@@ -44,8 +44,8 @@ lto = "thin"
 codegen-units = 1
 strip = true
-# `cargo build --profile profiling` keeps the symbols a sampling profiler needs while
-# generating exactly the code `--release` does.
+# `cargo build --profile profiling` はサンプリングプロファイラ用のシンボルを残しつつ、
+# `--release` と同じ最適化コードを生成する。
 [profile.profiling]
 inherits = "release"
 debug = 1

data/README.ja.md CHANGED Viewed

@@ -153,6 +153,8 @@ sonicop --show-cops
 `AllCops/DisabledByDefault`、`Include`／`Exclude`、Cop ごとの `Enabled`、`Exclude`、
 `Severity`、`Safe`、`SafeAutoCorrect` と設定値に対応します。宣言されたプラグイン由来の
 Cop は「認識済み・未実装」として受理し、Ruby プラグインコード自体は実行しません。
+リモート設定のリクエストには 30 秒のネットワークタイムアウトを設け、応答は 1 件あたり
+5 MiB に制限します。
 ```yaml
 inherit_from: .rubocop_todo.yml
@@ -229,52 +231,63 @@ autocorrect は RuboCop 自身のツリーと Mastodon でバイト単位に一
 既定の実行はどちらの群にも届きません。）
 各値は暖機後 2 回の最速値です。
-| コーパス | ファイル | RuboCop 並列 | Sonicop 並列 | RuboCop 単一 | Sonicop 単一 |
-|---|---:|---:|---:|---:|---:|
-| rubocop/rubocop | 1,765 | 12.71 秒 | **4.59 秒** | 42.74 秒 | **13.75 秒** |
-| mastodon/mastodon | 3,290 | 29.95 秒 | **6.48 秒** | 37.60 秒 | **15.88 秒** |
-| Homebrew/brew | 2,179 | 18.20 秒 | **4.31 秒** | 38.72 秒 | **11.67 秒** |
-| rails/rails | 3,551 | 52.55 秒 | **16.88 秒** | 162.55 秒 | **63.97 秒** |
-| ruby/ruby | 7,466 | 132.17 秒 | **43.10 秒** | 199.78 秒 | **76.07 秒** |
+| コーパス | ファイル | offense | RuboCop 並列 | Sonicop 並列 | RuboCop 単一 | Sonicop 単一 |
+|---|---:|---:|---:|---:|---:|---:|
+| rubocop/rubocop | 1,780 | 5,826 | 10.85 秒 | **1.53 秒** | 41.44 秒 | **8.96 秒** |
+| mastodon/mastodon | 3,292 | 15,293 | 22.59 秒 | **3.04 秒** | 34.74 秒 | **6.86 秒** |
+| Homebrew/brew | 2,296 | 51,527 | 13.56 秒 | **2.21 秒** | 40.36 秒 | **6.51 秒** |
+| rails/rails | 3,562 | 168,615 | 32.90 秒 | **8.84 秒** | 85.71 秒 | **19.17 秒** |
+| ruby/ruby | 7,477 | 765,975 | 86.89 秒 | **15.59 秒** | 193.59 秒 | **37.98 秒** |
-差は並列で 2.8〜4.6 倍、単一プロセスで 2.4〜3.3 倍と幅があり、1 コーパスでは代表できません。
+差は並列で 3.7〜7.4 倍、単一プロセスで 4.5〜6.2 倍と幅があり、1 コーパスでは代表できません。
 **単一プロセスの列を読み、並列は目安として扱ってください。** 同じ 2 つのバイナリを 1 日に
 3 回測ったところ、単一プロセスの値は毎回 16% 以内に収まったのに対し、RuboCop 自身のツリーでの
 並列の倍率は、マシンが他に何をしていたかだけで 3.3 倍から 9.2 倍まで動きました。単一プロセスは
 エンジンを測っていますが、並列はエンジンに加えて「その実行でスケジューリングがそのツリーに
 どれだけ噛み合ったか」を測っています。
-仕事を省いて速いわけではありません。この同じ 394 Cop について、RuboCop 自身のツリー・
-Rails・Mastodon の 3 つで**すべての offense が一致**します（計 188,812 件、どちらの側にも
-残りません）。autocorrect は前者と後者でバイト単位に一致します。
+仕事を省いて速いわけではありません。この同じ 394 Cop について、表のどのコーパスでも
+**offense の総数が一致**し、RuboCop 自身のツリーと Mastodon ではその 1 件ずつが同じ位置・
+同じメッセージ・同じ severity です。Rails は 168,615 件のうち 2 件だけ食い違います
+（Sonicop が出す `Style/CaseLikeIf` 1 件と、出さない `Metrics/AbcSize` 1 件）。
+RuboCop 自身のツリーでは 1 件の `correctable` フラグが違います。
+autocorrect は前者と後者でバイト単位に一致します。
-再現時に注意が必要な点が 3 つあります。RuboCop は **`--cache false` と併用すると
+再現時に注意が必要な点が 4 つあります。RuboCop は **`--cache false` と併用すると
 `--parallel` を黙って無効化します**。そのためここでの並列実行はキャッシュを有効にしたうえで
 実行ごとにキャッシュディレクトリを消しており、`--cache false --parallel` で計測すると
 単一プロセスを測ることになり差が過大に出ます。また RuboCop の既定は単一プロセス、
 Sonicop は `--no-parallel` を渡さない限り並列です。そして**両方ともキャッシュを空にする**
 必要があります。Sonicop も既定でキャッシュするため、同じツリーを 2 回目に流すと自分の
 キャッシュが答えてしまい、エンジンについては何も測れません。どちらにも使い捨ての
-キャッシュディレクトリを渡してください。
+キャッシュディレクトリを渡してください。最後に、そのキャッシュディレクトリは**実パス**である
+必要があります。macOS の `mktemp -d` は `/var/folders/…` を返し、その `/var` は symlink なので
+RuboCop はそこを拒み、キャッシュ無しで走ってしまいます。
 ```bash
 # RuboCop（並列・キャッシュは毎回空・既定の全 394 Cop）
-rubocop --force-default-config --cache true --cache-root "$(mktemp -d)" \
+root=$(mktemp -d /private/tmp/bench.XXXXXX)
+rubocop --force-default-config --cache true --cache-root "$root" \
         --no-color --parallel -f quiet
 # Sonicop（キャッシュは毎回空）
-sonicop --force-default-config --cache-root "$(mktemp -d)" --format quiet
+sonicop --force-default-config --cache-root "$root" --format quiet
 ```
+キャッシュの書き込みもこの数値に含まれており、無料ではありません。索引は全 offense を
+「見つかった行のテキスト」付きで保持するため、`ruby/ruby` では 336 MB になります。
+2 回目の実行（キャッシュ命中）は `ruby/ruby` で 1.59 秒、Rails で 0.42 秒です。
 測定機は Apple M2（8 コア）、Ruby 4.0.6（YJIT 利用可）、RubyGems 導入の RuboCop 1.89.0。
-1 分平均のロードアベレージは、計測開始時が 4.0、終了時が 3.1 でした。**アイドル状態ではありません**。
-RuboCop 自身のツリーだけは後から単独で測り直しています（負荷 3.7 → 4.0）。1 回目はリリース
-ビルドの終わりがけに走ってしまい、値が 60% ほど高く出たためです。**負荷の違う 1 行を同じ表に
-並べることはできません**。
-両者を同じ条件で測っているため倍率は保たれますが、秒数そのものは下限ではなく、静かなマシンなら
-より速く出ます。コアを奪い合うものが動いていると両者とも膨らみ、その度合いは一致しません。それが
-並列の列があれだけ動く理由です。秒数そのものが重要なときは、他に負荷のない状態で測り、**実行の
-前後でロードアベレージを記録してください** — その情報が無い数値は、別の数値と比べられません。
+2026-08-31 に、`rubocop_rubocop` 2693129 / `mastodon_mastodon` b59ddc7 / `Homebrew_brew` b42173b /
+`rails_rails` a19f07f / `ruby_ruby` 22e4a75 の各リビジョンに対して測定しました。
+1 分平均のロードアベレージは各行の測定時点で 4.5〜7.1 で、その大半は RuboCop 自身の並列
+ワーカーです（計測する以上避けられません）。**アイドル状態ではありません。**
+各コーパスで両者を連続して同じ条件で測っているため倍率は保たれますが、秒数そのものは下限ではなく、
+静かなマシンならより速く出ます。コアを奪い合うものが動いていると両者とも膨らみ、その度合いは
+一致しません。それが並列の列があれだけ動く理由です。秒数そのものが重要なときは、他に負荷のない
+状態で測り、**実行の前後でロードアベレージを記録してください** — その情報が無い数値は、
+別の数値と比べられません。
 ## 開発

data/README.md CHANGED Viewed

@@ -160,6 +160,8 @@ run. Local and HTTPS `inherit_from`, `inherit_gem`, `inherit_mode`,
 `AllCops/DisabledByDefault`, `Include`, and `Exclude`, plus per-cop `Enabled`, `Exclude`,
 `Severity`, `Safe`, `SafeAutoCorrect`, and cop settings are supported. Cops supplied by declared
 plugins are accepted as recognized-but-unimplemented without executing Ruby plugin code.
+Remote configuration requests use 30-second network timeouts, and each response is limited to
+5 MiB.
 ```yaml
 inherit_from: .rubocop_todo.yml
@@ -240,52 +242,62 @@ once the 159 RuboCop ships as `Enabled: pending` and the 56 it ships as `Enabled
 aside; a default run reaches neither group on either side.) Times are the fastest of two
 warmed runs.
-| Corpus | Files | RuboCop parallel | Sonicop parallel | RuboCop single | Sonicop single |
-|---|---:|---:|---:|---:|---:|
-| rubocop/rubocop | 1,765 | 12.71 s | **4.59 s** | 42.74 s | **13.75 s** |
-| mastodon/mastodon | 3,290 | 29.95 s | **6.48 s** | 37.60 s | **15.88 s** |
-| Homebrew/brew | 2,179 | 18.20 s | **4.31 s** | 38.72 s | **11.67 s** |
-| rails/rails | 3,551 | 52.55 s | **16.88 s** | 162.55 s | **63.97 s** |
-| ruby/ruby | 7,466 | 132.17 s | **43.10 s** | 199.78 s | **76.07 s** |
+| Corpus | Files | Offenses | RuboCop parallel | Sonicop parallel | RuboCop single | Sonicop single |
+|---|---:|---:|---:|---:|---:|---:|
+| rubocop/rubocop | 1,780 | 5,826 | 10.85 s | **1.53 s** | 41.44 s | **8.96 s** |
+| mastodon/mastodon | 3,292 | 15,293 | 22.59 s | **3.04 s** | 34.74 s | **6.86 s** |
+| Homebrew/brew | 2,296 | 51,527 | 13.56 s | **2.21 s** | 40.36 s | **6.51 s** |
+| rails/rails | 3,562 | 168,615 | 32.90 s | **8.84 s** | 85.71 s | **19.17 s** |
+| ruby/ruby | 7,477 | 765,975 | 86.89 s | **15.59 s** | 193.59 s | **37.98 s** |
-The gap is 2.8x to 4.6x in parallel and 2.4x to 3.3x single-process, so no single corpus summarizes
+The gap is 3.7x to 7.4x in parallel and 4.5x to 6.2x single-process, so no single corpus summarizes
 it. **Read the single-process column and treat the parallel one as indicative.** Measuring the same
 two binaries three times over a day put the single-process figures within 16% of each other every
 time, while the parallel ratio on RuboCop's own tree moved between 3.3x and 9.2x purely with what
 else the machine was doing. Single-process measures the engines; parallel measures the engines plus
 how well each one's scheduling happens to fit that tree on that run.
-The speed is not bought by skipping work: over those same 394 cops the two agree on **every offense**
-on RuboCop's own tree, on Rails and on Mastodon — 188,812 offenses with nothing on either side of the
-ledger — and autocorrect is byte-identical on the first and the last.
+The speed is not bought by skipping work. Over those same 394 cops the two find the **same number of
+offenses** on every corpus in the table, and on RuboCop's own tree and on Mastodon every one of them
+is at the same position with the same message and severity. Rails, at 168,615 offenses, differs in
+two of them — one `Style/CaseLikeIf` Sonicop reports and one `Metrics/AbcSize` it does not — and
+RuboCop's own tree differs in one offense's `correctable` flag. Autocorrect is byte-identical on the
+first and the last.
-Three details matter for reproducing this. RuboCop **silently turns `--parallel` off when combined
+Four details matter for reproducing this. RuboCop **silently turns `--parallel` off when combined
 with `--cache false`**, so its parallel runs here use a cache directory that is deleted before each
 run rather than disabled; timing it with `--cache false --parallel` measures a single process and
 overstates the difference. RuboCop's default is a single process, while Sonicop is parallel unless
-`--no-parallel` is passed. And both sides need a **cold** cache: Sonicop caches by default too, so a
-second run over the same tree answers from its own cache and measures nothing about the engine.
-Give each tool a throwaway cache root.
+`--no-parallel` is passed. Both sides need a **cold** cache: Sonicop caches by default too, so a
+second run over the same tree answers from its own cache and measures nothing about the engine —
+give each tool a throwaway cache root. And the cache root must be a **real path**: macOS `mktemp -d`
+returns `/var/folders/…`, whose `/var` is a symlink, and RuboCop refuses such a location and runs
+with no cache at all.
 ```bash
 # RuboCop, parallel, cold cache, its full default set of 394 cops
-rubocop --force-default-config --cache true --cache-root "$(mktemp -d)" \
+root=$(mktemp -d /private/tmp/bench.XXXXXX)
+rubocop --force-default-config --cache true --cache-root "$root" \
         --no-color --parallel -f quiet
 # Sonicop, cold cache
-sonicop --force-default-config --cache-root "$(mktemp -d)" --format quiet
+sonicop --force-default-config --cache-root "$root" --format quiet
 ```
+Writing the cache is part of these numbers, and it is not free: the index holds every offense with
+the source line it was found on, which is 336 MB over `ruby/ruby`. A second run against a warm cache
+answers in 1.59 s there, and in 0.42 s over Rails.
 Machine: Apple M2 (8 cores), Ruby 4.0.6 with YJIT available, RubyGems-installed RuboCop 1.89.0.
-The one-minute load average was 4.0 when the run started and 3.1 when it finished — the machine was
-in use, not idle. RuboCop's own tree was re-measured on its own afterwards, at load 3.7 rising to 4.0,
-because the first pass over it ran while a release build was still finishing and its numbers came out
-60% high; a row measured under a different load cannot sit in the same table as the others. Both tools
-ran under the same conditions, so the ratios hold, but the absolute
-seconds are not a floor: expect better on a quiet machine. Anything competing for cores inflates
-both sides, and not by the same factor on each, which is what makes the parallel column move as much
-as it does. If the absolute numbers matter to you, measure on an idle machine and record the load
-either side of the run — a figure without that context cannot be compared with another one.
+Measured on 2026-08-31 against the corpora at `rubocop_rubocop` 2693129, `mastodon_mastodon` b59ddc7,
+`Homebrew_brew` b42173b, `rails_rails` a19f07f and `ruby_ruby` 22e4a75. The one-minute load average
+was between 4.5 and 7.1 as each row was taken — most of it RuboCop's own parallel workers, which is
+inherent to measuring them. **The machine was in use, not idle.** Both tools ran back to back under
+the same conditions on each corpus, so the ratios hold, but the absolute seconds are not a floor:
+expect better on a quiet machine. Anything competing for cores inflates both sides, and not by the
+same factor on each, which is what makes the parallel column move as much as it does. If the
+absolute numbers matter to you, measure on an idle machine and record the load either side of the
+run — a figure without that context cannot be compared with another one.
 ## Development

data/lib/sonicop/version.rb CHANGED Viewed

@@ -2,5 +2,5 @@
 # Generated from Cargo.toml by `rake version:sync`. Do not edit by hand.
 module Sonicop
-  VERSION = '26.8.112'
+  VERSION = '26.8.113'
 end

data/src/config/inheritance.rs CHANGED Viewed

@@ -8,6 +8,8 @@ use std::time::Duration;
 use anyhow::{Context, Result, bail};
 use serde_yaml_ng::{Mapping, Value};
+const MAX_REMOTE_CONFIG_BYTES: u64 = 5 * 1024 * 1024;
 /// Configuration files whose inheritance has already been resolved, keyed by canonical path for
 /// local files and by URL for remote ones.
 ///
@@ -164,7 +166,8 @@ fn fetch_remote_config(url: &str) -> Result<String> {
     response
         .body_mut()
         .with_config()
-        .limit(5 * 1024 * 1024)
+        // ureq は指定値と同じ長さでも上限超過にするため、論理上限を含む 1 バイト先を渡す。
+        .limit(MAX_REMOTE_CONFIG_BYTES + 1)
         .read_to_string()
         .with_context(|| format!("failed to read remote configuration: {url}"))
 }
@@ -459,14 +462,17 @@ fn mode_keys(mode: &Value, name: &str) -> HashSet<String> {
 mod tests {
     use std::collections::HashSet;
     use std::fs;
+    use std::io::{Read, Write};
+    use std::net::TcpListener;
     use std::path::Path;
+    use std::thread;
     use serde_yaml_ng::Value;
     use tempfile::tempdir;
     use super::{
-        InheritMode, PARSED_CONFIG_COUNT, deep_merge, join_remote_url, load_with_inheritance,
-        merge_config, merge_inherited_config,
+        InheritMode, MAX_REMOTE_CONFIG_BYTES, PARSED_CONFIG_COUNT, deep_merge, fetch_remote_config,
+        join_remote_url, load_with_inheritance, merge_config, merge_inherited_config,
     };
     use crate::config::Config;
@@ -483,6 +489,24 @@ mod tests {
         load_with_inheritance(path, &mut HashSet::new())
     }
+    fn serve_once(body: Vec<u8>) -> (String, thread::JoinHandle<()>) {
+        let listener = TcpListener::bind(("127.0.0.1", 0)).unwrap();
+        let address = listener.local_addr().unwrap();
+        let server = thread::spawn(move || {
+            let (mut stream, _) = listener.accept().unwrap();
+            let mut request = [0; 1024];
+            assert_ne!(stream.read(&mut request).unwrap(), 0);
+            write!(
+                stream,
+                "HTTP/1.1 200 OK\r\nContent-Length: {}\r\nConnection: close\r\n\r\n",
+                body.len()
+            )
+            .unwrap();
+            stream.write_all(&body).unwrap();
+        });
+        (format!("http://{address}/config.yml"), server)
+    }
     fn cop_exclude(merged: &Value, cop: &str) -> Value {
         merged
             .as_mapping()
@@ -577,6 +601,24 @@ mod tests {
         assert!(join_remote_url("no-directory", "shared.yml").is_err());
     }
+    #[test]
+    fn remote_configuration_enforces_the_response_size_limit() {
+        let limit = MAX_REMOTE_CONFIG_BYTES as usize;
+        let (url, server) = serve_once(vec![b'a'; limit]);
+        let accepted = fetch_remote_config(&url).unwrap();
+        server.join().unwrap();
+        assert_eq!(accepted.len(), limit);
+        let (url, server) = serve_once(vec![b'a'; limit + 1]);
+        let error = fetch_remote_config(&url).unwrap_err().to_string();
+        server.join().unwrap();
+        assert!(
+            error.starts_with("failed to read remote configuration:"),
+            "unexpected error: {error}"
+        );
+    }
     #[test]
     fn merges_configurations_without_losing_untouched_keys() {
         let merged = merge_config(

data/src/engine.rs CHANGED Viewed

@@ -10,7 +10,6 @@ use ignore::WalkBuilder;
 use rayon::prelude::*;
 use serde::{Deserialize, Serialize};
 use tempfile::NamedTempFile;
-use tree_sitter::Parser;
 use crate::config::{Config, ConfigStore};
 use crate::cop_name::selector_matches;
@@ -554,7 +553,16 @@ fn persist_cache_index(path: &Path, index: &CacheIndex) -> bool {
     let Ok(mut temporary) = NamedTempFile::new_in(parent) else {
         return false;
     };
-    if serde_json::to_writer(temporary.as_file_mut(), index).is_err()
+    // **Buffered.** `serde_json::to_writer` hands the writer each token as it produces it, so an
+    // unbuffered `File` turns one index into millions of `write` calls. The index holds every
+    // offense of every file with the source line it was found on, which is 336 MB over `ruby/ruby`:
+    // writing it a token at a time cost 115 seconds of a 135-second run, nearly all of it blocked
+    // in the kernel rather than serializing.
+    let written = {
+        let mut writer = std::io::BufWriter::with_capacity(1 << 20, temporary.as_file_mut());
+        serde_json::to_writer(&mut writer, index).is_ok() && writer.flush().is_ok()
+    };
+    if !written
         || temporary.as_file_mut().flush().is_err()
         || temporary.as_file().sync_all().is_err()
     {
@@ -992,12 +1000,8 @@ fn inspect_planned(
     let length_as_read = text.len();
     let text = crate::nul_bytes::as_ruby_reads_it(&text).unwrap_or(text);
     let source = SourceFile::new(path, text).read_as_long_as(length_as_read);
-    let mut parser = Parser::new();
-    parser
-        .set_language(&tree_sitter_ruby::LANGUAGE.into())
-        .context("failed to initialize the Ruby parser")?;
     let tree = crate::profile::phase(crate::profile::Phase::Parse, || {
-        parser.parse(source.text(), None)
+        crate::parser::parse(source.text())
     })
     .context("Ruby parser returned no syntax tree")?;
     let ast = crate::profile::phase(crate::profile::Phase::Index, || {

data/src/lib.rs CHANGED Viewed

@@ -14,6 +14,7 @@ pub mod engine;
 mod formatter;
 mod magic_comment;
 mod nul_bytes;
+mod parser;
 mod profile;
 mod ruby_version;
 pub mod rules;

data/src/nul_bytes.rs CHANGED Viewed

@@ -23,7 +23,7 @@
 use std::ops::Range;
-use tree_sitter::{Node, Parser};
+use tree_sitter::Node;
 /// The byte a NUL inside a comment is read as.
 ///
@@ -144,11 +144,7 @@ thread_local! {
 fn parse(text: &str) -> Option<tree_sitter::Tree> {
     #[cfg(test)]
     PARSES.with(|parses| parses.set(parses.get() + 1));
-    let mut parser = Parser::new();
-    parser
-        .set_language(&tree_sitter_ruby::LANGUAGE.into())
-        .ok()?;
-    parser.parse(text, None)
+    crate::parser::parse(text)
 }
 /// The nodes that hold the text of a literal. `%w` and `%i` wrap theirs in a `bare_string` or a

data/src/parser.rs ADDED Viewed

@@ -0,0 +1,37 @@
+//! One Ruby parser per worker thread.
+//!
+//! `Parser::new` allocates the parse stack, the lexer buffers and the reusable subtree pool, and
+//! `set_language` resets all of them. That is work the file being read has nothing to do with, and
+//! several places used to repeat it for every file, every recovered fragment and every syntax
+//! probe. A sampling profile put it among the costs of a run.
+//!
+//! The tree a parse returns owns its own storage, so nothing here is shared with the caller.
+use std::cell::RefCell;
+use tree_sitter::{Parser, Tree};
+thread_local! {
+    static PARSER: RefCell<Option<Parser>> = const { RefCell::new(None) };
+}
+/// Parses `text` with this thread's parser, building one on first use.
+///
+/// `None` means the parser produced no tree at all, which is not the same as a tree holding
+/// errors: a source the grammar cannot read still comes back as a tree with `ERROR` nodes.
+pub(crate) fn parse(text: &str) -> Option<Tree> {
+    PARSER.with(|slot| {
+        let mut slot = slot.borrow_mut();
+        let parser = match slot.as_mut() {
+            Some(parser) => parser,
+            None => {
+                let mut parser = Parser::new();
+                parser
+                    .set_language(&tree_sitter_ruby::LANGUAGE.into())
+                    .expect("the grammar the whole run is parsed with");
+                slot.insert(parser)
+            }
+        };
+        parser.parse(text, None)
+    })
+}

data/src/profile.rs CHANGED Viewed

@@ -101,10 +101,18 @@ pub(crate) enum Phase {
     CacheKey,
     /// Reading a cached report back and turning it into offenses.
     CacheLoad,
+    /// `VariableForce`, built on the first cop of a file that asks for it.
+    Variables,
+    /// The code the grammar swallowed, recovered on the first cop that asks.
+    Fragments,
+    /// The Metrics cops' local-variable replay, built on the first cop that asks.
+    MetricLocals,
+    /// The lexer token stream, rebuilt on the first cop that asks.
+    LayoutTokens,
 }
 impl Phase {
-    const COUNT: usize = 13;
+    const COUNT: usize = 17;
     const NAMES: [&'static str; Self::COUNT] = [
         "read",
         "parse",
@@ -119,6 +127,10 @@ impl Phase {
         "shebang",
         "cache_key",
         "cache_load",
+        "variables",
+        "fragments",
+        "metric_locals",
+        "layout_tokens",
     ];
 }

data/src/rules/bundler/duplicated_group.rs CHANGED Viewed

@@ -2,10 +2,11 @@ use tree_sitter::Node;
 use crate::diagnostic::Offense;
 use crate::rules::RuleContext;
-use crate::rules::send_node::{arguments, first_line_range, named_children, send_range};
+use crate::rules::send_node::{arguments, first_line_range, send_range};
 use super::support::declarations;
 use crate::rules::node_ext::NodeExt;
+use crate::rules::send_node::named_children_of;
 /// `SOURCE_BLOCK_NAMES`. A group declared under a different source, git remote, platform or path is
 /// a different group even when it goes by the same name.
@@ -71,7 +72,7 @@ fn attributes(node: Node<'_>, context: &RuleContext<'_>) -> String {
             // `group :a, foo: 1` and `group :a, foo: 1` agree however they were spaced.
             if parts.len() > 1 || parts[0].kind_str() == "hash" {
                 let mut pairs: Vec<String> = match parts[0].kind_str() == "hash" {
-                    true => named_children(parts[0]),
+                    true => named_children_of(parts[0], context),
                     false => parts.to_vec(),
                 }
                 .into_iter()

data/src/rules/bundler/gem_comment.rs CHANGED Viewed

@@ -7,10 +7,11 @@ use tree_sitter::Node;
 use crate::diagnostic::Offense;
 use crate::rules::RuleContext;
 use crate::rules::node_ext::NodeExt;
-use crate::rules::push_named_children;
+use crate::rules::{push_named_children_in};
 use crate::rules::send_node::{arguments, is_string, pair_key_symbol, send_range, string_text};
 use super::support::gem_declarations;
+use crate::rules::send_node::named_children_iter;
 const MSG: &str = "Missing gem description comment.";
@@ -179,7 +180,7 @@ fn subtree_lines(node: Node<'_>, context: &RuleContext<'_>) -> HashSet<usize> {
             continue;
         }
         lines.insert(context.source.line_column(current.start_byte()).0);
-        push_named_children(current, &mut stack);
+        push_named_children_in(current, context, &mut stack);
     }
     lines
 }
@@ -224,8 +225,8 @@ fn gem_options<'a>(node: Node<'_>, context: &'a RuleContext<'_>) -> Vec<&'a str>
     };
     let pairs: Vec<Node<'_>> = match last.first().kind_str() {
         "hash" if last.parts().len() == 1 => {
-            let mut cursor = last.first().walk();
-            last.first().named_children(&mut cursor).collect()
+            let _cursor = last.first().walk();
+            named_children_iter(last.first(), context).collect()
         }
         _ => last.parts().to_vec(),
     };

data/src/rules/gemspec/attribute_assignment.rs CHANGED Viewed

@@ -3,9 +3,10 @@ use tree_sitter::Node;
 use crate::diagnostic::Offense;
 use crate::rules::RuleContext;
 use crate::rules::node_ext::NodeExt;
-use crate::rules::send_node::{is_plain_send, named_children};
+use crate::rules::send_node::is_plain_send;
 use super::support::{first_specification_variable, is_literal, is_specification_receiver};
+use crate::rules::send_node::named_children_of;
 pub(super) fn check(context: &RuleContext<'_>, offenses: &mut Vec<Offense>) {
     let variable = first_specification_variable(context);
@@ -34,7 +35,7 @@ pub(super) fn check(context: &RuleContext<'_>, offenses: &mut Vec<Offense>) {
             // multiple assignment carries no value of its own, so it never matches upstream's
             // `(send _ :[]= literal? _)`, which insists on both an index and a value.
             "left_assignment_list" => {
-                for target in named_children(left) {
+                for target in named_children_of(left, context) {
                     if target.kind_str() == "call"
                         && let Some(attribute) = assigned_attribute(target, variable, context)
                     {
@@ -93,7 +94,7 @@ fn indexed_attribute<'a>(
     if !is_specification_receiver(receiver, variable, context) {
         return None;
     }
-    let indices = named_children(target);
+    let indices = named_children_of(target, context);
     let [index] = indices.get(1..)? else {
         return None;
     };