songkick-transport 1.9.1 → 1.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1fe0da63a4b8a2922d2e54f19b00e65dd5fa7abe
-  data.tar.gz: 58a16dd55c6c201209beea4381935e61d8ad7f26
+  metadata.gz: dd1492f22e6d92c333c9020af25be71d79ed1e74
+  data.tar.gz: 735d399c0e155a6fe504c66c553b862e1ed7b3f7
 SHA512:
-  metadata.gz: 6786e9954745bb68d84a8509e6fa9cf2cbd090e4d9c66c0ed27136b1bda2abb7d630ff2b81006f4f473025b28e58232df6524989b23259f6e658b628e65bdb5e
-  data.tar.gz: 540c662c5c7683f2a62b6940a43cad2c0650674957ae6fb9157d520ade72b31a3d4df9111554b0ebc58716bb39d3bf26c65ecb1b31071572481842c66db4896a
+  metadata.gz: cbc9a6317cf7da6da37d6273be86dc23ea8974b5589b833414fe186028b4cccb4f4cb29ef70ab605f00ed20c57b6351efb1be7b00ad10dafe1eb9960c223685b
+  data.tar.gz: e1ca03fc8ee17b8b547785d802488597beca3af8afe4c0d9a0c7847455cb44f428b268501cfab0f3ec43127bf6450a05ea53ab103aa0dd3d366521d13d334924

data/lib/songkick/transport/request.rb

@@ -68,6 +68,7 @@ module Songkick
         Serialization.build_url(@verb, @endpoint, @path, @params)
       end
 
+      TRUNCATED_PARAM_LENGTH = 500
       def to_s
         url = String === @endpoint ?
               Serialization.build_url(@verb, @endpoint, @path, @params, true) :
@@ -79,7 +80,17 @@ module Songkick
           command << " -H '#{key}: #{value}'"
         end
         return command unless use_body?
-        query = Serialization.build_query_string(params, true, true)
+        sanitized_params = Serialization.build_query_string(params, false, true)
+        sanitized_params = sanitized_params.inject({}) do |result, param|
+          key, value = param
+          if value.length > TRUNCATED_PARAM_LENGTH
+            result[key] = "#{value[0...TRUNCATED_PARAM_LENGTH]}[TRUNCATED]"
+          else
+            result[key] = value
+          end
+          result
+        end
+        query = sanitized_params.map { |p| p.join('=') }.join('&')
         command << " -d '#{query}'"
         command
       end

data/spec/songkick/transport/request_spec.rb

@@ -59,6 +59,22 @@ describe Songkick::Transport::Request do
         end
       end
     end
+    
+    describe "with a long post body" do
+      let :params do
+        {
+          :username => "a" * 5000, 
+          :foo => "bar", 
+          :access => {:token => "b" * 5000}
+        }
+      end
+
+      it "truncates the long parameter values" do
+        pattern = %r{^POST 'www.example.com/' -H 'Content-Type: application/x-www-form-urlencoded' -d '([^']+)'$}
+        expect(post_request.to_s).to match(pattern)
+        expect(query(post_request, pattern)).to eq(["access[token]=#{"b" * 500}[TRUNCATED]", "foo=bar", "username=#{"a" * 500}[TRUNCATED]"])
+      end
+    end
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: songkick-transport
 version: !ruby/object:Gem::Version
-  version: 1.9.1
+  version: 1.10.0
 platform: ruby
 authors:
 - Daniel Lucraft
@@ -14,146 +14,146 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-28 00:00:00.000000000 Z
+date: 2016-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multipart-post
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: curb
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.3.0
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.8.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.8.0
 - !ruby/object:Gem::Dependency
   name: rack-test
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.4.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: thin
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: HTTP client abstraction for service clients
@@ -164,60 +164,59 @@ extra_rdoc_files:
 - README.rdoc
 files:
 - README.rdoc
+- examples/tcp_server.rb
 - examples/example.rb
+- examples/thread_safety.rb
 - examples/loop.rb
 - examples/server.rb
-- examples/tcp_server.rb
-- examples/thread_safety.rb
-- lib/songkick/transport.rb
-- lib/songkick/transport/authentication.rb
-- lib/songkick/transport/base.rb
-- lib/songkick/transport/curb.rb
+- lib/songkick/transport/reporting.rb
+- lib/songkick/transport/rack_test.rb
 - lib/songkick/transport/headers.rb
-- lib/songkick/transport/html_report.html.erb
+- lib/songkick/transport/response.rb
+- lib/songkick/transport/curb.rb
 - lib/songkick/transport/http_error.rb
 - lib/songkick/transport/httparty.rb
-- lib/songkick/transport/rack_test.rb
-- lib/songkick/transport/reporting.rb
+- lib/songkick/transport/service.rb
 - lib/songkick/transport/request.rb
-- lib/songkick/transport/response.rb
+- lib/songkick/transport/authentication.rb
 - lib/songkick/transport/serialization.rb
-- lib/songkick/transport/service.rb
 - lib/songkick/transport/upstream_error.rb
-- spec/songkick/transport/authentication_spec.rb
-- spec/songkick/transport/base_spec.rb
+- lib/songkick/transport/base.rb
+- lib/songkick/transport.rb
+- spec/spec_helper.rb
+- spec/songkick/transport_spec.rb
 - spec/songkick/transport/curb_spec.rb
-- spec/songkick/transport/httparty_spec.rb
+- spec/songkick/transport/service_spec.rb
 - spec/songkick/transport/request_spec.rb
+- spec/songkick/transport/authentication_spec.rb
+- spec/songkick/transport/httparty_spec.rb
+- spec/songkick/transport/base_spec.rb
 - spec/songkick/transport/response_spec.rb
-- spec/songkick/transport/service_spec.rb
-- spec/songkick/transport_spec.rb
-- spec/spec_helper.rb
+- lib/songkick/transport/html_report.html.erb
 homepage: http://github.com/songkick/transport
 licenses:
 - MIT
 metadata: {}
 post_install_message: 
 rdoc_options:
-- "--main"
+- --main
 - README.rdoc
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.8.7
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
 summary: HTTP client abstraction for service clients
 test_files: []
-has_rdoc: