solidus_webhooks 0.0.1.v0.1.0.beta.1.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ee15a8db0ac265823a8f226cabbd4a28881cf04191e27073abf252b4f554097a
-  data.tar.gz: b3888c9cfd6afa9bb6a513223274f60665013541e2c5a8e5d49970320cb0b258
+  metadata.gz: f94eb7d8c956dd983b90ff8ab0d14fde3fbad148400e29222c8be84d403c1baa
+  data.tar.gz: fd828061690984b542190754621d8d9b86ba34ae89070f25db9f838a0de22c78
 SHA512:
-  metadata.gz: bd1a0767f65439df1ff2273b36c1df0f04c492ccfd31ec04d676f9492eed61bfe2296890bec228fd3d28ad55b53f8032205bfbc07bb40cf966d3fc5031ccd37b
-  data.tar.gz: a47daaba62f5c9480c2330fd21c261844d35b55d63ff9d057e42fec129a002aee7d842e5e2c8a55eb214b827c2c30dc6c8fa7527c6942d70b74973ee626b2f30
+  metadata.gz: 37142b4bd06257070f31083a3a99a8594654c626e52e21d41b95f075c4f3a3adc2064cd9831f2c36de5500fa91805d763e5913ea07b9b7c184ac11f6bb6755a8
+  data.tar.gz: f4cb38e4f31a7e7e1c60603c79ccc96b35365b5309b35cd959ff29175f7368ca1f95cd16be32ebdd00a8eeeb92cde2c8d1f00287f2f3e6bab42d0a65987e482a

data/.circleci/config.yml

@@ -16,12 +16,18 @@ jobs:
     executor: solidusio_extensions/mysql
     steps:
       - solidusio_extensions/run-tests
+  lint-code:
+    executor: solidusio_extensions/sqlite-memory
+    steps:
+      - solidusio_extensions/lint-code
 
 workflows:
   "Run specs on supported Solidus versions":
     jobs:
       - run-specs-with-postgres
       - run-specs-with-mysql
+      - lint-code
+
   "Weekly run specs against master":
     triggers:
       - schedule:

data/.gem_release.yml

@@ -2,4 +2,4 @@ bump:
   recurse: false
   file: 'lib/solidus_webhooks/version.rb'
   message: Bump SolidusWebhooks to %{version}
-  tag: true
+  tag: false

data/.github/stale.yml

@@ -1,17 +1,17 @@
 # Number of days of inactivity before an issue becomes stale
 daysUntilStale: 60
 # Number of days of inactivity before a stale issue is closed
-daysUntilClose: 7
+daysUntilClose: false
 # Issues with these labels will never be considered stale
 exemptLabels:
   - pinned
   - security
 # Label to use when marking an issue as stale
-staleLabel: wontfix
+staleLabel: stale
 # Comment to post when marking an issue as stale. Set to `false` to disable
 markComment: >
   This issue has been automatically marked as stale because it has not had
-  recent activity. It will be closed if no further activity occurs. Thank you
+  recent activity. It might be closed if no further activity occurs. Thank you
   for your contributions.
 # Comment to post when closing a stale issue. Set to `false` to disable
-closeComment: false
+closeComment: false

data/.github_changelog_generator

@@ -0,0 +1,2 @@
+issues=false
+exclude-labels=infrastructure

data/.gitignore

@@ -15,3 +15,6 @@ pkg
 spec/dummy
 spec/examples.txt
 /sandbox
+.rvmrc
+.ruby-version
+.ruby-gemset

data/.rubocop.yml

@@ -2,6 +2,27 @@ require:
   - solidus_dev_support/rubocop
 
 AllCops:
+  NewCops: disable
   Exclude:
     - sandbox/**/*
     - spec/dummy/**/*
+    - vendor/bundle/**/*
+
+
+# This guys are troublemakers
+RSpec/FactoryBot/CreateList:
+  Enabled: false
+RSpec/Rails/HttpStatus:
+  Enabled: false
+
+# Deviations from the standard
+Style/ClassAndModuleChildren:
+  Enabled: false
+Style/FrozenStringLiteralComment:
+  Enabled: false
+RSpec/Capybara/FeatureMethods:
+  Enabled: false
+RSpec/MultipleExpectations:
+  Enabled: false
+RSpec/NamedSubject:
+  Enabled: false

data/CHANGELOG.md

@@ -0,0 +1,52 @@
+# Changelog
+
+## [v0.3.0](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.3.0) (2021-04-20)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/v0.3.0...v0.3.0)
+
+**Closed issues:**
+
+- Prepare Solidus Webhooks for Solidus 3.0 [\#8](https://github.com/solidusio-contrib/solidus_webhooks/issues/8)
+
+**Merged pull requests:**
+
+- Allow Solidus 3 [\#10](https://github.com/solidusio-contrib/solidus_webhooks/pull/10) ([kennyadsl](https://github.com/kennyadsl))
+- Reconcile master and v0.3.0 [\#7](https://github.com/solidusio-contrib/solidus_webhooks/pull/7) ([elia](https://github.com/elia))
+- Bump solidus\_support to ~\> 0.6 [\#6](https://github.com/solidusio-contrib/solidus_webhooks/pull/6) ([peterberkenbosch](https://github.com/peterberkenbosch))
+
+## [v0.3.0](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.3.0) (2020-10-20)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/v0.2.0...v0.3.0)
+
+**Fixed bugs:**
+
+- Fix error classes [\#5](https://github.com/solidusio-contrib/solidus_webhooks/pull/5) ([elia](https://github.com/elia))
+
+## [v0.2.0](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.2.0) (2020-06-10)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/v0.1.0...v0.2.0)
+
+**Implemented enhancements:**
+
+- Expose current\_api\_user to webhook handlers [\#4](https://github.com/solidusio-contrib/solidus_webhooks/pull/4) ([elia](https://github.com/elia))
+
+## [v0.1.0](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.1.0) (2020-05-14)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/v0.1.0.beta.1...v0.1.0)
+
+## [v0.1.0.beta.1](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.1.0.beta.1) (2020-05-13)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/v0.0.1.v0.1.0.beta.1.1...v0.1.0.beta.1)
+
+## [v0.0.1.v0.1.0.beta.1.1](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.0.1.v0.1.0.beta.1.1) (2020-05-13)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/9573caa400232ffb44cde7f8cf907171a529ced3...v0.0.1.v0.1.0.beta.1.1)
+
+**Merged pull requests:**
+
+- Prepare the repo to be moved to @solidusio-contrib [\#2](https://github.com/solidusio-contrib/solidus_webhooks/pull/2) ([elia](https://github.com/elia))
+- Add the ability to register and receive webhooks [\#1](https://github.com/solidusio-contrib/solidus_webhooks/pull/1) ([elia](https://github.com/elia))
+
+
+
+\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*

data/README.md

@@ -1,10 +1,27 @@
-SolidusWebhooks
-===============
+# Solidus Webhooks
 
-Provides comprehensive Webhook support for Solidus, with a simple and powerful way to register them and route payloads to appropriate actions, either synchronous or delayed.
+[![CircleCI](https://circleci.com/gh/solidusio-contrib/solidus_webhooks.svg?style=shield)](https://circleci.com/gh/solidusio-contrib/solidus_webhooks)
+[![codecov](https://codecov.io/gh/solidusio-contrib/solidus_webhooks/branch/master/graph/badge.svg)](https://codecov.io/gh/solidusio-contrib/solidus_webhooks)
 
-Usage
------
+<!-- Explain what your extension does. -->
+
+## Installation
+
+Add solidus_webhooks to your Gemfile:
+
+```ruby
+gem 'solidus_webhooks'
+```
+
+Bundle your dependencies and run the installation generator:
+
+```shell
+bin/rails generate solidus_webhooks:install
+```
+
+## Usage
+
+<!-- Explain how to use your extension once it's been installed. -->
 
 A Webhook receiver is just a callable and can be registered in the Solidus configuration as follows:
 
@@ -33,8 +50,8 @@ The only requirement on handlers is for them to respond to `#call` and accept a
 Example:
 
 ```ruby
-class TrackingNumberHandler
-  def call(payload)
+module TrackingNumberHandler
+  def self.call(payload)
     order = Spree::Order.find_by!(number: payload[:order])
     shipment = order.shipments.find_by!(number: payload[:shipment])
     shipment.update!(tracking: payload[:tracking])
@@ -108,29 +125,28 @@ Spree::RoleConfiguration.configure do |config|
 end
 ```
 
-Installation
-------------
+### Accessing the API User
 
-Add solidus_webhooks to your Gemfile:
+If you need to access the API user that is making the call to the webhook, you can just accept an additional argument in the callable handler.
+
+Example:
 
 ```ruby
-gem 'solidus_webhooks'
+SolidusWebhooks.config.register_webhook_handler :tracking_number, -> payload, user {
+  Rails.logger.info "Received payload from user #{user.email}: #{payload.to_json}"
+  # …
+}
 ```
 
-Bundle your dependencies and run the installation generator:
-
-```shell
-bundle
-bundle exec rails g solidus_webhooks:install
-```
+## Development
 
-Testing
--------
+### Testing the extension
 
-First bundle your dependencies, then run `bin/rake`. `bin/rake` will default to building the dummy app if it does not exist, then it will run specs. The dummy app can be regenerated by using `bin/rake extension:test_app`.
+First bundle your dependencies, then run `bin/rake`. `bin/rake` will default to building the dummy
+app if it does not exist, then it will run specs. The dummy app can be regenerated by using
+`bin/rake extension:test_app`.
 
 ```shell
-bundle
 bin/rake
 ```
 
@@ -147,16 +163,15 @@ Simply add this require statement to your spec_helper:
 require 'solidus_webhooks/factories'
 ```
 
-Sandbox app
------------
+### Running the sandbox
 
-To run this extension in a sandboxed Solidus application you can run `bin/sandbox`
-The path for the sandbox app is `./sandbox` and `bin/rails` will forward any Rails command
-to `sandbox/bin/rails`.
+To run this extension in a sandboxed Solidus application, you can run `bin/sandbox`. The path for
+the sandbox app is `./sandbox` and `bin/rails` will forward any Rails commands to
+`sandbox/bin/rails`.
 
-Example:
+Here's an example:
 
-```shell
+```
 $ bin/rails server
 => Booting Puma
 => Rails 6.0.2.1 application starting in development
@@ -164,13 +179,21 @@ $ bin/rails server
 Use Ctrl-C to stop
 ```
 
-Releasing
----------
+### Updating the changelog
 
-Your new extension version can be released using `gem-release` like this:
+Before and after releases the changelog should be updated to reflect the up-to-date status of
+the project:
 
 ```shell
-bundle exec gem bump -v VERSION --tag --push --remote upstream && gem release
+bin/rake changelog
+git add CHANGELOG.md
+git commit -m "Update the changelog"
 ```
 
-Copyright (c) 2020 Nebulab srls, released under the New BSD License
+### Releasing new versions
+
+Please refer to the dedicated [page](https://github.com/solidusio/solidus/wiki/How-to-release-extensions) on Solidus wiki.
+
+## License
+
+Copyright (c) 2020 Nebulab srls, released under the New BSD License.

data/Rakefile

@@ -1,6 +1,22 @@
 # frozen_string_literal: true
 
 require 'solidus_dev_support/rake_tasks'
+
+SolidusDevSupport::RakeTasks.class_eval do
+  def install_changelog_task
+    require 'github_changelog_generator/task'
+
+    source_code_uri = URI.parse(gemspec.metadata['source_code_uri'])
+    user, project = source_code_uri.path.split("/", 3)[1..2]
+
+    GitHubChangelogGenerator::RakeTask.new(:changelog) do |config|
+      config.user = user || 'solidus-contrib'
+      config.project = project || gemspec.name
+      config.future_release = "v#{gemspec.version}"
+    end
+  end
+end
+
 SolidusDevSupport::RakeTasks.install
 
 task default: 'extension:specs'

data/app/controllers/spree/webhooks_controller.rb

@@ -1,13 +1,14 @@
 class Spree::WebhooksController < Spree::Api::BaseController
-  rescue_from(Spree::Webhook::WebhookNotFound) { head :not_found }
+  rescue_from(SolidusWebhooks::WebhookNotFound) { head :not_found }
 
   def receive
     webhook = Spree::Webhook.find(params[:id])
     payload = request.request_parameters["webhook"]
+    user = current_api_user
 
     authorize! :receive, webhook
 
-    webhook.receive(payload)
+    webhook.receive(payload, user)
 
     head :ok
   end

data/app/models/spree/webhook.rb

@@ -1,19 +1,33 @@
+require 'solidus_webhooks/errors'
+
 class Spree::Webhook
   include ActiveModel::Model
   attr_accessor :handler, :id
 
-  WebhookNotFound = Class.new(StandardError)
-
-  def receive(payload)
-    handler.call(payload)
+  def receive(payload, user)
+    if handler_arity == 1
+      handler.call(payload)
+    else
+      handler.call(payload, user)
+    end
   end
 
   def self.find(id)
     id = id.to_sym # normalize incoming ids
 
     handler = SolidusWebhooks.config.find_webhook_handler(id) or
-      raise WebhookNotFound, "Cannot find a webhook handler for #{id.inspect}"
+      raise SolidusWebhooks::WebhookNotFound, "Cannot find a webhook handler for #{id.inspect}"
 
     new(id: id, handler: handler)
   end
+
+  private
+
+  def handler_arity
+    if handler.respond_to?(:arity)
+      handler.arity
+    else
+      handler.method(:call).arity
+    end
+  end
 end

data/bin/rails

@@ -0,0 +1,7 @@
+#!/usr/bin/env ruby
+
+if %w[g generate].include? ARGV.first
+  exec "#{__dir__}/rails-engine", *ARGV
+else
+  exec "#{__dir__}/rails-sandbox", *ARGV
+end

data/bin/{sandbox_rails → rails-sandbox}

@@ -1,13 +1,11 @@
 #!/usr/bin/env ruby
 
-# frozen_string_literal: true
-
 app_root = 'sandbox'
 
 unless File.exist? "#{app_root}/bin/rails"
   warn 'Creating the sandbox app...'
   Dir.chdir "#{__dir__}/.." do
-    system "#{__dir__}/sandbox" or begin # rubocop:disable Style/AndOr
+    system "#{__dir__}/sandbox" or begin
       warn 'Automatic creation of the sandbox app failed'
       exit 1
     end

data/bin/sandbox

@@ -72,9 +72,11 @@ unbundled bundle exec rails generate spree:install \
   --user_class=Spree::User \
   --enforce_available_locales=true \
   --with-authentication=false \
+  --payment-method=none \
   $@
 
 unbundled bundle exec rails generate solidus:auth:install
+unbundled bundle exec rails generate ${extension_name}:install
 
 echo
 echo "🚀 Sandbox app successfully created for $extension_name!"

data/lib/generators/solidus_webhooks/install/install_generator.rb

@@ -4,15 +4,20 @@ module SolidusWebhooks
   module Generators
     class InstallGenerator < Rails::Generators::Base
       class_option :auto_run_migrations, type: :boolean, default: false
+      source_root File.expand_path('templates', __dir__)
+
+      def copy_initializer
+        template 'initializer.rb', 'config/initializers/solidus_webhooks.rb'
+      end
 
       def add_javascripts
-        append_file 'vendor/assets/javascripts/spree/frontend/all.js', "//= require spree/frontend/solidus_webhooks\n" # rubocop:disable Metrics/LineLength
-        append_file 'vendor/assets/javascripts/spree/backend/all.js', "//= require spree/backend/solidus_webhooks\n" # rubocop:disable Metrics/LineLength
+        append_file 'vendor/assets/javascripts/spree/frontend/all.js', "//= require spree/frontend/solidus_webhooks\n"
+        append_file 'vendor/assets/javascripts/spree/backend/all.js', "//= require spree/backend/solidus_webhooks\n"
       end
 
       def add_stylesheets
-        inject_into_file 'vendor/assets/stylesheets/spree/frontend/all.css', " *= require spree/frontend/solidus_webhooks\n", before: %r{\*/}, verbose: true # rubocop:disable Metrics/LineLength
-        inject_into_file 'vendor/assets/stylesheets/spree/backend/all.css', " *= require spree/backend/solidus_webhooks\n", before: %r{\*/}, verbose: true # rubocop:disable Metrics/LineLength
+        inject_into_file 'vendor/assets/stylesheets/spree/frontend/all.css', " *= require spree/frontend/solidus_webhooks\n", before: %r{\*/}, verbose: true # rubocop:disable Layout/LineLength
+        inject_into_file 'vendor/assets/stylesheets/spree/backend/all.css', " *= require spree/backend/solidus_webhooks\n", before: %r{\*/}, verbose: true # rubocop:disable Layout/LineLength
       end
 
       def add_migrations
@@ -20,7 +25,7 @@ module SolidusWebhooks
       end
 
       def run_migrations
-        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]')) # rubocop:disable Metrics/LineLength
+        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]')) # rubocop:disable Layout/LineLength
         if run_migrations
           run 'bin/rails db:migrate'
         else

data/lib/generators/solidus_webhooks/install/templates/initializer.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+SolidusWebhooks.configure do |config|
+  # TODO: Remember to change this with the actual preferences you have implemented!
+  # config.sample_preference = 'sample_value'
+end

data/lib/solidus_webhooks.rb

@@ -3,6 +3,6 @@
 require 'solidus_core'
 require 'solidus_support'
 
-require 'solidus_webhooks/version'
 require 'solidus_webhooks/configuration'
+require 'solidus_webhooks/version'
 require 'solidus_webhooks/engine'

data/lib/solidus_webhooks/configuration.rb

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
+require 'solidus_webhooks/errors'
+
 module SolidusWebhooks
   class Configuration
     def initialize
@@ -6,7 +10,7 @@ module SolidusWebhooks
 
     def register_webhook_handler(id, handler)
       unless handler.respond_to? :call
-        raise Spree::Webhook::InvalidHandler,
+        raise SolidusWebhooks::InvalidHandler,
           "Please provide a handler that responds to #call, got: #{handler.inspect}"
       end
 
@@ -18,13 +22,19 @@ module SolidusWebhooks
     end
   end
 
-  def self.config
-    @config
-  end
+  class << self
+    def configuration
+      @configuration ||= Configuration.new
+    end
 
-  def self.reset_config!
-    @config = Configuration.new
-  end
+    alias config configuration
 
-  reset_config! # initialize the extension
+    def reset_config!
+      @configuration = nil
+    end
+
+    def configure
+      yield configuration
+    end
+  end
 end

data/lib/solidus_webhooks/errors.rb

@@ -0,0 +1,4 @@
+module SolidusWebhooks
+  WebhookNotFound = Class.new(StandardError)
+  InvalidHandler = Class.new(StandardError)
+end

data/lib/solidus_webhooks/testing_support/factories.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+end

data/lib/solidus_webhooks/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidusWebhooks
-  VERSION = '0.0.1.v0.1.0.beta.1.1'
+  VERSION = '0.4.0'
 end

data/solidus_webhooks.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
   spec.metadata['source_code_uri'] = 'https://github.com/solidusio-contrib/solidus_webhooks'
   spec.metadata['changelog_uri'] = 'https://github.com/solidusio-contrib/solidus_webhooks/releases'
 
-  spec.required_ruby_version = Gem::Requirement.new('~> 2.4')
+  spec.required_ruby_version = Gem::Requirement.new('>= 2.5')
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -28,8 +28,8 @@ Gem::Specification.new do |spec|
   spec.executables = files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 3']
-  spec.add_dependency 'solidus_support', '~> 0.5.0'
+  spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 4']
+  spec.add_dependency 'solidus_support', '~> 0.6'
 
-  spec.add_development_dependency 'solidus_dev_support'
+  spec.add_development_dependency 'solidus_dev_support', '~> 2.2'
 end

data/spec/features/can_register_a_handler_and_receive_webhooks_spec.rb

@@ -2,46 +2,73 @@ require 'spec_helper'
 
 RSpec.feature "Can register a handler and receive Webhooks", type: :request do
   background do
-    SolidusWebhooks.reset_config!
-    SolidusWebhooks.config.register_webhook_handler :foo, foo_handler
-    SolidusWebhooks.config.register_webhook_handler :bar, bar_handler
+    SolidusWebhooks.config.register_webhook_handler :proc, proc_handler
+    SolidusWebhooks.config.register_webhook_handler :method, method_handler
+    SolidusWebhooks.config.register_webhook_handler :user, user_handler
+    SolidusWebhooks.config.register_webhook_handler :splat, splat_handler
+    SolidusWebhooks.config.register_webhook_handler :method_and_user, method_and_user_handler
   end
 
-  let(:foo_payloads) { [] }
-  let(:bar_payloads) { [] }
+  let(:proc_payloads) { [] }
+  let(:method_payloads) { [] }
+  let(:user_payloads) { [] }
+  let(:splat_payloads) { [] }
+  let(:method_and_user_payloads) { [] }
 
-  let(:foo_handler) { ->(payload) { foo_payloads << payload } }
-  let(:bar_handler) { ->(payload) { bar_payloads << payload } }
+  let(:proc_handler) { ->(payload) { proc_payloads << payload } }
+  let(:method_handler) {
+    Struct.new(:payloads) { def call(payload) payloads << payload end }.new(method_payloads)
+  }
+  let(:user_handler) { ->(payload, user) { user_payloads << [payload, user] } }
+  let(:splat_handler) { ->(*args) { splat_payloads << args } }
+  let(:method_and_user_handler) {
+    Struct.new(:payloads) { def call(payload, user) payloads << [payload, user] end }.new(method_and_user_payloads)
+  }
 
-  let(:token) { create(:admin_user, spree_api_key: "123").spree_api_key }
-  let(:token_without_permission) { create(:user, spree_api_key: "456").spree_api_key }
+  let(:authorized_user) { create(:admin_user, spree_api_key: "123") }
+  let(:authorized_token) { authorized_user.spree_api_key }
+
+  let(:unauthorized_user) { create(:user, spree_api_key: "456") }
+  let(:unauthorized_token) { unauthorized_user.spree_api_key }
 
   scenario "calls the handler passing the payload" do
-    post "/webhooks/foo?token=#{token}", as: :json, params: {a: 123}
+    post "/webhooks/proc?token=#{authorized_token}", as: :json, params: { a: 123 }
+    expect(response).to have_http_status(:ok)
+
+    post "/webhooks/proc?token=#{authorized_token}", as: :json, params: { b: 456 }
+    expect(response).to have_http_status(:ok)
+
+    post "/webhooks/method?token=#{authorized_token}", as: :json, params: { c: 789 }
+    expect(response).to have_http_status(:ok)
+
+    post "/webhooks/user?token=#{authorized_token}", as: :json, params: { d: 12 }
     expect(response).to have_http_status(:ok)
 
-    post "/webhooks/foo?token=#{token}", as: :json, params: {b: 456}
+    post "/webhooks/splat?token=#{authorized_token}", as: :json, params: { e: 345 }
     expect(response).to have_http_status(:ok)
 
-    post "/webhooks/bar?token=#{token}", as: :json, params: {c: 789}
+    post "/webhooks/method_and_user?token=#{authorized_token}", as: :json, params: { f: 678 }
     expect(response).to have_http_status(:ok)
 
-    expect(foo_payloads).to eq([{'a' => 123}, {'b' => 456}])
-    expect(bar_payloads).to eq([{'c' => 789}])
+    expect(proc_payloads).to eq([{ 'a' => 123 }, { 'b' => 456 }])
+    expect(method_payloads).to eq([{ 'c' => 789 }])
+    expect(user_payloads).to eq([[{ 'd' => 12 }, authorized_user]])
+    expect(splat_payloads).to eq([[{ 'e' => 345 }, authorized_user]])
+    expect(method_and_user_payloads).to eq([[{ 'f' => 678 }, authorized_user]])
   end
 
   scenario "receives a bad handler id" do
-    post "/webhooks/baz?token=#{token}", as: :json, params: {a: 123}
+    post "/webhooks/abc?token=#{authorized_token}", as: :json, params: { a: 123 }
     expect(response).to have_http_status(:not_found)
   end
 
   scenario "refuses a bad token" do
-    post "/webhooks/baz?token=b4d-t0k3n", as: :json, params: {a: 123}
+    post "/webhooks/user?token=b4d-t0k3n", as: :json, params: { a: 123 }
     expect(response).to have_http_status(:unauthorized)
   end
 
   scenario "refuses a token without permissions" do
-    post "/webhooks/foo?token=#{token_without_permission}", as: :json, params: {a: 123}
+    post "/webhooks/proc?token=#{unauthorized_token}", as: :json, params: { a: 123 }
     expect(response).to have_http_status(:unauthorized)
   end
 end

data/spec/models/spree/webhook_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+RSpec.describe Spree::Webhook do
+  describe '.find' do
+    before { SolidusWebhooks.config.register_webhook_handler :foo, ->(payload) {} }
+
+    it 'can find a registered handler' do
+      expect(described_class.find(:foo)).to be_a(described_class)
+      expect{ described_class.find(:bar) }.to raise_error(SolidusWebhooks::WebhookNotFound)
+    end
+  end
+end

data/spec/solidus_webhooks/configuration_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+RSpec.describe SolidusWebhooks::Configuration do
+  describe '#register_webhook_handler' do
+    it 'only accepts callable' do
+      expect{ subject.register_webhook_handler(:foo, Object.new) }.to raise_error(SolidusWebhooks::InvalidHandler)
+      expect{ subject.register_webhook_handler(:bar, proc {}) }.not_to raise_error
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -6,19 +6,26 @@ ENV['RAILS_ENV'] = 'test'
 # Run Coverage report
 require 'solidus_dev_support/rspec/coverage'
 
-require File.expand_path('dummy/config/environment.rb', __dir__)
+# Create the dummy app if it's still missing.
+dummy_env = "#{__dir__}/dummy/config/environment.rb"
+system 'bin/rake extension:test_app' unless File.exist? dummy_env
+require dummy_env
 
 # Requires factories and other useful helpers defined in spree_core.
 require 'solidus_dev_support/rspec/feature_helper'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
-Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+Dir["#{__dir__}/support/**/*.rb"].sort.each { |f| require f }
 
-# Requires factories defined in lib/solidus_webhooks/factories.rb
-require 'solidus_webhooks/factories'
+# Requires factories defined in lib/solidus_webhooks/testing_support/factories.rb
+require 'solidus_webhooks/testing_support/factories'
 
 RSpec.configure do |config|
   config.infer_spec_type_from_file_location!
   config.use_transactional_fixtures = false
+
+  if Spree.solidus_gem_version < Gem::Version.new('2.11')
+    config.extend Spree::TestingSupport::AuthorizationHelpers::Request, type: :system
+  end
 end

data/spec/support/reset_config.rb

@@ -0,0 +1,3 @@
+RSpec.configure do |config|
+  config.before { SolidusWebhooks.reset_config! }
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_webhooks
 version: !ruby/object:Gem::Version
-  version: 0.0.1.v0.1.0.beta.1.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Elia Schito
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-05-13 00:00:00.000000000 Z
+date: 2021-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -19,7 +19,7 @@ dependencies:
         version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,36 +29,36 @@ dependencies:
         version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: solidus_support
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: solidus_dev_support
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-description: 
+        version: '2.2'
+description:
 email: contact@solidus.io
 executables: []
 extensions: []
@@ -67,9 +67,11 @@ files:
 - ".circleci/config.yml"
 - ".gem_release.yml"
 - ".github/stale.yml"
+- ".github_changelog_generator"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
@@ -81,22 +83,29 @@ files:
 - app/controllers/spree/webhooks_controller.rb
 - app/models/spree/webhook.rb
 - bin/console
-- bin/r
+- bin/rails
+- bin/rails-engine
+- bin/rails-sandbox
 - bin/rake
 - bin/sandbox
-- bin/sandbox_rails
 - bin/setup
 - config/locales/en.yml
 - config/routes.rb
 - lib/generators/solidus_webhooks/install/install_generator.rb
+- lib/generators/solidus_webhooks/install/templates/initializer.rb
 - lib/solidus_webhooks.rb
 - lib/solidus_webhooks/configuration.rb
 - lib/solidus_webhooks/engine.rb
+- lib/solidus_webhooks/errors.rb
 - lib/solidus_webhooks/factories.rb
+- lib/solidus_webhooks/testing_support/factories.rb
 - lib/solidus_webhooks/version.rb
 - solidus_webhooks.gemspec
 - spec/features/can_register_a_handler_and_receive_webhooks_spec.rb
+- spec/models/spree/webhook_spec.rb
+- spec/solidus_webhooks/configuration_spec.rb
 - spec/spec_helper.rb
+- spec/support/reset_config.rb
 homepage: https://github.com/solidusio-contrib/solidus_webhooks#readme
 licenses:
 - BSD-3-Clause
@@ -104,25 +113,28 @@ metadata:
   homepage_uri: https://github.com/solidusio-contrib/solidus_webhooks#readme
   source_code_uri: https://github.com/solidusio-contrib/solidus_webhooks
   changelog_uri: https://github.com/solidusio-contrib/solidus_webhooks/releases
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Webhooks support for Solidus
 test_files:
 - spec/features/can_register_a_handler_and_receive_webhooks_spec.rb
+- spec/models/spree/webhook_spec.rb
+- spec/solidus_webhooks/configuration_spec.rb
 - spec/spec_helper.rb
+- spec/support/reset_config.rb