solidus_volume_pricing 0.2.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: fbe1e772f2746fe3ef1be321bebf2677d6adb6f1
-  data.tar.gz: '09057b1c10577aef143f72ce88e4f29e93424ee8'
+SHA256:
+  metadata.gz: 98bbc2761ea5f9a04ec275d189fc8ef633a9a23a174b0fb0fe7183db0e51ac90
+  data.tar.gz: 966b8ca6e650a96310cd69d8c216fed8dff2705f2e35f4722bdf29ef9fe4b747
 SHA512:
-  metadata.gz: d90d442c9da53d8229c6f8cc8cf06a0a047ab212084eb2fe76a36fbb3fb1ba8e585855bcfc467e0f15737af12340687114c51abde3c6f66ebb09b84645372e9c
-  data.tar.gz: 4eb845de35f1c6edf05f5c9e8c267f3b99ba2a1e01b6118126afb20673a0d4e469cd9cf5d738b8c03ce0c7804f9a291fb215f28392d5653eee0c7d4de8cbdc18
+  metadata.gz: ea5dec857a30471edb436aadd74bdfd21f553e1320fc29fd787619b73eb74cfeddfea8699fc8c3c960e9a7630d4032591ba4c2fd2fba2527edc0ca0e6e1fb7a4
+  data.tar.gz: cf4b9beecf2f6cb70d05b4e1018ec910eff96a24c09535b350beb2de2bfa2b802a9e333a19f5242a9888a12347bfda8ad7236731f27bd3e8b9b8c1f63865a1a3

data/.circleci/config.yml

@@ -0,0 +1,35 @@
+version: 2.1
+
+orbs:
+  # Always take the latest version of the orb, this allows us to
+  # run specs against Solidus supported versions only without the need
+  # to change this configuration every time a Solidus version is released
+  # or goes EOL.
+  solidusio_extensions: solidusio/extensions@volatile
+
+jobs:
+  run-specs-with-postgres:
+    executor: solidusio_extensions/postgres
+    steps:
+      - solidusio_extensions/run-tests
+  run-specs-with-mysql:
+    executor: solidusio_extensions/mysql
+    steps:
+      - solidusio_extensions/run-tests
+
+workflows:
+  "Run specs on supported Solidus versions":
+    jobs:
+      - run-specs-with-postgres
+      - run-specs-with-mysql
+  "Weekly run specs against master":
+    triggers:
+      - schedule:
+          cron: "0 0 * * 4" # every Thursday
+          filters:
+            branches:
+              only:
+                - master
+    jobs:
+      - run-specs-with-postgres
+      - run-specs-with-mysql

data/.gem_release.yml

@@ -0,0 +1,5 @@
+bump:
+  recurse: false
+  file: 'lib/solidus_volume_pricing/version.rb'
+  message: Bump SolidusVolumePricing to %{version}
+  tag: true

data/.github/dependabot.yml

@@ -0,0 +1,7 @@
+version: 2
+updates:
+- package-ecosystem: bundler
+  directory: "/"
+  schedule:
+    interval: daily
+  open-pull-requests-limit: 10

data/.github/stale.yml

@@ -0,0 +1,17 @@
+# Number of days of inactivity before an issue becomes stale
+daysUntilStale: 60
+# Number of days of inactivity before a stale issue is closed
+daysUntilClose: 7
+# Issues with these labels will never be considered stale
+exemptLabels:
+  - pinned
+  - security
+# Label to use when marking an issue as stale
+staleLabel: wontfix
+# Comment to post when marking an issue as stale. Set to `false` to disable
+markComment: >
+  This issue has been automatically marked as stale because it has not had
+  recent activity. It will be closed if no further activity occurs. Thank you
+  for your contributions.
+# Comment to post when closing a stale issue. Set to `false` to disable
+closeComment: false

data/.gitignore

@@ -1,13 +1,18 @@
 *.gem
-*.swp
-.bundle
-.idea
+\#*
+*~
+.#*
 .DS_Store
-Gemfile.lock
-pkg/*
-spec/dummy
+.idea
+.project
+.sass-cache
 coverage
-.rvmrc
-.ruby-version
-.ruby-gemset
+Gemfile.lock
 tmp
+nbproject
+pkg
+*.swp
+spec/dummy
+spec/examples.txt
+.byebug*
+Gemfile-local

data/.rspec

@@ -1,3 +1,3 @@
 --color
--f documentation
--r spec_helper
+--format documentation
+--require spec_helper

data/.rubocop.yml

@@ -1,8 +1,4 @@
----
-inherit_from: .hound.yml
+require:
+  - solidus_dev_support/rubocop
 
-AllCops:
-  Exclude:
-    - spec/dummy/**/*
-    - bin/*
-    - Guardfile
+inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,126 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2019-11-23 17:04:33 +0100 using RuboCop version 0.76.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec, 
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'solidus_volume_pricing.gemspec'
+
+# Offense count: 2
+Lint/InterpolationCheck:
+  Exclude:
+    - 'spec/lib/solidus_volume_pricing/range_from_string_spec.rb'
+
+# Offense count: 21
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 160
+
+# Offense count: 43
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/controllers/spree/admin/variants_controller_spec.rb'
+    - 'spec/helpers/base_helper_spec.rb'
+    - 'spec/models/solidus_volume_pricing/pricer_spec.rb'
+    - 'spec/models/spree/order_spec.rb'
+    - 'spec/models/spree/volume_price_spec.rb'
+
+# Offense count: 2
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/features/manage_volume_price_models_feature_spec.rb'
+    - 'spec/features/manage_volume_prices_feature_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: CustomTransform, IgnoreMethods.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/helpers/base_helper_spec.rb'
+
+# Offense count: 29
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Exclude:
+    - 'spec/helpers/base_helper_spec.rb'
+    - 'spec/models/spree/order_spec.rb'
+
+# Offense count: 5
+# Configuration parameters: AggregateFailuresByDefault.
+RSpec/MultipleExpectations:
+  Max: 3
+
+# Offense count: 58
+# Configuration parameters: IgnoreSharedExamples.
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/lib/solidus_volume_pricing/range_from_string_spec.rb'
+    - 'spec/models/solidus_volume_pricing/pricer_spec.rb'
+    - 'spec/models/solidus_volume_pricing/pricing_options_spec.rb'
+    - 'spec/models/spree/volume_price_spec.rb'
+
+# Offense count: 74
+RSpec/NestedGroups:
+  Max: 7
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: db/migrate/*.rb
+Rails/CreateTableWithTimestamps:
+  Exclude:
+    - 'db/migrate/20150603143015_create_spree_volume_price_models.rb'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/HasManyOrHasOneDependent:
+  Exclude:
+    - 'app/models/spree/volume_price_model.rb'
+
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/InverseOf:
+  Exclude:
+    - 'app/models/spree/volume_price.rb'
+    - 'app/models/spree/volume_price_model.rb'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: app/controllers/**/*.rb
+Rails/LexicallyScopedActionFilter:
+  Exclude:
+    - 'app/controllers/spree/admin/volume_price_models_controller.rb'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
+Rails/Output:
+  Exclude:
+    - 'lib/generators/solidus_volume_pricing/install/install_generator.rb'
+
+# Offense count: 2
+# Configuration parameters: Blacklist, Whitelist.
+# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
+Rails/SkipsModelValidations:
+  Exclude:
+    - 'spec/models/spree/volume_price_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'app/models/spree/volume_price.rb'
+    - 'app/models/spree/volume_price_model.rb'

data/CHANGELOG.md

@@ -0,0 +1,86 @@
+# Changelog
+
+## [v1.1.0](https://github.com/solidusio-contrib/solidus_volume_pricing/tree/v1.1.0) (2023-02-09)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_volume_pricing/compare/v1.0.0...v1.1.0)
+
+**Closed issues:**
+
+- Dependabot can't resolve your Ruby dependency files [\#57](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/57)
+- Prepare Solidus Volume Pricing for Solidus 3.0 [\#53](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/53)
+- Dependabot can't resolve your Ruby dependency files [\#52](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/52)
+- Dependabot can't resolve your Ruby dependency files [\#51](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/51)
+- Role base volume pricing not working [\#47](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/47)
+- Dependabot couldn't find a Gemfile-local for this project [\#44](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/44)
+- Dependabot can't resolve your Ruby dependency files [\#42](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/42)
+- Dependabot can't resolve your Ruby dependency files [\#41](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/41)
+- Dependabot can't resolve your Ruby dependency files [\#40](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/40)
+- Dependabot can't resolve your Ruby dependency files [\#39](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/39)
+- Dependabot can't resolve your Ruby dependency files [\#38](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/38)
+- Dependabot can't resolve your Ruby dependency files [\#37](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/37)
+- Dependabot can't resolve your Ruby dependency files [\#36](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/36)
+- Dependabot can't resolve your Ruby dependency files [\#35](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/35)
+- Can we get a new release? [\#29](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/29)
+
+**Merged pull requests:**
+
+- Update supported ruby version [\#66](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/66) ([mcrisologo](https://github.com/mcrisologo))
+- Bump version to 1.1.0 [\#65](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/65) ([mcrisologo](https://github.com/mcrisologo))
+- Update to use forked solidus\_frontend when needed [\#64](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/64) ([waiting-for-dev](https://github.com/waiting-for-dev))
+- Configure autoloader to ignore decorators [\#61](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/61) ([pelargir](https://github.com/pelargir))
+- Updating gemspec for Ruby 3 support [\#60](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/60) ([embold-given](https://github.com/embold-given))
+- Solidus 3 preparation [\#59](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/59) ([cpfergus1](https://github.com/cpfergus1))
+- Upgrade to GitHub-native Dependabot [\#58](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/58) ([dependabot-preview[bot]](https://github.com/apps/dependabot-preview))
+- Relax solidus\_support dependency [\#50](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/50) ([kennyadsl](https://github.com/kennyadsl))
+- Fix Dependabot looking for Gemfile-local [\#48](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/48) ([aldesantis](https://github.com/aldesantis))
+- Fix role discounts [\#46](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/46) ([hrdchz](https://github.com/hrdchz))
+- Rerun dev tools extension update command to improve the structure [\#45](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/45) ([blocknotes](https://github.com/blocknotes))
+- Upgrade the extension using solidus\_dev\_support [\#43](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/43) ([blocknotes](https://github.com/blocknotes))
+
+## [v1.0.0](https://github.com/solidusio-contrib/solidus_volume_pricing/tree/v1.0.0) (2019-11-23)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_volume_pricing/compare/v0.2.1...v1.0.0)
+
+**Implemented enhancements:**
+
+- Replace `I18n.t` with `t` in views [\#22](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/22)
+
+**Closed issues:**
+
+- can we create packs of product by this ? [\#13](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/13)
+- Rails v 5.0.1 [\#8](https://github.com/solidusio-contrib/solidus_volume_pricing/issues/8)
+
+**Merged pull requests:**
+
+- Replace I18n.t with t in views [\#34](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/34) ([aldesantis](https://github.com/aldesantis))
+- Reformat readme [\#33](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/33) ([aldesantis](https://github.com/aldesantis))
+- Adopt solidus\_extension\_dev\_tools [\#32](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/32) ([aldesantis](https://github.com/aldesantis))
+- Switch to sassc/rails [\#30](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/30) ([pelargir](https://github.com/pelargir))
+- Update pg requirement from ~\> 0.21 to ~\> 1.1 [\#27](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/27) ([dependabot-preview[bot]](https://github.com/apps/dependabot-preview))
+- Update coffee-rails requirement from ~\> 4.0 to ~\> 5.0 [\#26](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/26) ([dependabot-preview[bot]](https://github.com/apps/dependabot-preview))
+- Adopt CircleCI instead of Travis [\#23](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/23) ([aldesantis](https://github.com/aldesantis))
+- Solidus 2.4 UI updates [\#21](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/21) ([tvdeyen](https://github.com/tvdeyen))
+- Test suite maintenance [\#20](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/20) ([aitbw](https://github.com/aitbw))
+- Remove 2.2 from CI \(EOL\) [\#19](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/19) ([jacobherrington](https://github.com/jacobherrington))
+- Remove versions past EOL from .travis.yml [\#17](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/17) ([jacobherrington](https://github.com/jacobherrington))
+- Add Solidus 2.1-2.7 to .travis.yml [\#16](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/16) ([jacobherrington](https://github.com/jacobherrington))
+- Remove deprecated icon option from button [\#12](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/12) ([pelargir](https://github.com/pelargir))
+- V2.1 [\#11](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/11) ([seand7565](https://github.com/seand7565))
+- Role fix [\#9](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/9) ([Senjai](https://github.com/Senjai))
+- 1.0 fixes [\#7](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/7) ([tvdeyen](https://github.com/tvdeyen))
+- Add pricers to calculate volume prices [\#4](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/4) ([tvdeyen](https://github.com/tvdeyen))
+- Remove String monkey patch [\#3](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/3) ([tvdeyen](https://github.com/tvdeyen))
+- Solidus 1.3 [\#2](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/2) ([tvdeyen](https://github.com/tvdeyen))
+- Rename to solidus [\#1](https://github.com/solidusio-contrib/solidus_volume_pricing/pull/1) ([tvdeyen](https://github.com/tvdeyen))
+
+## [v0.2.1](https://github.com/solidusio-contrib/solidus_volume_pricing/tree/v0.2.1) (2017-01-20)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_volume_pricing/compare/v0.1.1...v0.2.1)
+
+## [v0.1.1](https://github.com/solidusio-contrib/solidus_volume_pricing/tree/v0.1.1) (2017-01-20)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_volume_pricing/compare/9bcf78426749d2d73878c6c7c8eb3bf0e5747ada...v0.1.1)
+
+
+
+\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*

data/Gemfile

@@ -1,13 +1,36 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
+git_source(:github) { |repo| "https://github.com/#{repo}.git" }
+
+branch = ENV.fetch('SOLIDUS_BRANCH', 'master')
+solidus_git, solidus_frontend_git = if (branch == 'master') || (branch >= 'v3.2')
+                                      %w[solidusio/solidus solidusio/solidus_frontend]
+                                    else
+                                      %w[solidusio/solidus] * 2
+                                    end
+gem 'solidus', github: solidus_git, branch: branch
+gem 'solidus_frontend', github: solidus_frontend_git, branch: branch
 
-branch = ENV.fetch('SOLIDUS_BRANCH', 'v1.3')
-gem "solidus", github: "solidusio/solidus", branch: branch
+# Needed to help Bundler figure out how to resolve dependencies,
+# otherwise it takes forever to resolve them.
+# See https://github.com/bundler/bundler/issues/6677
+gem 'rails', '>0.a'
+
+# Provides basic authentication functionality for testing parts of your engine
+gem 'solidus_auth_devise'
 
 case ENV['DB']
 when 'mysql'
   gem 'mysql2'
 when 'postgresql'
   gem 'pg'
+else
+  gem 'sqlite3'
 end
 
 gemspec
+
+# Use a local Gemfile to include development dependencies that might not be
+# relevant for the project or for other contributors, e.g.: `gem 'pry-debug'`.
+send :eval_gemfile, 'Gemfile-local' if File.exist? 'Gemfile-local'

data/Guardfile

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 guard 'rspec', cmd: 'bundle exec rspec' do
   watch('spec/spec_helper.rb')                        { 'spec' }
   watch('config/routes.rb')                           { 'spec/controllers' }
   watch('app/controllers/application_controller.rb')  { 'spec/controllers' }
-  watch(%r{^spec/(.+)_spec\.rb$})                     { |m| "spec/#{m[1]}_spec.rb"}
+  watch(%r{^spec/(.+)_spec\.rb$})                     { |m| "spec/#{m[1]}_spec.rb" }
   watch(%r{^app/(.+)_decorator\.rb$})                 { |m| "spec/#{m[1]}_spec.rb" }
   watch(%r{^(app|lib)/(.+)(\.rb|\.erb)$})             { |m| "spec/#{m[2]}_spec.rb" }
   watch(%r{^app/controllers/(.+)_(controller)\.rb$})  { |m| "spec/#{m[2]}s/#{m[1]}_#{m[2]}_spec.rb" }

data/{LICENSE.md → LICENSE}

@@ -1,4 +1,4 @@
-Copyright (c) 2009-2015 Spree Commerce and contributors.
+Copyright (c) 2009-2015 Spree Commerce and contributors, 2019 Sean Schofield
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification,
@@ -9,7 +9,7 @@ are permitted provided that the following conditions are met:
     * Redistributions in binary form must reproduce the above copyright notice,
       this list of conditions and the following disclaimer in the documentation
       and/or other materials provided with the distribution.
-    * Neither the name Spree nor the names of its contributors may be used to
+    * Neither the name Solidus nor the names of its contributors may be used to
       endorse or promote products derived from this software without specific
       prior written permission.
 

data/README.md

@@ -1,24 +1,33 @@
 # Volume Pricing
 
-[![Build Status](https://travis-ci.org/solidusio-contrib/solidus_volume_pricing.svg?branch=3-0-stable)](https://travis-ci.org/solidusio-contrib/solidus_volume_pricing)
+[![CircleCI](https://circleci.com/gh/solidusio-contrib/solidus_volume_pricing.svg?style=svg)](https://circleci.com/gh/solidusio-contrib/solidus_volume_pricing)
 [![Code Climate](https://codeclimate.com/github/solidusio-contrib/solidus_volume_pricing/badges/gpa.svg)](https://codeclimate.com/github/solidusio-contrib/solidus_volume_pricing)
 
-Volume Pricing is an extension to Solidus that uses predefined ranges of quantities to determine the price for a particular product variant.  For instance, this allows you to set a price for quantities between 1-10, another price for quantities between (10-100) and another for quantities of 100 or more.  If no volume price is defined for a variant, then the standard price is used.
+Volume Pricing is an extension to Solidus that uses predefined ranges of quantities to determine the
+price for a particular product variant.
 
-Each VolumePrice contains the following values:
+For instance, this allows you to set a price for quantities between 1-10, another price for
+quantities between (10-100) and another for quantities of 100 or more. If no volume price is defined
+for a variant, then the standard price is used.
 
-1. **Variant:** Each VolumePrice is associated with a _Variant_, which is used to link products to particular prices.
-1. **Name:** The human readable representation of the quantity range (Ex. 10-100).  (Optional)
-1. **Discount Type** The type of discount to apply.  **Price:** sets price to the amount specified. **Dollar:** subtracts specified amount from the Variant price.  **Percent:** subtracts the specified amounts percentage from the Variant price.
-1. **Range:** The quantity range for which the price is valid (See Below for Examples of Valid Ranges.)
-1. **Amount:** The price of the product if the line item quantity falls within the specified range.
-1. **Position:** Integer value for `acts_as_list` (Helps keep the volume prices in a defined order.)
+Each VolumePrice contains the following values:
 
----
+1. **Variant:** Each VolumePrice is associated with a _Variant_, which is used to link products to
+   particular prices.
+2. **Name:** The human readable representation of the quantity range (Ex. 10-100). (Optional)
+3. **Discount Type** The type of discount to apply.  **Price:** sets price to the amount specified.
+     * **Dollar:** subtracts specified amount from the Variant price.
+     * **Percent:** subtracts the specified amounts percentage from the Variant price.
+4. **Range:** The quantity range for which the price is valid (See Below for Examples of Valid
+   Ranges.)
+5. **Amount:** The price of the product if the line item quantity falls within the specified range.
+6. **Position:** Integer value for `acts_as_list` (Helps keep the volume prices in a defined order.)
 
 ## Install
 
-The extension contains a rails generator that will add the necessary migrations and give you the option to run the migrations, or run them later, perhaps after installing other extensions. Once you have bundled the extension, run the install generator and its ready to use.
+The extension contains a rails generator that will add the necessary migrations and give you the
+option to run the migrations, or run them later, perhaps after installing other extensions. Once you
+have bundled the extension, run the install generator and its ready to use.
 
       rails generate solidus_volume_pricing:install
 
@@ -26,85 +35,81 @@ Easily add volume pricing display to your product page:
 
       <%= render partial: 'spree/products/volume_pricing', locals: { product: @product } %>
 
----
-
 ## Ranges
 
-Ranges are expressed as Strings and are similar to the format of a Range object in Ruby.  The lower number of the range is always inclusive.  If the range is defined with '..' then it also includes the upper end of the range.  If the range is defined with '...' then the upper end of the range is not inclusive.
+Ranges are expressed as Strings and are similar to the format of a Range object in Ruby. The lower
+number of the range is always inclusive.  If the range is defined with '..' then it also includes
+the upper end of the range.  If the range is defined with '...' then the upper end of the range is
+not inclusive.
 
-Ranges can also be defined as "open ended."  Open ended ranges are defined with an integer followed by a '+' character.  These ranges are inclusive of the integer and any value higher then the integer.
+Ranges can also be defined as "open ended."  Open ended ranges are defined with an integer followed
+by a '+' character.  These ranges are inclusive of the integer and any value higher then the
+integer.
 
-All ranges need to be expressed as Strings and can include or exclude parentheses.  "(1..10)" and "1..10" are considered to be a valid range.
-
----
+All ranges need to be expressed as Strings and can include or exclude parentheses.  "(1..10)" and
+"1..10" are considered to be a valid range.
 
 ## Examples
 
 Consider the following examples of volume prices:
 
-       Variant                Name               Range        Amount         Position
-       -------------------------------------------------------------------------------
-       Rails T-Shirt          1-5                (1..5)       19.99          1
-       Rails T-Shirt          6-9                (6...10)     18.99          2
-       Rails T-Shirt          10 or more         (10+)        17.99          3
+| Variant | Name | Range | Amount | Position |
+| ------- | ---- | ----- | ------ | -------- |
+| Rails T-Shirt | 1-5 | (1..5) | 19.99 | 1 |
+| Rails T-Shirt | 6-9 | (6...10) | 18.99 | 2 |
+| Rails T-Shirt | 10 or more | (10+) | 17.99 | 3 |
 
 ### Example 1
 
 Cart Contents:
 
-       Product                Quantity       Price       Total
-       ----------------------------------------------------------------
-       Rails T-Shirt          1              19.99       19.99
+| Product | Quantity | Price | Total |
+| ------- | -------- | ----- | ----- |
+| Rails T-Shirt | 1 | 19.99 | 19.99 |
 
 ### Example 2
 
 Cart Contents:
 
-       Product                Quantity       Price       Total
-       ----------------------------------------------------------------
-       Rails T-Shirt          5              19.99       99.95
+| Product | Quantity | Price | Total |
+| ------- | -------- | ----- | ----- |
+| Rails T-Shirt | 5 | 19.99 | 99.95 |
 
 ### Example 3
 
 Cart Contents:
 
-      Product                Quantity       Price       Total
-      ----------------------------------------------------------------
-      Rails T-Shirt          6              18.99       113.94
+| Product | Quantity | Price | Total |
+| ------- | -------- | ----- | ----- |
+| Rails T-Shirt | 6 | 18.99 | 113.94 |
 
 ### Example 4
 
 Cart Contents:
 
-      Product                Quantity       Price       Total
-      ----------------------------------------------------------------
-      Rails T-Shirt          10             17.99       179.90
+| Product | Quantity | Price | Total |
+| ------- | -------- | ----- | ----- |
+| Rails T-Shirt | 10 | 17.99 | 179.90 |
 
 ### Example 5
 
 Cart Contents:
 
-      Product                Quantity       Price       Total
-      ----------------------------------------------------------------
-      Rails T-Shirt          20             17.99       359.80
-
----
+| Product | Quantity | Price | Total |
+| ------- | -------- | ----- | ----- |
+| Rails T-Shirt | 20 | 17.99 | 359.80 |
 
 ## Additional Notes
 
-* The volume price is applied based on the total quantity ordered for a particular variant.  It does not apply different prices for the portion of the quantity that falls within a particular range. Only the one price is used (although this would be an interesting configurable option if someone wanted to write a patch.)
-
----
-
-## Contributing
-
-See corresponding [contributing guidelines][1].
-
----
+* The volume price is applied based on the total quantity ordered for a particular variant. It does
+  not apply different prices for the portion of the quantity that falls within a particular range.
+  Only the one price is used (although this would be an interesting configurable option if someone
+  wanted to write a patch.)
 
 ## License
 
-Copyright (c) 2009-2015 [Spree Commerce][2] and [contributors][3], released under the [New BSD License][4]
+Copyright (c) 2009-2015 [Spree Commerce][2] and [contributors][3], released under the
+[New BSD License][4].
 
 [1]: https://github.com/solidusio-contrib/solidus_volume_pricing/blob/master/CONTRIBUTING.md
 [2]: https://github.com/spree

data/Rakefile

@@ -1,21 +1,6 @@
-require 'bundler'
-Bundler::GemHelper.install_tasks
+# frozen_string_literal: true
 
-require 'rspec/core/rake_task'
-require 'spree/testing_support/extension_rake'
+require 'solidus_dev_support/rake_tasks'
+SolidusDevSupport::RakeTasks.install
 
-RSpec::Core::RakeTask.new
-
-task :default do
-  if Dir["spec/dummy"].empty?
-    Rake::Task[:test_app].invoke
-    Dir.chdir("../../")
-  end
-  Rake::Task[:spec].invoke
-end
-
-desc 'Generates a dummy app for testing'
-task :test_app do
-  ENV['LIB_NAME'] = 'solidus_volume_pricing'
-  Rake::Task['extension:test_app'].invoke
-end
+task default: 'extension:specs'

data/app/assets/javascripts/spree/backend/solidus_volume_pricing.js

@@ -1,16 +1,2 @@
-//= require spree/backend
+// Just here for backwards compatibility
 
-// spree's version only handles 'input', not 'select', and this breaks solidus_volume_pricing
-
-$(function () {
-  $('#add_volume_price').click( function() {
-    var target = $(this).data("target"),
-      new_table_row = $(target + ' tr:visible:first');
-    new_table_row.find('div.select2').remove();
-    $('select.select2').select2({
-      allowClear: true,
-      dropdownAutoWidth: true
-    });
-  });
-
-});

data/app/controllers/spree/admin/volume_price_models_controller.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 module Spree
   module Admin
     class VolumePriceModelsController < ResourceController
-
       before_action :load_volume_prices, only: [:new, :edit]
 
       private