solidus_volume_pricing 0.2.1 → 1.0.0

data/config/routes.rb

@@ -1,4 +1,6 @@
-Spree::Core::Engine.add_routes do
+# frozen_string_literal: true
+
+Spree::Core::Engine.routes.draw do
   namespace :admin do
     resources :products do
       resources :variants do

data/db/migrate/20081119145604_create_volume_prices.rb

@@ -1,4 +1,6 @@
-class CreateVolumePrices < ActiveRecord::Migration
+# frozen_string_literal: true
+
+class CreateVolumePrices < ActiveRecord::Migration[4.2]
   def self.up
     create_table :volume_prices do |t|
       t.references :variant

data/db/migrate/20110203174010_change_display_name_for_volume_prices.rb

@@ -1,4 +1,6 @@
-class ChangeDisplayNameForVolumePrices < ActiveRecord::Migration
+# frozen_string_literal: true
+
+class ChangeDisplayNameForVolumePrices < ActiveRecord::Migration[4.2]
   def self.up
     rename_column :volume_prices, :display, :name
   end

data/db/migrate/20111206173307_prefix_volume_pricing_table_names.rb

@@ -1,4 +1,6 @@
-class PrefixVolumePricingTableNames < ActiveRecord::Migration
+# frozen_string_literal: true
+
+class PrefixVolumePricingTableNames < ActiveRecord::Migration[4.2]
   def change
     rename_table :volume_prices, :spree_volume_prices unless Spree::VolumePrice.table_exists?
   end

data/db/migrate/20121115043422_add_discount_type_column.rb

@@ -1,4 +1,6 @@
-class AddDiscountTypeColumn < ActiveRecord::Migration
+# frozen_string_literal: true
+
+class AddDiscountTypeColumn < ActiveRecord::Migration[4.2]
   def change
     add_column :spree_volume_prices, :discount_type, :string
   end

data/db/migrate/20150513200904_add_role_to_volume_price.rb

@@ -1,4 +1,6 @@
-class AddRoleToVolumePrice < ActiveRecord::Migration
+# frozen_string_literal: true
+
+class AddRoleToVolumePrice < ActiveRecord::Migration[4.2]
   def change
     add_column :spree_volume_prices, :role_id, :integer
   end

data/db/migrate/20150603143015_create_spree_volume_price_models.rb

@@ -1,4 +1,6 @@
-class CreateSpreeVolumePriceModels < ActiveRecord::Migration
+# frozen_string_literal: true
+
+class CreateSpreeVolumePriceModels < ActiveRecord::Migration[4.2]
   def change
     create_table :spree_volume_price_models do |t|
       t.string :name

data/lib/generators/solidus_volume_pricing/install/install_generator.rb

@@ -1,18 +1,16 @@
+# frozen_string_literal: true
+
 module SolidusVolumePricing
   module Generators
     class InstallGenerator < Rails::Generators::Base
       class_option :auto_run_migrations, type: :boolean, default: false
 
-      def add_javascripts
-        append_file 'vendor/assets/javascripts/spree/backend/all.js', "//= require spree/backend/solidus_volume_pricing\n"
-      end
-
       def add_migrations
         run 'bundle exec rake railties:install:migrations FROM=solidus_volume_pricing'
       end
 
       def run_migrations
-        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask 'Would you like to run the migrations now? [Y/n]')
+        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]'))
         if run_migrations
           run 'bundle exec rake db:migrate'
         else

data/lib/solidus_volume_pricing.rb

@@ -1,6 +1,10 @@
-require 'sass/rails'
+# frozen_string_literal: true
+
+require 'active_support/deprecation'
+require 'sassc/rails'
 require 'deface'
 require 'solidus_core'
 require 'solidus_volume_pricing/engine'
 require 'solidus_volume_pricing/version'
+require 'solidus_volume_pricing/range_from_string'
 require 'coffee_script'

data/lib/solidus_volume_pricing/engine.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module SolidusVolumePricing
   class Engine < Rails::Engine
-    isolate_namespace Spree
+    isolate_namespace ::Spree
     engine_name 'solidus_volume_pricing'
 
     initializer 'solidus_volume_pricing.preferences', before: 'spree.environment' do
-      Spree::AppConfiguration.class_eval do
+      ::Spree::AppConfiguration.class_eval do
         preference :use_master_variant_volume_pricing, :boolean, default: false
         preference :volume_pricing_role, :string, default: 'wholesale'
       end
@@ -14,26 +16,7 @@ module SolidusVolumePricing
       Dir.glob(File.join(File.dirname(__FILE__), '../../app/**/*_decorator*.rb')) do |c|
         Rails.configuration.cache_classes ? require(c) : load(c)
       end
-
-      String.class_eval do
-        def to_range
-          case count('.')
-          when 2
-            elements = split('..')
-            return Range.new(elements[0].delete('(').to_i, elements[1].to_i)
-          when 3
-            elements = split('...')
-            return Range.new(elements[0].delete('(').to_i, elements[1].to_i - 1)
-          else
-            raise ArgumentError.new(
-              I18n.t(
-                :'activerecord.errors.messages.could_not_conver_to_range',
-                number: self
-              )
-            )
-          end
-        end
-      end
+      ::Spree::BackendConfiguration::CONFIGURATION_TABS << :volume_price_models
     end
 
     config.autoload_paths += %W(#{config.root}/lib)

data/lib/solidus_volume_pricing/range_from_string.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module SolidusVolumePricing
+  class RangeFromString
+    attr_reader :range_string
+
+    RANGE_FORMAT = /\A\(?(\d+)(\.{2,3})(\d+)\)?\z/.freeze
+    OPEN_ENDED = /\(?[0-9]+\+\)?/.freeze
+
+    def initialize(range_string)
+      @range_string = range_string
+    end
+
+    def to_range
+      ::Range.new(*options_from_string)
+    end
+
+    private
+
+    def options_from_string
+      case range_string
+      when OPEN_ENDED
+        [range_string.tr("^0-9", '').to_i, Float::INFINITY]
+      when RANGE_FORMAT
+        [
+          Regexp.last_match[1].to_i,
+          Regexp.last_match[3].to_i,
+          Regexp.last_match[2].length == 3
+        ]
+      else
+        raise ArgumentError,
+          I18n.t(:could_not_convert_to_range, scope: 'activerecord.errors.messages', string: range_string)
+      end
+    end
+  end
+end

data/lib/solidus_volume_pricing/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SolidusVolumePricing
   module_function
 
@@ -8,9 +10,9 @@ module SolidusVolumePricing
   end
 
   module VERSION
-    MAJOR = 0
-    MINOR = 2
-    TINY  = 1
+    MAJOR = 1
+    MINOR = 0
+    TINY  = 0
     PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')

data/solidus_volume_pricing.gemspec

@@ -1,4 +1,6 @@
-lib = File.expand_path('../lib/', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift lib unless $LOAD_PATH.include?(lib)
 
 require 'solidus_volume_pricing/version'
@@ -21,20 +23,10 @@ Gem::Specification.new do |s|
   s.require_path = 'lib'
   s.requirements << 'none'
 
-  s.add_runtime_dependency 'solidus_core', '~> 1.3'
   s.add_runtime_dependency 'deface', '~> 1.0'
+  s.add_runtime_dependency 'solidus_backend', '>= 2.0'
+  s.add_runtime_dependency 'solidus_core', '>= 2.0'
 
-  s.add_development_dependency 'sqlite3', '>= 1.3.10'
-  s.add_development_dependency 'capybara', '~> 2.4'
-  s.add_development_dependency 'ffaker', '>= 1.32.1'
   s.add_development_dependency 'shoulda-matchers'
-  s.add_development_dependency 'rspec-rails', '~> 3.2'
-  s.add_development_dependency 'simplecov', '~> 0.9'
-  s.add_development_dependency 'factory_girl', '~> 4.5'
-  s.add_development_dependency 'pry-rails', '>= 0.3'
-  s.add_development_dependency 'poltergeist', '~> 1.6'
-  s.add_development_dependency 'database_cleaner', '~> 1.4'
-  s.add_development_dependency 'coffee-rails', '~> 4.0'
-  s.add_development_dependency 'sass-rails', '~> 5.0'
-  s.add_development_dependency 'rubocop', '>= 0.24.1'
+  s.add_development_dependency 'solidus_extension_dev_tools'
 end

data/spec/controllers/spree/admin/variants_controller_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe Spree::Admin::VariantsController, type: :controller do
   stub_authorization!
 
@@ -6,21 +8,22 @@ RSpec.describe Spree::Admin::VariantsController, type: :controller do
       variant = create :variant
 
       expect do
-        spree_put :update,
-                  product_id: variant.product.slug,
-                  id: variant.id,
-                  variant: {
-                    'volume_prices_attributes' => {
-                      '1335830259720' => {
-                        'name' => '5-10',
-                        'discount_type' => 'price',
-                        'range' => '5..10',
-                        'amount' => '90',
-                        'position' => '1',
-                        '_destroy' => 'false'
-                      }
-                    }
-                  }
+        put :update, params: {
+          product_id: variant.product.slug,
+          id: variant.id,
+          variant: {
+            'volume_prices_attributes' => {
+              '1335830259720' => {
+                'name' => '5-10',
+                'discount_type' => 'price',
+                'range' => '5..10',
+                'amount' => '90',
+                'position' => '1',
+                '_destroy' => 'false'
+              }
+            }
+          }
+        }
       end.to change(variant.volume_prices, :count).by(1)
     end
   end

data/spec/factories/volume_price_factory.rb

@@ -1,12 +1,14 @@
-FactoryGirl.define do
+# frozen_string_literal: true
+
+FactoryBot.define do
   factory :volume_price, class: Spree::VolumePrice do
-    amount 10
-    discount_type 'price'
-    range '(1..5)'
+    amount { 10 }
+    discount_type { 'price' }
+    range { '(1..5)' }
     association :variant
   end
 
   factory :volume_price_model, class: Spree::VolumePriceModel do
-    name 'name'
+    name { 'name' }
   end
 end

data/spec/features/manage_volume_price_models_feature_spec.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-RSpec.feature 'Managing volume price models' do
+RSpec.describe 'Managing volume price models' do
   stub_authorization!
 
-  scenario 'a admin can create and remove volume price models', :js do
+  it 'a admin can create and remove volume price models', :js do
     visit spree.admin_volume_price_models_path
     expect(page).to have_content('Volume Price Models')
 
@@ -20,7 +22,7 @@ RSpec.feature 'Managing volume price models' do
     within 'tr.volume_price.fields' do
       expect(page).to have_field('volume_price_model_volume_prices_attributes_0_name', with: '5 pieces discount')
       page.find('a[data-action="remove"]').click
-      expect(page).to_not have_field('volume_price_model_volume_prices_attributes_0_name', with: '5 pieces discount')
+      expect(page).not_to have_field('volume_price_model_volume_prices_attributes_0_name', with: '5 pieces discount')
     end
   end
 end

data/spec/features/manage_volume_prices_feature_spec.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-RSpec.feature 'Managing volume prices' do
+RSpec.describe 'Managing volume prices' do
   stub_authorization!
 
   let(:variant) { create(:variant) }
 
-  scenario 'a admin can create and remove volume prices', :js do
+  it 'a admin can create and remove volume prices', :js do
     visit spree.edit_admin_product_path(variant.product)
     click_on 'Volume Pricing'
     expect(page).to have_content('Volume Prices')
@@ -19,11 +21,11 @@ RSpec.feature 'Managing volume prices' do
     within 'tr.volume_price.fields' do
       expect(page).to have_field('variant_volume_prices_attributes_0_name', with: '5 pieces discount')
       page.find('a[data-action="remove"]').click
-      expect(page).to_not have_field('variant_volume_prices_attributes_0_name', with: '5 pieces discount')
+      expect(page).not_to have_field('variant_volume_prices_attributes_0_name', with: '5 pieces discount')
     end
   end
 
-  scenario 'a admin editing a variant has a new volume price already built for her' do
+  it 'a admin editing a variant has a new volume price already built for her' do
     visit spree.edit_admin_product_variant_path(product_id: variant.product, id: variant)
     within '#volume_prices' do
       expect(page).to have_field('variant_volume_prices_attributes_0_name')

data/spec/helpers/base_helper_spec.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 RSpec.describe Spree::BaseHelper, type: :helper do
-  include Spree::BaseHelper
+  include described_class
 
   context 'volume pricing' do
     before do

data/spec/lib/solidus_volume_pricing/range_from_string_spec.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe SolidusVolumePricing::RangeFromString do
+  describe 'new' do
+    subject(:range) { described_class.new(argument).to_range }
+
+    context 'with a string with two dots' do
+      let(:argument) { '1..2' }
+
+      it { is_expected.to eq(1..2) }
+    end
+
+    context 'with a string with two dots and parens' do
+      let(:argument) { '(1..2)' }
+
+      it { is_expected.to eq(1..2) }
+    end
+
+    context 'with a string with three dots' do
+      let(:argument) { '1...2' }
+
+      it { is_expected.to eq(1...2) }
+    end
+
+    context 'with a string with three dots and parens' do
+      let(:argument) { '(1...2)' }
+
+      it { is_expected.to eq(1...2) }
+    end
+
+    context 'with an open-ended string like #{x}+' do
+      let(:argument) { '10+' }
+
+      it { is_expected.to eq(10..Float::INFINITY) }
+    end
+
+    context 'with an open-ended string like #{x}+ and parens' do
+      let(:argument) { '(10+)' }
+
+      it { is_expected.to eq(10..Float::INFINITY) }
+    end
+
+    context 'with invalid input' do
+      let(:argument) { 'system("rm -rf /*")' }
+
+      it do
+        expect { subject }.to raise_error(ArgumentError)
+      end
+    end
+
+    context 'with invalid input' do
+      let(:argument) { '1..3; puts "Do not run Ruby Code"' }
+
+      it do
+        expect { subject }.to raise_error(ArgumentError)
+      end
+    end
+  end
+end

data/spec/models/solidus_volume_pricing/pricer_spec.rb

@@ -0,0 +1,673 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.shared_examples 'having the variant price' do
+  it 'uses the variants price' do
+    expect(subject).to eq('$10.00')
+  end
+end
+
+RSpec.describe SolidusVolumePricing::Pricer do
+  let(:other_role) { create(:role) }
+  let(:role) { create(:role) }
+  let(:user) { create(:user) }
+  let(:variant) { create(:variant, price: 10) }
+
+  before do
+    stub_spree_preferences(volume_pricing_role: role.name)
+  end
+
+  it 'inherits from default variant pricer' do
+    expect(described_class < Spree::Variant::PriceSelector).to be(true)
+  end
+
+  it 'has SolidusVolumePricing::PricingOptions as pricing options class' do
+    expect(described_class.pricing_options_class).to eq(SolidusVolumePricing::PricingOptions)
+  end
+
+  describe '#price_for' do
+    subject do
+      described_class.new(variant).price_for(pricing_options).to_s
+    end
+
+    let(:quantity) { 1 }
+
+    let(:pricing_options) do
+      SolidusVolumePricing::PricingOptions.new(quantity: quantity)
+    end
+
+    context 'discount_type = price' do
+      before do
+        variant.volume_prices.create!(amount: 7, discount_type: 'price', range: '(10+)')
+      end
+
+      context 'when quantity does not match the range' do
+        it_behaves_like 'having the variant price'
+      end
+
+      context 'when quantity matches the range' do
+        let(:quantity) { 10 }
+
+        it 'uses the volume price' do
+          expect(subject).to eq('$7.00')
+        end
+
+        context 'when volume price has a role' do
+          before do
+            variant.volume_prices.first.update(role_id: role.id)
+          end
+
+          context 'when no user is given' do
+            it_behaves_like 'having the variant price'
+          end
+
+          context 'when a user is given' do
+            let(:pricing_options) do
+              SolidusVolumePricing::PricingOptions.new(
+                quantity: quantity,
+                user: user
+              )
+            end
+
+            context 'whose role matches' do
+              before { user.spree_roles << role }
+
+              it 'uses the volume price' do
+                expect(subject).to eq('$7.00')
+              end
+            end
+
+            context 'whose role does not match' do
+              before { user.spree_roles << other_role }
+
+              it_behaves_like 'having the variant price'
+            end
+          end
+        end
+
+        context 'of a volume price model instead' do
+          let(:quantity) { 6 }
+
+          before do
+            variant.volume_price_models << create(:volume_price_model)
+            variant.volume_price_models.first.volume_prices.create!(amount: 5, discount_type: 'price', range: '(5+)')
+          end
+
+          it 'uses the volume price from model' do
+            expect(subject).to eq('$5.00')
+          end
+        end
+      end
+    end
+
+    context 'discount_type = dollar' do
+      before do
+        variant.volume_prices.create!(amount: 1, discount_type: 'dollar', range: '(10+)')
+      end
+
+      context 'when quantity does not match the range' do
+        it_behaves_like 'having the variant price'
+      end
+
+      context 'when quantity matches the range' do
+        let(:quantity) { 10 }
+
+        it 'uses the volume price' do
+          expect(subject).to eq('$9.00')
+        end
+
+        context 'when volume price has a role' do
+          before do
+            variant.volume_prices.first.update(role_id: role.id)
+          end
+
+          context 'when no user is given' do
+            it_behaves_like 'having the variant price'
+          end
+
+          context 'when a user is given' do
+            let(:pricing_options) do
+              SolidusVolumePricing::PricingOptions.new(
+                quantity: quantity,
+                user: user
+              )
+            end
+
+            context 'whose role matches' do
+              before { user.spree_roles << role }
+
+              it 'uses the volume price' do
+                expect(subject).to eq('$9.00')
+              end
+            end
+
+            context 'whose role does not match' do
+              before { user.spree_roles << other_role }
+
+              it_behaves_like 'having the variant price'
+            end
+          end
+        end
+      end
+
+      context 'of a volume price model instead' do
+        let(:quantity) { 6 }
+
+        before do
+          variant.volume_price_models << create(:volume_price_model)
+          variant.volume_price_models.first.volume_prices.create!(amount: 2, discount_type: 'dollar', range: '(5+)')
+        end
+
+        it 'uses the volume price from model' do
+          expect(subject).to eq('$8.00')
+        end
+      end
+    end
+
+    context 'discount_type = percent' do
+      before do
+        variant.volume_prices.create!(amount: 0.25, discount_type: 'percent', range: '(10+)')
+      end
+
+      context 'when quantity does not match the range' do
+        it_behaves_like 'having the variant price'
+      end
+
+      context 'when quantity matches the range' do
+        let(:quantity) { 10 }
+
+        it 'uses the volume price' do
+          expect(subject).to eq('$7.50')
+        end
+
+        context 'when volume price has a role' do
+          before do
+            variant.volume_prices.first.update(role_id: role.id)
+          end
+
+          context 'when no user is given' do
+            it_behaves_like 'having the variant price'
+          end
+
+          context 'when a user is given' do
+            let(:pricing_options) do
+              SolidusVolumePricing::PricingOptions.new(
+                quantity: quantity,
+                user: user
+              )
+            end
+
+            context 'whose role matches' do
+              before { user.spree_roles << role }
+
+              it 'uses the volume price' do
+                expect(subject).to eq('$7.50')
+              end
+            end
+
+            context 'whose role does not match' do
+              before { user.spree_roles << other_role }
+
+              it_behaves_like 'having the variant price'
+            end
+          end
+        end
+      end
+
+      context 'of a volume price model instead' do
+        let(:quantity) { 6 }
+
+        it 'uses the volume price from model' do
+          variant.volume_price_models << create(:volume_price_model)
+          variant.volume_price_models.first.volume_prices.create!(amount: 0.75, discount_type: 'percent', range: '(5+)')
+          expect(subject).to eq('$2.50')
+        end
+      end
+    end
+
+    context 'discount_type is unknown' do
+      before do
+        variant.volume_prices.create(amount: 7, discount_type: 'foo', range: '(10+)')
+      end
+
+      it_behaves_like 'having the variant price'
+    end
+
+    context 'when use_master_variant_volume_pricing' do
+      let(:master) { variant.product.master }
+
+      before do
+        stub_spree_preferences(use_master_variant_volume_pricing: use_master_variant_volume_pricing)
+        master.volume_prices.create!(amount: 1.5, discount_type: 'price', range: '(1+)')
+        variant.volume_prices.create!(amount: 3.5, discount_type: 'price', range: '(1+)')
+      end
+
+      context 'is enabled' do
+        let(:use_master_variant_volume_pricing) { true }
+
+        context 'when volume prices are present on variant' do
+          it 'uses the variant to compute price' do
+            expect(subject).to eq('$3.50')
+          end
+        end
+
+        context 'when no volume prices present on variant' do
+          before do
+            variant.volume_prices.delete_all
+          end
+
+          it 'uses the master variant to compute price' do
+            expect(subject).to eq('$1.50')
+          end
+        end
+      end
+
+      context 'is disabled' do
+        let(:use_master_variant_volume_pricing) { false }
+
+        it 'uses the master variant to compute price' do
+          expect(subject).to eq('$3.50')
+        end
+      end
+    end
+  end
+
+  describe '#earning_amount' do
+    subject do
+      described_class.new(variant).earning_amount(pricing_options).to_s
+    end
+
+    let(:pricing_options) do
+      SolidusVolumePricing::PricingOptions.new(quantity: quantity)
+    end
+
+    context 'discount_type = price' do
+      before do
+        variant.volume_prices.create!(amount: 9, discount_type: 'price', range: '(10+)')
+      end
+
+      context 'when quantity matches range' do
+        let(:quantity) { 10 }
+
+        it 'gives amount earning' do
+          expect(subject).to eq('$1.00')
+        end
+
+        context 'when volume_price has role' do
+          before do
+            variant.volume_prices.first.update(role_id: role.id)
+          end
+
+          context 'when user is given' do
+            let(:pricing_options) do
+              SolidusVolumePricing::PricingOptions.new(
+                quantity: quantity,
+                user: user
+              )
+            end
+
+            context 'whose role matches' do
+              before do
+                user.spree_roles << role
+              end
+
+              it 'gives amount earning' do
+                expect(subject).to eq('$1.00')
+              end
+            end
+
+            context 'whose role does not match' do
+              before do
+                user.spree_roles << other_role
+              end
+
+              it 'gives zero earning amount' do
+                expect(subject).to eq('$0.00')
+              end
+            end
+          end
+
+          context 'when no user is given' do
+            it 'gives zero earning amount' do
+              expect(subject).to eq('$0.00')
+            end
+          end
+        end
+      end
+
+      context 'when quantity does not match range' do
+        let(:quantity) { 1 }
+
+        it 'gives zero earning amount' do
+          expect(subject).to eq('$0.00')
+        end
+      end
+    end
+
+    context 'discount_type = dollar' do
+      before do
+        variant.volume_prices.create!(amount: 2.5, discount_type: 'dollar', range: '(10+)')
+      end
+
+      context 'when amount matches range' do
+        let(:quantity) { 10 }
+
+        it 'gives amount earning' do
+          expect(subject).to eq('$2.50')
+        end
+
+        context 'when volume_price has role' do
+          before do
+            variant.volume_prices.first.update(role_id: role.id)
+          end
+
+          context 'when user is given' do
+            let(:pricing_options) do
+              SolidusVolumePricing::PricingOptions.new(
+                quantity: quantity,
+                user: user
+              )
+            end
+
+            context 'whose role matches' do
+              before do
+                user.spree_roles << role
+              end
+
+              it 'gives amount earning' do
+                expect(subject).to eq('$2.50')
+              end
+            end
+
+            context 'whose role does not match' do
+              before do
+                user.spree_roles << other_role
+              end
+
+              it 'gives zero earning amount' do
+                expect(subject).to eq('$0.00')
+              end
+            end
+          end
+
+          context 'when no user is given' do
+            it 'gives zero earning amount' do
+              expect(subject).to eq('$0.00')
+            end
+          end
+        end
+      end
+
+      context 'when amount does not match range' do
+        let(:quantity) { 1 }
+
+        it 'gives zero earning amount' do
+          expect(subject).to eq('$0.00')
+        end
+      end
+    end
+
+    context 'discount_type = percent' do
+      before do
+        variant.volume_prices.create!(amount: 0.75, discount_type: 'percent', range: '(10+)')
+      end
+
+      context 'when amount matches range' do
+        let(:quantity) { 10 }
+
+        it 'gives amount earning' do
+          expect(subject).to eq('$7.50')
+        end
+
+        context 'when volume_price has role' do
+          before do
+            variant.volume_prices.first.update(role_id: role.id)
+          end
+
+          context 'when user is given' do
+            let(:pricing_options) do
+              SolidusVolumePricing::PricingOptions.new(
+                quantity: quantity,
+                user: user
+              )
+            end
+
+            context 'whose role matches' do
+              before do
+                user.spree_roles << role
+              end
+
+              it 'gives amount earning' do
+                expect(subject).to eq('$7.50')
+              end
+            end
+
+            context 'whose role does not match' do
+              before do
+                user.spree_roles << other_role
+              end
+
+              it 'gives zero earning amount' do
+                expect(subject).to eq('$0.00')
+              end
+            end
+          end
+
+          context 'when no user is given' do
+            it 'gives zero earning amount' do
+              expect(subject).to eq('$0.00')
+            end
+          end
+        end
+      end
+
+      context 'when amount does not match range' do
+        let(:quantity) { 1 }
+
+        it 'gives zero earning amount' do
+          expect(subject).to eq('$0.00')
+        end
+      end
+    end
+  end
+
+  describe '#earning_percent' do
+    subject do
+      described_class.new(variant).earning_percent(pricing_options)
+    end
+
+    let(:pricing_options) do
+      SolidusVolumePricing::PricingOptions.new(quantity: quantity)
+    end
+
+    context 'discount_type = price' do
+      before do
+        variant.volume_prices.create!(amount: 9, discount_type: 'price', range: '(10+)')
+      end
+
+      context 'when quantity matches range' do
+        let(:quantity) { 10 }
+
+        it 'gives percent of earning' do
+          expect(subject).to eq(10)
+        end
+
+        context 'when volume_price has role' do
+          before do
+            variant.volume_prices.first.update(role_id: role.id)
+          end
+
+          context 'when user is given' do
+            let(:pricing_options) do
+              SolidusVolumePricing::PricingOptions.new(
+                quantity: quantity,
+                user: user
+              )
+            end
+
+            context 'whose role matches' do
+              before do
+                user.spree_roles << role
+              end
+
+              it 'gives percent of earning if role matches' do
+                expect(subject).to eq(10)
+              end
+            end
+
+            context 'whose role doesnt match' do
+              before do
+                user.spree_roles << other_role
+              end
+
+              it 'gives zero percent earning' do
+                expect(subject).to eq(0)
+              end
+            end
+          end
+
+          context 'when no user is given' do
+            it 'gives zero earning amount' do
+              expect(subject).to eq(0)
+            end
+          end
+        end
+      end
+
+      context 'when quantity does not match range' do
+        let(:quantity) { 1 }
+
+        it 'gives zero percent earning' do
+          expect(subject).to eq(0)
+        end
+      end
+    end
+
+    context 'discount_type = dollar' do
+      before do
+        variant.volume_prices.create!(amount: 2.5, discount_type: 'dollar', range: '(10+)')
+      end
+
+      context 'when quantity matches range' do
+        let(:quantity) { 10 }
+
+        it 'gives percent of earning' do
+          expect(subject).to eq(25)
+        end
+
+        context 'when volume_price has role' do
+          before do
+            variant.volume_prices.first.update(role_id: role.id)
+          end
+
+          context 'when user is given' do
+            let(:pricing_options) do
+              SolidusVolumePricing::PricingOptions.new(
+                quantity: quantity,
+                user: user
+              )
+            end
+
+            context 'whose role matches' do
+              before do
+                user.spree_roles << role
+              end
+
+              it 'gives percent of earning if role matches' do
+                expect(subject).to eq(25)
+              end
+            end
+
+            context 'whose role doesnt match' do
+              before do
+                user.spree_roles << other_role
+              end
+
+              it 'gives zero percent earning' do
+                expect(subject).to eq(0)
+              end
+            end
+          end
+
+          context 'when no user is given' do
+            it 'gives zero earning amount' do
+              expect(subject).to eq(0)
+            end
+          end
+        end
+      end
+
+      context 'when quantity does not match range' do
+        let(:quantity) { 1 }
+
+        it 'gives zero percent earning' do
+          expect(subject).to eq(0)
+        end
+      end
+    end
+
+    context 'discount_type = percent' do
+      before do
+        variant.volume_prices.create!(amount: 0.25, discount_type: 'percent', range: '(10+)')
+      end
+
+      context 'when quantity matches range' do
+        let(:quantity) { 10 }
+
+        it 'gives percent of earning' do
+          expect(subject).to eq(25)
+        end
+
+        context 'when volume_price has role' do
+          before do
+            variant.volume_prices.first.update(role_id: role.id)
+          end
+
+          context 'when user is given' do
+            let(:pricing_options) do
+              SolidusVolumePricing::PricingOptions.new(
+                quantity: quantity,
+                user: user
+              )
+            end
+
+            context 'whose role matches' do
+              before do
+                user.spree_roles << role
+              end
+
+              it 'gives percent of earning if role matches' do
+                expect(subject).to eq(25)
+              end
+            end
+
+            context 'whose role doesnt match' do
+              before do
+                user.spree_roles << other_role
+              end
+
+              it 'gives zero percent earning' do
+                expect(subject).to eq(0)
+              end
+            end
+          end
+
+          context 'when no user is given' do
+            it 'gives zero earning amount' do
+              expect(subject).to eq(0)
+            end
+          end
+        end
+      end
+
+      context 'when quantity does not match range' do
+        let(:quantity) { 1 }
+
+        it 'gives zero percent earning' do
+          expect(subject).to eq(0)
+        end
+      end
+    end
+  end
+end