solidus_volume_pricing 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1ab65d3e0219f88f5090273cae51341342455fbd
-  data.tar.gz: b410f7e09e809081651efa63c0815c0a386c3da9
+  metadata.gz: fbe1e772f2746fe3ef1be321bebf2677d6adb6f1
+  data.tar.gz: '09057b1c10577aef143f72ce88e4f29e93424ee8'
 SHA512:
-  metadata.gz: eda5105921410138eb449b40605487fef91711b773b1b208349a7598bf48a662477c6ccb83baba53cd3d6853c580f5dec6204e113a0582ca2905c155f9fc0f47
-  data.tar.gz: 0dfdc9b4cbc45a51791ef82a09453b1acfc4a9ead09d0d16e91f2033315cd97d930fdeb320e3823f6eae6e55eca60d902d1ac19a74d309f0791477a185bad3f2
+  metadata.gz: d90d442c9da53d8229c6f8cc8cf06a0a047ab212084eb2fe76a36fbb3fb1ba8e585855bcfc467e0f15737af12340687114c51abde3c6f66ebb09b84645372e9c
+  data.tar.gz: 4eb845de35f1c6edf05f5c9e8c267f3b99ba2a1e01b6118126afb20673a0d4e469cd9cf5d738b8c03ce0c7804f9a291fb215f28392d5653eee0c7d4de8cbdc18

data/app/controllers/spree/admin/volume_price_models_controller.rb

@@ -3,11 +3,6 @@ module Spree
     class VolumePriceModelsController < ResourceController
 
       before_action :load_volume_prices, only: [:new, :edit]
-      respond_to :json, only: [:get_children]
-
-      def get_children
-        @volume_prices = VolumePrice.find(params[:parent_id]).children
-      end
 
       private
 

data/app/views/spree/admin/variants/volume_prices.html.erb

@@ -24,7 +24,7 @@
     </thead>
     <tbody id="volume_prices">
       <%= f.fields_for :volume_prices do |vp_form| %>
-      <%= render partial: 'spree/admin/volume_prices/volume_price_fields', locals: { f: vp_form } %>
+        <%= render partial: 'spree/admin/volume_prices/volume_price_fields', locals: { f: vp_form } %>
       <% end %>
     </tbody>
     <tbody id="volume_price_models">

data/app/views/spree/admin/volume_prices/_edit_fields.html.erb

@@ -19,7 +19,7 @@
       <th><%= Spree.t(:amount) %></th>
       <th><%= Spree.t(:position) %></th>
       <th><%= Spree.t(:role) %></th>
-      <th><%= Spree.t(:action) %></th>
+      <th class="actions"></th>
     </tr>
   </thead>
   <tbody id="volume_prices">

data/app/views/spree/admin/volume_prices/_volume_price_fields.html.erb

@@ -9,7 +9,7 @@
         ["#{Spree.t(:total_price)}", 'price'],
         ["#{Spree.t(:percent_discount)}", 'percent'],
         ["#{Spree.t(:price_discount)}", 'dollar']
-      ], { inlcude_blank: true }, class: 'select2' %>
+      ], { include_blank: true }, class: 'select2' %>
   </td>
   <td>
     <%= error_message_on(f.object, :range) %>
@@ -28,6 +28,6 @@
     <%= f.collection_select(:role_id, Spree::Role.all, :id, :name, { include_blank: Spree.t('match_choices.none') }, { class: 'select2' }) %>
   </td>
   <td class="actions">
-    <%= link_to_icon_remove_fields f %>
+    <%= link_to_remove_fields Spree.t(:remove), f, no_text: true %>
   </td>
 </tr>

data/lib/solidus_volume_pricing/version.rb

@@ -10,7 +10,7 @@ module SolidusVolumePricing
   module VERSION
     MAJOR = 0
     MINOR = 2
-    TINY  = 0
+    TINY  = 1
     PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')

data/spec/features/manage_volume_price_models_feature_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+RSpec.feature 'Managing volume price models' do
+  stub_authorization!
+
+  scenario 'a admin can create and remove volume price models', :js do
+    visit spree.admin_volume_price_models_path
+    expect(page).to have_content('Volume Price Models')
+
+    click_on 'New Volume Price Model'
+    fill_in 'Name', with: 'Discount'
+    within '#volume_prices' do
+      fill_in 'volume_price_model_volume_prices_attributes_0_name', with: '5 pieces discount'
+      select 'Total price', from: 'volume_price_model_volume_prices_attributes_0_discount_type'
+      fill_in 'volume_price_model_volume_prices_attributes_0_range', with: '1..5'
+      fill_in 'volume_price_model_volume_prices_attributes_0_amount', with: '1'
+    end
+    click_on 'Create'
+
+    within 'tr.volume_price.fields' do
+      expect(page).to have_field('volume_price_model_volume_prices_attributes_0_name', with: '5 pieces discount')
+      page.find('a[data-action="remove"]').click
+      expect(page).to_not have_field('volume_price_model_volume_prices_attributes_0_name', with: '5 pieces discount')
+    end
+  end
+end

data/spec/features/manage_volume_prices_feature_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+RSpec.feature 'Managing volume prices' do
+  stub_authorization!
+
+  let(:variant) { create(:variant) }
+
+  scenario 'a admin can create and remove volume prices', :js do
+    visit spree.edit_admin_product_path(variant.product)
+    click_on 'Volume Pricing'
+    expect(page).to have_content('Volume Prices')
+
+    fill_in 'variant_volume_prices_attributes_0_name', with: '5 pieces discount'
+    select 'Total price', from: 'variant_volume_prices_attributes_0_discount_type'
+    fill_in 'variant_volume_prices_attributes_0_range', with: '1..5'
+    fill_in 'variant_volume_prices_attributes_0_amount', with: '1'
+    click_on 'Update'
+
+    within 'tr.volume_price.fields' do
+      expect(page).to have_field('variant_volume_prices_attributes_0_name', with: '5 pieces discount')
+      page.find('a[data-action="remove"]').click
+      expect(page).to_not have_field('variant_volume_prices_attributes_0_name', with: '5 pieces discount')
+    end
+  end
+
+  scenario 'a admin editing a variant has a new volume price already built for her' do
+    visit spree.edit_admin_product_variant_path(product_id: variant.product, id: variant)
+    within '#volume_prices' do
+      expect(page).to have_field('variant_volume_prices_attributes_0_name')
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,5 +1,8 @@
 require 'simplecov'
-SimpleCov.start 'rails'
+SimpleCov.start 'rails' do
+  add_filter "/lib/generators"
+  add_filter "/lib/solidus_volume_pricing"
+end
 
 ENV['RAILS_ENV'] ||= 'test'
 

data/spec/support/database_cleaner.rb

@@ -2,23 +2,20 @@ require 'database_cleaner'
 
 RSpec.configure do |config|
 
-  config.before(:suite) do
+  config.before :suite do
     DatabaseCleaner.clean_with :truncation
   end
 
-  config.before do
-    DatabaseCleaner.strategy = :transaction
-  end
-
-  config.before(:each, :js) do
-    DatabaseCleaner.strategy = :truncation
-  end
-
-  config.before do
+  config.prepend_before(:each) do
+    if RSpec.current_example.metadata[:js]
+      DatabaseCleaner.strategy = :truncation
+    else
+      DatabaseCleaner.strategy = :transaction
+    end
     DatabaseCleaner.start
   end
 
-  config.after do
+  config.append_after(:each) do
     DatabaseCleaner.clean
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_volume_pricing
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Sean Schofield
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-17 00:00:00.000000000 Z
+date: 2017-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -281,6 +281,8 @@ files:
 - solidus_volume_pricing.gemspec
 - spec/controllers/spree/admin/variants_controller_spec.rb
 - spec/factories/volume_price_factory.rb
+- spec/features/manage_volume_price_models_feature_spec.rb
+- spec/features/manage_volume_prices_feature_spec.rb
 - spec/helpers/base_helper_spec.rb
 - spec/models/spree/line_item_spec.rb
 - spec/models/spree/order_spec.rb
@@ -319,6 +321,8 @@ summary: Allow prices to be configured in quantity ranges for each variant
 test_files:
 - spec/controllers/spree/admin/variants_controller_spec.rb
 - spec/factories/volume_price_factory.rb
+- spec/features/manage_volume_price_models_feature_spec.rb
+- spec/features/manage_volume_prices_feature_spec.rb
 - spec/helpers/base_helper_spec.rb
 - spec/models/spree/line_item_spec.rb
 - spec/models/spree/order_spec.rb