solidus_virtual_gift_card 1.2.0 → 1.3.0

data/spec/models/spree/order_contents_spec.rb

@@ -5,40 +5,40 @@ describe Spree::OrderContents do
   let(:variant) { create(:variant) }
   let(:order_contents) { Spree::OrderContents.new(order) }
 
-  let(:recipient_name) { "Ron Weasly" }
-  let(:recipient_email) { "ron@weasly.com" }
-  let(:purchaser_name) { "Harry Potter" }
-  let(:gift_message) { "Thought you could use some trousers, mate" }
+  let(:recipient_name) { 'Ron Weasly' }
+  let(:recipient_email) { 'ron@weasly.com' }
+  let(:purchaser_name) { 'Harry Potter' }
+  let(:gift_message) { 'Thought you could use some trousers, mate' }
   let(:send_email_at) { 2.days.from_now }
   let(:options) do
     {
-      "gift_card_details" => {
-        "recipient_name" => recipient_name,
-        "recipient_email" => recipient_email,
-        "purchaser_name" => purchaser_name,
-        "gift_message" => gift_message,
-        "send_email_at" => send_email_at,
+      'gift_card_details' => {
+        'recipient_name' => recipient_name,
+        'recipient_email' => recipient_email,
+        'purchaser_name' => purchaser_name,
+        'gift_message' => gift_message,
+        'send_email_at' => send_email_at
       }
     }
   end
   let(:quantity) { 1 }
 
-  describe "#add" do
+  describe '#add' do
     subject { order_contents.add(variant, quantity, options) }
 
-    it "creates a line item" do
+    it 'creates a line item' do
       expect { subject }.to change { Spree::LineItem.count }.by(1)
     end
 
-    context "with a gift card product" do
-      before { variant.product.update_attributes(gift_card: true) }
+    context 'with a gift card product' do
+      before { variant.product.update(gift_card: true) }
 
-      it "creates a line item" do
+      it 'creates a line item' do
         expect { subject }.to change { Spree::LineItem.count }.by(1)
       end
 
-      context "with a single gift card" do
-        it "creates a gift card" do
+      context 'with a single gift card' do
+        it 'creates a gift card' do
           expect { subject }.to change { Spree::VirtualGiftCard.count }.by(1)
           gift_card = Spree::VirtualGiftCard.last
           expect(gift_card.recipient_name).to eq(recipient_name)
@@ -48,38 +48,38 @@ describe Spree::OrderContents do
           expect(gift_card.send_email_at).to eq(send_email_at.to_date)
         end
 
-        context "#format_date" do
-          context "without send_email_at" do
+        context '#format_date' do
+          context 'without send_email_at' do
             let(:send_email_at) { nil }
-            it "sets to current date" do
+            it 'sets to current date' do
               subject
               gift_card = Spree::VirtualGiftCard.last
               expect(gift_card.send_email_at).to eq(Date.today)
             end
           end
 
-          context "with invalid date" do
-            let(:send_email_at) { "12/14/2020" }
-            it "errors" do
-             expect{ subject }.to raise_error Spree::GiftCards::OrderContentsConcerns::GiftCardDateFormatError
+          context 'with invalid date' do
+            let(:send_email_at) { '12/14/2020' }
+            it 'errors' do
+             expect{ subject }.to raise_error Spree::GiftCards::GiftCardDateFormatError
             end
           end
         end
       end
 
-      context "with multiple gift cards" do
+      context 'with multiple gift cards' do
         let(:quantity) { 2 }
 
-        it "creates two gift cards" do
+        it 'creates two gift cards' do
           expect { subject }.to change { Spree::VirtualGiftCard.count }.by(2)
         end
       end
 
-      context "adding a gift card with an existing line item" do
-        context "when the gift card properties match" do
+      context 'adding a gift card with an existing line item' do
+        context 'when the gift card properties match' do
           before { @line_item = order_contents.add(variant, quantity, options) }
 
-          it "adds to the existing gift card" do
+          it 'adds to the existing gift card' do
             expect(order.line_items.count).to be(1)
             new_line_item = subject
             expect(order.reload.line_items.count).to be(1)
@@ -87,25 +87,25 @@ describe Spree::OrderContents do
           end
         end
 
-        context "when the gift card properties are different" do
-          let(:recipient_name2)  { "Severus Snape" }
-          let(:recipient_email2) { "wingardium@leviosa.com" }
-          let(:purchaser_name2)  { "Dumbledore" }
+        context 'when the gift card properties are different' do
+          let(:recipient_name2)  { 'Severus Snape' }
+          let(:recipient_email2) { 'wingardium@leviosa.com' }
+          let(:purchaser_name2)  { 'Dumbledore' }
           let(:options2) do
             {
-              "gift_card_details" => {
-                "recipient_name" => recipient_name2,
-                "recipient_email" => recipient_email2,
-                "purchaser_name" => purchaser_name2,
-                "gift_message" => gift_message,
-                "send_email_at" => send_email_at,
+              'gift_card_details' => {
+                'recipient_name' => recipient_name2,
+                'recipient_email' => recipient_email2,
+                'purchaser_name' => purchaser_name2,
+                'gift_message' => gift_message,
+                'send_email_at' => send_email_at
               }
             }
           end
 
           before { @line_item = order_contents.add(variant, quantity, options2) }
 
-          it "creates a new line item with a gift card" do
+          it 'creates a new line item with a gift card' do
             expect(order.line_items.count).to be(1)
             new_line_item = subject
             expect(@line_item.id).to_not eq new_line_item.id
@@ -116,67 +116,67 @@ describe Spree::OrderContents do
       end
     end
 
-    context "with a non gift card product" do
-      it "does not create a gift card" do
+    context 'with a non gift card product' do
+      it 'does not create a gift card' do
         expect { subject }.to_not change { Spree::VirtualGiftCard.count }
       end
     end
   end
 
-  describe "#remove" do
+  describe '#remove' do
     subject { order_contents.remove(variant, quantity, options) }
 
-    context "for a non-gift-card product" do
+    context 'for a non-gift-card product' do
       before { order_contents.add(variant, quantity, options) }
 
-      it "deletes a line item" do
+      it 'deletes a line item' do
         expect { subject }.to change { Spree::LineItem.count }.by(-1)
       end
     end
 
-    context "with a gift card product" do
+    context 'with a gift card product' do
       before do
-        variant.product.update_attributes(gift_card: true)
+        variant.product.update(gift_card: true)
       end
 
-      context "with a single gift card" do
+      context 'with a single gift card' do
         before do
           order_contents.add(variant, quantity, options)
         end
 
-        it "deletes a line item" do
+        it 'deletes a line item' do
           expect { subject }.to change { Spree::LineItem.count }.by(-1)
         end
 
-        it "deletes a gift card" do
+        it 'deletes a gift card' do
           expect { subject }.to change { Spree::VirtualGiftCard.count }.by(-1)
         end
       end
 
-      context "with multiple gift cards" do
+      context 'with multiple gift cards' do
         let(:quantity) { 2 }
 
         before do
           order_contents.add(variant, quantity, options)
         end
 
-        it "deletes two gift cards" do
+        it 'deletes two gift cards' do
           expect { subject }.to change { Spree::VirtualGiftCard.count }.by(-2)
         end
       end
 
-      context "with two gift card line items with identical variants" do
-        let(:recipient_name2)  { "Severus Snape" }
-        let(:recipient_email2) { "wingardium@leviosa.com" }
-        let(:purchaser_name2)  { "Dumbledore" }
+      context 'with two gift card line items with identical variants' do
+        let(:recipient_name2)  { 'Severus Snape' }
+        let(:recipient_email2) { 'wingardium@leviosa.com' }
+        let(:purchaser_name2)  { 'Dumbledore' }
         let(:options2) do
           {
-            "gift_card_details" => {
-              "recipient_name" => recipient_name2,
-              "recipient_email" => recipient_email2,
-              "purchaser_name" => purchaser_name2,
-              "gift_message" => gift_message,
-              "send_email_at" => send_email_at,
+            'gift_card_details' => {
+              'recipient_name' => recipient_name2,
+              'recipient_email' => recipient_email2,
+              'purchaser_name' => purchaser_name2,
+              'gift_message' => gift_message,
+              'send_email_at' => send_email_at
             }
           }
         end
@@ -186,8 +186,8 @@ describe Spree::OrderContents do
           @line_item2 = order_contents.add(variant, quantity, options2)
         end
 
-        context "removing the first line item" do
-          it "removes the correct line item" do
+        context 'removing the first line item' do
+          it 'removes the correct line item' do
             expect(order.line_items.count).to be(2)
             subject
             expect(order.reload.line_items.count).to be(1)
@@ -195,10 +195,10 @@ describe Spree::OrderContents do
           end
         end
 
-        context "removing the second line item" do
+        context 'removing the second line item' do
           subject { order_contents.remove(variant, quantity, options2) }
 
-          it "removes the correct line item" do
+          it 'removes the correct line item' do
             expect(order.line_items.count).to be(2)
             subject
             expect(order.reload.line_items.count).to be(1)
@@ -207,24 +207,24 @@ describe Spree::OrderContents do
         end
       end
 
-      context "when no gift card details are supplied" do
+      context 'when no gift card details are supplied' do
         subject { order_contents.remove(variant, quantity) }
 
         before do
           order_contents.add(variant, quantity, options)
         end
 
-        it "removes the line item with the correct variant" do
+        it 'removes the line item with the correct variant' do
           expect { subject }.to change { Spree::LineItem.count }.by(-1)
         end
 
-        it "removes the gift card" do
+        it 'removes the gift card' do
           expect { subject }.to change { Spree::VirtualGiftCard.count }.by(-1)
         end
       end
     end
 
-    describe "#update_cart" do
+    describe '#update_cart' do
       subject { order_contents.update_cart(update_params) }
 
       let(:update_params) do
@@ -233,33 +233,33 @@ describe Spree::OrderContents do
         }
       end
 
-      context "for a gift card line item" do
+      context 'for a gift card line item' do
         before do
-          variant.product.update_attributes(gift_card: true)
+          variant.product.update(gift_card: true)
           @line_item = order_contents.add(variant, 2, options)
         end
 
-        context "line item is being updated to a higher quantity" do
-          let(:quantity) { "4" }
+        context 'line item is being updated to a higher quantity' do
+          let(:quantity) { '4' }
 
-          it "creates new gift cards" do
+          it 'creates new gift cards' do
             expect { subject }.to change { Spree::VirtualGiftCard.count }.by(2)
           end
         end
 
-        context "line item is being updated to a lower quantity" do
-          context "one lower" do
-            let(:quantity) { "1" }
+        context 'line item is being updated to a lower quantity' do
+          context 'one lower' do
+            let(:quantity) { '1' }
 
-            it "destroys gift cards" do
+            it 'destroys gift cards' do
               expect { subject }.to change { Spree::VirtualGiftCard.count }.by(-1)
             end
           end
 
-          context "multiple lower" do
-            let(:quantity) { "0" }
+          context 'multiple lower' do
+            let(:quantity) { '0' }
 
-            it "destroys gift cards" do
+            it 'destroys gift cards' do
               expect { subject }.to change { Spree::VirtualGiftCard.count }.by(-2)
             end
           end

data/spec/models/spree/order_spec.rb

@@ -1,14 +1,14 @@
 require 'spec_helper'
 
 describe Spree::Order do
-  describe "#finalize!" do
-    context "the order contains gift cards and transitions to complete" do
+  describe '#finalize!' do
+    context 'the order contains gift cards and transitions to complete' do
       let(:gift_card) { create(:virtual_gift_card) }
       let(:order) { create(:order_with_line_items, state: 'complete', line_items: [gift_card.line_item]) }
 
       subject { order.finalize! }
 
-      it "makes the gift card redeemable" do
+      it 'makes the gift card redeemable' do
         subject
         expect(gift_card.reload.redeemable).to be true
         expect(gift_card.reload.redemption_code).to be_present
@@ -16,18 +16,18 @@ describe Spree::Order do
     end
   end
 
-  describe "#send_gift_card_emails" do
+  describe '#send_gift_card_emails' do
     subject { order.send_gift_card_emails }
 
-    context "the order has gift cards" do
+    context 'the order has gift cards' do
       let(:gift_card) { create(:virtual_gift_card, send_email_at: send_email_at) }
       let(:line_item) { gift_card.line_item }
       let(:gift_card_2) { create(:virtual_gift_card, line_item: line_item, send_email_at: send_email_at) }
       let(:order) { gift_card.line_item.order }
 
-      context "send_email_at is not set" do
+      context 'send_email_at is not set' do
         let(:send_email_at) { nil }
-        it "should call GiftCardMailer#send" do
+        it 'should call GiftCardMailer#send' do
           expect(Spree::GiftCardMailer).to receive(:gift_card_email).with(gift_card).and_return(double(deliver_later: true))
           expect(Spree::GiftCardMailer).to receive(:gift_card_email).with(gift_card_2).and_return(double(deliver_later: true))
           subject
@@ -35,9 +35,9 @@ describe Spree::Order do
         end
       end
 
-      context "send_email_at is in the past" do
+      context 'send_email_at is in the past' do
         let(:send_email_at) { 2.days.ago }
-        it "should call GiftCardMailer#send" do
+        it 'should call GiftCardMailer#send' do
           expect(Spree::GiftCardMailer).to receive(:gift_card_email).with(gift_card).and_return(double(deliver_later: true))
           expect(Spree::GiftCardMailer).to receive(:gift_card_email).with(gift_card_2).and_return(double(deliver_later: true))
           subject
@@ -45,9 +45,9 @@ describe Spree::Order do
         end
       end
 
-      context "send_email_at is in the future" do
+      context 'send_email_at is in the future' do
         let(:send_email_at) { 2.days.from_now }
-        it "does not call GiftCardMailer#send" do
+        it 'does not call GiftCardMailer#send' do
           expect(Spree::GiftCardMailer).to_not receive(:gift_card_email)
           subject
           expect(gift_card.reload.sent_at).to_not be_present
@@ -55,10 +55,10 @@ describe Spree::Order do
       end
     end
 
-    context "no gift cards" do
+    context 'no gift cards' do
       let(:order) { create(:order_with_line_items) }
 
-      it "should not call GiftCardMailer#send" do
+      it 'should not call GiftCardMailer#send' do
         expect(Spree::GiftCardMailer).to_not receive(:gift_card_email)
         subject
       end

data/spec/models/spree/permission_sets/virtual_gift_card_display_spec.rb

@@ -5,7 +5,7 @@ describe Spree::PermissionSets::VirtualGiftCardDisplay do
 
   subject { ability }
 
-  context "when activated" do
+  context 'when activated' do
     before do
       described_class.new(ability).activate!
     end
@@ -14,7 +14,7 @@ describe Spree::PermissionSets::VirtualGiftCardDisplay do
     it { should be_able_to(:display, Spree::VirtualGiftCard) }
   end
 
-  context "when not activated" do
+  context 'when not activated' do
     it { should_not be_able_to(:admin, Spree::VirtualGiftCard) }
     it { should_not be_able_to(:display, Spree::VirtualGiftCard) }
   end

data/spec/models/spree/permission_sets/virtual_gift_card_management_spec.rb

@@ -6,7 +6,7 @@ describe Spree::PermissionSets::VirtualGiftCardManagement do
 
   subject { ability }
 
-  context "when activated" do
+  context 'when activated' do
     before do
       described_class.new(ability).activate!
     end
@@ -14,7 +14,7 @@ describe Spree::PermissionSets::VirtualGiftCardManagement do
     it { should be_able_to(:manage, Spree::VirtualGiftCard) }
   end
 
-  context "when not activated" do
+  context 'when not activated' do
     it { should_not be_able_to(:manage, Spree::VirtualGiftCard) }
   end
 end

data/spec/models/spree/store_credit_category_spec.rb

@@ -1,21 +1,21 @@
 require 'spec_helper'
 
 describe Spree::StoreCreditCategory, type: :model do
-  describe "#non_expiring?" do
+  describe '#non_expiring?' do
     subject { build(:store_credit_category, name: category_name).non_expiring? }
 
-    context "non-expiring type store credit" do
+    context 'non-expiring type store credit' do
       let(:category_name) { Spree::StoreCreditCategory.non_expiring_credit_types.first }
 
-      it "returns true" do
+      it 'returns true' do
         expect(subject).to be true
       end
     end
 
-    context "expiring type store credit" do
-      let(:category_name) { "Expiring" }
+    context 'expiring type store credit' do
+      let(:category_name) { 'Expiring' }
 
-      it "returns false" do
+      it 'returns false' do
         expect(subject).to be false
       end
     end