solidus_virtual_gift_card 1.0.0 → 1.0.1

data/spec/lib/tasks/send_gift_card_emails_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+describe "solidus_virtual_gift_card:send_current_emails" do
+
+  let(:task) { Rake::Task['solidus_virtual_gift_card:send_current_emails'] }
+  let(:purchaser) {create(:user)}
+
+  before do
+    Rails.application.load_tasks
+    task.reenable
+  end
+
+  subject { task.invoke }
+
+  context "with gift card sent today" do
+    it "sends emails to be sent today" do
+      gift_card = Spree::VirtualGiftCard.create!(amount: 50, send_email_at: Date.today, redeemable: true, purchaser: purchaser)
+      expect(Spree::GiftCardMailer).to receive(:gift_card_email).with(gift_card).and_return(double(deliver_later: true))
+      subject
+    end
+
+    it "does not send unredeemable giftcards" do
+      gift_card = Spree::VirtualGiftCard.create!(amount: 50, send_email_at: Date.today)
+      expect(Spree::GiftCardMailer).to_not receive(:gift_card_email).with(gift_card)
+      subject
+    end
+  end
+
+  context "with gift card already sent today" do
+    it "sends emails to be sent today" do
+      Spree::VirtualGiftCard.create!(amount: 50, send_email_at: Date.today, sent_at: DateTime.now, redeemable: true, purchaser: purchaser)
+      expect(Spree::GiftCardMailer).to_not receive(:gift_card_email)
+      subject
+    end
+  end
+
+  context "with gift cards sent in the future" do
+    it "does not sends emails" do
+      Spree::VirtualGiftCard.create!(amount: 50, send_email_at: 10.days.from_now.to_date, redeemable: true, purchaser: purchaser)
+      expect(Spree::GiftCardMailer).to_not receive(:gift_card_email)
+      subject
+    end
+  end
+
+  context "with gift cards sent in the past" do
+    it "does not sends emails" do
+      Spree::VirtualGiftCard.create!(amount: 50, send_email_at: 1.days.ago, sent_at: 1.days.ago.to_date, redeemable: true, purchaser: purchaser)
+      expect(Spree::GiftCardMailer).to_not receive(:gift_card_email)
+      subject
+    end
+  end
+
+  context "with gift cards not specified" do
+    it "does not sends emails" do
+      Spree::VirtualGiftCard.create!(amount: 50, send_email_at: nil)
+      expect(Spree::GiftCardMailer).to_not receive(:gift_card_email)
+      subject
+    end
+  end
+end

data/spec/models/spree/line_item_spec.rb

@@ -27,4 +27,25 @@ describe Spree::LineItem do
       expect(subject.first).to have_value gift_card.formatted_amount
     end
   end
+
+  describe "#gift_card_details" do
+    let(:line_item) { create(:line_item, quantity: 2) }
+    let!(:gift_card) { create(:redeemable_virtual_gift_card, line_item: line_item) }
+    let!(:gift_card_2) { create(:redeemable_virtual_gift_card, line_item: line_item) }
+    let(:subject) { line_item.gift_card_details }
+
+    it 'contains all gift cards on the line item' do
+      expect(subject.size).to eq line_item.quantity
+    end
+
+    it 'contains the correct keys and values' do
+      gift_card_details = subject.first
+      expect(gift_card_details[:amount]).to eq gift_card.formatted_amount
+      expect(gift_card_details[:redemption_code]).to eq gift_card.formatted_redemption_code
+      expect(gift_card_details[:recipient_email]).to eq gift_card.recipient_email
+      expect(gift_card_details[:recipient_name]).to eq gift_card.recipient_name
+      expect(gift_card_details[:purchaser_name]).to eq gift_card.purchaser_name
+      expect(gift_card_details[:gift_message]).to eq gift_card.gift_message
+    end
+  end
 end

data/spec/models/spree/order_contents_spec.rb

@@ -0,0 +1,270 @@
+require 'spec_helper'
+
+describe Spree::OrderContents do
+  let(:order) { create(:order) }
+  let(:variant) { create(:variant) }
+  let(:order_contents) { Spree::OrderContents.new(order) }
+
+  let(:recipient_name) { "Ron Weasly" }
+  let(:recipient_email) { "ron@weasly.com" }
+  let(:purchaser_name) { "Harry Potter" }
+  let(:gift_message) { "Thought you could use some trousers, mate" }
+  let(:send_email_at) { 2.days.from_now }
+  let(:options) do
+    {
+      "gift_card_details" => {
+        "recipient_name" => recipient_name,
+        "recipient_email" => recipient_email,
+        "purchaser_name" => purchaser_name,
+        "gift_message" => gift_message,
+        "send_email_at" => send_email_at,
+      }
+    }
+  end
+  let(:quantity) { 1 }
+
+  describe "#add" do
+    subject { order_contents.add(variant, quantity, options) }
+
+    it "creates a line item" do
+      expect { subject }.to change { Spree::LineItem.count }.by(1)
+    end
+
+    context "with a gift card product" do
+      before { variant.product.update_attributes(gift_card: true) }
+
+      it "creates a line item" do
+        expect { subject }.to change { Spree::LineItem.count }.by(1)
+      end
+
+      context "with a single gift card" do
+        it "creates a gift card" do
+          expect { subject }.to change { Spree::VirtualGiftCard.count }.by(1)
+          gift_card = Spree::VirtualGiftCard.last
+          expect(gift_card.recipient_name).to eq(recipient_name)
+          expect(gift_card.recipient_email).to eq(recipient_email)
+          expect(gift_card.purchaser_name).to eq(purchaser_name)
+          expect(gift_card.gift_message).to eq(gift_message)
+          expect(gift_card.send_email_at).to eq(send_email_at.to_date)
+        end
+
+        context "#format_date" do
+          context "without send_email_at" do
+            let(:send_email_at) { nil }
+            it "sets to current date" do
+              subject
+              gift_card = Spree::VirtualGiftCard.last
+              expect(gift_card.send_email_at).to eq(Date.today)
+            end
+          end
+
+          context "with invalid date" do
+            let(:send_email_at) { "12/14/2020" }
+            it "errors" do
+             expect{ subject }.to raise_error Spree::GiftCards::OrderContentsConcerns::GiftCardDateFormatError
+            end
+          end
+        end
+      end
+
+      context "with multiple gift cards" do
+        let(:quantity) { 2 }
+
+        it "creates two gift cards" do
+          expect { subject }.to change { Spree::VirtualGiftCard.count }.by(2)
+        end
+      end
+
+      context "adding a gift card with an existing line item" do
+        context "when the gift card properties match" do
+          before { @line_item = order_contents.add(variant, quantity, options) }
+
+          it "adds to the existing gift card" do
+            expect(order.line_items.count).to be(1)
+            new_line_item = subject
+            expect(order.reload.line_items.count).to be(1)
+            expect(@line_item.reload.gift_cards.count).to be(2)
+          end
+        end
+
+        context "when the gift card properties are different" do
+          let(:recipient_name2)  { "Severus Snape" }
+          let(:recipient_email2) { "wingardium@leviosa.com" }
+          let(:purchaser_name2)  { "Dumbledore" }
+          let(:options2) do
+            {
+              "gift_card_details" => {
+                "recipient_name" => recipient_name2,
+                "recipient_email" => recipient_email2,
+                "purchaser_name" => purchaser_name2,
+                "gift_message" => gift_message,
+                "send_email_at" => send_email_at,
+              }
+            }
+          end
+
+          before { @line_item = order_contents.add(variant, quantity, options2) }
+
+          it "creates a new line item with a gift card" do
+            expect(order.line_items.count).to be(1)
+            new_line_item = subject
+            expect(@line_item.id).to_not eq new_line_item.id
+            expect(order.reload.line_items.count).to be(2)
+            expect(new_line_item.gift_cards.count).to be(1)
+          end
+        end
+      end
+    end
+
+    context "with a non gift card product" do
+      it "does not create a gift card" do
+        expect { subject }.to_not change { Spree::VirtualGiftCard.count }
+      end
+    end
+  end
+
+  describe "#remove" do
+    subject { order_contents.remove(variant, quantity, options) }
+
+    context "for a non-gift-card product" do
+      before { order_contents.add(variant, quantity, options) }
+
+      it "deletes a line item" do
+        expect { subject }.to change { Spree::LineItem.count }.by(-1)
+      end
+    end
+
+    context "with a gift card product" do
+      before do
+        variant.product.update_attributes(gift_card: true)
+      end
+
+      context "with a single gift card" do
+        before do
+          order_contents.add(variant, quantity, options)
+        end
+
+        it "deletes a line item" do
+          expect { subject }.to change { Spree::LineItem.count }.by(-1)
+        end
+
+        it "deletes a gift card" do
+          expect { subject }.to change { Spree::VirtualGiftCard.count }.by(-1)
+        end
+      end
+
+      context "with multiple gift cards" do
+        let(:quantity) { 2 }
+
+        before do
+          order_contents.add(variant, quantity, options)
+        end
+
+        it "deletes two gift cards" do
+          expect { subject }.to change { Spree::VirtualGiftCard.count }.by(-2)
+        end
+      end
+
+      context "with two gift card line items with identical variants" do
+        let(:recipient_name2)  { "Severus Snape" }
+        let(:recipient_email2) { "wingardium@leviosa.com" }
+        let(:purchaser_name2)  { "Dumbledore" }
+        let(:options2) do
+          {
+            "gift_card_details" => {
+              "recipient_name" => recipient_name2,
+              "recipient_email" => recipient_email2,
+              "purchaser_name" => purchaser_name2,
+              "gift_message" => gift_message,
+              "send_email_at" => send_email_at,
+            }
+          }
+        end
+
+        before do
+          @line_item = order_contents.add(variant, quantity, options)
+          @line_item2 = order_contents.add(variant, quantity, options2)
+        end
+
+        context "removing the first line item" do
+          it "removes the correct line item" do
+            expect(order.line_items.count).to be(2)
+            subject
+            expect(order.reload.line_items.count).to be(1)
+            expect(order.line_items).to_not include(@line_item)
+          end
+        end
+
+        context "removing the second line item" do
+          subject { order_contents.remove(variant, quantity, options2) }
+
+          it "removes the correct line item" do
+            expect(order.line_items.count).to be(2)
+            subject
+            expect(order.reload.line_items.count).to be(1)
+            expect(order.line_items).to_not include(@line_item2)
+          end
+        end
+      end
+
+      context "when no gift card details are supplied" do
+        subject { order_contents.remove(variant, quantity) }
+
+        before do
+          order_contents.add(variant, quantity, options)
+        end
+
+        it "removes the line item with the correct variant" do
+          expect { subject }.to change { Spree::LineItem.count }.by(-1)
+        end
+
+        it "removes the gift card" do
+          expect { subject }.to change { Spree::VirtualGiftCard.count }.by(-1)
+        end
+      end
+    end
+
+    describe "#update_cart" do
+      subject { order_contents.update_cart(update_params) }
+
+      let(:update_params) do
+        {
+          line_items_attributes: { id: @line_item.id, quantity: quantity, options: {}}
+        }
+      end
+
+      context "for a gift card line item" do
+        before do
+          variant.product.update_attributes(gift_card: true)
+          @line_item = order_contents.add(variant, 2, options)
+        end
+
+        context "line item is being updated to a higher quantity" do
+          let(:quantity) { "4" }
+
+          it "creates new gift cards" do
+            expect { subject }.to change { Spree::VirtualGiftCard.count }.by(2)
+          end
+        end
+
+        context "line item is being updated to a lower quantity" do
+          context "one lower" do
+            let(:quantity) { "1" }
+
+            it "destroys gift cards" do
+              expect { subject }.to change { Spree::VirtualGiftCard.count }.by(-1)
+            end
+          end
+
+          context "multiple lower" do
+            let(:quantity) { "0" }
+
+            it "destroys gift cards" do
+              expect { subject }.to change { Spree::VirtualGiftCard.count }.by(-2)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/order_spec.rb

@@ -1,64 +1,57 @@
 require 'spec_helper'
 
 describe Spree::Order do
-  describe "#create_gift_cards" do
-    let(:order) { create(:order_with_line_items) }
-    let(:line_item) { order.line_items.first }
-    subject { order.create_gift_cards }
-
-    context "the line item is a gift card" do
-      before do
-        allow(line_item).to receive(:gift_card?).and_return(true)
-        allow(line_item).to receive(:quantity).and_return(3)
-      end
-
-      it 'creates a gift card for each gift card in the line item' do
-        expect { subject }.to change { Spree::VirtualGiftCard.count }.by(line_item.quantity)
-      end
-
-      it 'sets the purchaser, amount, and currency' do
-        expect(Spree::VirtualGiftCard).to receive(:create!).exactly(3).times.with(amount: line_item.price, currency: line_item.currency, purchaser: order.user, line_item: line_item)
-        subject
-      end
-    end
-
-    context "the line item is not a gift card" do
-      before { allow(line_item).to receive(:gift_card?).and_return(false) }
-
-      it 'does not create a gift card' do
-        expect(Spree::VirtualGiftCard).not_to receive(:create!)
-        subject
-      end
-    end
-  end
-
   describe "#finalize!" do
     context "the order contains gift cards and transitions to complete" do
-      let(:order) { create(:order_with_line_items, state: 'complete') }
+      let(:gift_card) { create(:virtual_gift_card) }
+      let(:order) { create(:order_with_line_items, state: 'complete', line_items: [gift_card.line_item]) }
 
       subject { order.finalize! }
 
-      it "calls #create_gift_cards" do
-        expect(order).to receive(:create_gift_cards)
+      it "makes the gift card redeemable" do
         subject
+        expect(gift_card.reload.redeemable).to be true
+        expect(gift_card.reload.redemption_code).to be_present
       end
     end
   end
 
   describe "#send_gift_card_emails" do
-
     subject { order.send_gift_card_emails }
 
     context "the order has gift cards" do
-      let(:gift_card) { create(:virtual_gift_card) }
+      let(:gift_card) { create(:virtual_gift_card, send_email_at: send_email_at) }
       let(:line_item) { gift_card.line_item }
-      let(:gift_card_2) { create(:virtual_gift_card, line_item: line_item) }
+      let(:gift_card_2) { create(:virtual_gift_card, line_item: line_item, send_email_at: send_email_at) }
       let(:order) { gift_card.line_item.order }
 
-      it "should call GiftCardMailer#send" do
-        expect(Spree::GiftCardMailer).to receive(:gift_card_email).with(gift_card).and_return(double(deliver: true))
-        expect(Spree::GiftCardMailer).to receive(:gift_card_email).with(gift_card_2).and_return(double(deliver: true))
-        subject
+      context "send_email_at is not set" do
+        let(:send_email_at) { nil }
+        it "should call GiftCardMailer#send" do
+          expect(Spree::GiftCardMailer).to receive(:gift_card_email).with(gift_card).and_return(double(deliver_later: true))
+          expect(Spree::GiftCardMailer).to receive(:gift_card_email).with(gift_card_2).and_return(double(deliver_later: true))
+          subject
+          expect(gift_card.reload.sent_at).to be_present
+        end
+      end
+
+      context "send_email_at is in the past" do
+        let(:send_email_at) { 2.days.ago }
+        it "should call GiftCardMailer#send" do
+          expect(Spree::GiftCardMailer).to receive(:gift_card_email).with(gift_card).and_return(double(deliver_later: true))
+          expect(Spree::GiftCardMailer).to receive(:gift_card_email).with(gift_card_2).and_return(double(deliver_later: true))
+          subject
+          expect(gift_card.reload.sent_at).to be_present
+        end
+      end
+
+      context "send_email_at is in the future" do
+        let(:send_email_at) { 2.days.from_now }
+        it "does not call GiftCardMailer#send" do
+          expect(Spree::GiftCardMailer).to_not receive(:gift_card_email)
+          subject
+          expect(gift_card.reload.sent_at).to_not be_present
+        end
       end
     end
 
@@ -71,20 +64,4 @@ describe Spree::Order do
       end
     end
   end
-
-  describe "#display_total_applicable_store_credit" do
-    let(:total_applicable_store_credit) { 10.00 }
-
-    subject { create(:order) }
-
-    before { allow(subject).to receive_messages(total_applicable_store_credit: total_applicable_store_credit) }
-
-    it "returns a money instance" do
-      expect(subject.display_total_applicable_store_credit).to be_a(Spree::Money)
-    end
-
-    it "returns a negative amount" do
-      expect(subject.display_total_applicable_store_credit.money.cents).to eq (total_applicable_store_credit * -100.0)
-    end
-  end
 end